Change-Id: Id14b5530c994e10bb9f45f036b43025c73c7ac83
Reviewed-on: https://gerrit.libreoffice.org/68977Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

In the properties dialog, code expected that the ODF_FORMDROPDOWN_RESULT
is not set in case of an empty list. This caused a crash.
The field popup window code expected that the list is not specified
when it is empty, but DOC import code sets ODF_FORMDROPDOWN_LISTENTRY
even if the list is empty.

Change-Id: If4c86fc5a08cdc578150afaa42ad7e86bdba9150
Reviewed-on: https://gerrit.libreoffice.org/68963Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I71c095e5e5dd21650663e6fb717bcb22958a597f
Reviewed-on: https://gerrit.libreoffice.org/68976
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Id92be196bd4a6a061ef7985d8a07ab0be4523a0f
Reviewed-on: https://gerrit.libreoffice.org/68986
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iebf28bebb009a46872dd6d4662a7434e3c66b7dc
Reviewed-on: https://gerrit.libreoffice.org/68993
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Move XTableCharts Java tests to C++ for ScChartsObj.

Change-Id: Ibd08cc60d38d8ca01af9168d862a9f391c48e90a
Reviewed-on: https://gerrit.libreoffice.org/68992
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ic85a697939263892c1d1a49b1d0900ee5fb73c1c
Reviewed-on: https://gerrit.libreoffice.org/68991
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XNameAccess Java tests to C++ for ScChartsObj.

	modified:   sc/qa/extras/scchartsobj.cxx

Change-Id: I0599bebf163b122ce315b843337adee08abf2ae3
Reviewed-on: https://gerrit.libreoffice.org/68990
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XIndexAccess Java tests to C++ for ScChartsObj.

Change-Id: I1a6babb59e6feb2ed825f9ca698a8852f8bce6bb
Reviewed-on: https://gerrit.libreoffice.org/68989
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I318508531b3f52da2d699e6d35c7cda72d4de115
Reviewed-on: https://gerrit.libreoffice.org/68981
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The defaults for EnableSQL92Check, PreferDosLikeLineEnds, RespectDriverResultSetType
in connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu made
consistent with respective defaults in ODatabaseModelImpl::getDefaultDataSourceSettings

When inconsistent, the settings don't ever get written to the ODB's
content.xml (likely they are filtered out as default at different levels).
This change allows the non-default to be written. Since the defaults in
ODatabaseModelImpl::getDefaultDataSourceSettings are there at least since
2006 (commit 0eb02629), so that in any
existing ODB the settings are absent if they are equal to those defaults,
they are not changed.

Change-Id: I220336fae666554c1bc23c1915152515fefd18ce
Reviewed-on: https://gerrit.libreoffice.org/68979Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I61dd04afe8d753123eeb88e6d8eb0c76c88f5836
Reviewed-on: https://gerrit.libreoffice.org/68985
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I2e1e55d4111e3c996afc27e8970af331b5d76613
Reviewed-on: https://gerrit.libreoffice.org/68988
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id0798cbff2d327e2bb955fbbc530a201975f6003
Reviewed-on: https://gerrit.libreoffice.org/68833
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Move XElementAccess Java tests to C++ for ScChartsObj.

	modified:   sc/qa/extras/scchartsobj.cxx

Change-Id: I8577af7eb9d29d3877e5d515bad121d3fd844716
Reviewed-on: https://gerrit.libreoffice.org/68954
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XEnumerationAccess Java test to C++ for ScChartsObj.

Change-Id: Ia9afb9fcaa5b81b140f47f309166f09af779ca52
Reviewed-on: https://gerrit.libreoffice.org/68953
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I66c0a7bad63d929ae346afe9d328d87dfa2c24ae
Reviewed-on: https://gerrit.libreoffice.org/68962
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

* Introduce a editing frame with a button for drop-down form field.
** The frame is mouse transparent.
** Pushing the button opens the popup window with the items of the field.
* The button is visible when the cursor is inside the field.

Change-Id: I5c7db138d14380899fee046c95a5afe14cfea213
Reviewed-on: https://gerrit.libreoffice.org/68961
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Use range-based loop or replace with STL functions

Change-Id: I1f7c1ea19cdc8d450b7ed88a663ba9ccb3249304
Reviewed-on: https://gerrit.libreoffice.org/68974
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I11cd695da81bae7b49b2319b89e5c560ba64f04e
Reviewed-on: https://gerrit.libreoffice.org/68975
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Idbdd2a97cdcc7f874c12cff8e024214badda1522
Reviewed-on: https://gerrit.libreoffice.org/68973
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

If the AppLanguage is RTL, then it is likely that paragraph
styles inheriting from the environment will export as RTL.
So, if the paragraph is LTR (from a page style for example),
then it needs to be specified in order to override the paragraph style.
So, this is not just for RTL, even if it is a default value.

Exactly what the paragraph style will become is complicated, and
not necessarily the same across the different formats. Thus it
is safest to just spam the bidi attributes across any questionable
paragraphs.

A followup commit will similarly spam Justify in these situations,
and again the difference between doc and docx suggests it is
better to spam more, rather than less.

Change-Id: Id184a983675b147f051821e828583a4bf98b3211
Reviewed-on: https://gerrit.libreoffice.org/66922
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

* It was weird anyway that a drop-down form field was represented
as an CheckboxFieldmark.
* It will be useful for later commits, to have a separate field type
for drop-down field.
* Needed to fix-up the API a bit because it was designed to specify
the field type after initialization. I solved it in a way to not break
the API behavior. Hopefully it's not very slow.

Change-Id: I3103e6b1c36289b27b62ab9ca7dfeebc14901c8a
Reviewed-on: https://gerrit.libreoffice.org/68960
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I0e9e8a0e9212cdf539caa163f9071bc2f21e4c9f
Reviewed-on: https://gerrit.libreoffice.org/68959
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Use is{Left,Right}Aligned instead of is{First,Last}. In multi-line
tabs, not only first/last item needs to be drawn differently, but
also some middle, which is now the first in the new line now.

Change-Id: I81ddde192eca794f16df98d629f47991c59732c7
Reviewed-on: https://gerrit.libreoffice.org/68945
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

which will result in a hidpi triangle rather than
a bunch of visible lines arranged in a triangle pattern

Change-Id: I9208177aa5e32791f46c9b1dcbe71f5442475282
Reviewed-on: https://gerrit.libreoffice.org/68946
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Insertion of fields inside fields is not an allowed operation.

Change-Id: Icfdbc1add9c828227201b70cd545a83b6dcbc3e6
Reviewed-on: https://gerrit.libreoffice.org/68957
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I2b09bf30c3769f6b987409cabf24735647d3c31d
Reviewed-on: https://gerrit.libreoffice.org/68958Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Need to handle undo / redo explicitely for form fields, because
there is no a general working undo / redo mechanism for fieldmarks.
During the insertion of the fieldmark, text insertion also happens which
generates an interfering undo action, so we need to disable undoing
temporary.
Also need to invalidta SID_UNDO slot to make the undo toolbar item updated
after we insert a form field.

Change-Id: I358c2704cb30212a38f8a998888a36f72fa404e5
Reviewed-on: https://gerrit.libreoffice.org/68956
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I28a8d96d3ff31a53512af6d61c58594da7b9f73e
Reviewed-on: https://gerrit.libreoffice.org/68008
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Idb164537abb0011b223b952df1dc2fc9cc414904
Reviewed-on: https://gerrit.libreoffice.org/68955
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Icd9f7ebab89d6c2b166b6f42fd7682e89127fd51
Reviewed-on: https://gerrit.libreoffice.org/68903
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7f9ff0fc58adf51eae7fef5ce925b91b8d1f4922
Reviewed-on: https://gerrit.libreoffice.org/68940
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifb2c9a2d1d7dcc0ed3e8458c1a13933ccababd4c
Reviewed-on: https://gerrit.libreoffice.org/68939
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa
Reviewed-on: https://gerrit.libreoffice.org/68938
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1fcde14b66ce80157cbebe7f3ec8c5ced1e13143
Reviewed-on: https://gerrit.libreoffice.org/68937
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I89bea33e3a07655a25f1951109679188532001dd
Reviewed-on: https://gerrit.libreoffice.org/68943
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Move XRefreshable Java tests to C++ for ScAreaLinkObj.
To make this test work, had to provide parameter aSourceArea (in this
case file sc/qa/extras/testdocuments/scarealinkobj.ods). All the other
depended tests of ScAreaLinkObj had to adjusted to the new test
environment.
Also fixes i84711, because the XRefreshable test runs independent from
the other tests, as mentioned in the bug description.

Change-Id: I8847813431e2fdd60ed95be0f7d115bcaeafe500
Reviewed-on: https://gerrit.libreoffice.org/68949
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Accidentally formatted some files, and decided to keep them formatted
then revert everything.

Change-Id: I8e3127fc1e255dfe95ba0736d9cabeeede17ae24
Reviewed-on: https://gerrit.libreoffice.org/68950
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Add all split shared formula groups to regrouping and mark for
listening, even if the references had not be to adjusted.

This partly also resolves tdf#120013 but there's more to that, a
remaining partial group is not updated.

Change-Id: If6d1fef7e545017232a1b7e29b4d60dd58775e88
Reviewed-on: https://gerrit.libreoffice.org/68951Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins