After all, everyone else using DocumentInserter across the codebase
does the same.

For KDE4, an attempt to reuse the same filepicker dialog sporadically
crashes in the depths of (old-ish, possibly buggy) libQt due to nested
event loop and/or recursive repaints.

(crash scenario: Calc > Sheet > Link to external data > Browse > double-click
a file > Browse again > Kaboom!)

Change-Id: Ib494203abd07873919b8394a442f09c5329d237c
Reviewed-on: https://gerrit.libreoffice.org/49082Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Add new alternative reference formats, stored by
the proposed text:reference-language attribute.

This is an implementation of the ODF improvement draft
published in the bug report.

Note: choose Hungarian locale setting to show the
new "Article a/az + Page" etc. reference formats
in dialog window "Fields".

Change-Id: I210d4b9a3e821fb4e45e24643bad9c70b867c89d
Reviewed-on: https://gerrit.libreoffice.org/48944Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I9e8c87beb86ee073d6b5ee95c3f80e6dc55a99e9
Reviewed-on: https://gerrit.libreoffice.org/49117Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

This fixes loads of warnings like this one:

warn:legacy.osl:22335:22335:writerfilter/source/dmapper/StyleSheetTable.cxx:1611: Exception in StyleSheetTable::getOrCreateCharStyle - Style::setPropertyValue

during import. They are harmless as we catch the exception, but they are
just noise. It seems the code that transforms grab-bag pseudo-props into
real props was added in commit 4c3ba3a4
(fdo#75757: Remove inheritance from std::map., 2014-07-26), which is
supposed to be a pure refactoring, so just remove this problematic
transformation.

Change-Id: Ibf45bfedc661f9e065405c47623516c4026148a4
Reviewed-on: https://gerrit.libreoffice.org/49105Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

...which had originally been added with 766d2b65
"INTEGRATION: CWS geordi2q10: #111934#: join CWS os21" as

-    rInf.Left( KSHORT(Left()) );
-    rInf.Right( KSHORT(Right()) );
-    rInf.First( short(FirstLeft()) );
+
+    // Handle overflows:
+    SwTwips nTmpLeft = Left();
+    SwTwips nTmpRight = Right();
+    SwTwips nTmpFirst = FirstLeft();
+
+    if ( nTmpLeft > USHRT_MAX ||
+         nTmpRight > USHRT_MAX ||
+         nTmpFirst > USHRT_MAX )
+    {
+        SWRECTFN( rInf.GetTxtFrm() )
+        nTmpLeft = (rInf.GetTxtFrm()->Frm().*fnRect->fnGetLeft)();
+        nTmpRight = (rInf.GetTxtFrm()->Frm().*fnRect->fnGetRight)();
+        nTmpFirst = nTmpLeft;
+    }
+
+    rInf.Left(  KSHORT( nTmpLeft  ) );
+    rInf.Right( KSHORT( nTmpRight ) );
+    rInf.First( KSHORT( nTmpFirst ) );

But later 2a2f9a30 "INTEGRATION: CWS
swqbugfixes10: #i34348# Underflow with negative numbering indent values" had
changed the SwTxtFormatInfo members from KSHORT to SwTwips, presumably obviating
the need for such an overflow check.

Change-Id: Id622d2bbc280e3d825981356e19c7fe9ed23fc5b
Reviewed-on: https://gerrit.libreoffice.org/49077Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4cab78d3566e574e4176ca9b3b9692cd13f5bf86
Reviewed-on: https://gerrit.libreoffice.org/49121Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

This reverts commit 61be109b.

Change-Id: I1e3dc953154a6b75ffb507e9dc554df1acea45bf
Reviewed-on: https://gerrit.libreoffice.org/47442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

part of a larger project to hide BitmapWriteAccess inside Bitmap

Change-Id: Ia46c12b3297107892a6236633c11ca9ada6edbd4
Reviewed-on: https://gerrit.libreoffice.org/49106Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I010339eaf7874e61b5d0e5d41574c54e98ea1921
Reviewed-on: https://gerrit.libreoffice.org/49094Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I346f236e28cb0bd064a7d757b187e5e64544700f
Reviewed-on: https://gerrit.libreoffice.org/49086Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

this looks like an oversight, just use the baseclass member

Change-Id: Ida36be64266bbc33a6bd1d89dcb665d24a6dd83f
Reviewed-on: https://gerrit.libreoffice.org/49075Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

and reduce code duplication

Change-Id: I292d7515b15fce4cf1714c3b11b947493706bc3c
Reviewed-on: https://gerrit.libreoffice.org/49090Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I530c432176ea6bd338387d2f8855f9f477e8ca75
Reviewed-on: https://gerrit.libreoffice.org/49093Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6b6e7b59113fcae8dfafa4ed8586b87d2c82489e
Reviewed-on: https://gerrit.libreoffice.org/49092Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib7ad23257a966447d627b4f73698d9298790f759
Reviewed-on: https://gerrit.libreoffice.org/49042Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie9f63d982acf368d27bb5b97728b060a80e8bd67
Reviewed-on: https://gerrit.libreoffice.org/49047Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie2391b1feed31fe9cee7dc097c57ebebab698705
Reviewed-on: https://gerrit.libreoffice.org/49049Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If4cd747826307e1050eaf4ba38e6201c1e08e84e
Reviewed-on: https://gerrit.libreoffice.org/49048Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ia3c30aa136bdc75ca2aac9b4dff66cd0445c2497
Reviewed-on: https://gerrit.libreoffice.org/49045Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I133e053d19fd39b575f7daf0e70fb5ba5442ec47
Reviewed-on: https://gerrit.libreoffice.org/49044Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I05f1706931612d4d8804cecd860b7195861b1149
Reviewed-on: https://gerrit.libreoffice.org/49043Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id907f466bc9dc45f3e522fb948488eb35c011bfe
Reviewed-on: https://gerrit.libreoffice.org/49041Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

In orcus, a solid fill type uses the foreground color only and ignores
the background color.  Also, let's not use the alpha component as it
would cause the color to not get rendered at all.

Some patches are applied against liborcus in order to adjust the ODF
styles import code for this change.  These changes will be incorporated
in 0.13.3.

Change-Id: I9e8c243cc6a7f366de2393e7b7ecf77366f5f9ea
Reviewed-on: https://gerrit.libreoffice.org/49071Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: Iaeefae99f41926a6af83ae4cef60796d9f2b3980
Reviewed-on: https://gerrit.libreoffice.org/49110Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I7d171fdf21c02af9a14600c5e0c6294c0f3ebb57

Apart from that, the hard coded storage order for ocRRI and ocIpmt
did the same as the general loop, just with a fixed number of
parameters. Instead, limit the number of arguments for the loop
for these opcodes.

Change-Id: I378ccaf60da61c1a385555451456d8422ee33c50

Change-Id: I02926aa962c045081dcf61bfc7a8d2cf522d6e92
Reviewed-on: https://gerrit.libreoffice.org/47011Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

by replacing front/pop_front calls
with use for-range loops with a call clear() afterwards

Change-Id: I5eadebadca688dc2bb9818b67ca8b5f4ddb06acc
Reviewed-on: https://gerrit.libreoffice.org/49089Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

revert

commit ed8dd7f4
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Wed Dec 13 20:22:11 2017 +0000

    ofz: skip tables when parser is invalid

Change-Id: Icf90f53795f6b01678c760771aec34acd93dbe3e
Reviewed-on: https://gerrit.libreoffice.org/49113Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The check was like this ever since 84a3db80
"initial import" (and SwRootFrame::mnBrowseWidth---which the nWidth here is
ultimately assigned to---was also of type long back then).  But the only use
of SwRootFrame::mnBrowseWidth, in the call to SwRootFrame::GetBrowseWidth at

> long nWidth = GetUpper() ? static_cast<SwRootFrame*>(GetUpper())->GetBrowseWidth() : 0;

in SwPageFrame::MakeAll (sw/source/core/layout/calcmove.cxx), assigns it to a
long nWidth that doesn't appear to be used in a context where it needs to be
restricted to USHORT values (at least not any longer?), so assume that initial
check against USHRT_MAX-2000 is no longer needed.

Change-Id: Ibac19ab9d3f5499e817cae0fed79c11a452314f4
Reviewed-on: https://gerrit.libreoffice.org/49096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

According to the crash reports, it's possible for the grammar checking
thread to call GetGrammarChecker, instantiating lightproof, at the same
time as the main thread instantiates LngSvcMgr, which also instantiates
(some?) (all?) grammar checkers.

Ensure that pyuno_loader::CreateInstance() initialises Python only
once with a C++11 thread safe static.

Change-Id: I5b1faba9107355c508831a078366e4a29fdbfadf

Change-Id: Icaa09de92fb25583f35139632fa8453e5fa4dd85

Change-Id: I0de0ceeda63d733779aa595bdbd0f2be97827694

Change-Id: Ia25e5e9968038849d539f9bc112a4a56e6190277
Reviewed-on: https://gerrit.libreoffice.org/49088Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

+ remove the duplicate "top" line

Change-Id: I74f2250d531637ee910e0dfcf77c339acebe8779
Reviewed-on: https://gerrit.libreoffice.org/48679Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4f23971186ab7c61fb6c76422f654291333ee07d
Reviewed-on: https://gerrit.libreoffice.org/49067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I3fb21aaebf97a143954f84e5d41415f58ecd9326
Reviewed-on: https://gerrit.libreoffice.org/49062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I30b53bd7c5105fee6b384441bb2d996b2e216b21
Reviewed-on: https://gerrit.libreoffice.org/48981Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I0fbba0c1b12f9ade703ceee477dae4056fe9d31e
Reviewed-on: https://gerrit.libreoffice.org/48994Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Iba5ffe646e5a6cf8ecfb635c21546025fc5606db
Reviewed-on: https://gerrit.libreoffice.org/48995Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>