Change-Id: Idbad94c9f2f946f4d2be9b0a88ac2fdbbbd71e2b
Reviewed-on: https://gerrit.libreoffice.org/5287Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...with recent Clang trunk towards 3.4

Change-Id: Ie0991c7bd560c30551aeaada426382a889b46391

Change-Id: I338505aa67ef63699fc0d8966fe09db3c050da92

The document itself is stupid and uses a SURROUND_THROUGH object with a number
of empty lines that make it act is if it in fact was SURROUND_NONE, rather
than actually disabling wrapping for the object and be done with it.
But the difference was that Word still managed to fit those empty lines
next to the object into the little space that was there, while LO already
considered the space too small. So keep a compatibility setting for Word
documents in order to avoid problems with such lame documents and hopefully
that's enough.

Change-Id: I7d17b90de381fd86914ce5efd9c5a29fe4850edc

Change-Id: I20154c12b9406b7ea2f8f245aa688859118982f7

Previously this was only handled for drawinglayer shapes.

Change-Id: I7ce440a27ebe44fc867b8a7f4ee62217076677f0

Change-Id: I96efcab67f05407923b022dfd95a94fd8c2169ed

Change-Id: I0010663951fe67bfb864ffdaecb251b3da5a3ac3

Lots of Linux themes are rather 'black' anyway, and yet want the
icon set they selected and the colours too. If this is needed it
can still be forced either by changing the setting back, changing
the setting back in the UI, and/or exporting SAL_FORCE_HC=1

Change-Id: Ia034942db7ec2fdd27b4a0b43f2f19269e05f5c6

using a heuristic that assumes a glyph with unknown char mapping
is the continuation of the preceding glyph. If there is no known
preceding mapping use the run bounds.

(cherry picked from commit 576e4ea6)

Change-Id: I70e58a02d814e14e9592ff8efc0ae630346ae5df

Project: help  190ae2431088d9969b7d5929b92ac003f3282aff

and restore strange custom unit multi unit mode
to these metricfields

Change-Id: I7e228f6fd658374e3f1588c757ef2ed1e6ba78c8

Change-Id: I38046e0e333dc548e5b30c15f11fec7be7f7a7be
Reviewed-on: https://gerrit.libreoffice.org/5285Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  e5b96ea56ae509b4f49dc0cce4cdd702a375dcd2

Change-Id: Iad6ab86123bd3c5f83452a1037c661003dcd7cdc

The CTLayout constructor called CFRetain() on the associated
CTTextStyle's attribute directory (a CFMutableDictionaryRef) and the
destructor then called CFRelease() on it, even if there was no
guarantee it was still the same CTTextStyle. And in the scenario that
caused this crash, AquaSalGraphics::SetFont() had in fact deleted the
original CTTextStyle and created a new one.

It seems to me that these CFRetain() and CFRelease() calls are not
necessary.

Change-Id: I18e03965dd05d450955353f8c48f111c19a069e3

...as is reproducible when creating a new dialog via "Tools - Macros - Organize
Dialogs", adding e.g. some date/time controls to it, then closing LO.

Invalid read of size 8
 at 0x23DD58DB: basctl::Layout::SplittedSide::Remove(basctl::DockingWindow*) (/basctl/source/basicide/layout.cxx:205)
 by 0x23DD4F65: basctl::Layout::Remove(basctl::DockingWindow*) (/basctl/source/basicide/layout.cxx:62)
 by 0x23D847B7: basctl::DialogWindowLayout::RemovePropertyBrowser() (/basctl/source/basicide/baside3.cxx:1459)
 by 0x23E45AB3: basctl::PropBrw::~PropBrw() (/basctl/source/dlged/propbrw.cxx:202)
 by 0x23E45BA5: basctl::PropBrw::~PropBrw() (/basctl/source/dlged/propbrw.cxx:205)
 by 0x7E03A49: VCLXDevice::DestroyOutputDevice() (/toolkit/source/awt/vclxdevice.cxx:56)
 by 0x7E4655D: VCLXWindow::dispose() (/toolkit/source/awt/vclxwindow.cxx:956)
 by 0x7FD451C: UnoWrapper::WindowDestroyed(Window*) (/toolkit/source/helper/unowrapper.cxx:263)
 by 0x95EA632: Window::~Window() (/vcl/source/window/window.cxx:4365)
 by 0x23DD4EFD: basctl::Layout::~Layout() (/basctl/source/basicide/layout.cxx:56)
 by 0x23D89E39: basctl::DialogWindowLayout::~DialogWindowLayout() (in /data/lo/core/solver/unxlngx6/installation/opt/program/libbasctllo.so)
 by 0x23D89E69: basctl::DialogWindowLayout::~DialogWindowLayout() (/basctl/source/inc/baside3.hxx:125)
 ...
Address 0x19d17da0 is 0 bytes inside a block of size 80 free'd
 at 0x4A078DE: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
 by 0x23DD92D5: __gnu_cxx::new_allocator<basctl::Layout::SplittedSide::Item>::deallocate(basctl::Layout::SplittedSide::Item*, unsigned long) (/usr/include/c++/4.8.1/ext/new_allocator.h:110)
 by 0x23DD8C77: std::__cxx1998::_Vector_base<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::_M_deallocate(basctl::Layout::SplittedSide::Item*, unsigned long) (/usr/include/c++/4.8.1/bits/stl_vector.h:174)
 by 0x23DD7F89: std::__cxx1998::_Vector_base<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~_Vector_base() (/usr/include/c++/4.8.1/bits/stl_vector.h:160)
 by 0x23DD73DC: std::__cxx1998::vector<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~vector() (/usr/include/c++/4.8.1/bits/stl_vector.h:416)
 by 0x23DD6A05: std::__debug::vector<basctl::Layout::SplittedSide::Item, std::allocator<basctl::Layout::SplittedSide::Item> >::~vector() (/usr/include/c++/4.8.1/debug/vector:144)
 by 0x23DD6889: basctl::Layout::SplittedSide::~SplittedSide() (/basctl/source/basicide/layout.hxx:80)
 by 0x23DD4EF1: basctl::Layout::~Layout() (/basctl/source/basicide/layout.cxx:56)
 by 0x23D89E39: basctl::DialogWindowLayout::~DialogWindowLayout() (in /data/lo/core/solver/unxlngx6/installation/opt/program/libbasctllo.so)
 by 0x23D89E69: basctl::DialogWindowLayout::~DialogWindowLayout() (/basctl/source/inc/baside3.hxx:125)
 by 0x23D997F3: void boost::checked_delete<basctl::DialogWindowLayout>(basctl::DialogWindowLayout*) (/workdir/unxlngx6/UnpackedTarball/boost/boost/checked_delete.hpp:34)
 by 0x23D99694: boost::scoped_ptr<basctl::DialogWindowLayout>::~scoped_ptr() (/workdir/unxlngx6/UnpackedTarball/boost/boost/smart_ptr/scoped_ptr.hpp:82)
 by 0x23D9A5E7: basctl::Shell::~Shell() (/basctl/source/basicide/basidesh.cxx:223)
 by 0x23D9A717: basctl::Shell::~Shell() (/basctl/source/basicide/basidesh.cxx:248)
 by 0x6942297: SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:1089)
 by 0x6943BAB: SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1484)
 by 0x6943E09: SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1505)
 by 0x69427EC: SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1144)
 by 0x6919441: SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:175)
 by 0x6934542: SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1035)
 by 0x1BC8C5B3: framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1357)
 by 0x1BBAF54B: framework::CloseDispatcher::implts_establishBackingMode() (/framework/source/dispatch/closedispatcher.cxx:540)
 by 0x1BBAEB15: framework::CloseDispatcher::impl_asyncCallback(void*) (/framework/source/dispatch/closedispatcher.cxx:391)
 by 0x1BBAE6AF: framework::CloseDispatcher::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (/framework/source/dispatch/closedispatcher.cxx:228)
 by 0x23A2A71D: framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/dispatchhelper.cxx:142)
 by 0x1BC06442: framework::LayoutManager::MenuBarClose(void*) (/framework/source/layoutmanager/layoutmanager.cxx:2638)
 by 0x1BC062F6: framework::LayoutManager::LinkStubMenuBarClose(void*, void*) (/framework/source/layoutmanager/layoutmanager.cxx:2621)
 by 0x9053555: Link::Call(void*) const (/include/tools/link.hxx:123)
 by 0x9610263: ImplHandleUserEvent(ImplSVEvent*) (/vcl/source/window/winproc.cxx:1975)
 by 0x961173A: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (/vcl/source/window/winproc.cxx:2590)
 by 0x961FCAE: SalFrame::CallCallback(unsigned short, void const*) const (in /data/lo/core/solver/unxlngx6/installation/opt/program/libvcllo.so)
 by 0x961F74D: SalGenericDisplay::DispatchInternalEvent() (/vcl/generic/app/gendisp.cxx:91)
 by 0x171A5821: GtkData::userEventFn(void*) (/vcl/unx/gtk/app/gtkdata.cxx:933)
 by 0x171A587C: call_userEventFn (/vcl/unx/gtk/app/gtkdata.cxx:943)
 by 0x3B78E47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
 by 0x3B78E48157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
 by 0x3B78E481FB: g_main_context_iteration (in /usr/lib64/libglib-2.0.so.0.3600.3)
 by 0x171A47B0: GtkData::Yield(bool, bool) (/vcl/unx/gtk/app/gtkdata.cxx:574)
 by 0x171A82BD: GtkInstance::Yield(bool, bool) (/vcl/unx/gtk/app/gtkinst.cxx:405)
 by 0x906C838: ImplYield(bool, bool) (/vcl/source/app/svapp.cxx:417)
 by 0x9068F00: Application::Yield() (/vcl/source/app/svapp.cxx:451)
 by 0x9068EB0: Application::Execute() (/vcl/source/app/svapp.cxx:396)
 by 0x4EC6117: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1720)
 by 0x9075192: ImplSVMain() (/vcl/source/app/svmain.cxx:162)
 by 0x907529C: SVMain() (/vcl/source/app/svmain.cxx:198)
 by 0x4F0A9C0: soffice_main (/desktop/source/app/sofficemain.cxx:81)
 by 0x40096B: sal_main (/desktop/source/app/main.c:48)
 by 0x40094C: main (/desktop/source/app/main.c:47)

Change-Id: If7ec0fceec6da1731df8ac389406327fbd95b382

Conflicts:
	include/svx/unoapi.hxx

Change-Id: Icd0adbe98727a83fae3822863f7c6395f7474882

- removed some paths from include
- more of this kind will follow

Change-Id: Ia5c410a5b9a7a0dfa5610dd50d82c8b23fcf43b2
Reviewed-on: https://gerrit.libreoffice.org/5288Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>

I changed String class to OUString class in the following:
SwHTMLPosFlyFrm, CSS1Parser, SvxCSS1Parser, SwCSS1Parser classes,
CSS1PropEntry struct and htmlctxt.cxx file.

Change-Id: I5d474a62c28ff3ee3848abb414acdf1b69492278
Reviewed-on: https://gerrit.libreoffice.org/5234Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>

Change-Id: Id8ef8e131b94ff4676af388da2abd437fc1f7704

Project: help  1f981001a22122860b383fd1195f0460c8b7327e

Change-Id: Id6516aec9a4c79d1ccceb06b06582eb00dd8c5eb

Change-Id: If7317c33142d0854a4e10953e1a8bbcb0403ec59
Reviewed-on: https://gerrit.libreoffice.org/5282Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia80ef855dc83bb60dfe484d95e8199679bd58d44

Change-Id: I6b56880e64c4f0bcf7883817f2fb60c2dced4fe3

Change-Id: I4ea660a151992c74afb321f1bae19fdd2c5ee40e

Change-Id: I471f111a654bf6498e39de79912135b7a39f3088

Change-Id: I4894e76dfbfda5fe1bc89641f774b2c96c04486b

to:
 commit 8ee69b0b

 fdo#67235 adapt form control code to time nanosecond API change, step 3.

Change-Id: I57b549c9c1379154173bb50463171a60ce35ca0c

Change-Id: I2524db7dbf07d8899bea6f90d1dcb7cd81acf8d9

The document had 3 sections, separated by continuous section breaks.
Previously only margins from the last section were imported, this way
the first page had default margins.

Now margins are also applied when we hit continuous section breaks. This
way margin values from the last section break affecting the page wins. A
later commit could improve this further by setting the minimum of these
and setting a section margin for each non-minimal sections.

Change-Id: I4d9a4585e795220533909bd1d467d933caaa0d71

SetText itself internally clears the content, except that it doesn't clear
text attributes for some reason.  Since Clear() is quite expensive even when
called with empty content, we need to call it only when necessary.

Change-Id: I25ca36c1c2f690b160511180892595daf43681b3

...to 8ee69b0b "fdo#67235 adapt form control
code to time nanosecond API change, step 3."  It is a bit unclear to me how
exactly this code is used, so to be safe, just read and write in the old format
(of using a single integer to represent a Date resp. Time) at least for now,
loosing nanosecond precision and the UTC flag.

Change-Id: Ib5148f750a420ad09366c79b68370ad0efd501f4

Project: help  58d9629fb0e5264f07cca2f0fb3b75ca467f91c4

Change-Id: I7f541dca151b3e755f1e21de05ee29abd15daebb

Change-Id: I126a4a03618060f8fe8dbe0f1a8caa6d7e891c73

Change-Id: If037eac010d3cb72ca185382232c211758d009e6

Change-Id: I0a4cfd0ddb0c03b0db95d003004195df29a3f6df

Change-Id: I60756d9054dfa5c55aeae8ddc904ddf6d67d2088