Change-Id: Ice59e286debb6bd0eb692f2b2b0c2c5087c069c0
Reviewed-on: https://gerrit.libreoffice.org/39239Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

... to avoid "corrupted" warning from Excel.
In case of string fields, Excel expects the item list to be present,
and containsXXX attributes of sharedItems to be absent, otherwise
it shows a warning about file corruption.
For numeric fields, it doesn't expect item list, othervise it also
warns about file corruption.

Change-Id: I5ded5b836587bed3177eb0a6b6c418e459e6be8b
Reviewed-on: https://gerrit.libreoffice.org/39114Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I854703ea3cb09ace2d0b01a47d9f07bb7a98b70e
Reviewed-on: https://gerrit.libreoffice.org/39172Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

I guess Coverity complained that there was a copy assignment operator
but no copy ctor, move assignment and move ctor defined.

Change-Id: I10641c9f403e609406b2a1420b22abbfc9dbc6fc
Reviewed-on: https://gerrit.libreoffice.org/39240Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fixes c0ce1ec3 "loplugin:unusedfields in sfx2
part1" part on "fix a memory leak in NotebookbarTabControl where it was not
freeing it's m_pListener field", which now caused ASan to report heap-use-after-
free during CppunitTest_sw_dialogs_test.

Change-Id: Ic0209650692a34abd1ee451713615a03ed9c746f

Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5
Reviewed-on: https://gerrit.libreoffice.org/39232Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I9aadcb9a12ef9b0c3f93ea255f2542e51d31fbf7
Reviewed-on: https://gerrit.libreoffice.org/39242Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "r".

Additionally:
- Translates test strings in /registry/test/testregcpp.cxx

Change-Id: I9fda72a3d1830268c4eb83d67ee7a95e38c31c0d
Reviewed-on: https://gerrit.libreoffice.org/39210Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

COMPMOD_RESPREFIX=abp was unused ever since initial commit in 2001.

COMPMOD_NAMESPACE was used to set the namespace name qualifier of
the helper in componentmodule.hxx to the extension's namespace name.

I don't see why this is necessary as the helper is always compiled in
a separate extension library.

Change-Id: I287607008db3dc0ebc32731536747a921c91807d
Reviewed-on: https://gerrit.libreoffice.org/39184Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Those will be implicitly-defined by compiler and a move assignment
operator should be implicitly-defined now too.

Change-Id: I03c4bb3b95e76c706b606a170ed02c2a39862b36
Reviewed-on: https://gerrit.libreoffice.org/39246Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264
Reviewed-on: https://gerrit.libreoffice.org/39164Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0fee8bcddaeea48335e3be05761d2ad2c45020e2
Reviewed-on: https://gerrit.libreoffice.org/39238Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iacdf76eec11aedc8a3308897edfda400790bdc19
Reviewed-on: https://gerrit.libreoffice.org/39245Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Project: help  b915986913b52910c342eb831351897868226c0d

Help-in-browser (v)

* Add piwik analysis
* handle SHARED module in search

Change-Id: I7c3c653d5e1211eed6c45b521fc35a9dc52ed21e
Reviewed-on: https://gerrit.libreoffice.org/39251Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

The export code is not called, because the PageShape is actually
of type presentation.PageShape and not drawing.PageShape. A
PageShape has no text at all, which results in an empty p:txBody
element that fails validation, so it needs to be checked first if
the shape actually has text.

Change-Id: I559f15c2396739c74d5c4f36eb952754bc040ce8
Reviewed-on: https://gerrit.libreoffice.org/38574Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Ia953443ba352aea1b33b6efd312a0e95a6b8918e
Reviewed-on: https://gerrit.libreoffice.org/39244Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ifd4826f8ba4e10f2e012172fa693794d68bb6b4d
Reviewed-on: https://gerrit.libreoffice.org/39188Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia9b20a8ca95684cbeb21e3425972c43ba50df3cd
Reviewed-on: https://gerrit.libreoffice.org/39187Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I96d6af49c1994ebd7d6dcc41469127e3151b4350
Reviewed-on: https://gerrit.libreoffice.org/39186Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

in the process, eliminate the need to explicitly specify the
source/destination type at the callsites.

Change-Id: Ie556645791a479989fb737933f1dd58e8533cb1c
Reviewed-on: https://gerrit.libreoffice.org/39171Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ERRCODE_AREA_SO and ERRCODE_AREA_SBX were being referenced before their
definition., by ERRCODE_AREA_SVX_END and ERRCODE_AREA_SO_END

Change-Id: I51af1752290479adf0985746253134a0924b1e17
Reviewed-on: https://gerrit.libreoffice.org/39150Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If61037a2df12fd7389f46913d96f4b386460fc76
Reviewed-on: https://gerrit.libreoffice.org/39205Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

since commit 95c348af
    loplugin:unusedfields in svx part2

Change-Id: I6d5f3704f4efef0a9fb69623f46a216c509c8302
Reviewed-on: https://gerrit.libreoffice.org/39229Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: Ie0339482bf3a9b108e26008526bc5e73b761d27b
Reviewed-on: https://gerrit.libreoffice.org/39223Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id4e92f0c7927bbc767061461361936dbad8da778
Reviewed-on: https://gerrit.libreoffice.org/39204Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8debaa590c570ea7a6447668b053a2d4c507edf0
Reviewed-on: https://gerrit.libreoffice.org/39203Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I10c9a8d1474920afb7f6afc4d7d34172c398ab4d
Reviewed-on: https://gerrit.libreoffice.org/39201Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I26d8b665e8940fd3821d29ced0046c2d1dd5a59c
Reviewed-on: https://gerrit.libreoffice.org/39200Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9db651d2d9763aca8c70c1a313bab8d7d4d73e10
Reviewed-on: https://gerrit.libreoffice.org/39228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic1d171cf11cf36058f6d1f40c9ca041012e1b0e1
Reviewed-on: https://gerrit.libreoffice.org/39198Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic914d9240e6b06b7e6550fe311fd69e310254bd5
Reviewed-on: https://gerrit.libreoffice.org/39197Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If2e4c06a1d083f82ab531a15ae0bd983f7a5586e
Reviewed-on: https://gerrit.libreoffice.org/39199Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and use references instead of pointers for output parameters.

Change-Id: Ib91a821ff84e464639aa6f09a44ba00301f1d783
Reviewed-on: https://gerrit.libreoffice.org/39220Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I17bd01dc129f0e530d5e227a5ddc12f11486e85d
Reviewed-on: https://gerrit.libreoffice.org/39206Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I774497c07f682a3923a6317af5804e477540995c
Reviewed-on: https://gerrit.libreoffice.org/39225Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I9c8933616d36027314c990301e67a54c567429b5
Reviewed-on: https://gerrit.libreoffice.org/39222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I1b2fa0db88bf9b25283ff532f9634eb4605775c3
Reviewed-on: https://gerrit.libreoffice.org/39221Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I48e4bcce447a1efdb37d6dca9e5808ec8d73492b

Change-Id: I9945df95e14fbca47f7cea80b1d4097d00a3eb54

Project: help  181b72469b27cc2f711525838463e98a0920161c

Help-in-browser: several improvements

* tabs for Contents/Index/Search
* product version (6.0, 5.3, 5.2, etc...)
* capable to receive URL from LibreOffice help call
(need to change help url in sfx2/:
protocol://<host>/index.html?<params>

Change-Id: I2244336ea47cdb923884ae97b9f4a586d85ec706
Reviewed-on: https://gerrit.libreoffice.org/39227Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>