- 29 Mar, 2019 8 kayıt (commit)
-
-
Serge Krot yazdı
Change-Id: Ic0c4b6f7480a4c6c3f53bd04e285cb0cab172531 Reviewed-on: https://gerrit.libreoffice.org/69888 Tested-by: Jenkins Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 8a76b845) Reviewed-on: https://gerrit.libreoffice.org/69933Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
and ensure the modify arrives after the input text has been filtered Change-Id: I16c0bd095700e7d9858e3e74884b5a1ad3eb7e4c Reviewed-on: https://gerrit.libreoffice.org/69764 Tested-by: Jenkins Reviewed-by:
Xisco Faulí <xiscofauli@libreoffice.org>
-
László Németh yazdı
to show/handle them in Calc AutoFilter. Partial revert of "tdf#116666 fix Hungarian sorting" (commit 7b1eb631). Change-Id: Ib135f1eac77780e901fb4c427c3f1bb8a5e090b9 Reviewed-on: https://gerrit.libreoffice.org/68014 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org> (cherry picked from commit 7618490d) Reviewed-on: https://gerrit.libreoffice.org/69496Reviewed-by:
Eike Rathke <erack@redhat.com>
-
Christian Lohmaier yazdı
Change-Id: I1307c30f732e0ea12dc65e1f80503a0145371566
-
Christian Lohmaier yazdı
* Update translations from branch 'libreoffice-6-2' - update translations for 6.2.3 rc1 and force-fix errors using pocheck Change-Id: I76da2876015e25484eb696c3278818f0b4f032d1 -
Stephan Bergmann yazdı
...for compatible changes 61c4f96d "Support AdoptOpenJDK" and 41507db5 "Support Amazon Corretto". Changing <updated> causes jfw_startVM and jfw_getSelectedJRE (both jvmfwk/source/framework.cxx) to fail with JFW_E_INVALID_SETTINGS, which in turn causes functionality that requires a JVM to issue a GUI error dialog stating that the user must select a new JRE in the Options dialog. While that behavior makes sense if a JRE was selected that would no longer be supported by the modified javavendors_*.xml, it is just annoying if an already selected JRE is still supported. And a compatible change to javavendors_*.xml implies that an already selected JRE will still be supported. Now, on master towards LO 6.3, javavendors_*.xml have meanwhile been changed incompatibly with 49c21e31 "Javavendors: Set minimum version to 1.6", so keep <updated> updated there. And the updated <updated> from 61c4f96d "Support AdoptOpenJDK" are included in the published LO 6.2.1, so don't change those back. But the updated <updated> from the subsequent 41507db5 "Support Amazon Corretto" (cherry-picked to libreoffice-6-2 towards LO 6.2.3 as be9c3ff7) have not yet been included in a published LO, so they can be changed back to the previous values. Change-Id: I59113db8c3c6c449947692597bc9a3b2c4504a26 Reviewed-on: https://gerrit.libreoffice.org/69730 Tested-by: Jenkins Reviewed-by:
-
Dennis Francis yazdı
at specified position. At least in case of ScUndoPaste, during undo operation, the content from changed area in main-document is removed before actual undo-paste, so when cloned formula-cell from undo-doc is inserted to main-doc, there is no "old" cell to detach, so "rNewSharedRows" is not populated which is needed for proper re-establishment of listeners if there are formula/ formula-groups adjacent to insertion position. Change-Id: Id2bfb65a2a7a5abb03effbdcc4405015fddc401c Next: fix the vector version of this case and write unit tests. Reviewed-on: https://gerrit.libreoffice.org/69737 Tested-by: Jenkins Reviewed-by:
-
Serge Krot yazdı
Change-Id: Ib241edd07e4c6781d80db274f73146bda310d8c0 Reviewed-on: https://gerrit.libreoffice.org/69827 Tested-by: Jenkins Reviewed-by:
-
- 28 Mar, 2019 6 kayıt (commit)
-
-
Caolán McNamara yazdı
we were emitting page-entered but not emitting the page-leave signal Change-Id: I64131631016331cf102d08244982148ac8c3c69c Reviewed-on: https://gerrit.libreoffice.org/69686 Tested-by: Jenkins Tested-by:
Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-
Eike Rathke yazdı
This is a combination of 4 commits. Add unit tests for tdf#123736 and related unshared/regrouped listening Reviewed-on: https://gerrit.libreoffice.org/69372 Tested-by: Jenkins Reviewed-by:
-
Luboš Luňák yazdı
Normally when ScInterpreter has bMatrixFormula set, pMyFormulaCell is set as well (done in the ctor). But in some rare cases, this may not be so, and some functions such as ScRandom() already check for this. But not all do, tdf#123479 specifically crashes because ec974965 added AssertFormulaMatrix() to force bMatrixFormula be set without pMyFormulaCell being set, and ScColumn() doesn't handle this case. Fix this by trying to pass ScFormulaCell* to ScInterpreter when AssertFormulaMatrix() is used, this should ensure the result in the formula editor fits better the edited formula. Since there still may be cases when the cell is not set (e.g. editing a new formula), also handle that case gracefully. Ideally ScSimpleFormulaCalculator should pass ScMarkData to ScInterpreter in such cases so that those functions use that when they can't use GetMatColsRows(), but currently the handling of selections is rather poor in the formula edit dialog: Non-array formulas are simply entered in one cell and the selection is ignored, in case of a multi-selection there's an error dialog only after the dialog is closed, and the result field of the dialog is rather small and doesn't scroll, so e.g. matrix result of ScRandom() wouldn't show more than one item anyway. Given that tdf#123479 is a priority bug, better just fix it and possibly handle selections better somewhen later. Change-Id: I5fcbe1e358fac3623d4917eb0ead8eae00a1e153 Reviewed-on: https://gerrit.libreoffice.org/69161Reviewed-by:
Dennis Francis <dennis.francis@collabora.com> Reviewed-by:
Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by:
Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit ade1df09) Reviewed-on: https://gerrit.libreoffice.org/69849 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Regression from commit 50223ea6 (tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31), SwFEShell::ImpEndCreate() was not adapted to call SwTextFrame::GetBaseVertOffsetForFly() when determining the vertical position of the inserted shape. The call can be unconditional, the returned value is already 0 when the DocumentSettingId::ADD_VERTICAL_FLY_OFFSETS compat setting is false. (cherry picked from commit 4218caf1) Conflicts: sw/qa/extras/uiwriter/uiwriter2.cxx Change-Id: Iec6af5a6d1ff3466e08377853cc8ca84f33a76d1 Reviewed-on: https://gerrit.libreoffice.org/69766 Tested-by: Jenkins Reviewed-by:
-
Luboš Luňák yazdı
Apparently the Color class uses transparency as the opposite of the normally used meaning of opacity, so transparency 255 means transparent. Change-Id: I3a76c2c93d98ad3c850017d3fd569b04dc6c19c8 Reviewed-on: https://gerrit.libreoffice.org/69211 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6cf42add) Reviewed-on: https://gerrit.libreoffice.org/69671Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Luboš Luňák yazdı
If the bitmap to be written is non-8bit, e.g. in case of using OpenGL (on Linux the test requires "SAL_FORCEGL=1 SAL_USE_VCLPLUGIN=gen", on Windows it's probably the default case), then the bitmap is not in native format for 8bit. This was done correctly by 45e8e0fb that introduced it but somehow it got lost later (I can't even find where). Reviewed-on: https://gerrit.libreoffice.org/69213 Tested-by: Jenkins Reviewed-by:
-
- 27 Mar, 2019 3 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: Ie14600e9f9a1e1c4e99c7a872f5d677453481888 Reviewed-on: https://gerrit.libreoffice.org/69666 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
See https://bugs.documentfoundation.org/show_bug.cgi?id=123999#c14 Change-Id: I47ff6171c873c701794f179b924005c43551ba21 (cherry picked from commit 3149ffea) Reviewed-on: https://gerrit.libreoffice.org/69786Reviewed-by:
Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
-
Luboš Luňák yazdı
If the bitmap to be drawn will need to be scale for drawing, OpenGL handles this by scaling, but the scaling is of poor quality. Other backends scale in such a case with a good quality, and e.g. opengl's drawAlphaBitmap() also does the same check, so copy that check to drawBitmap() as well. Change-Id: If6a457c69c6676d03fa4046b9910683f51479d21 Reviewed-on: https://gerrit.libreoffice.org/69556 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com>
-
- 26 Mar, 2019 6 kayıt (commit)
-
-
Thorsten Behrens yazdı
Temp fix, since update check is an extension, and extensions can't currently modify notebookbars. This needs implementation of something like https://wiki.openoffice.org/wiki/Framework/Article/Addon_Menu_Toolbar_Merging for notebookbar popup menus. Such that Addons.xcs provide some merge points with notebookbar menu IDs, we can then plug into existing popup menus. Change-Id: If30525fec1e7be0429e351588614618c5f56cdd4 Reviewed-on: https://gerrit.libreoffice.org/69735Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> Tested-by:
-
Samuel Mehrbrodt yazdı
Reintroduce the UpdateFields call, but guard it so that it does not modify the doc (as it was before) Change-Id: I23e814f0b5d900d145dc82272034f03e66c079ed Reviewed-on: https://gerrit.libreoffice.org/69696 Tested-by: Jenkins Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 055480aa) Reviewed-on: https://gerrit.libreoffice.org/69727Reviewed-by:
-
Eike Rathke yazdı
This was done long ago for the tr-TR locale as well. Change-Id: I5bf8595f6d49adb7fd76b3c4924c4d72b3b8ea5e Reviewed-on: https://gerrit.libreoffice.org/69717Reviewed-by:
-
Eike Rathke yazdı
This is a combination of 7 commits. Resolves: tdf#123714 tdf#123736 all split formula groups; tdf#120013 related Add all split shared formula groups to regrouping and mark for listening, even if the references had not be to adjusted. This partly also resolves tdf#120013 but there's more to that, a remaining partial group is not updated. Reviewed-on: https://gerrit.libreoffice.org/68951Reviewed-by:
-
Mike Kaganski yazdı
https://aws.amazon.com/corretto Change-Id: I7f9ef25e1e81ededce426bad661adc6880feb9d3 Reviewed-on: https://gerrit.libreoffice.org/67289 (cherry picked from commit 41507db5) Reviewed-on: https://gerrit.libreoffice.org/69688 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Noel Grandin yazdı
regression from commit 6be7e2e9 Date: Thu Aug 30 13:54:33 2018 +0200 pass SdrUndoAction around by std::unique_ptr Looks like previously this memory was just leaked, so fix that and the crash Change-Id: I5eb5c104dccd82cef30af533ce1fe8546ced0ea0 Reviewed-on: https://gerrit.libreoffice.org/69648 Tested-by: Jenkins Reviewed-by:Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit dec5b119) Reviewed-on: https://gerrit.libreoffice.org/69662
-
- 25 Mar, 2019 6 kayıt (commit)
-
-
Mike Kaganski yazdı
Reportedly under some circumstances execution of wusa.exe may hang for very long time (available logs show more than 90 min). LO MSI installer waits for wusa.exe indefinitely in its deferred inst_msu custom action; during this wait, one can't abort the installation. There is an evidence [1] that stopping WU service prior to wusa launch might prevent this hang. The patch does two things: 1. It stops running WU service prior to wusa launch. 2. It adds a check for user input by executing MsiProcessMessage twice a second, and checking its return value, to allow early return in case user cancels the installation. This is a blind shot, since I cannot reproduce the problem myself. [1] https://superuser.com/questions/1044528/ Change-Id: I8bf4ce52b3e9d98a4f90af3abcc49ac63b6a0e40 Reviewed-on: https://gerrit.libreoffice.org/69487Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by:
-
Tomáš Chvátal yazdı
The RegexMatcher.find(status) is new since icu 55 and this works even on the old releases thus revert there to the available albeit slower call. Change-Id: I964c10efd15515b04ac9037cda3b5b309910baf5 Reviewed-on: https://gerrit.libreoffice.org/69311 Tested-by: Jenkins Reviewed-by:
Tomáš Chvátal <tchvatal@suse.cz> Tested-by:
-
Tomáš Chvátal yazdı
Change-Id: Ifbdbf7f2d44d569c491b1822d9d842433a9978a1 Reviewed-on: https://gerrit.libreoffice.org/69461Reviewed-by:
-
Tomáš Chvátal yazdı
This is also fixed with master with boost bump which we do not need here. Change-Id: I61caec10c0c6d442cef3d51c31eaff01f18b89e3 Reviewed-on: https://gerrit.libreoffice.org/69310Reviewed-by:
-
Noel Grandin yazdı
regression from commit 52f69445 Date: Wed Aug 1 17:03:18 2018 +0200 loplugin:stringloop in sc Change-Id: I7d481ea27866fc146c5de9d027aa7bb308f14e52 Reviewed-on: https://gerrit.libreoffice.org/69652 Tested-by: Jenkins Reviewed-by: -
Tünde Tóth yazdı
When the sheet name/cell address separator was an exclamation mark, bad conversion of the optional dot separator replaced the last dot of the exported sheet name, resulting broken links: 'sheet.name.with!dot'!A1 Change-Id: I84fb6c8da345c144b04657ea350f1f96614071b7 Reviewed-on: https://gerrit.libreoffice.org/69272 Tested-by: Jenkins Reviewed-by:
Tünde Tóth <tundeth@gmail.com>
-
- 22 Mar, 2019 4 kayıt (commit)
-
-
Khaled Hosny yazdı
This partially reverts: commit 436b829f Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Thu Aug 16 17:35:17 2018 +0200 sw: save one vcl layout call in SwFntObj::DrawText() Pressing a key in Writer used to lay out the relevant string 4 times (counting GenericSalLayout::LayoutText() invocations), save one of them by pre-calculating the layout and sharing it between GetTextArray() and DrawTextArray(). The reverted part was causing inserted Kashida to be missing, leaving gaps inside the words. See attachment in the bug report. Change-Id: Iaafbc793ed5906e6fdf3dcb03c54d5a440e15da4 Reviewed-on: https://gerrit.libreoffice.org/69530 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Regression from commit b2c1474c (SwTxtNode::IsIgnoredCharFmtForNumbering: ignore RES_CHRATR_COLOR, 2014-11-20), where the problem was that unconditionally ignoring or not ignoring the font color is not correct. Re-examining the test document from the above commit, it has an explicit font color set in the numbering, while this bugdoc doesn't have it. So make applying the paragraph mark font color to the numbering conditional if the numbering already has a color set, this makes both cases work correctly. (cherry picked from commit 00ac1906) Change-Id: I43a6dec7d3a77689e2acbdc9d3671e79a9c4cac8 Reviewed-on: https://gerrit.libreoffice.org/69476 Tested-by: Jenkins Reviewed-by:
-
Khaled Hosny yazdı
This reverts commit c45b2337. This commit breaks Kashida justification when a document is first opened (the kashida justification will be disabled and spaces will be used untill the text is changed). Probably it is checking for width of Kashida glyph too early. Also I'm not sure what the reverted commit was trying to fix since we already do kashida justification in fonts that has non-zero width Kashida and it has been the case for a long time. This does not fix the original issue in the document attched with the bug report, but if fixes kashida not being applied when opening the document. Change-Id: Ic95859bca94fa792793e3223d2adb465bc6d880f Reviewed-on: https://gerrit.libreoffice.org/69509 Tested-by: Jenkins Reviewed-by:
Khaled Hosny <khaledhosny@eglug.org>
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'libreoffice-6-2' - Backport of Help online donnation button Change-Id: I600ca4327385d36d00fe042bbdb36b906d199f75 Reviewed-on: https://gerrit.libreoffice.org/69511 Tested-by: Jenkins Reviewed-by:Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
- 21 Mar, 2019 7 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I0c4f6775b8bc9fae8dc81f07fec2e21218e36037 Reviewed-on: https://gerrit.libreoffice.org/69521 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Iaa2ee6c982c8fd5d5cf1b9b09a835b917217d85c Reviewed-on: https://gerrit.libreoffice.org/69517Reviewed-by:
-
Mark Hung yazdı
Indefinite duration isn't necessary for indefinite repetition, so simply check the number of iteration left and do not decrease the number when the repetition is indefinite. Note: a known issue is that the next effect starts before "until click" or "until next slide" if the starting time of the next slide is "after previous". A workaround is to set the starting time of the next slide to "click". Change-Id: Ie9c73b472dc400bc41501029ff19ecc3e3fab2df Reviewed-on: https://gerrit.libreoffice.org/67896 Tested-by: Jenkins Reviewed-by:
Mark Hung <marklh9@gmail.com> (cherry picked from commit cacdb1ae) Reviewed-on: https://gerrit.libreoffice.org/69100Tested-by:
-
Katarina Behrens yazdı
qt5 didn't provide implementation of virtual SalMenu::ShowMenuBar so native menu bar was visible at all times. Hopefully notebookbar fans are happier now Change-Id: Ie581397521369160e16f40231bade40100dcd6f6 Reviewed-on: https://gerrit.libreoffice.org/69327 Tested-by: Jenkins Reviewed-by:
-
Katarina Behrens yazdı
Change-Id: I1492423fe6110bdc79aa68c715e968770f6767ab Reviewed-on: https://gerrit.libreoffice.org/68672 Tested-by: Jenkins Reviewed-by:
-
Juergen Funk yazdı
the problem is that at least the msvc_win32_x86-64 bridge's unoInterfaceProxyDispatch (bridges/source/cpp_uno/msvc_win32_x86-64/uno2cpp.cxx) requires pUnoReturn to be a nullptr when the UNO method has VOID return type (see computation of retKind in cpp_call in the same file), but that IdlInterfaceMethodImpl::invoke doesn't set up the arguments according to that expectation. Change-Id: I187a997300571cd9822de2eeacf7ad887ad00a4f Reviewed-on: https://gerrit.libreoffice.org/69495Reviewed-by:
-
Caolán McNamara yazdı
of the widget after gaining focus, otherwise gtk loses track of where the focus should be and tdf#124226 do fill-on-demand hack only on first visit disconnect focus handler after the fill Change-Id: I90d9f36acf807aec8687c7f563449ef16d5eb574 Reviewed-on: https://gerrit.libreoffice.org/69356 Tested-by: Jenkins Reviewed-by:
-
