In my macOS build, that clang::tooling::runToolOnCodeWithArgs invocation failed
to find headers like cassert and assert.h, which works now with

  COMPILER_PLUGINS_TOOLING_ARGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -isystem /Users/stephan/Software/llvm/inst/include/c++/v1

added to my autogen.input (I build against my Clang trunk libc++ whose headers
are at /Users/stephan/Software/llvm/inst/include/c++/v1).

Change-Id: Idbffa39c9fd4a88743fd498b8f7b6c9c56d7630d
Reviewed-on: https://gerrit.libreoffice.org/69538
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

on the fontconfig/harfbuzz/cairo drawing path for preset variations

Change-Id: I95ef68aecfd59687ae9aae58e01e394c83c6ea9e
Reviewed-on: https://gerrit.libreoffice.org/69505
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

As seen in include/sfx2/dispatch.hxx IWYU proposes to replace
o3tl/span.hxx with fw declaration, but that won't compile

Change-Id: If5739075bd91511cf22a39f3382c424c21829053
Reviewed-on: https://gerrit.libreoffice.org/69397
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I4f3731e2236f1b8be97a6f5d21e32e678610fecb
Reviewed-on: https://gerrit.libreoffice.org/69532Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

since...

commit 57ca02a7
Date:   Wed Apr 18 00:04:09 2018 +0200

    NB Impress tabbed toolbar big update

Change-Id: I357a65b5f71ff9960f36d2e4ae64117509b41a48
Reviewed-on: https://gerrit.libreoffice.org/69536
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

since...

commit 57ca02a7
Date:   Wed Apr 18 00:04:09 2018 +0200

    NB Impress tabbed toolbar big update

    Reviewed-on: https://gerrit.libreoffice.org/53072

Change-Id: I45f099d2521db576089e8d555f7ccc8fef6d49bc
Reviewed-on: https://gerrit.libreoffice.org/69535
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

since...

commit 57ca02a7
Date:   Wed Apr 18 00:04:09 2018 +0200

    NB Impress tabbed toolbar big update

Change-Id: I7c59d5388138166851c24d1494dc3293a32f8330
Reviewed-on: https://gerrit.libreoffice.org/69537
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4883d3f79250edeafb78fa58f993955b5839f041
Reviewed-on: https://gerrit.libreoffice.org/69531
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This partially reverts:

commit 436b829f
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date:   Thu Aug 16 17:35:17 2018 +0200

    sw: save one vcl layout call in SwFntObj::DrawText()

    Pressing a key in Writer used to lay out the relevant string 4 times
    (counting GenericSalLayout::LayoutText() invocations), save one of them
    by pre-calculating the layout and sharing it between GetTextArray() and
    DrawTextArray().

The reverted part was causing inserted Kashida to be missing, leaving gaps
inside the words. See attachment in the bug report.

Change-Id: Iaafbc793ed5906e6fdf3dcb03c54d5a440e15da4
Reviewed-on: https://gerrit.libreoffice.org/69530
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

The text frame is swapped in this case, so handle BTLR similar to the
normal vert (TBRL) case and the background will be positioned correctly
behind the text portion.

Change-Id: I2399131ef74ea8849577a467ad9bb02d980d8609
Reviewed-on: https://gerrit.libreoffice.org/69539
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8f6a170e4bbb5d0a0bf06d26560189e4ca7ecfb0

Change-Id: I2b574cc7ddaf55e770bc5b746e615834f413b6b4
Reviewed-on: https://gerrit.libreoffice.org/69540Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I54ffd3ea66fcb5d6e7eb9922a1bb5e848ac74c58
Reviewed-on: https://gerrit.libreoffice.org/69542
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I3cb9d607c468cf29ef3e409c4f59b7e0960362a7
Reviewed-on: https://gerrit.libreoffice.org/69544
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Doxygen is misled by the "127." at the beginning of a sentence and
converts it to "<ol><li>..."

So it is erroneously rendered as:
all ASCII characters are in the allowed range between 0 and
   1. The ASCII string must be NULL-terminated.

Change-Id: If36de7d4df668b5f9e9f6c7ea139552798e349d2
Reviewed-on: https://gerrit.libreoffice.org/69360Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I87e18e8624d63de18bd6e0d68eececab75e7166b
Reviewed-on: https://gerrit.libreoffice.org/69527
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I0c4f6775b8bc9fae8dc81f07fec2e21218e36037
Reviewed-on: https://gerrit.libreoffice.org/69520
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I36606503c469cb069f81f57ac4f0836842c12e0f
Reviewed-on: https://gerrit.libreoffice.org/69513
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I3f72089d2f0dc4b34f166841049a6d0c757333cb
Reviewed-on: https://gerrit.libreoffice.org/69526
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I38e30fb45aed7d2b8f39348e92afeb6a6f85ef6e
Reviewed-on: https://gerrit.libreoffice.org/69525
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I58ae4b4c7b94ba4d821681448e2cca19210db346
Reviewed-on: https://gerrit.libreoffice.org/69524
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Iaa4ff5cd30d3163e7a44f162bbe296c59a7111cb
Reviewed-on: https://gerrit.libreoffice.org/69514
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Calculate the relative position of the floating toolbars by calling
the ImplCallMove function, where the current position is read from
the real window.

Change-Id: I6a142055c3340dda2339980fbc5a7ebb431e228b
Reviewed-on: https://gerrit.libreoffice.org/64093
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Iaa2ee6c982c8fd5d5cf1b9b09a835b917217d85c
Reviewed-on: https://gerrit.libreoffice.org/69516Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>

This reverts commit c45b2337.

This commit breaks Kashida justification when a document is first opened (the
kashida justification will be disabled and spaces will be used untill the text
is changed). Probably it is checking for width of Kashida glyph too early. Also
I'm not sure what the reverted commit was trying to fix since we already do
kashida justification in fonts that has non-zero width Kashida and it has been
the case for a long time.

This does not fix the original issue in the document attched with the bug
report, but if fixes kashida not being applied when opening the document.

Change-Id: Ic95859bca94fa792793e3223d2adb465bc6d880f
Reviewed-on: https://gerrit.libreoffice.org/69509
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

In method SetHandleControllerPosition() all transformations are
reversed to get the coordinates in shape inner coordinate system
from the outer position. The error was, that the first
transformation, the move in method GetPoint was forgotten. In case
of default viewBox '0 0 21600 21600' it is not visible. But the
error is noticeable, if left or top do not equal zero.

Change-Id: Icc3f4f2c603826151c95b8b9eea5030fb5805d67
Reviewed-on: https://gerrit.libreoffice.org/69439
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I7c1e11ec57537441417f6b1cebe137587883d8c1
Reviewed-on: https://gerrit.libreoffice.org/69259
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

i.e. don't tag custom shapes and other than bitmap background fills

Change-Id: I1d42012420f59e1e7b62affb8aca5a8c85688423
Reviewed-on: https://gerrit.libreoffice.org/69258
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

in particular, don't terminate L prematurely

Change-Id: Iaf642f547b072b12ccbf861536825a2526b8798a
Reviewed-on: https://gerrit.libreoffice.org/69257
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

No functional change, but avoid the warning.

Change-Id: Ia552c6199806a9e029800e9d65c0852baa370bd8
Reviewed-on: https://gerrit.libreoffice.org/69270
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

SvxChartColorTableItem has non-const members (aka modifiers)
which is bad for SfxItems in general, see comments in change.
Adapt SvxChartColorTableItem and it's usage in
SvxDefaultColorOptPage as needed.
This is also preparation for possible SfxItem refactoring

Change-Id: Ia7982b4e7bbfa736229223e55ce63e02143b8cf7
Reviewed-on: https://gerrit.libreoffice.org/69499
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

Change-Id: I085cb646037f260ada4d4d04c2419638dd235048
Reviewed-on: https://gerrit.libreoffice.org/69264
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>

the problem is that at least the msvc_win32_x86-64 bridge's 
unoInterfaceProxyDispatch 
(bridges/source/cpp_uno/msvc_win32_x86-64/uno2cpp.cxx) 
requires pUnoReturn to be a nullptr when the UNO method has VOID 
return type (see computation of retKind in cpp_call in the same file), 
but that IdlInterfaceMethodImpl::invoke doesn't set up the arguments 
according to that expectation.


Change-Id: I187a997300571cd9822de2eeacf7ad887ad00a4f
Reviewed-on: https://gerrit.libreoffice.org/69495Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

See: http://tagoh.github.io/liblangtag/#sec2
or
workdir/UnpackedTarball/liblangtag/README

Change-Id: I0ce9b4c6ada0dad93f214d23f43800b89b6533df
Reviewed-on: https://gerrit.libreoffice.org/69497
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

to ScDocument lifetime if possible. This helps to avoid lots
of thread setup-cost while doing recalcs especially if there are
many formula-groups in the document and most of them are fairly
light-weight.

Change-Id: Idd57e1ebd0d4e492f99e31237d4a55ec9c95a121
Reviewed-on: https://gerrit.libreoffice.org/69473
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

See:
- https://bugs.documentfoundation.org/attachment.cgi?id=149853
- https://bugs.documentfoundation.org/attachment.cgi?id=149854
- https://bugs.documentfoundation.org/show_bug.cgi?id=122788#c5
- https://bugs.documentfoundation.org/show_bug.cgi?id=122788#c6

Change-Id: Icd1d4afcd05bf5398813505702bf244bd18fbfee
Reviewed-on: https://gerrit.libreoffice.org/69006
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

to show/handle them in Calc AutoFilter.

Partial revert of "tdf#116666 fix Hungarian sorting"
(commit 7b1eb631).

Change-Id: Ib135f1eac77780e901fb4c427c3f1bb8a5e090b9
Reviewed-on: https://gerrit.libreoffice.org/68014
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Icb5f0235339364e6dc09936e26f256765a60830a
Reviewed-on: https://gerrit.libreoffice.org/69378
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Ib2eac7368ebb06702f05101641e8830ea1fff6d5
Reviewed-on: https://gerrit.libreoffice.org/69483
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I467e8e7eb60ab0005b15217b0ff088fa6704cf1c
Reviewed-on: https://gerrit.libreoffice.org/69492
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I482f6b88314737a793e1d9e9ec1375d49ef676a3
Reviewed-on: https://gerrit.libreoffice.org/69491
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>