Bah, the reverted change actually of course breaks the compilation, I
had missed that accidentally. More intrusive chnages are needed to
change css::uno::Reference to rtl::Reference, also in parameters to
constructors and other calls here.

This reverts commit 073f8cdb.

Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f

Change-Id: I5bf8adf86da9d2e9c53341cdbc94aba05557abfc

To avoid this:

sc/source/core/tool/formulalogger.cxx:55:26: error: bad static variable causes crash on shutdown [loplugin:badstatics]
    static FormulaLogger aLogger;
    ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
sc/inc/formulalogger.hxx:42:31: note: ... due to this member of 'FormulaLogger' [loplugin:badstatics]
    const ScFormulaCellGroup* mpLastGroup = nullptr;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
sc/inc/formulacell.hxx:66:20: note: ... due to this member of 'ScFormulaCellGroup' [loplugin:badstatics]
    ScFormulaCell *mpTopCell;
    ~~~~~~~~~~~~~~~^~~~~~~~~
sc/inc/formulacell.hxx:114:21: note: ... due to this member of 'ScFormulaCell' [loplugin:badstatics]
    ScDocument*     pDocument;
    ~~~~~~~~~~~~~~~~^~~~~~~~~
sc/inc/document.hxx:312:27: note: ... due to this member of 'ScDocument' [loplugin:badstatics]
    VclPtr<SfxPrinter>    pPrinter;
    ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~

Change-Id: I533e45f655ca928a801188aa48ee818d89a962ac

Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe

Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3

Change-Id: I7ef42d66a0ffbbd8f2754bd4aba0e77659c9ae83

Change-Id: I6ab405e7e9a0c8ac3a323fd2484e334c500280ae

Change-Id: I45d7e14cef0058c4bfca4a3466e31d64e29bdfae

Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb

Change-Id: Ic8e00ab8961811044c26eb237f283617ddeb5cb6

Change-Id: I44a03f557d7a7aafeb17e5d662797203f975672f

Change-Id: If35981bce951dfab4a784d4cb54ac911249572ed

Change-Id: I4437484192016db7ce72614ae07c5a7d1bd9ec5b

Change-Id: I17146905c93162977effe9179c844ba691320d35

Format "%.2f" is not optimal for large or small values.
Format "%g" should be prefered.

Change-Id: I92899d80564b9000b1f3e049221c456f8e1176a9
Reviewed-on: https://gerrit.libreoffice.org/31445Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Despite being a 32-bit architecture, m68k has a basic
alignment of 16-bit for historic reasons. On m68k,
SAL_TYPES_ALIGNMENT8 is therefore equal to 2 and we
need to cover this case in the static asserts as well.

Change-Id: I4c756af25d57e5d49209697f6e678ef71a5845aa
Reviewed-on: https://gerrit.libreoffice.org/31878Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Remove useless class NameContainerImpl.

Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c
Reviewed-on: https://gerrit.libreoffice.org/31830Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8
Reviewed-on: https://gerrit.libreoffice.org/31898Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4

Change-Id: Ib0106c3b88cf54e54aaf784bb526480a1c745a1f

This reverts commit cc020974.

Need to improve the solution here a little I think.

Change-Id: I02a3a46d2222b8bfe955eb17ca655d36d9155b48
Reviewed-on: https://gerrit.libreoffice.org/31867Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I9759a0f21641b6f5ba5e456e5c45ac28238ca672
Reviewed-on: https://gerrit.libreoffice.org/31866Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I76e9d317dabeefcdf53468a89f3a6130279993f3
Reviewed-on: https://gerrit.libreoffice.org/31865Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ie7127668aceade312c68ed3d7f3398fbaf5e8df7
Reviewed-on: https://gerrit.libreoffice.org/31864Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I49c448c454f9bb820c3b9afa3825c58cb2dab978
Reviewed-on: https://gerrit.libreoffice.org/31863Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Iad8b5ff731c9d53f0f015a95387a00993a4a31f8
Reviewed-on: https://gerrit.libreoffice.org/31862Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4

Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831

Failing to do that leads to write-past-end-of-document, drawing
loss and SAXParseException if the drawing is part of a footnote.

A unit test is included.

Change-Id: Ie7d8263dc72dfef1e9827cc0579a5eaaf5819410
Reviewed-on: https://gerrit.libreoffice.org/31871Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

to bring up File Open... dialog

we need to hold the SolarMutex when doing VclPtr ref-counting

Change-Id: I843f2a243acaf73db1f6557df23475fe5bb12131
Reviewed-on: https://gerrit.libreoffice.org/31892Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifceb60ee9f1f5e0ba5fd68d88a0358b5400008ee

Change-Id: Ibb24dea2464c2e0bba289f08bba053efe6fe57fc

Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679

and

coverity#1397044 Unchecked return value

Change-Id: I193bd676e417c35450efa91cb5773c78c998b63f

Change-Id: I7f8988a7cf5f3d815a20cac249b3753d732994e1

Change-Id: Ie33ef6565cadcddb59c1d78a63aec666e8693f87

Change-Id: I37c49aa568646e44c05f5feec537d344a2440b91

This appears to be a consequence of my change

    commit 942716fe
    convert EID constants to typed_flags

in that change I made a "fix":
    @@ -689,20 +687,20 @@ void
EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent&
rEv
         ListenerList::const_iterator iListenerEnd
(aCopyListeners.end());
         for (; iListener!=iListenerEnd; ++iListener)
         {
    -        if ((iListener->second && rEvent.meEventId))
    +        if (iListener->second & rEvent.meEventId)
             iListener->first.Call(rEvent);
         }
     }

which causes this bug.

I should have noticed that my "fix" indicates that the event filtering
part of this multiplexing code was never working, and since no-one has
ever complained about, lets just remove all of this unnecessary
complexity.

Change-Id: Id71613d4fd5817ee1358705059e4ce63d57573ad
Reviewed-on: https://gerrit.libreoffice.org/31894Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and

coverity#1397055 Inferred misuse of enum

copy and paste error from the other converted call site I bet

Change-Id: I63701db153c5fd424374a95dd757d9fd7a8bc216