RTF is a bit simplistic compared to the others, but at least
we can handle the Environment situation similarly.

Change-Id: I87bc389373275d19f1229e11ffd742836a0fd498
Reviewed-on: https://gerrit.libreoffice.org/66966
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ic580df179c6aa1dedc866cf0882c124d5b13fcb3
Reviewed-on: https://gerrit.libreoffice.org/68360
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ie07147c9d6af469ed1088148dd8b9bdb64ae8590
Reviewed-on: https://gerrit.libreoffice.org/68362
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: I41a48893d007cf9226f8fd9491af36a4d24a3661
Reviewed-on: https://gerrit.libreoffice.org/68393
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I003703f0bc2e1697124e068a68bfb2e24c33cd1a
Reviewed-on: https://gerrit.libreoffice.org/68351
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ia10e08c04fb6dfc18597fcfba3fe52cf0ba7184c
Reviewed-on: https://gerrit.libreoffice.org/68377
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I28fe2ba99c4a17cab781d95ef9da8b2774667baa
Reviewed-on: https://gerrit.libreoffice.org/68383
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia47dbe8d0b8caf835fef50bc8e046d5a05f30b7d

...when implicit special member functions are defined for FWE_DLLPUBLIC
MergeMenuInstruction etc.

Change-Id: Ida796edaea73cf2c918feee1ee961e2065f25ee8
Reviewed-on: https://gerrit.libreoffice.org/68376
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

* Update helpcontent2 from branch 'master'
  - Mute Pootle complain on reserved words
    
    Change-Id: I8e0832a8be6a5118aa1d8b306a250a87434088ca
    Reviewed-on: https://gerrit.libreoffice.org/68252
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Name tag updates in links
    
    Change-Id: I88cdf6ea514ba98d45d90d59bc170f4c59938df6
    Reviewed-on: https://gerrit.libreoffice.org/68382
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I0d2318ea4176b301ec8e814e3de8816729bb6a51
Reviewed-on: https://gerrit.libreoffice.org/68381Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

* Update helpcontent2 from branch 'master'
  - Removed executable permission on SVG file
    
    Change-Id: I6ff78e12c6d547f18e1808c79d32ef2d6ffa0037
    Reviewed-on: https://gerrit.libreoffice.org/68380
    Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    

Change-Id: If74c831e763b0067cc1e98d6bd3c8d2699d9891e
Reviewed-on: https://gerrit.libreoffice.org/68366Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

after
    commit 589ce330
    Date:   Mon Feb 25 14:38:21 2019 +0200
    sal_uIntPtr->sal_uInt64 in SalTimer::Start

Change-Id: I0fe5d972d2acf90a98f6e0203c51e509a60920c1

As in f2afa2af

Change-Id: I617544ff00128ec3ff4bc4cff523db55f49c493a
Reviewed-on: https://gerrit.libreoffice.org/68246
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

The bugdoc has 3 items in the picture strip and PowerPoint laid this out
as a single column with 3 rows (as a snake algorithm). We used to put
the first two items to the first row and the third item to the second
row.

Improve out layout by taking into account what aspect ratio the child
algorithms request: this way it's obvious that we should use a single
column in case we have a large enough aspect ratio and few enough items.

(PowerPoint also uses multiple columns without the aspect ratio
request.)

Change-Id: I9f1158c04c665fc6a2c85e4ac3a1ed363b1c75fb
Reviewed-on: https://gerrit.libreoffice.org/68370Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Ia2c103a5b530d007f750e4a034b253b3ec5406ec
Reviewed-on: https://gerrit.libreoffice.org/68368
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

...so the new background tab page works correctly in Calc Border/
Background dialog

Change-Id: I4121d5ef0e69ccd6f819b5ea760461004d484364
Reviewed-on: https://gerrit.libreoffice.org/68369
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

after
    commit 589ce330
    Date:   Mon Feb 25 14:38:21 2019 +0200
    sal_uIntPtr->sal_uInt64 in SalTimer::Start

Change-Id: I0091ac4750dfb2ca8a3f4b5a544f7ec4f0ee0957

Change-Id: I3578a1c3e345211d3504d8abf6c520defb62f448
Reviewed-on: https://gerrit.libreoffice.org/68299
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

At least during JunitTest_sw_unoapi_4
sw.SwXTextTable::com::sun::star::text::TextTable::TableColumnSeparators, some
SwFormatFrameSize is created with a width of USHRT_MAX ("Set USHRT_MAX as the
Table's default SSize") in SwDoc::InsertTable
(sw/source/core/docnode/ndtbl.cxx).  In SwTabFrame::Format
(sw/source/core/layout/tabfrm.cxx) that leads to nWishedTableWidth with a value
near USHRT_MAX and substantially larger than nMax, causing nLeftSpacing to be a
large negative value in the text::HoriOrientation::CENTER case.  That in turn
causes SwTextAdjuster::CalcRightMargin (sw/source/core/text/itradj.cxx) to
set

    pRight->PrtWidth( sal_uInt16( nRealWidth - nPrtWidth ) );

with a value of 32768 (where pRight is a SwGluePortion).  And a later call to
that SwGluePortion's GetPrtGlue would try to convert that 32768 to 'short',
getting flagged by Clang's -fsanitize=implicit-signed-integer-truncation.

In addition to changing GetPrtGlue (and MoveGlue) to use 'long' instead of
'short', drop some unncessary narrowing casts from client code.

Change-Id: I6a0d763acfad1fc3b550ec6107adf9f5429dd005
Reviewed-on: https://gerrit.libreoffice.org/68253
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

after
    commit b792e4ee
    sal_uLong->sal_uInt32 in drawEPS

Change-Id: Ic35c165cd9dd756e229c33f643355150d6249688

The reason was that A2 had an explicit paragraph style reference, but A1
did not, so table buffering caused A2 style to affect A1 style as well.

Combine this with style deduplication, and then A2 style considered the
direct formatting (font size) in A1 to be redundant, so it was lost on
import.

Fix the problem by moving the copy&pasted properties buffering to a
single function, and there buffering not only the properties, but also
the active style index.

Change-Id: I99f2020b8bef237849fd622b25ac5ef0516d69e4
Reviewed-on: https://gerrit.libreoffice.org/68361
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

sal_uInt32 seems reasonable given that this is the number of rectanges
in an image.

And then convert all of the other BeginSetClipRegion methods to use
sal_uInt32 too.

Change-Id: I85a712ec823662ac30f3859051e2b974fb99775e
Reviewed-on: https://gerrit.libreoffice.org/68343
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This way bottom docked toolbars appear above each other
to avoid Table pushing Track Changes out from under the mouse cursor

Change-Id: Ic0a9e745246bce6d12cfb17d6adf8ad703753168
Reviewed-on: https://gerrit.libreoffice.org/68365
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: Icb79576142da57b5aa16af1df3df51217929799d
Reviewed-on: https://gerrit.libreoffice.org/68363
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

because the call site specifies millis in a sal_uInt64 variable

Change-Id: I5cf42407b9e7f3cdef976d8f442609723fd67af9
Reviewed-on: https://gerrit.libreoffice.org/68342
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I58beedfee1a55df971e778ba2aa3b6989ba53663
Reviewed-on: https://gerrit.libreoffice.org/68341
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4ed777711c1302b3aaa73474b6182214c61b09f2
Reviewed-on: https://gerrit.libreoffice.org/68340
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This patch allows the whole interactive sequence to
restart automatically when it's done. User don't
need to insert multiple pause toggle command to
a media object just for toggling the media
multiple times.

Change-Id: I000a55f580917327ae438ea8e79e62f63275cce7
Reviewed-on: https://gerrit.libreoffice.org/68283
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I1657c495928f8c7b86032c974a218f8db4f9b6ba
Reviewed-on: https://gerrit.libreoffice.org/68170
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I56f1de2ac91076a35f1f3583d7500e5b2fa4ce54
Reviewed-on: https://gerrit.libreoffice.org/68315
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8d9b1ea3bad07ccaf18de5621e4788940dc33c61
Reviewed-on: https://gerrit.libreoffice.org/68294
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ic428cf9b1d7f3aed60b941445d4ddf52a8c2415c
Reviewed-on: https://gerrit.libreoffice.org/68289
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: I0350bfbe32afc68f94e0fd10c379ac39f2b7c2ca
Reviewed-on: https://gerrit.libreoffice.org/68353
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

The aspect ratio request of the Shape is not yet used in
AlgAtom::layoutShape(), though.

The heavy-lifting is needed, because the number of cols/rows in the
snake algorithm depends on the aspect ratio request from the child
algorithm, so need to transfer the aspect ratio from child algorithm ->
layout node -> shape -> parent algorithm.

Still no functional changes intended.

Change-Id: I8cbe53cfac0965ab5d8c05f75fe27e819de6836a
Reviewed-on: https://gerrit.libreoffice.org/68354Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

(And probably the same holds for Android, too.)

This change makes at least the Format>Character... and
Format>Paragraph... dialogs in the iOS app show up. For some reason
they are claimed to be modeless, and that meant that the mechanism for
dialog display in the iOS app did not work. The exact mecahnism is
unclear to me, but the alleged modelessness was the root cause.

Change-Id: I237a5e16ec34221912a2fb062068101562ba7dbb

* Update helpcontent2 from branch 'master'
  - Mutual references (links) in Session & Locations help pages for Python
    
    Change-Id: I96c55ca44c1b04598fcdd663a394c68211f4a29d
    Reviewed-on: https://gerrit.libreoffice.org/68310
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#123192 - Improve help for function ATAN2
    
    updated text in ATAN2 section of 04060106.xhp
    added coordinates-to-polar-01.svg
    changed example and image
    removed 'Important!', added 'radians'
    changed 'LibreOffice' to '%PRODUCTNAME'
    created new folder 'scalc' under 'media/helpimg/'
    moved coordinates-to-polar-01.svg to new folder
    and added the path/image name to Package_html_media.mk
    droped xml-lang="en-US" tag, removed 'Note',
    removed '<pre>' tag, did not add <embed> as
    Jenkins rejects it.
    
    Change-Id: I5cff6289e8ab25f511e7d31ba2d4ad733dea184a
    Reviewed-on: https://gerrit.libreoffice.org/67619
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>