Change-Id: I9cb03530150ee35bdaee4920dd2e818007a0a658
Reviewed-on: https://gerrit.libreoffice.org/68469
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This basically reverts b6b1ded0, since it
introduces tdf#118707, and I cannot reproduce any of the original problems
when reverting.
The patch itself is technically correct, but the problem is in the Windows
implementation of clipboard handling, which uses delayed processing
of setting clipboard contents. This leads to previous clipboard contents
being deleted too late, and with shared_ptr instances of SdrCaptionObj may
get deleted after the related SdrModel has already been deleted.
A proper fix would be to remove the stupid delayed processing from
the clipboard code, but that's non-trivial. If that gets fixed, the change
removing ScCaptionPtr may most probably be applied again.

Change-Id: I29634847486aa955b20483c9eb38bba4fed87187
Reviewed-on: https://gerrit.libreoffice.org/67725
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I5304e85cd3fd2edc48147f1297caa57417a3d038
Reviewed-on: https://gerrit.libreoffice.org/68496
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Checks xPropset is exist for chart handling on LibreOffice Online.

Change-Id: I57947fd23e089ace4df011873613c2f886770b30
Reviewed-on: https://gerrit.libreoffice.org/68493Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

regression from
    commit 082e69fe
    Date:   Mon Feb 26 16:53:37 2018 +0000
    convert various MessBox to weld::MessageDialog

Change-Id: Ia9cef4de4ae9c13201c838f20f0ba6b6cff7f35d
Reviewed-on: https://gerrit.libreoffice.org/68490
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Extra style is causing editing problem near footnote/endnote
references. This behavior is a side effect of
eaa9cf6a, allowing emission
of these "technical" styles.

Change-Id: I1885b92814746e7b5cd19f3ddd7bc22eb691615e
Reviewed-on: https://gerrit.libreoffice.org/68304
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

looks like a copy/paste error in
    commit 942f0599
    Author: Caolán McNamara <caolanm@redhat.com>
    convert remaining ErrorBox to weld::MessageDialog

Change-Id: I52d38311b1e276fd799128e058ea0b9c902aef06
Reviewed-on: https://gerrit.libreoffice.org/68491
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

And move some code pieces, related to the redaction functionality,
from objserv.cxx to the new SfxRedactionHelper.cxx file.

Change-Id: I6491c9b581ea6d3a05a72117c5b72e1dc19025dc
Reviewed-on: https://gerrit.libreoffice.org/68338
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I476744d8f351f4ab2afce5974355a066edc8a4a6
Reviewed-on: https://gerrit.libreoffice.org/68489Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I18edeff43fcae98514c80d9f2c1594cc2f866e75
Reviewed-on: https://gerrit.libreoffice.org/68401
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I4477874116e8059cf0a82b9b3106c9e26a641947
Reviewed-on: https://gerrit.libreoffice.org/68400
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I70de808487fab77af720897ecd14370396d4bc93
Reviewed-on: https://gerrit.libreoffice.org/68416
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I7775a7d86e9641cd514e58f03d3727d2ad846120
Reviewed-on: https://gerrit.libreoffice.org/68485
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As in f2afa2af

Change-Id: I54323e4b993d4c584932608c9d3721becacddb60
Reviewed-on: https://gerrit.libreoffice.org/68247
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I7d51d09b78297442d07dd4ecbab7b5ce38d8ffee
Reviewed-on: https://gerrit.libreoffice.org/68447
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I7f87f24ed65c3fbc4a0a37357c7be4d16b44ac89
Reviewed-on: https://gerrit.libreoffice.org/68467
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id2c44c104a417feba152d4af43caca561f3432bf
Reviewed-on: https://gerrit.libreoffice.org/68465
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Given SwColumn::m_nWish is documented as "Desired width, borders included."
(sw/inc/fmtclds.hxx), it appears that the invariant

  GetWishWidth() >= GetLeft() + GetRight()

should always hold for SwColumn instances.

However, during UITest_writer_tests4's test_tdf113284 loading of
sw/qa/uitest/writer_tests/data/tdf113284.odt, it appears that some five-column
table is created for which initially all SwColumns'

  GetWishWidth() = 13107
  GetLeft() = 144 (except for first SwColumn, where it's 0)
  GetRight() = 144 (except for last SwColumn, where it's 0)

and later FitToActualSize is called reducing each SwColunn to

  GetWishWidth() = 286

so that for most SwColumns (except first and last), GetLeft() + GetRight() = 288
would exceed GetWishWidth().  And then (still during loading of the test's
document), SwFormatCol::CalcPrtColWidth (sw/source/core/layout/atrfrm.cxx) is
called for such a problematic SwColumn, trying to subtract from its
GetWishWidth() (the result of SwFormatCol::CalcColWidth) both GetLeft() and
GetRight(), and store that into sal_uInt16 nRet.  Which triggers Clang's
-fsanitize=implicit-signed-integer-truncation "runtime error: implicit
conversion from type 'int' of value -2 (32-bit, signed) to type 'sal_uInt16'
(aka 'unsigned short') changed the value to 65534 (16-bit, unsigned)".

So make sure that FitToAcutalSize upholds that presumed SwColumns invariant,
shrinking the borders as necessary.

Change-Id: I3f6fc07e65a0fc5d5f58c99f1dcdea4467b825f0
Reviewed-on: https://gerrit.libreoffice.org/68463
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Fix aVerticalLeftToRightBottomToTop:

- fnXDiff takes "logically larger, logically smaller" arguments, so it's
  first - second for top to bottom text (existing directions) but it's
  second - first for btlr

- fnXInc was effectively unused before, but it probably meant to provide
  logical left + width, so set that to physical left - width for btlr

And then port 3 places in lcl_UpDown() to use aRectFnSet, so we get
correct behavior for both ttb and btt directions.

With this, pressing the left/right arrow jumps to the previous / next
paragraph correctly.

Change-Id: I1323e95e2ce0ab2d66a3ea6e02bd50df2cebf232
Reviewed-on: https://gerrit.libreoffice.org/68462
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I84657379bfc999df40a17fc199bdd20b95414e32
Reviewed-on: https://gerrit.libreoffice.org/68468
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I7f09837e76a8368fd60aed1bb3a16fd0434e11ec
Reviewed-on: https://gerrit.libreoffice.org/68466
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8dc9d97b384a2686f7513499e3ee5819a1b05fe8
Reviewed-on: https://gerrit.libreoffice.org/68482
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

As stated in

ECMA-376-1:2016 OOXML 18.17.7.327 TRANSPOSE
"The formula containing the call to TRANSPOSE shall be an array
formula [...]"

Similar to

    commit d0ded163
    CommitDate: Wed Jan 16 11:17:14 2019 +0100

        Related: tdf#122301 FREQUENCY() with ForceArrayReturn on caller

Change-Id: I617bfcc0b8ecb244df3441ab885ec926efd77e3f
Reviewed-on: https://gerrit.libreoffice.org/68436Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

When we save the document we get a SwXShape for the SdrObject and call
getShapeText on it, which creates a TextForwarder for it. The SwXShape
is temporary and is discarded afterwards. If we modify the text and
save again we get a new SwXShape and a new TextForwarder.

If a11y is active, then when the textbox is inserted a11y gets a SwXShape
for the object and the SwXShape stays alive while the a11y view of the
Sdrobject stays around.

The SdrObject will keep a weak ref to the current SwXShape for it, so
on save we get the already existing SwXShape instead of a new one. On the
first save this is ok, as the TextForwarder is created on demand.

On the second save, the problem is that the SvxTextEditSourceImpl of the
TextForwarded was initially created without a SdrView so its in sort of a
"snapshot" mode, so first time the text is queried, that sticks as the result.

So a cached text forwarder cannot be trusted when its for a SdrTextObj
that's being edited and HasView is false

Change-Id: Ib3d500752f1876086ef1996885a2b86b581f5bc4
Reviewed-on: https://gerrit.libreoffice.org/68457Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

it only uses the color subtab, so just measure
ones which can be visible

Change-Id: Id09419480fd920b242f4d0d65e9ac5fbfb619784
Reviewed-on: https://gerrit.libreoffice.org/68431Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ieca75774925a8766162481713f6e8a6ba0e9feb0
Reviewed-on: https://gerrit.libreoffice.org/68396
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I52d69d825ed11a15d9dbbe61f157035361fa5d52
Reviewed-on: https://gerrit.libreoffice.org/68374
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf
Reviewed-on: https://gerrit.libreoffice.org/68389Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2c24ea46b6e81ed02ae53da5e9ae1b7df85e44a1
Reviewed-on: https://gerrit.libreoffice.org/68454Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Update list of missin icon replacements
    
    Change-Id: I193c10fa8c75f61fbcd749284f81e69f5f4ad603
    Reviewed-on: https://gerrit.libreoffice.org/68464
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I8368c8a1d52f6c55a8cea952b2b02345e41c1e5c
Reviewed-on: https://gerrit.libreoffice.org/68448
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

* Update helpcontent2 from branch 'master'
  - tdf#117890 Remove unhelpful screenshots (1/2)
    
    Change-Id: I8a96220ae688f78fe43d66ab205323f3d4605140
    Reviewed-on: https://gerrit.libreoffice.org/68392
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Previously, once 'm_aContents' had been assigned in
'VclQt5Clipboard::setContents()', its value (or the one set
in a subsequent call to the same method) was always
returned in 'VclQt5Clipboard::getContents()', thus
ignoring all system clipboard updates done by any other
third-party applications, preventing copy-paste from other
applications.

In order to take external clipboard updates into account,
add a slot for the 'QClipboard::changed' signal and
drop the current own clipboard content if the clipboard
has been updated by another application.

In order to detect whether the clipboard update was made
by this 'VclQt5Clipboard' itself or elsewhere, a custom MIME type
"application/x-libreoffice-clipboard-uuid" is added, whose
value is set to the clipboard's (randomly generated) UUID.
If the entry is present and has the correct value, the clipboard
content was added by this clipboard and can be kept.

Otherwise, clear 'm_aContents', so that it's newly assigned
in 'VclQt5Clipboard::getContents()', taking into account
the external clipboard update.

[Side note: Testing showed that, on Wayland, more
'QClipboard::changed' events were emitted without the clipboard
content actually having changed (e.g. when switching focus between
windows), which is why an approach of simply setting a flag and
checking for that one is not enough, like "wrapping" the
'QClipboard::setMimeData()' call in 'VclQt5Clipboard::setContents()'
as follows

    m_bIsFillingClipboard = true;
    clipboard->setMimeData(pMimeData.release(), m_aClipboardMode);
    m_bIsFillingClipboard = false;

and then evaluating the 'm_bIsfillingClipboard' flag in
'VclQt5Clipboard::handleClipboardChange' instead of using the UUID-based
approach. These additional 'QClipboard::changed' events did not
show up the same way while testing on X11.]

Change-Id: Ib3a6a4f9b7f5ca3573666fb9c072ae97cf2e0049
Reviewed-on: https://gerrit.libreoffice.org/68214
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Set correct parent menu in function Qt5Menu::InsertMenuItem
instead of just returning it and setting it later if needed.

Change-Id: Id866987e91ec1d57c720735da6afc44109aa901a
Reviewed-on: https://gerrit.libreoffice.org/68437
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Also add item bits change notification function
for SalMenu to properly convert regenerated menu items
to check or radiocheck items.

Change-Id: I61f16a771b484644bbefd9afaf2776232d38a2f9
Reviewed-on: https://gerrit.libreoffice.org/68438
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Ia8c2600aee42c3063e18032d1e485ad417ec4639
Reviewed-on: https://gerrit.libreoffice.org/68421
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Set a default icon in Qt5Frame constructor, similar to how it's done
for the gtk and gtk3 VCL plugins in 'GtkSalFrame::InitCommon'.

Change-Id: I4e4e62ffa0eca6499f4752ff467d004cae68788f
Reviewed-on: https://gerrit.libreoffice.org/68450
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Shape text has two kind of spacing inside the shape's bounding box: the
shape-level margin and the paragraph-level one. Only the second was
handled in the tx algorithm so far, add support for the first.

The margins taken from constraints were way large by default: the only
explanation I found for that is that SmartArt layout sometimes
calculates in MMs, sometimes in Points, and the ratio between the two is
exactly the Impress / PowerPoint margin. So assume that indeed that unit
difference is the reason for the smaller in-PowerPoint margin values and
do the same on our side.

Change-Id: I6f1e54301e2e9b33a7e721be34244d968cccf42d
Reviewed-on: https://gerrit.libreoffice.org/68453Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

since

commit c600817e
Date:   Mon Feb 25 15:34:13 2019 +0200

    Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOP

Change-Id: I95ff8ed3dc81ec542ac76d5f5bbd7582391c84a5

Change-Id: I2de32f700125fc8306c16fe4963ef76f87b0034c
Reviewed-on: https://gerrit.libreoffice.org/68435Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins