Change-Id: I95a46d206f846b5babaca41544442bcf8a8b7aa9
Reviewed-on: https://gerrit.libreoffice.org/62773
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

V1023 A pointer without owner is added to the 'm_aChartTypeDialogControllerList'
      container by the 'emplace_back' method. A memory leak will occur in case
      of an exception.

Change-Id: I35bf344fd083c6a1717a150f78370ec59f206240
Reviewed-on: https://gerrit.libreoffice.org/62821
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I27bf92770431f6a1f35e1c8224c0847555a8d43f
Reviewed-on: https://gerrit.libreoffice.org/62819
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Let ScEditFieldObj::getData() return reference.

Change-Id: I4deed9a1692953088cf6d939508b9045e3e6cb3c
Reviewed-on: https://gerrit.libreoffice.org/62816
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I75082c85862b83ed2503900186ce9c70783e54db
Reviewed-on: https://gerrit.libreoffice.org/62817
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V581 The conditional expressions of the 'if' statements situated alongside
     each other are identical. Check lines: 153, 181.

Change-Id: Ifcec371bc2207bdd3594e514f0eab1d06dd24c84
Reviewed-on: https://gerrit.libreoffice.org/62820
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad8
Reviewed-on: https://gerrit.libreoffice.org/62801Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

Change-Id: I66cde29f8b64c5212f748930b5575763f54e59bd
Reviewed-on: https://gerrit.libreoffice.org/62818Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

...macOS 10.9 reportedly doesn't yet support the 'CGContext' replacement, see
the comments to <https://gerrit.libreoffice.org/#/c/61353/>
"loplugin:redundantcast".

This reverts c3c88d6b "loplugin:redundantcast"
(whose commit message was rather misleading; the redundantcast warnings were
merely a follow-up to the commit's actual meat, of replacing deprecated uses of
'graphicsPort' with 'CGContext'; I had failed to realize that when I chunked the
various changes necessary for 10.14 into several individual commits) and adds
SAL_WNODEPRECATED_DECLARATIONS_PUSH/POP instead.

Change-Id: I778d7c3a29c780beff561fbbcc38df9e1494114c
Reviewed-on: https://gerrit.libreoffice.org/62815
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This resulted from commit 009e3f48
which failed to replace some of numeric sprm ids with mnemonic names.

Change-Id: Ie00a89bee02da383df0cbe27b093f3a1d25e8b03
Reviewed-on: https://gerrit.libreoffice.org/62813
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Use range-based loop or replace with STL functions.

Change-Id: Ifffb7ba08b3a9950ee076558ec4048b0788a38c8
Reviewed-on: https://gerrit.libreoffice.org/62806
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Just like in doc_paintTile().

Now at least some of the dialogs work in the iOS app, yay.

Change-Id: I10c7eeb1f121ba68a1af723d45575890b1d598da
Reviewed-on: https://gerrit.libreoffice.org/62800
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

In the DISABLE_DYNLOADING case there is normally no need for functions
marked with SAL_DLLPUBLIC_EXPORT to be exported, as these functions
won't be dynamically looked up anyway. Thus, when DISABLE_DYNLOADING,
SAL_DLLPUBLIC_EXPORT is defined in <sal/types.h> to actually mean
__attribute__ ((visibility("hidden"))).

But we do need to export the UI builder factory functions so that the
osl_getFunctionSymbol() in VclBuilder::makeObject() finds them.

(I kinda dislike looking up symbols with dlsym() from the same binary.
We know that the function is there and what its name is, we could just
call it directly. But makeObject() gets the function name as a string,
so we would need a long set of string comparisons to select which
function to call. A bit ugly. Let's see if I can come up with
something elegant enough later.)

Change-Id: Idceaf8c1ed54cd7d372bf4eb85d0428f9b57baeb
Reviewed-on: https://gerrit.libreoffice.org/62799
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I5b2c24e555f77199782d60d56086455f04787821
Reviewed-on: https://gerrit.libreoffice.org/62798
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ib7b54ebed1c66324c79c116bd4d1e08ebaa1eac9
Reviewed-on: https://gerrit.libreoffice.org/62797
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Thus no need for any special __attribute__ ((visibility("default")))
dance.

Change-Id: I398d588a0165fd616ea0d259bbf2cab1e1a07ccb
Reviewed-on: https://gerrit.libreoffice.org/62796
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I1cf37fccdd3a58d50a015b3fc32c32fba89f2f09
Reviewed-on: https://gerrit.libreoffice.org/62795
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Build the swui library for non-DESKTOP platforms, too. Handle fallout
for !HAVE_FEATURE_DBCONNECTIVITY and !HAVE_FEATURE_AVMEDIA (both of
which features we for now don't want to bother with in the iOS app).

Make VclAbstractDialogFactory::Create() do its thing also on
non-DESKTOP.

This commit just causes more code to be compiled for the non-DESKTOP
case, dialogs in general surely don't actually work yet in the iOS
app. For instance:

vcl/source/window/builder.cxx:2060: probably need to implement sfxlo-CustomPropertiesControl or add a makesfxlo-CustomPropertiesControl function

Change-Id: I579efba605f519dcbf407b675be88c7c6ee0f19b
Reviewed-on: https://gerrit.libreoffice.org/62794
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

This fixes possible leaks from missed pipe releases

Change-Id: Ic3cdbd46e0eadc503e5711fe447d14bd5f0f7273
Reviewed-on: https://gerrit.libreoffice.org/62804
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I856345576ff5c10a41509a97ad4539272bd55568
Reviewed-on: https://gerrit.libreoffice.org/62803
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I66cde29f8b64c5212f748930b5575763f54e59be
Reviewed-on: https://gerrit.libreoffice.org/62793
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

elementary: ^mail merge, cell border color (related to tdf#120185),conditional format, table, sheet, etc"

Change-Id: I8d7fda42d0ff9a2108ba8406bd4e82af4c54ff0d
Reviewed-on: https://gerrit.libreoffice.org/62790Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

...when sidebar is floating and deck has one panel

Change-Id: Ic741efbfbaf60241b360470c9bc736743f18f0ed
Reviewed-on: https://gerrit.libreoffice.org/61052
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Change-Id: Iba43de47839170973067a19d7c8715eeaefb9b95
Reviewed-on: https://gerrit.libreoffice.org/62791Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9829341cb54e9a5964c9d018de89511a262069b7
Reviewed-on: https://gerrit.libreoffice.org/62784
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: Id1809b6f14690dff2edbc806a33297fda4373c6f
Reviewed-on: https://gerrit.libreoffice.org/62782
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This reverts commit 26c37567.
Conflicts:
	vcl/qt5/Qt5Frame.cxx

It caused null pointer dereference during UITest_writer_tests, as seen at
<https://ci.libreoffice.org//job/lo_ubsan/1090/>:

> /sfx2/source/appl/childwin.cxx:654:18: runtime error: member call on null pointer of type 'vcl::Window'
>     #0 0x2b97d4160fa3 in SfxChildWindow::SetWorkWindow_Impl(SfxWorkWindow*) /sfx2/source/appl/childwin.cxx:654:18
>     #1 0x2b97d462ab86 in SfxWorkWindow::CreateChildWin_Impl(SfxChildWin_Impl*, bool) /sfx2/source/appl/workwin.cxx:1350:9
>     #2 0x2b97d463e6bb in SfxWorkWindow::ToggleChildWindow_Impl(unsigned short, bool) /sfx2/source/appl/workwin.cxx:1837:21
>     #3 0x2b97d6eae94d in SfxViewFrame::ToggleChildWindow(unsigned short) /sfx2/source/view/viewfrm.cxx:3080:9
>     #4 0x2b987664316d in SwView::UpdateWordCount(SfxShell*, unsigned short) /sw/source/uibase/uiview/view1.cxx:212:9
>     #5 0x2b9876126a5d in SwTextShell::Execute(SfxRequest&) /sw/source/uibase/shells/textsh1.cxx:1369:9
>     #6 0x2b98760a2391 in SfxStubSwTextShellExecute(SfxShell*, SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:2974:1
>     #7 0x2b97d49050f6 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) /include/sfx2/shell.hxx:207:35
>     #8 0x2b97d48c27d0 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:353:13
>     #9 0x2b97d48de12d in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:854:9
>     #10 0x2b97d482ea34 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1063:9
>     #11 0x2b97d4e5cead in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:754:29
>     #12 0x2b97d4e60b5e in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:239:9
>     #13 0x2b97c6c10b19 in comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /comphelper/source/misc/dispatchcommand.cxx:60:9
>     #14 0x2b980472020c in UITest::executeCommand(rtl::OUString const&) /vcl/source/uitest/uitest.cxx:22:12
[...]

Change-Id: I276684a5617bfec3803b195af59c51735bfa470a

Change-Id: Ibfd5c7f0eb931faf00e40d349176237c12bfbdbf
Reviewed-on: https://gerrit.libreoffice.org/62777
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad9
Reviewed-on: https://gerrit.libreoffice.org/62772
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: If4d093079e13cfaebb9d226e39581b0c66e82786
Reviewed-on: https://gerrit.libreoffice.org/62651
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I27924775165ce45a9a91cb6793db93811ebfb5c8
Reviewed-on: https://gerrit.libreoffice.org/62760
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I6382be559a0c70d899d48d11e6f9b10ef270c9a4
Reviewed-on: https://gerrit.libreoffice.org/62744
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic0e85b2077c89a63301cf1d5b1cede7f6a0d7dce
Reviewed-on: https://gerrit.libreoffice.org/62767Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2eca0010f1c533d35212ecd2b9f3fb0e45b797e9
Reviewed-on: https://gerrit.libreoffice.org/62770
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I604f4cd616ec6eb31198806456a660e7a1e915ca
Reviewed-on: https://gerrit.libreoffice.org/62662
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iccef9a2f613e3f4a2e3198bf8bc59f61627b8b75
Reviewed-on: https://gerrit.libreoffice.org/62766
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I353cc4fff6ea48cf69bf1f25371c9ac70dd9b4c2
Reviewed-on: https://gerrit.libreoffice.org/62765
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Id5724783be913d81d04bf6de218bc63133adf393
Reviewed-on: https://gerrit.libreoffice.org/62764
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

GalleryToolBox is used in the Gallery deck/panel in the sidebar.
Guidelines for keyboard navigation in the sidebar are that Escape from
content moves focus to content panel title or in absence of panel title
to the deck title or if sidebar is floating and the deck has only one
panel move focus to the tab bar settings menu button. This patch removes
ToolBox key input method from being used to handle escape key input in
GalleryToolBox. This allows sidebar focus manger to provide the correct
behavior.

Change-Id: Iaf6fb404aae784b1119b5477948c4edb674a972a
Reviewed-on: https://gerrit.libreoffice.org/62768Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

This patch is sponsored by ULAKBIM/Pardus project.
Signed-off-by: Mert Tumer <merttumer@outlook.com>

Change-Id: Ic56991b2957be91822d040d776a3dfcef2d5b451
Reviewed-on: https://gerrit.libreoffice.org/62753
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>