Points of discussion
--------------------

(*) where in the Window destructor should dispose() be called?
   It's a seriously large method.

(*) we're going to need similar typedefs and declarations for every
single sub-class of vcl::Window, I assume that I will need to create a
macro to make it less verbose.

TODO
----

Update clang plugin to verify that:
(a) dispose() methods always call their superclass dispose()
(b) dispose() methods don't forget to clear any references owned
    by that class.

Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30

Change-Id: I47c5c60b0ffef3923c1d2830de992e1a67eb76ff

Change-Id: I3227a05a4cafdcca23c32a62fdb72245cdf493d6

Change-Id: I7c5ca8cb9533a1df07a86909a6993bc36eda5253
Reviewed-on: https://gerrit.libreoffice.org/12129Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>

Change-Id: Ic69bbcd877d248afd0f23a867d4c57d801479b74

Right now one row of SvxColorValueSet is 12 colors.

Change-Id: I9be6e8487d5325866e17f578b7abb08f7c338fb1

Change-Id: Ieb6277f0962f88dfa55b6af80535ec8af497433e

Change-Id: I680517bc7d91ef15593d235a7ff72588c7513b15

So it will be similar to addEntriesForXColorList

Change-Id: Ie352e0cf05fa6875ed76e69478131a57293b39a1

Change-Id: Ia118c81e39f5f48d4678cc375bad45f31ba8322e

Change-Id: I511c2df37c7feda8a3ffa311074bcf2fe669a73a

Change-Id: If528f3cbaab66ceec07e35b479b4fe2ed55aa3c7

Change-Id: I6f40eafee7652209395bd471e3508fe3a3d19d73
Reviewed-on: https://gerrit.libreoffice.org/12085Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2

Change-Id: Ia6f1b60108784660c4a2dfd311592207e6bf5d88

Change-Id: I7d8e3be80f04ec0a9d1dbd394ac0e2ab2f1a4551

I forgot to clean this up when cherry-picking
6e61ecd0 (Merge back branch
alg_writerframes to trunk, 2014-03-19).

Change-Id: I531dea63d3b62d16f11d414758012432bb4b2503

Change-Id: I64a805503d0c044b5c5a80df1513e35df5c39171

Change-Id: Icfb055123e049cdc16a5825e4be4f18a42d6cb7f

and throw ogham at the bugzilla bot for kicks

Change-Id: I50cdf676e59e4e966f999218837dabfdd2008b6e

Regression from commit 7d9bb549
(Related: #i124638# Second step of DrawingLayer FillAttributes...,
2014-06-02), the problem was that the new branch (used for paragraphs)
in the method does not tolerate unknown properties (it throws), while
the behavior was just a warning.

Adapt the new branch to the old behavior, so that the document can be
opened again.

Change-Id: I5d849987602fb8aa0cbbda92ce07c050067473b3

I simply didn't get the logic behind calling GotoNextFly(). It caused
not only this bug. For example Ctrl+click on a background text frame
did not select the text frame, but an image on the previous page.

Change-Id: I85ccbbda2f324de55417d6199b4abe79e59bf295

wrt the blasted SwIndexReg dtor assert

Change-Id: I4b3eeab76d5d76f7b769b458baeadbc0a9bd4238

For a document of 1000 pages and with 1000 bookmarks, this brings a
considerable speedup on ODF export:

before:
real    3m28.187s
after:
real    2m51.565s

Change-Id: Ic3f85c727a8ea4b5012d5c3f0a5887ff47762fb8

Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c

etc.

Change-Id: I1548d60280ab4f74fe023d026435a05f7865b516

the !isAfterLast should be sufficient

Change-Id: Iab45b70c24ae1f90c38178d261e467d9b1e3fa6c

Change-Id: I06e8e946063dc54335f3b672105d5cd0b3ff71a4

Change-Id: I762796b848aa8d8dd35b401e03bf40af18fb8e72

Change-Id: Icbdd0b6b19a91a3339c8635c112729b46232069e

Change-Id: I15cbfb15054962998a058da1381a84bb667944ef

Change-Id: I0f03b67a5df3427e78f70f2b86aba26024ea575f

going to assume that this is correct

Change-Id: I47072dc668f200eacf0f6a6d7ccdad0c9d6bfa68

rework code a little to help coverity out

Change-Id: I4aa253a579153ad389d4667a9676fff04aa00a34

following check is sufficient

Change-Id: Ibcf53293c8e862ab823ed422d1a7a59dcc0977cf

other patterns aren't really the same as this one

Change-Id: Ie26fd5c01d156004f755017a859679e904a29520

Change-Id: I3bd198fc21bb414a0b80e8234e22782e24e0477e

and

coverity#704068 Unchecked return value

those are ok I think

Change-Id: I7869c3f4200792d4bafafdff49735e8563d2e822

that's ok I think

Change-Id: Ie8dd3b938a058d771791471833fde4ef4ceef252

that's ok I think

Change-Id: I8ad2f3eab55d5a5907c431532768c9080fccfcf5