Change-Id: Ibc5c55dbe9c4c5101ebb292696f79e4e8c8a35c5
Reviewed-on: https://gerrit.libreoffice.org/33293Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

... which usually is the case, so don't unnecessarily create iterators and dive
into an empty mdds tree.

Change-Id: Iba345cd231d5911adefabc0584290834678a68f1

Change-Id: I0e263583e27c5103c0bb90e8fe00562e46a52d98

so disposeAndClear is called.

Change-Id: I40da317ac03f815c8664e8a4648870c2066f9650

SID_ATTR_CHAR_COLOR_BACKGROUND code was mostly a copy-paste
of SID_ATTR_CHAR_COLOR_BACKGROUND_EXT.

Change-Id: I713bfd72a2f51f2d0ff10b36e9e0a9150b13a640

Change-Id: I86b810a6ad94255a5f2a59392ba85775a488ba12

Change-Id: I77ac7701ccb35aa32152d85a20fc59ed0bd942cf

Change-Id: I0ec89e022cac47b4a761da1715b39a7fb86ffdb0

Change-Id: I77b5a892478d048decc2f5a018dbaf5a11b0194d

Commit e0f9bb79 added the property
"IsBrowseMode" to SwXDocumentSettings, but it is already available in
the API as SwXViewSettings property "ShowOnlineLayout".

The problem is that both of these properties get exported in ODF into
settings.xml, so it contains "IsBrowseMode" twice.

Unfortunately the SwXViewSettings are not available in writerfilter,
because the XModel::getCurrentController() is null, the view is created
after the import.

But there is already a way to store ViewData in the SfxBaseModel, which
is then used by SfxBaseController::ConnectSfxFrame_Impl() when creating
the view.  This applies the property at just the right time.

Change-Id: I842845d09a7b3fe81e27a1ed8ac8a8594da7f4e8

This is already a document setting, no point in writing it twice into
settings.xml.

Change-Id: Idcc99a194df321e11e091a2388b919e11fe94316

Change-Id: I4ab3fc515bb1484d00f3a690b9fe8ae9c9dca9fe

The DrawControlText always renders with a reference device positions but
we pass in a rectangle which is derived a different way.

So, add a GetControlTextRect which operates on the same reference
device as DrawControlText so the rectangles match

The rectangle is mapped from pixels to logic and back from logic
to pixel, so add an argument to store the logic size from
GetControlTextRect and re-use it without conversion on the cases
where we pass back the original rectangle

zooming in/out on the button in writer is now stable wrt text shown at all zoom
levels

Change-Id: Ic581eca67d0ff265e2753ab8b6c40e8fca7e6ae4
Reviewed-on: https://gerrit.libreoffice.org/33277Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Before that patch clicking on the Edit button
in the print preview mode was causing a crash.

Change-Id: Idd6ab2f16f515caa1d5fd3ed4ccdf9ae681849b5
Reviewed-on: https://gerrit.libreoffice.org/33269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>

Change-Id: Id5c80ff263e429d4239a844db216e87a656edb2e

this patch improve the functions:
-find_all_headers -> make _allheaders a dict: _allheaders['<modulename>'] contains the list of all headers for that module
-headers_of(modulename) -> it return the list of headers for that module, or a empty list for module that not have headers

Change-Id: I7e4e2bf063ccf6fd2e3e5155b58d2be2412480ba
Reviewed-on: https://gerrit.libreoffice.org/33255Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

so set it as private to de-confuse this a little

Change-Id: Idde7f78a767227cc2d52e417b6c39d12e1339745

This is only a workaround to prevent a crash, the actual note content is lost
when pasting, only a standard empty note caption will be pasted.

Change-Id: Ifaef5d30cc2024f3d03d6b2b4f56c5ccfbb67142

cause on dispose all the state change callbacks are
called, and all of the conditional formatting code assumes
that if there's an entry in the entries, that its not an
empty disposed one

Change-Id: I50d85128ba884a0719959f2d6e7ae83d6fb3431c

Change-Id: I17cb60fa1dd55667a15a7dbc50532993c3145244

Change-Id: Ic01f496b45a68ae35627bfbfb18f5aaf0b2b783d
Reviewed-on: https://gerrit.libreoffice.org/33253Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ifc852b1cb886b30abdf1061b73c2b600334264c6

Change-Id: Ic85e3d37a2696bf2bf67e5c48c71386336e07675

both BMP_PLUGIN resources point to the same plugin.png ultimately

Change-Id: Ifa1cc00698f749ba84f17a79074c73e080e1d356

Change-Id: Ia3f5a4ed5cb1eb9fefeb3a4fe5b5a14f2e260a6a

Change-Id: I53abf3267e1a75e944de82222c6ea80a72de0e7e
Reviewed-on: https://gerrit.libreoffice.org/33245Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

instead of storing both a raw pointer and an uno::Reference

Change-Id: Ib0197985523b10039a5abea7cab1de3fab4c72c1

instead of storing both a raw pointer and an uno::Reference

Change-Id: I02dd356d9693116f98ad2b96951570b3ba448b14

instead of storing both a raw pointer and an uno::Reference

Change-Id: Ia155ebcb856884461871d5992380c364da07a1d3

instead of storing both a raw pointer and an uno::Reference

Change-Id: Iba7317e37046c62411bae9d943f9e81f23ff3554

instead of storing both a raw pointer and an uno::Reference

Change-Id: I868530ba1697baae88a4322eda6c467c9f8e8eb6

Change-Id: I18b587aaef066c9558933d6d557219c1bad24656

Change-Id: I56e4a6817edac93dee9866b9ae009f0651a29b56

 #2  0x00007ffff7429da7 in __assert_fail_base () at /lib64/libc.so.6
 #3  0x00007ffff7429e52 in  () at /lib64/libc.so.6
 #4  0x00007ffff1ce2dc9 in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x1b147a0, nWhich=nWhich@entry=10023)
     at /home/caolan/LibreOffice/core/svl/source/items/itempool.cxx:817
 #5  0x00007ffff1ce2da5 in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x1b0eb30, nWhich=nWhich@entry=10023)
     at /home/caolan/LibreOffice/core/svl/source/items/itempool.cxx:816
 #6  0x00007ffff1ce2da5 in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x1b0dbe0, nWhich=nWhich@entry=10023)
     at /home/caolan/LibreOffice/core/svl/source/items/itempool.cxx:816
 #7  0x00007ffff1d00ba8 in SfxItemSet::MergeValues(SfxItemSet const&) (this=this@entry=0x7fffffffd4d0, rSet=SfxItemSet of pool 0x1b0dbe0 with parent 0x0 and Which ranges: [(105, 105), (10023, 10023)] = {...}) at /home/caolan/LibreOffice/core/svl/source/items/itemset.cxx:1100
 #8  0x00007fffa9118372 in SwEditShell::GetPaMAttr(SwPaM*, SfxItemSet&, bool) const (this=this@entry=
     0x1be06c0, pPaM=<optimized out>, rSet=SfxItemSet of pool 0x1b0dbe0 with parent 0x0 and Which ranges: [(105, 105), (10023, 10023)] = {...}, bMergeIndentValuesOfNumRule=bMergeIndentValuesOfNumRule@entry=false) at /home/caolan/LibreOffice/core/sw/source/core/edit/edattr.cxx:158
 #9  0x00007fffa911846f in SwEditShell::GetCurAttr(SfxItemSet&, bool) const (this=this@entry=0x1be06c0, rSet=SfxItemSet of pool 0x1b0dbe0 with parent 0x0 and Which ranges: [(105, 105), (10023, 10023)] = {...}, bMergeIndentValuesOfNumRule=bMergeIndentValuesOfNumRule@entry=false) at /home/caolan/LibreOffice/core/sw/source/core/edit/edattr.cxx:174
 #10 0x00007fffa986caa5 in SwView::StateTabWin(SfxItemSet&) (this=0x1bd4120,
     this@entry=<error reading variable: value has been optimized out>, rSet=SfxItemSet of pool 0x1b0dbe0 with parent 0x0 and Which ranges: [(68, 68), (10042, 10042), (10080, 10080), (10082, 10082), (10084, 10084), (10284, 10285), (10415, 10415), (10935, 10935), (10946, 10948), (10952, 10952), (10992, 10993), (11145, 11146)] = {...},
     rSet@entry=<error reading variable: value has been optimized out>) at /home/caolan/LibreOffice/core/sw/source/uibase/uiview/viewtab.cxx:1596

Change-Id: I460e004e6dfa8fa6460c167c6483f2b24502b775

Change-Id: Idea2a46a692aed666eb8dbc6185ae001d30757c2
Reviewed-on: https://gerrit.libreoffice.org/33228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ibf741af5e5043fae6139a19cec3d244dee06f225

Change-Id: Ifa901f75072d8474d8a97ca57c2b5b48d8c6b79d
Reviewed-on: https://gerrit.libreoffice.org/33250Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

nothing in LibreOffice calls it, and anything external would get a
resource id which is useless to anything except LibreOffice internals

Change-Id: I9d6d91a047da64dc98b556ae46fc86d84cf774f4

Change-Id: I67c395106d2a24c679cddaddd9aba138388463a5
Reviewed-on: https://gerrit.libreoffice.org/33237Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>

Change-Id: I6a139d5be193c968c2bf3373b415baa25dc32595