* Update helpcontent2 from branch 'master'
  - tdf#114263 Undocumented BASIC Options
    
    Option Compatible
    Option ClassModule
    
    Change-Id: Ieb07fddb216f4f8cc26089a30226da5760b0065e
    Reviewed-on: https://gerrit.libreoffice.org/66824
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

no functional change

Change-Id: I8d7171913d14ccb81b88c82362cfa997f9b9964a
Reviewed-on: https://gerrit.libreoffice.org/66823
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

As seen while analysing
sw/source/core/inc/DocumentChartDataProviderManager.hxx
replacing o3tl/deleter.hxx with fw declaration does not work,
it compiles only when it is transitively included.

This also removes mistakenly added fw declarations and
now unnecessary IwyuFilter blacklist items

Change-Id: I2d631f0693dbfd0bb0e62218a525113042c9a907
Reviewed-on: https://gerrit.libreoffice.org/66750
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

...which was at maximum set to GCC's -finline-limit=0 -fno-inline
(solenv/gbuild/platform/com_GCC_defs.mk).  Those options were set for debug
builds "since forever", but that looks very much like cargo cult:  -fno-inline
"is the default when not optimizing" anyway
(<https://gcc.gnu.org/onlinedocs/gcc-7.4.0/gcc/Optimize-Options.html>), and it
is unclear to me how -finline-limit=0 should have any impact beyond -fno-inline
(and maybe was present for ancient compilers that only supported -finline-limit
but not -fno-inline?).

Change-Id: Id6752d03b1b7ec8763defabc5720d4dd08790874
Reviewed-on: https://gerrit.libreoffice.org/66836
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4dfa637c76e28f820f60388315631d57669b15bf
Reviewed-on: https://gerrit.libreoffice.org/66766Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I50b864ffc4ed13ba801af46815988bf568b83d2e
Reviewed-on: https://gerrit.libreoffice.org/66832
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

... due to incorrectly exported font size.

Change-Id: If06dccc000530427be767fc7a5031f5ebe6fd431
Reviewed-on: https://gerrit.libreoffice.org/66803
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

... by default, instead of leaving it with
m_nPSLevel == 0 && m_nPDFDevice == 0.

Change-Id: I44059ac39791442602cbc48582670d98edc578ee
Reviewed-on: https://gerrit.libreoffice.org/66802
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

seen while investigating tdf#122662

since...

commit ff4b8d39
Date:   Wed Jul 1 20:58:14 2015 +0100

    gtk3: disable using notification that we are in the backdrop

there's no need for this code

Change-Id: Iea7f30f8b9a601b0254e6472d8d33a1664ec18c0
Reviewed-on: https://gerrit.libreoffice.org/66804
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4a0f51eae28c82eca3c44b9d06c0410f9645f62f
Reviewed-on: https://gerrit.libreoffice.org/66833
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie211eea01eaceb718f701d3fdbb6253700d14e5e
Reviewed-on: https://gerrit.libreoffice.org/66831
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2eb92d83f50b91b39a10e22298d496668c1cbf72
Reviewed-on: https://gerrit.libreoffice.org/66775
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Looks like this is no longer needed to correctly render
editbox borders. Not clear what fixed the issue.

This reverts commit 7484f169.

Change-Id: Ieb3b8d6f60ab762d0baccb341ed6a39ae2771e79
Reviewed-on: https://gerrit.libreoffice.org/66774
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I212301ffbad7dd975c0e16c1c71d471ec064c83f
Reviewed-on: https://gerrit.libreoffice.org/66821
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Ic0c4d10d60bddc461fc20e98b8424c4e8480ee6e
Reviewed-on: https://gerrit.libreoffice.org/66822
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Use range-based loop or replace with STL functions

Change-Id: I7e024d5bf97d942b8b43465e0779cf9e30df8eb0
Reviewed-on: https://gerrit.libreoffice.org/66827
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

applied in Show Changes mode, instead of losing them after
saving the document or hiding the changes.

The bug occurred in paragraphs with directly preceding tracked deletions.

Change-Id: I25a84aec0159f809dd7b67d4e530e87b01070f44
Reviewed-on: https://gerrit.libreoffice.org/66800Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

and preset line spaces applied in Show Changes mode, instead of
losing them after saving the document or hiding the changes.

The bug occurred in paragraphs with directly preceding tracked deletions.

Change-Id: I33d9db8ee3522470c4f2dfdcfbea4060db8769a2
Reviewed-on: https://gerrit.libreoffice.org/66789Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Change-Id: I9c04906dd492c6f8a816f57f40bc31406a871a78
Reviewed-on: https://gerrit.libreoffice.org/66793
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia2ae97498a9aad8638c4b77ce20143eeec616751
Reviewed-on: https://gerrit.libreoffice.org/66792
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9ac9a34ba58f411d5aad235407553df63216319c
Reviewed-on: https://gerrit.libreoffice.org/66791
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I371d987884987fab8039c3329968f7a9282455f2
Reviewed-on: https://gerrit.libreoffice.org/66829
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ifc48e5fbcc212f0e80cf6877e2781910e38e5e54

Move XIndexAccess Java tests to C++ for ScSheetLinksObj.

Change-Id: I1662766ab9026da7c8ce97953e4f690d94c2d479
Reviewed-on: https://gerrit.libreoffice.org/66816
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScSheetLinksObj.

Change-Id: I8265bb9234c93e8a6e64b55522e7f0543b3af7a9
Reviewed-on: https://gerrit.libreoffice.org/66815
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XEnumerationAccess Java test to C++ for ScSheetLinksObj.

Change-Id: I68013a9717ab8da1dd4b15f489fc394c101cc016
Reviewed-on: https://gerrit.libreoffice.org/66814
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

* Update helpcontent2 from branch 'master'
  - Fix some typos
    
    Change-Id: Ife8c609e1db336417077a31d8a549614e00bd91b
    

In Writer it might cause a problem to use relative
size with text based numberings.

Change-Id: Id19b5e45f0f932d1b69028f343daad7dec34ae23
Reviewed-on: https://gerrit.libreoffice.org/66811
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

...that is documented as: "Does nothing.  Preserved for backward compatibility."
ever since <https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=160384> from
2010.

-fno-default-inline was the only value ever set in gb_DEBUG_CXXFLAGS, so the
latter can be removed now.

The use of gb_DEBUG_CXXFLAGS had accidentally already been removed from
gb_LinkTarget__get_debugcxxflags with e751e242
"--enable-optimized should be orthogonal to --enable-debug/--enable-dbgutil",
and that leaves gb_LinkTarget__get_debugcflags and
gb_LinkTarget__get_debugcxxflags with identical definitions, so replace those
two with a single gb_LinkTarget__get_debugflags.

Some external modules had used only gb_DEBUG_CXXFLAGS, when this was apparently
meant to be used in addition to gb_DEBUG_CFLAGS, so those uses have been changed
to gb_DEBUG_CFLAGS now.

Change-Id: I84ea0ab1233569b0b02ca057240a71f138352381
Reviewed-on: https://gerrit.libreoffice.org/66808
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Map that EOPNOTSUPP to osl_File_E_NOSYS (and intercept it in
StillReadWriteInteraction, as used by MediaDescriptor::impl_openStreamWithURL in
unotools/source/misc/mediadescriptor.cxx, which will retry opening it read-only
then), instead of to osl_File_E_invalidError (which lead to the "General
input/output error" box).

Instead of "silently" opening the doc as read-only, this still pops up a box
claiming that the doc is locked by somebody else, asking whether to open it
read-only or to open a copy.  That's probably because of the

  rDescriptor.erase( utl::MediaDescriptor::PROP_READONLY() );

in TypeDetection::impl_openStream (filter/source/config/cache/typedetection.cxx)
where the comment already hints at the confusion among the different read-only
and locking concepts.  Changing that looks like it would easily cause
regressions, so is left for a follow-up commit.  (And ultimately LO wouldn't
need to treat the doc as read-only at all; it would just need to not attempt to
open it O_RDWR upfront, and save it via copy+rename, like other apps appear to
commonly do.)

Change-Id: I56e18f1864084ba222acaf0e38a604082edaf4c6
Reviewed-on: https://gerrit.libreoffice.org/66805
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic968b022e3b37a9329ca29708f53b36f0e7b2ce9
Reviewed-on: https://gerrit.libreoffice.org/66797
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

so no select-handler called

Change-Id: I0398b53b24fa8095af67706922c93bb7e8d6d8d2
Reviewed-on: https://gerrit.libreoffice.org/66799
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id073f9bc4ed4710ba29d7864f8d03a54fa14354c
Reviewed-on: https://gerrit.libreoffice.org/66788
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

and reweld SwMailConfigDlg

Change-Id: Icf7497db0cd2e9097752414eb11498c694723646
Reviewed-on: https://gerrit.libreoffice.org/66787
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib5e07977b6dd15b533e94185ecb80d0d6587b7c7

* Update helpcontent2 from branch 'master'
  - Moved the pagination controls to the top
    
    As the height of the result list keeps changing constantly,
    it was highly annoying to click the arrows in the controls.
    
    Change-Id: I82308adc3971f25ed629009bf1e0854d38197560
    Reviewed-on: https://gerrit.libreoffice.org/66795
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

UpdateName_Impl is called if its sensitive, regardless of hidden
and it makes no sense for the character style to update it and
results in unsightly warnings of...

... gtk_tree_model_iter_nth_child: assertion 'n >= 0' failed
... gtk_list_store_remove: assertion 'iter_is_valid (iter, list_store)' failed

Change-Id: Iaca6104ebb5e44ce45a7bb01a348f9c5f54de876
Reviewed-on: https://gerrit.libreoffice.org/66778
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Already broken for windows and mac, the numbers changed
for me on Ubuntu when switching from gcc5 to gcc7 or gcc8.
How it still  works on the tinderboxes etc I don't know.
Anyway, by removing the obviously irrelevant actual numbers,
the test still covers the original intent by ensuring that
the top point is farther to the right than the bottom point.

Change-Id: Ieeb7cd854847d47a11dc305db82371e2b8f85049
Reviewed-on: https://gerrit.libreoffice.org/66724
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

If a floating table was imported from docx, it will be placed in a frame.
A grabBag attribute remembers the original positioning values.

Restore this state when exporting to docx again and do not export the
surrounding frame.

This has to be done at the start of a paragraph, so remember the exported
table in a std::set and skip it later in frame export.

Change-Id: Ib62d4b228b306e5d1c4ce61fbbd4b6c3e1206603
Reviewed-on: https://gerrit.libreoffice.org/65982
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I0b444eae51b65caf740e625e65137ff9ff8ce4da
Reviewed-on: https://gerrit.libreoffice.org/66782
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>