Change-Id: Ia5dc32fbcd8ad738d5ec0f20cc233b58fcadc882

... so formula expressions using it actually get the ranges highlighted.

Change-Id: Ibb0d2b49101e62b1f219a14d1669a501a450aaf4

Change-Id: Ic648fd2b0a1424aa5ae5d924b29dfd2cb8dddbf9

Change-Id: I23777477d31f30ee18ee8926a8f3170505f74264
Reviewed-on: https://gerrit.libreoffice.org/38535Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I40acd32229faa9a4ec9941592a4a952b7d05ef01
Reviewed-on: https://gerrit.libreoffice.org/38464Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: If81494b9279d3c1f2c3887097f1b0036c18cab78

Change-Id: I94b8054cc978c04ae994380ea0c564a4b16de26d

Change-Id: I70e3bd1129da76e11b5f71b1b56d79898eb3d5be

Change-Id: Ib7f9b3961a3885be8c39ec5a20e7f383ecc9cc37

Change-Id: I3a485518be1372c9c56137c35cefdbc8d0362fe4

...to stop CppunitTest_sd_dialogs_test failing with

> cppunittester: /data/sbergman/lo-san/core/svl/source/items/itemset.cxx:678: void SfxItemSet::MergeRange(sal_uInt16, sal_uInt16): Assertion `!pRange[2] || (pRange[2] - pRange[1]) > 1' failed.

(and whyever that only started to hit now)

Change-Id: Iadb5538b8b10182ddf5dbe02d34d7c73c7d62a14

...since 87c94652 "Bin unused function
DbgCheckItemSet"

Change-Id: I109598dc5e087697d77b96a0ba2fb178d47b3aa6

We guarantee that all references are of same size.

Change-Id: I61888a257691f902cb958741f6b63779d9744e10

Also add some useful hidden commands for easy access for users to enable

Change-Id: I28806047f2fac51995d88b7c204d54479471aa29
Reviewed-on: https://gerrit.libreoffice.org/38552Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

See <https://listarchives.libreoffice.org/global/users/msg51243.html>
"[libreoffice-users] type byte in Basic", where

> Sub Main
>   dim oOutputStream as variant
>   oOutputStream = createUnoService("com.sun.star.io.SequenceOutputStream")
>   dim nA as byte
>   nA = 195
>   oOutputStream.writeBytes(array(nA))
>   oOutputStream.flush
>   dim back(0) as byte
>   back = oOutputStream.getWrittenBytes
>   MsgBox(back(0))
> End Sub

failed with "Inadmissible value or data type. Overflow." instead of showing
"-61".

Change-Id: I0445476c67510d5f8669a6e711e92332c01ec06c

because the user has modified the document

Change-Id: Ib32ea2ff41f41a81c9a382585f6afbec12fe6a35
Reviewed-on: https://gerrit.libreoffice.org/38284Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

XBufferedThreadedStream class buffers data in a new thread,
which will be available to be read from parent thread.

Change-Id: I62d367fa1dec23da39aba24b5c765b57707956bb
Reviewed-on: https://gerrit.libreoffice.org/38135Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Mutexes in different classes operate exclusively, which might
cause sync problem when multithreads are involved. This
patch shares the mutex across all classes that share
the underlying stream.

Change-Id: I57e549fb7c375f93955bf54886b91b1892db1e27
Reviewed-on: https://gerrit.libreoffice.org/38563Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Except those who were set open r/o with the File->Properties checkbox

Change-Id: Id44daac364cae73636b6f1c051521928743b88f4
Reviewed-on: https://gerrit.libreoffice.org/36258Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This way it's not necessary to state the size of the array in advance,
which is kind of redundant. It's also easy to forget to adjust it when
adding new elements.

Change-Id: I5fe24fd24954afb69ead014941b8f8b90bcaeac3

Fails here on Linux dbgutil like this:

======================================================================
ERROR: test_validation (calc.ManualCalcTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "uitest/manual_tests/calc.py", line 133, in test_validation
    self.ui_test.execute_blocking_action(enter_text, "ok", args=("B6", "2.18"))
  File "uitest/uitest/test.py", line 191, in execute_blocking_action
    raise DialogNotExecutedException("did not execute a dialog for a blocking action")
uitest.test.DialogNotExecutedException: Dialog not executed for: did not execute a dialog for a blocking action

Change-Id: I2004eb52ce0846ada7ed38dc19d71258d2272ad5

 #define STR_POOLCOLL_TOX_AUTHORITIESH   (RC_POOLCOLL_REGISTER_BEGIN+ 29)
 #define STR_POOLCOLL_TOX_AUTHORITIES1   (RC_POOLCOLL_REGISTER_BEGIN+ 30)

in the context of

switch( m_eType )
...
case TOX_AUTHORITIES  : nPoolId = STR_POOLCOLL_TOX_AUTHORITIESH;    break;

SetTemplate( 0, SwResId( nPoolId++ ));

already results in a nPoolId of STR_POOLCOLL_TOX_AUTHORITIES1 when we enter this
loop, so don't need to special case TOX_AUTHORITIES

Change-Id: Ic41596a85c48d080cd38003663b729583f08ff98
Reviewed-on: https://gerrit.libreoffice.org/38561Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

..."tdf#45904 Move java XCellSeries test to c++".

For one, the XCellSeries tests needed to be removed from
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv, now that those
tests are done in C++.  (Plus some clean-up in
qadevOOo/tests/java/mod/_sc/ScTableSheetObj.java and
sc/qa/unoapi/knownissues.xcl that was missing from
f1454b47.)

But for another, qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellCursorObj.csv
and qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellRangeObj.csv still list
XCellSeries tests (which apparently have not been superseded with C++ tests),
so partially revert f1454b47 to get back
qadevOOo/tests/java/ifc/sheet/_XCellSeries.java needed by those tests.

Change-Id: I09f756fb804dafee3064947abcfb796db4797b32

Change-Id: I28459b157411b4ab5b10a25e017a0a7208e09aed

Change-Id: I71405f1dbf0a1524e4e367ae5e05edaf6a8e98b8
Reviewed-on: https://gerrit.libreoffice.org/38559Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

...so document saved in Web view shows in Web Layout in Word.

Change-Id: If39d566be02966fe5d22f74aee46e6d5452a9451
Reviewed-on: https://gerrit.libreoffice.org/38469Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I11409dfc621018a761c70a640938e18ae679d3f5
Reviewed-on: https://gerrit.libreoffice.org/38254Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ia9bf97f10771dad5ecf1c3a9638384a80b65b181

with thread safe local statics.

Change-Id: I660f6a899d1821bab627ed4972c4fc0d40610de2
Reviewed-on: https://gerrit.libreoffice.org/38541Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...in recently introduced basic/qa/basic_coverage/test_string_overflow_safe.vb
in CppunitTest_basic_macros

Change-Id: Ib33272afa26e90729617cb86ae979c0b35b45f62

Change-Id: Ia4e02589d2fe79a27b83200a0e7a528a2c806519
Reviewed-on: https://gerrit.libreoffice.org/38508Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As documented at
<https://msdn.microsoft.com/en-us/library/office/ff192986.aspx>.

Change-Id: I390c22e75c8cfb41034287848f92578ad67e724f
Reviewed-on: https://gerrit.libreoffice.org/38524Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

As documented at
<https://msdn.microsoft.com/en-us/library/office/ff197557.aspx>.

Change-Id: I4ffa74293978e4642e043a9cda80a7b4a9b5512c
Reviewed-on: https://gerrit.libreoffice.org/38523Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

As documented at
<https://msdn.microsoft.com/en-us/library/office/ff839402.aspx>.

And also extend ov::excel::XInterior with a ThemeColor property, as
documented at
<https://msdn.microsoft.com/en-us/library/office/ff820778.aspx>;
implementation is just a stub for now.

Change-Id: I05f1490cdc366f5db127d340cab5f51efcafa862
Reviewed-on: https://gerrit.libreoffice.org/38522Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ie9356a4922f7d01c674ec50bb30cd70e73469055
Reviewed-on: https://gerrit.libreoffice.org/38549Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

HTML tables with border="1" were parsed and displayed incorrectly:
no vertical borders; invalid border width.

Also fixing problem with strange condition allowing setting right
border.

Change-Id: Ibe87e630ef9ef0a4352bbe659340f69c8ebc0d0d
Reviewed-on: https://gerrit.libreoffice.org/38454Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

If a drop-down list has a valid entry that is an empty string,
it should be acceptable as a data entry value, instead of just
ignoring it and leaving the old value in the cell.

Yes, the other simpler option is to just hit delete, but anyone using
the UI will get confused, and if not paying attention will have
incorrect data entry since it doesn't work as expected.

In the bug tested here, the selection dropdown was created with
data validation. Unsure of other times that create the grid...

Change-Id: I3b49c34d01079d4c1ec9e140e2c51123408b10a6
Reviewed-on: https://gerrit.libreoffice.org/38124Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iedc1023b67138727061c2da13bebdb75af370ec6
Reviewed-on: https://gerrit.libreoffice.org/38105Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I7efdbc1278d27ed75d8e48a35a9fac0358144214
Reviewed-on: https://gerrit.libreoffice.org/38548Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I10589a17b9c01998a54328ea290983de72067f5e
Reviewed-on: https://gerrit.libreoffice.org/38540Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>