Change-Id: Ide0e10fa528d53a7e732d00b54c940111beebe19

Change-Id: Ie1ec0308f72efe3bc46564d81f0cf37c0d606114

Change-Id: Ia69283a9998c233784c0da0f7a65f58a6c102596

Good riddance.  It was optimized for the old cell storage.

Change-Id: I374194fe211d5b13dd60dbb68b9511a366fb32bd

Change-Id: I54d0bbe460f95ada7632d7c9cbedb8a677995fd4

Easier to follow this way.

Change-Id: Idf7e93106f1e1927967f4917062ee619ed71d694

This scrapes off additional 2.2 seconds.

Change-Id: I08ae67f45946721d722be7183270d7bcf01f96b0

Change-Id: I2ee377a865f361673912b796af1eb8517c1456f7

Change-Id: I490ecade6b909bcf36b848c05e198d58adc90e0a

To ensure that there is no SC_SCRIPTTYPE_UNKNOWN in the sort range,
the presence of which would slow down during AdjustRowHeight().

This only adds a tiny overhead (0.3 second) and cuts the duration of
AdjustRowHeight() from 15 seconds to 5 seconds.

Change-Id: I145e901225ef1136f53c6f682ffed3902099859c

Only when the "keep query" flag is set.

Change-Id: Ia799f62ec53a08cfd92e93c546965002c030b324

Unfortunately sorting becomes noticeably slower when cell format is
enabled.  Perhaps a future project.

Change-Id: Ieb02b207b62df343d1f667a8075874b7688ee9a7

Otherwise it'd throw an exception.

All unit tests pass now.

Change-Id: I1dc49afcdf3e6604de4c0bc2440106c5ce0da090

Also, during unit test, the function separator is set to ';', not ','.

Change-Id: I3ba948c54bee3c05715928f6f2f2945621fbacad

Change-Id: Ib541cb9f99b3f1094e33d7b333fdbeeeccadce26

Change-Id: Ibb330aa6f515d756c5578296fd9c83aa235a59fd

Otherwise formula cells would mis-behave during grouping.  Also, the
range-based release() was renamed to release_range() to avoid unwanted
function overloading due to implicit type conversion.

Change-Id: I3dc1421f89926f161963eede9a2c8eb477d7e5be

This makes the sorting fly.  Still slow in AdjustRowHeight() which gets
called after the sort().  Will have to look at that later.

This change requires a newer version of mdds (not yet released).

Change-Id: I50c6ec9bb562af85c3b77201e2cd31b30dd719e9

Change-Id: Ia74c0f07c7f1021de92f77fdb93b2279a3b8462c

Change-Id: I415b3cddc4b764668564affd573ae9cc00601278

Change-Id: Iab46c26606880f0fa7c7067d8514b8be3629fe0f

Change-Id: I107ccbbc61a5e8024f21a7a30fae9fea00c90bde

Change-Id: I21cc7aa2cc521203f4da6f754a2ad7b4e985dd67

Change-Id: I5f7e5747336c7104004083e4d23f621a00d4b494

Change-Id: I03c52705979dd239ee90fde2406800c1a9c2809a

Instead, build a data table prior to sorting, swap rows in this data table
as we sort, then transfer the results back to the document in one step.  This
significantly speeds up the sort performance.

Formula cells are yet to be handled. I'll work on that next.

Change-Id: I59bde1a243dc8940411d1a33eef147671b060cd0

To ensure that the cell and cell text attribute storage stay in sync at all
times.

Change-Id: I5ea3fb7601f42f22af30f4f2d96d9d5e481e0853

This will be used later when re-ordering rows.

Change-Id: I47504b49be11174b0002b1af1cbce9b8b7f2531c

Change-Id: I5acdb7e55cb3dfeff880f1f361fed4a8cc4acd3c

Change-Id: Iec2cdcdccb3c9a9771dd5f31f527ddccd470765c

* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>

This reverts commit e7646e7e.

At least, it makes CppunitTest_sw_ooxmlsdrexport succeed again.

Change-Id: I05b9de5366b0e3d2007311d00991758b6d6f8dba

Change-Id: I14e48d56b6f34be31a1580d448352b925f9aadde

Test name: testShapeEffectPreservation::Import_Export_Import
equality assertion failed
- Expected: FFFF00
- Actual  : ffffffff
- Attribute 'val' of '/w:document/w:body/w:p[3]/w:r/mc:AlternateContent/mc:Choi
ce/w:drawing/wp:anchor/a:graphic/a:graphicData/wps:wsp/wps:spPr/a:effectLst/a:i
nnerShdw/a:srgbClr' incorrect value.

Test name: testShapeEffectPreservation::Import_Export_Import
equality assertion failed
- Expected: 1
- Actual  : 0
- XPath '/w:document/w:body/w:p[3]/w:r/mc:AlternateContent/mc:Choice/w:drawing/
wp:anchor/a:graphic/a:graphicData/wps:wsp/wps:spPr/a:effectLst/a:innerShdw/a:sr
gbClr/a:alpha' number of nodes is incorrect

Change-Id: Ia21a96009137e7e68900ff0d3b61656a9a7b7659

Change-Id: I5980ba6b77f8adfe9a57fd2cffd8034e26bb086d

I have plans to change the sal textenc stuff to use ICU so better assertion
messages is essential.

Change-Id: I764a317435b6bd7c88d6e42fcfbefb1ec9c308fd

Change-Id: Ic1a99ef971168093835207dd084e50a4f02b5e5f
Reviewed-on: https://gerrit.libreoffice.org/9141Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>

Change-Id: I5ca7c564e2ec79862a3ad522df61b24e44e9a16d

Change-Id: Ie9c3e5e6c39cc4c80b064088df5f3b8748819d7d