Also changed the fill color of "Data" button to a lighter shade
to distiguish it from other buttons, for both row and column fields.

Added matching testcase in chart2dump.cxx

Change-Id: I2ae5da6c3552372f606da41055f1e0663b6f0802
Reviewed-on: https://gerrit.libreoffice.org/39687Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

...proportional to the chart size. This lets a default pivot
chart maintain its current size even when there are no data points
which may result from a pivot field filter operation.

Tried to add a test, but could not with a reasonable amount of
effort.

Some observations I made when tried to create a unit test:

1. If a new chart is created using uno api fresh from a pivot table,
   no legend is created irrespective of whether there is data or not.
2. Pivot charts with zero data points work fine with this patch, but
   on round trip the chart needs to be explicitly refreshed by
   clicking one of the pivot table's field selectors to make the chart
   show axis/labels etc.

Change-Id: I010ca9093ce94dc216ba06e9d7aedaa412e59401
Reviewed-on: https://gerrit.libreoffice.org/39620Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I8d782b109eb390838b6c4f3a85e9b344ecef87ec
Reviewed-on: https://gerrit.libreoffice.org/39606Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Icbe27f697aed9a67e3e1783783df0c6ad598b582

this is a problem since

commit bea1dc5f
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Jul 7 13:59:27 2017 +0100

    Resolves: rhbz#1467512 mask not created as 1 bit depth

Change-Id: I3c9fd81bf7413f5decf2b55a660f028c0613c3b3
Reviewed-on: https://gerrit.libreoffice.org/39745Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I002f9ecea2933642399667caaa1a9d77e30751a9

Change-Id: I0edd454c03b0c3e502d4ef87db584a0cec2884be

which was gone at cbcfda9b.

Change-Id: I37dea6c6696b03443bad255b68e78eaf3ff0dae5
Reviewed-on: https://gerrit.libreoffice.org/39746Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I504d7d118d30a310bbb0199de8b9fd58f2bcaaa6
Reviewed-on: https://gerrit.libreoffice.org/39751Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8d18efcc609dfc2d5154bfae8799f3517bc3e48f
Reviewed-on: https://gerrit.libreoffice.org/39738Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

/sd/source/ui/sidebar/SlideBackground.cxx:176:17: runtime error:
downcast of misaligned address 0x00009cf8cd67 for type 'const
SvxSizeItem', which requires 8 byte alignment

(regression from fba28df7)

Change-Id: I822efe57f35c851b6f63e1e5489ab2448a19963d
Reviewed-on: https://gerrit.libreoffice.org/39753Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Actually only the SvTreeList::InsertEntry() needs a non-const void*

Change-Id: I63eb05ba63264efd63bfa287f0ab0bf2840b4414

Change-Id: Ieece2f9728755a8ae91275535eaa39319eea274e
Reviewed-on: https://gerrit.libreoffice.org/39740Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id271fdb59cb0dedf2f180879d2116d11e45d68b3
Reviewed-on: https://gerrit.libreoffice.org/39739Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

In the desktop case we invalidate up to the right side of the visible
area, however in the tiled rendering case we need to take care to
invalidate also cached tiles.

Change-Id: I7290ff35c155fab6bda3ce8b5d9c765624507052
Reviewed-on: https://gerrit.libreoffice.org/39728Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4ee2df05ffceaea9d22ec7e2f78dc6e13061b5ef
Reviewed-on: https://gerrit.libreoffice.org/39714Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie64ba38d607733b457d66ed1b9af84303c676e13
Reviewed-on: https://gerrit.libreoffice.org/39695Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and thus avoid crash when user clicks 'show signatures' button
in a window where signature bar shouldn't even be

Change-Id: I5eba8d1ddd8c76dd10acedfa03d732df586748de
Reviewed-on: https://gerrit.libreoffice.org/39699Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I53b5430d1563fcceae29418fd5907ac42ea856e7
Reviewed-on: https://gerrit.libreoffice.org/37626Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

cowardly avoiding use of DrawViewShell in constructor

Change-Id: Ib40406d439403d0e2de270827bf5c2f06cfb18c2
Reviewed-on: https://gerrit.libreoffice.org/39368Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I2e57e9413f98de9a6d240c3c61c85fd7bd435498

Change-Id: Ia4517b01a39c02619ccae73e4c182ac8d7e6e22c

Change-Id: I6837937945749a0f44e4e50aae1267edb37921d7

Fun fact - CreateFileW returns INVALID_HANDLE_VALUE (-1_) because the
16-bit functions OPenFile, _lopen and _lcreat return -1, so the Win32
API function CreateFile function also returned INVALID_HANDLE_VALUE
to ease porting Win16 code to Win32.

CreateMutexW, on the other hand, had no corresponding function in
16-bit Windows so it returns NULL on failure.

cf. https://blogs.msdn.microsoft.com/oldnewthing/20040302-00/?p=40443
Raymond Chen is a gem who explains clearly why Win32 code is so
idiosyncratic.

Change-Id: I7888d46b048e5674ad776c8ac8070a1e57aa37a6

remove_copy_if copies entries for which predicate returns false.
since C++11 there is copy_if which copies entries for which
predicate returns true.

Change-Id: I3ade82f13d27364e2cd35f4286b18128f52f8a5b
Reviewed-on: https://gerrit.libreoffice.org/39727Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Project: help  adc9f8c1cd429d2b3aea19efc8f5e7010a951240

Hyphenate compound adjective

Change-Id: I9114f0017335dff30a3273a55a4ac1610dcb1511

std::remove returns a past the end iterator which should be used
for the reallocation.

This makes the code more robust. Previously it only worked if
there was exactly one value with type XGeneratedResultSet in the
Sequence.

Change-Id: Ia2db1252ba8fe682dbc55d9722eaa62ed596e297
Reviewed-on: https://gerrit.libreoffice.org/39724Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib530567df9cb487951d8dbf1b7824f78a7d150d9
Reviewed-on: https://gerrit.libreoffice.org/37581Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I766fedb34737a1a7815693bf496fa08c08f492b1
Reviewed-on: https://gerrit.libreoffice.org/39719Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Also simplify this class.

Change-Id: I7abccd19287101918a6d9b4636ce2faecf169123
Reviewed-on: https://gerrit.libreoffice.org/39446Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6e0e1a7f58873c012e0e8015ed69da38a32a44f4
Reviewed-on: https://gerrit.libreoffice.org/39323Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I5a3d64fd255fb8fd1f1caba572bc00a5399a6519
Reviewed-on: https://gerrit.libreoffice.org/39550Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Word appears to use negative z-indexes to indicate behind-text
zordering and positive numbers for in-front placement. This
was added for shapes in LO4.3, now applying to textboxes also.

Change-Id: I3b06fb231329f151ca978f3a68b4d4e89bc28515
Reviewed-on: https://gerrit.libreoffice.org/39671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ieb89a2e69ae44fe1cfbe99e843239cf25e97463a
Reviewed-on: https://gerrit.libreoffice.org/39712Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: If1dd46643dc2ae9cc74ba94038609ae3445a416c
Reviewed-on: https://gerrit.libreoffice.org/39706Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

If DrawAspect is equal "Icon", show an icon not document preview
Document is opened in the separate window, not in-place.

Change-Id: I3a8d81e7340b29d247f8ac440c06b0420bb65644
Reviewed-on: https://gerrit.libreoffice.org/39440Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

As pointed out by sberg, either the issue is a programming error that
needs an assert, or the issue is unusual and should just generated a
warning, but never both.

Change-Id: I07ae1e99597cd6c342791aa268b2240db987ae91
Reviewed-on: https://gerrit.libreoffice.org/39514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

See http://dbase.free.fr/tlcharge/structure%20tables.pdf

Change-Id: I68df30f73d2556a217f30d80d1d55ec93bca1564
Reviewed-on: https://gerrit.libreoffice.org/39710Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iabc7293370c7a8b3fdccb00d6e1cdbfac4c46992
Reviewed-on: https://gerrit.libreoffice.org/39445Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>