This addresses some cppcheck warnings.

Change-Id: I4c55c109f81407d5383932e4254e0f5f61d12cd7
Reviewed-on: https://gerrit.libreoffice.org/13939Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Id28c3e1617f2e73c36f13b506488d401a22b00a8

left over from "SVStream operator>> to Write method" conversion

Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b

It's basically the same thing we do in ScDocument::DeleteArea(), implemented
in ScDocument::SetValue() and SetString().

Change-Id: Ifcae31aaef0e00ed8659aa5e2b9b8e206dc1a099

Change-Id: I1e5e9d50af471bc0e63f0d39478d96bf479583d5

The tdoc_ucp::OfficeDocumentsManager lives until the service manager
is disposed on shutdown, but if the database stuff isn't disposed in due
time then a document may call the notifyClosing() on the listener after
the OfficeDocumentsManager dies; probably something is leaking the
ODatabaseContext...

Change-Id: I59662b910589d7270697452b2f4ca6c960d22f22

This reverts commit 7de5ffbf.

Change-Id: I3cf20882dc706700688cbbaea4f45bbe64d7aeca

Change-Id: I60446644e7700f5c119dd94d4da08bb39f5bd268

also

coverity#1264392 Logically dead code

Change-Id: I37c542a6d088a2aca4cf09a341d389efd34f423a

Change-Id: I085f2d0e15c88b995bea3f99945c9ab2e2bcc909

Change-Id: Idfca6110d3170a94efaa9ac51902893d9403c27d

Change-Id: I9e6e15cc5a5597586b4a913e0cc75cf337ddfc05

Change-Id: Iaea31af5b7e41367b59fe02d523bcb7e08a8e0fc

Change-Id: I20bf0fa3a9b1562d46eba6321edca047cf02b128

Check that grouped area listeners aren't discarded when unsharing a
grouped formula.

Change-Id: Ic3d3e9acb5b97d927a85ca433de127dd3b74a30c

Further implementation is needed to re-establish grouped listeners after
unshare and split.

Change-Id: I861b3f9d63a611ab0e32918ce1b272121bf12988

The SwDBManager is owned by SwDoc, so if the database thing is still
alive when SwDoc dies (which may or may not indicate a leak), the
listener will crash when the database stuff is eventually disposed
during shutdown.

Change-Id: I2bb5eb35f0a403374bc8f123b85ba2d7244016b0

glibc declares write() with the warn_unused_result attribute, so we need
to check the return value to avoid a compiler warning.

(This warning only seems to occur when gcc optimizations are enabled)

Change-Id: I31962aae63d0a12eecfe44bb7920a68b29c05d8a
Reviewed-on: https://gerrit.libreoffice.org/13927Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

an old bug that I finally hit on by typing one paragraph
of three lines consisting of repeated "Apple " and the cursor
at position 0 and click the bullet icon

Change-Id: I90e998561f2645ebfa51423bcaab9a4195144338

Change-Id: I8ea6dbf5fbe6c7706d833dddf43b31128f079017

Turns out this is still useful to have, let's not be that aggressive :-)

Change-Id: Ie9eb8b241594ce470238aa0b769a0afd2418e498

Change-Id: Idbee7d8c96082a88c9653556ec7f88f4e7ced973

Change-Id: Ie73b7ead02434a0614287f61f0ffd49eeab32aba
Reviewed-on: https://gerrit.libreoffice.org/13681Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I081d375b0249a3b0e47c1dd6db3f86fef272e7fd
Reviewed-on: https://gerrit.libreoffice.org/13925Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I8f7777c1234a69e1851b8f4f4e8afc8466cc2e06
Reviewed-on: https://gerrit.libreoffice.org/13918Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I0bb6df332a6666a0ae96bba38626b2626f880490

This reverts commit 8c291bb1
because a pile of stuff then crashes, its not sufficient
to remove things from .ui files if there are still used but
the cxx. e.g. opencl options page

Change-Id: Ice608af7e4a3f7798183a45602715ab04afbc87a

leftovers from conversion of SvStream operator>> to Write methods

Change-Id: Id1d1e60ae42afb689910845a3c6ec75e3388fb56

Change-Id: Ie116cee9282b3cc73e3bbb9b3fbaa50b1e8e974a

Change-Id: Ibf34083d99e0aceee2855ed10939ad3b60b8abae

if we didn't make use of them.

Change-Id: Iee1c2fef5966a614b068c832bf8c6b51973b4c8a

Change-Id: I662f51d8d7c88a6c6f7306c344d99841a3102bb4

Change-Id: I199f4cd8897e3fa7b794f3d6d96077e98ccff51e

Change-Id: I9c825663508abdc7efa9cf2801770acc2b79174a

Change-Id: I22f500cb6b62ac4ed7158bc68fa76f84173bc86d

Change-Id: I4bcdeca96e59e2bc3a2a96f546d060504f020bc7
Reviewed-on: https://gerrit.libreoffice.org/13917Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Change-Id: I7e6afeea9368241bea8af141726e73c557475317

Change-Id: I2da98a82f2d2407f48960a4e53643cee63b4844d

Change-Id: I54b9f3ca66035b66509c960ca79391446ecf8778

Change-Id: Ie8ccf61f0b04b718c930b14374843e3858c6278b