look for classes which are effectively final, but contain protected
members. These members can be made private.

Change-Id: If53d535b068b668d1aff548ebfd0fe6c51a48a0e

Change-Id: I92c84d0d0fba1adcd0adfc93e3fe9b5ea6b8cbf2
Reviewed-on: https://gerrit.libreoffice.org/43065Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Icb2fa621e1f7da1e2d4bd221c8e1d8677cc956a2
Reviewed-on: https://gerrit.libreoffice.org/43057Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Bug was introduced in
    commit 12b2803f
    "drop unused PRESOBJ_IMAGE"

Change-Id: I50be74b505a674439bd8b67545b89a9660a85a33
Reviewed-on: https://gerrit.libreoffice.org/43062Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iab3c142cd85ca54bf3c37a0710ce7da7a5d77a35

Commit e6ec0794 (tdf#104937 RTF import:
\trwWidthA is an absolute value, 2017-08-29) changed the handling of the
fake empty cell at the end of table rows so that the parameter of the
control word is an absolute, not a relative value.  Turns out this
wasn't correct, the DOCX equivalent of that bugdoc shows that the
parameter is a relative value after all. The RTF spec also talks about a
"width", which is assumed to be a relative value.

So fix that bug in a different way again (by making sure that this
additional fake cell contributes to the total width of the table, so
column separators are counted correctly), this time without less
side-effects.

Change-Id: Ic64fd3a6abae8e0398e8e77123f0473d73f0c4b0
Reviewed-on: https://gerrit.libreoffice.org/43063Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: If81cd3d4508ba3f44304a9ec9b643bf771e8930c

Change-Id: I3b9f00adb76fc702e1847d9fab866b7796cfd942
Reviewed-on: https://gerrit.libreoffice.org/43061Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

This also inlines SdrGluePointList::GetObject().

Change-Id: I70052a5e94b3451f5a00e1185e6dee59e5537184
Reviewed-on: https://gerrit.libreoffice.org/43059Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd
Reviewed-on: https://gerrit.libreoffice.org/43025Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4a1f04b9dfe9e3ebbc174380db93c332e958ccfa
Reviewed-on: https://gerrit.libreoffice.org/43060Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>

Change-Id: Icca25565d396a36154bca0ac748554e95cd83ae9
Reviewed-on: https://gerrit.libreoffice.org/43049Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  aa1e7fffd4f067414833d593cd0307bd2dc9d6f9

tdf#112804 Fix key combination for inserting paragraph before table

Change-Id: Ibe077bd39c5e2a44520052ae0afa9cd69ca59991
Reviewed-on: https://gerrit.libreoffice.org/43054Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Since RSC is gone..

Change-Id: I146e6a7284766f0462ba8099458700507d982214

Change-Id: I52843868a62cb1b89fba21c4e412a52501d2dc20
Reviewed-on: https://gerrit.libreoffice.org/43007Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Ifebd1124fa081d50797904175d90e6d26d50ab7f

This is similar to gb_JunitTest_DEBUGRUN, i.e. allows running soffice in
gdb, and then connecting to that soffice from the test, instead of
starting an own one.

Change-Id: I023d6b0ede146837666c946cb865feb9046e5a94
Reviewed-on: https://gerrit.libreoffice.org/42756Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

User events processing - as all event processing - can be nested,
which can cause TriggerAllUserEventsProcessed to be called multiple
times, when a nested event loops ends.

So track TriggerAllUserEventsProcessed calls and just reset, if
a new event was inserted.

Change-Id: I4a1b1b08901c99a7ece08f8baf008c8bb73506bf
Reviewed-on: https://gerrit.libreoffice.org/43043Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I80e00083e851cd3db44a3ca9391225657526bfe4
Reviewed-on: https://gerrit.libreoffice.org/43045Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I325141f90104496c62af8704d75568df3418952a
Reviewed-on: https://gerrit.libreoffice.org/43050Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Due to previously intruduced optimizations, it is safe and fast enough
to navigate through a 500k rows speadsheet.

Change-Id: I865d0b60629b5bbf796e9e48df6ff21242a13e5a
Reviewed-on: https://gerrit.libreoffice.org/40454Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

Now the computation of the row/column headers data exploits the cached
row/col positions in HeightHelper/WidthHelper.

That makes updating row/column headers at the bottom of the document
as fast as at the top even for very big spreadsheets.

Change-Id: I27381b520aaed68662e4d07c5879046d182c70e6
Reviewed-on: https://gerrit.libreoffice.org/40451Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

Now the computation of the cell cursor position exploits the cached
row/col positions in HeightHelper/WidthHelper.

That makes navigating through arrow keys independent from the current
cell cursor position: the cell cursor position is updated at the
bottom of the document as fast as at the top even for very big
spreadsheets.

Change-Id: I2f23d4439f2157e702f09b56106bebdd0e0bbe86
Reviewed-on: https://gerrit.libreoffice.org/40450Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

Cached row positions are invalidated when one of the following event
occurs:

- one or more rows are inserted
- one or more rows are deleted
- one or more hidden rows are made visible
- one or more visible rows are made hidden
- one row is resized
- optimal row height is changed
- the value of the PPTY parameter is updated
- a undo/redo involving any of the above actions

The same occurs for cached column positions.

The solution takes care of row/column operations performed in another
view and of the current tab each view is displaying

Change-Id: I57895506b17986d36ab024eec9c79864ea95dad7
Reviewed-on: https://gerrit.libreoffice.org/40449Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

Grid lines, cursor overlay, row/col headers are all computed by
summing up row heights / col widths converted to pixels.

On the contrary the document size was converted to pixel only at the
end after having summed up heights/widths in twips.

All that lead to have a document height/width greater than the
position of the last row/col, with the scrolling in online going
unplesantly far beyond the last row/column.

This patch change the way the document size is computed, so that the
spreadsheet height/width matches the position of the last row/column.

Moreover it exploits the cache-like structure for row/col positions
introduced in a previous commit.

Change-Id: Ibb2cc6a7b592e359a0b1202dc9bea1dd4c421354
Reviewed-on: https://gerrit.libreoffice.org/40448Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

ScPositionHelper provides the ability to insert (and remove) row-
position pairs where the position is in pixel and related to the
spreadsheet top.

In this way one can compute a new row position by starting from the
nearest row presents in this cache-like data structure.

It offers also the ability to invalidate the cache by removing all
cached data below a given row or position.

This data structure can be used for columns, too.

Change-Id: Ifd66a003680ef9a3babf46ae952221c04451be9a
Reviewed-on: https://gerrit.libreoffice.org/40447Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

The edit view, the cell cursor and the cell selection overlays become
misplaced when another user inserts, deletes or resizes a row.

The same is true for columns.

The solution takes care of the current tab each view is
displaying and of undo/redo actions.

Change-Id: I24c94f774f3b18028c9356a904e1b14b07c5c61a
Reviewed-on: https://gerrit.libreoffice.org/40016Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

Change-Id: I2f2c31e3605c1bff353b5749c593305c3fc7028f
Reviewed-on: https://gerrit.libreoffice.org/43044Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Iab53f39313c1bac04fe5718823455e5ef0e52f13

... if comma is the group separator (or some other separator).
Strictly only if 'T' separator was encountered.

Change-Id: I4df55235a6a416f0719752dfcde659d846ac208e

Change-Id: I326424551c280140db03b4c92ef450cc04f18813
Reviewed-on: https://gerrit.libreoffice.org/43040Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Not sure if this is the better approach, but this gives the
application window dispatch function access to the now private
timer implementation, so nobody else can call them.

Change-Id: Ic361d2c93116fbd6c85b20f7da3cffbd538b3558
Reviewed-on: https://gerrit.libreoffice.org/43041Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

These names of variables correspond to German function names in Calc
and were translated to their English equivalents. For used translations,
see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=kapz&sfields=target

Change-Id: I5c0e4232b2e7b3039a42aff96a44a8f55c818d2e
Reviewed-on: https://gerrit.libreoffice.org/42993Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

These names of variables correspond to German function names in Calc
and were translated to their English equivalents. For used translations,
see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=kapz&sfields=target

Change-Id: Ifffa1ae8394cafde6dd7a78626b957e07919d5c9
Reviewed-on: https://gerrit.libreoffice.org/42991Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Idea5c1bd8e8577eaf90fc47d39f88c79963c422b

Change-Id: I307c9095aa562348ce1b9338203995d9d62eebb4
Reviewed-on: https://gerrit.libreoffice.org/43037Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If6f66a03c5c97ec87931944147d64b3f6de1ef03
Reviewed-on: https://gerrit.libreoffice.org/43021Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: Ib60a22fefe3464e29427a3d82b3af0926375433b
Reviewed-on: https://gerrit.libreoffice.org/43020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I67f9d173526d785bfbb2c09526f915aa7c6216eb
Reviewed-on: https://gerrit.libreoffice.org/43019Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: Ia24500f490d24e28446057bd840d8e6084bf3336
Reviewed-on: https://gerrit.libreoffice.org/43018Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>