Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
to ScFilterDescriptorBase.

Change-Id: I932560c42d9c5f3077f47f116f6ae011f6aea79e
Reviewed-on: https://gerrit.libreoffice.org/67097
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I085a21afdf842a70dcdaaf9694fc6b09502985fe
Reviewed-on: https://gerrit.libreoffice.org/67096
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

- Use the correct method to remove the frame, so DOC
export will work correctly.
- Remove pagedesc attribute of the first text node if
the table is moved before it to avoid to generate a page
break.

Change-Id: I02802c4d25c947ec140b846c594848117815f1ce
Reviewed-on: https://gerrit.libreoffice.org/67093
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I635097e00e6b5d4f08badb1e99fa9b61b6b43856
Reviewed-on: https://gerrit.libreoffice.org/67084
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...that accidentally got lost in 6584a5d9
"Upgrade libatomic_ops to latest libatomic_ops-7.6.8.tar.gz"

Change-Id: I79823428499efb951761c4d55eb16e154397ce60
Reviewed-on: https://gerrit.libreoffice.org/67081
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Format-only changes had 1) disabled (in Manage Changes
dialog window) or 2) bad rejection (Track Changes toolbar
icons and Edit->Track Changes menu item functions
"Reject"/"Reject All" resulted acception of the tracked
format-only changes instead of rejection).

Because format-only changes haven't had real rejection
support, yet, this commit 1) adds an often useful
reject-like function in the Manage Changes dialog window:
instead of disabling Reject/Reject All, now these buttons
clears direct text formatting in the area of the tracked
format-only changes. Because this may be not a rejection
(ie. the original text can contain direct text formatting),
the labels of the button warn about it: "Reject/Clear
formatting" and "Reject All/Clear formatting".
Note: "Reject All" still rejects only
insertions/deletions at (now first) pressing,
as from commit a8a3928b.

2) Icons and menu items "Reject"/"Reject All" clear
direct text formatting in the areas of the tracked
format-only changes. Note: this is still not ideal,
but it can help to avoid of unintended direct
text formatting until implementing upcoming ODF 1.3
change tracking.

Change-Id: I87c3ac6165019cae9c49ed4591eaadef9e06beb5
Reviewed-on: https://gerrit.libreoffice.org/67080
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Following https://cgit.freedesktop.org/libreoffice/core/commit/?id=02623af4f5e0049ec5988df8ff6c7ff0f32f3fb1
See details here:
http://document-foundation-mail-archive.969070.n3.nabble.com/fatal-error-LNK1561-on-nss-Visual-Studio-2017-td4256601.html

Change-Id: I75f2c8a5409e484a8a5a12a6f12d5c20b244d2b2
Reviewed-on: https://gerrit.libreoffice.org/67092
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I9d13cfd136f9b70674b3e43268525f8a6e1c0954
Reviewed-on: https://gerrit.libreoffice.org/66483
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Change-Id: I8c21623f7148ab2c05fe3d4198cf12231600f88d
Reviewed-on: https://gerrit.libreoffice.org/67077
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

This is similar to commit 2dc3a6c2
(framework: allow loading a component on the main thread, 2018-12-19),
just it allows saving (via .uno:Save) and other commands operating in a
similar environment.

The use-case is that once a document is loaded on the main thread (see
commit message of the above mentioned commit), then saving also has to
happen on the main thread, or OLE objects on Windows may be lost.

Change-Id: I7321659550b556e96085ac20f197a87d5d13f1ed
Reviewed-on: https://gerrit.libreoffice.org/67089Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

It was difficult to find the sentence capitalization function.
I thought it would be a good idea to add the UI strings of the
options as comments before the function blocks.

Also added a couple of notes inside FnCapitalStartSentence.

Change-Id: I7047b199193ee0b61ba7fd955411952aae33ab41
Reviewed-on: https://gerrit.libreoffice.org/66812
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I759f1041faa1222b0feb42e01c95166f56591e19
Reviewed-on: https://gerrit.libreoffice.org/66129
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

i.e. 4E00-9FAF -> 4E00-9FFF.

According to <https://www.unicode.org/mail-arch/unicode-ml/y2003-m02/0351.html>,
the confusion was partly due to older Unicode specification.
As of Unicode 4.1 the trailing end (9FB0-9FFF) is in fact in use
by "CJK Additions": <https://www.unicode.org/versions/Unicode4.1.0/>

Change-Id: Ibd3704a81341743b3fa80686d3fcfc0bd11104ef
Reviewed-on: https://gerrit.libreoffice.org/67087
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Also add test for inserting and reading timestamp values.

Change-Id: I2ba997c438f4e33965b0fe0602e58eddeff38b01
Reviewed-on: https://gerrit.libreoffice.org/67066
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: If76e1acdcb601d70c956bcaf0392046430f4853e
Reviewed-on: https://gerrit.libreoffice.org/67086
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

XRefreshable::testRefreshListener() fails on read-only filesystem
because the ScDDELinksObj.ods cannot be loaded read-write.

It is loaded read-write since commit
5b2794e2.

Change-Id: I27b954b216acd3d138ade0d3f1b21fedd2f74fb1
Reviewed-on: https://gerrit.libreoffice.org/67071
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

which matters in at least gtk 3.19

Change-Id: I760e46d02f2678842a685aa077bd0129520a3263
Reviewed-on: https://gerrit.libreoffice.org/67072
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... so it fails if these aren't available; instead use the
C++ compiler of the LO build system.

Change-Id: I8a95d1865c481dc0a790d6fec6ff9fae8284d76d
Reviewed-on: https://gerrit.libreoffice.org/67078Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins

By restoring includes which are still needed, conditionally.

Change-Id: Icc331c7d6a084af7d93b941ea879f0c60b9ca9f3

since...

commit c80ac2ba
Date:   Fri Nov 11 18:16:52 2016 +0100

    Avoid -fsanitize=signed-integer-overflow

Change-Id: I2ec85e854ee1547d55b43b8540c357297d3b6cce
Reviewed-on: https://gerrit.libreoffice.org/67068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ia1b2f0a9c99acc7ac538f3b41c1b6757d414db35
Reviewed-on: https://gerrit.libreoffice.org/66970
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

otherwise we get a default one if SetMinClientSize is never called, which
is the case for these spawned-from-basic dialogs

Change-Id: I4f0389de6abcb1e99b32798969dca49bf8f0f760
Reviewed-on: https://gerrit.libreoffice.org/67063
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

From the Qt5 documentation: "QFont::AnyStretch / 0: Accept any
stretch matched using the other QFont properties (added in Qt
5.8)". So this maps 0 to LO's WIDTH_DONTKNOW, which fixes the
too narrow font selection in the KDE5 backend, when applying the
KDE5 font setting to LO.

Change-Id: I5f1a62d6c314c0766b540869c49c72bc3f6821c3
Reviewed-on: https://gerrit.libreoffice.org/67059
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

KDE 4 has been unmaintained upstream for various year now and
the kde4 VCL Plugin was removed with
6ca3b364 in favor of the kde5 one.

Drop desktop detection for this obsolete KDE 4 version as well.
Should new LO versions be run on old systems still running KDE 4, it's
very unlikely that they have the kf5 libraries that are required
to use the kde5 or gtk3_kde5 SAL plugins anyway, so the default
fallback for an unknown desktop environment is quite as good.

Change-Id: If8de489fbca836a80451435edfb00d2a8d501031
Reviewed-on: https://gerrit.libreoffice.org/67053
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Commit d587931f changed
HandlerCache::s_pConfig to a unique_ptr, which may now crash on
shutdown because it's a utl::ConfigItem and by atexit() time the
configmgr is long gone.

Due to the HandlerCache::m_nRefCount, the crash probably only happens
in case of an unclean shutdown, but we don't know whether this can
happen in practice or not, so just avoid crashing on shutdown.

Change-Id: Ifd2b782aa5592c344d1bc85acaa434c3f2a69b60
Reviewed-on: https://gerrit.libreoffice.org/67029
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

It's going to throw IOException anyway.

This fixes CppunitTest_dbaccess_hsqldb_test on read-only file system.

Change-Id: Ifc8a4791ab9a1a8d3e0f1e67d65e10dac458147c
Reviewed-on: https://gerrit.libreoffice.org/67028
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

The buildLowLevelConnection() will try to modify the read-only storage
and throw IOException.

Change-Id: I9b8ec840bebcac3c8a69bc6921d32e692d9d9e86
Reviewed-on: https://gerrit.libreoffice.org/67027
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

pointless since...

commit 33761c69
Date:   Sun Dec 3 23:35:26 2017 -0500

    vcl-svp: Store 24-bit images in 3-byte pixels

squashed the effort to percolate preferred target format as bitmap storage
format

Change-Id: I8a5367d4d7d251d5dd37011d0e51ab09cf5c57ac
Reviewed-on: https://gerrit.libreoffice.org/67055
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This actually increases readability of the code (for me)

Change-Id: I39603f2921dcbd57984ced7e2c64b28868e8b608
Reviewed-on: https://gerrit.libreoffice.org/67052
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie99b3a4d6a311b2f5140a00fddbbd53801b8cfb3
Reviewed-on: https://gerrit.libreoffice.org/67045
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id1aff2ede83e4c35976ebd51fc05aeea80dfae20
Reviewed-on: https://gerrit.libreoffice.org/67049
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

LO's own configure doesn't need it, but the
ExternalProject_libnumbertext requires this version; since it's
available in RHEL6 as "autoconf268", just keep it simple and require it
in the top-level configure.

Change-Id: I43a6ef10089363c344f06134d75f54685ed7026b
Reviewed-on: https://gerrit.libreoffice.org/67002
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: If15ac08d8334a386312870d3ebebb385cf55e5f6
Reviewed-on: https://gerrit.libreoffice.org/67050
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I351999f92b83e156ffe62e02c851050d4621fe7e
Reviewed-on: https://gerrit.libreoffice.org/67048
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If81ee19dd0127f48b9e57bf420323927c5981840

Change-Id: I3eeb6b8e27cced0a8a86969368f48a2af8ac5892
Reviewed-on: https://gerrit.libreoffice.org/67026
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If9efe56a40a866269a06ce944885a324495af48a
Reviewed-on: https://gerrit.libreoffice.org/67036
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The kde4 VCL Plugin was removed with
6ca3b364, so drop some
now superfluous leftovers.

Change-Id: I92887b679462a6ac22c3668a24ec6a9fdee8fac1
Reviewed-on: https://gerrit.libreoffice.org/67047
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Both env variables 'KDE_FULL_SESSION' and 'KDE_SESSION_VERSION'
are set in both X11 and Wayland sessions for Plasma 5 (kde5),
s.a. https://userbase.kde.org/KDE_System_Administration/Environment_Variables,
so drop the alternative X-specific check.

Move the check for a kde5 upward, so that kde5 is actually detected
in a Plasma 5 Wayland session, rather than falling back to
assuming GNOME.

Change-Id: Ieb5b47272f375ceed4d44a2ccc5b517222ae86b9
Reviewed-on: https://gerrit.libreoffice.org/67044Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
Tested-by: Tomáš Chvátal <tchvatal@suse.cz>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I5063d29baa5e4140d2be35684eed746ae28c2cf5
Reviewed-on: https://gerrit.libreoffice.org/67040
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>