Change-Id: I699fb3e07d21dc1852c0d50d4a7d478bcf1d1a96
Reviewed-on: https://gerrit.libreoffice.org/52063Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic384dfd66f834ee360c60e497b8b7b688c913f02
Reviewed-on: https://gerrit.libreoffice.org/52057Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I18506b74ac999893eab1d652b46ee2226f5a3dea
Reviewed-on: https://gerrit.libreoffice.org/52058Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The part to detect a hit on a TableObjectText
in Draw/Impress for a non-selected Table was
setting the HitType to SdrHitKind::TextEditObj.
This prevents the latter happeing check for URL
(see below). Not directly setting to TextEditObj
is okay, this is determined and set later. I
checked various possible changes to keep the
behaviour as for 'normal' SdrObjects, so please
be careful when doing changes in the HitTest code

Change-Id: I326a73b88fc56fd902b5052cc3a2ddecf3c3ba61
Reviewed-on: https://gerrit.libreoffice.org/52016Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: If0d729ee84263a5afb2c7acb2d62b08602aa59f4
Reviewed-on: https://gerrit.libreoffice.org/52046Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8b6ab688ec13cee7c5a6b49d6691efdcea2a3d74
Reviewed-on: https://gerrit.libreoffice.org/52049Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

...as the SwTextBlocks ctor internally calls SwDOCXReader::MakeEntries ->
BeginPutDoc which wants to open the document read-write.  That would fail if
SRCDIR is a read-only tree.

Change-Id: I433b80bcec53c8ca4282d1f45c941153a4064eb9
Reviewed-on: https://gerrit.libreoffice.org/52053Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Also fix bugs shown by the unit test

Use boost date/time instead of std, because std::tm cannot handle dates
before 1970.

Change-Id: I7f5dbb3d828a591a4b51c7204dc3bd39fefc42ff
Reviewed-on: https://gerrit.libreoffice.org/51804Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

rather than a question form when it was used in a query dialog

Change-Id: Ife5caba5bf307a2786e7581fce44bc1fc9a8368d
Reviewed-on: https://gerrit.libreoffice.org/52004Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie0971fae1ef3d02ab0c9ca8cce1cd1fd3d7b6166
Reviewed-on: https://gerrit.libreoffice.org/52050Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I17ac726e498546676fb6de3328356d2e155e734a
Reviewed-on: https://gerrit.libreoffice.org/52048Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

can generate OOM

Change-Id: Ie9fbed147687c06727a702616764a18d91b38e9c
Reviewed-on: https://gerrit.libreoffice.org/52052Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

(BeginPutDoc can fail if the document is a read-only file)

Change-Id: I2ee6f421e73459daf75adce67dedb47b23931d7c
Reviewed-on: https://gerrit.libreoffice.org/52045Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: If4b18747292dd265d789b70078979361bd044fde
Reviewed-on: https://gerrit.libreoffice.org/52039Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Id86a38521fe287a824bdda4b0fd2d68e97ae1b73
Reviewed-on: https://gerrit.libreoffice.org/52036Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I51e79a4a3d2c799e69bc13c66b5b84056bee6206
Reviewed-on: https://gerrit.libreoffice.org/52034Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id74c0dac582b1dc52076488332e26c88e5e7b4c3
Reviewed-on: https://gerrit.libreoffice.org/52033Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I529ca5016ab22a8e57655da7fe5ec4f3344a05d5
Reviewed-on: https://gerrit.libreoffice.org/52032Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I79d18cb8fdb029afbe6008edd058265b1503e5eb
Reviewed-on: https://gerrit.libreoffice.org/52031Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I051f63173a7b58819d340b00ea237a4164b1dbad
Reviewed-on: https://gerrit.libreoffice.org/52030Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id089f39a03f3793f2a5d9c24130d25ce6823df5a
Reviewed-on: https://gerrit.libreoffice.org/52029Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I682fa97a567ecf952214aa050a0ec981b4897ef5
Reviewed-on: https://gerrit.libreoffice.org/52028Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

I expect a lot of the overriding methods will be removed as soon as I
run the unusedmethods plugin

Change-Id: I4fb228724fcfba51a98d2113efb93cec1bc15c7c
Reviewed-on: https://gerrit.libreoffice.org/52006Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I953780a4b2879266c415a3c4e8992c8be74dced4
Reviewed-on: https://gerrit.libreoffice.org/52001Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iea173295b7bc5e7f8a5e0215dc13ab32190c6f8f
Reviewed-on: https://gerrit.libreoffice.org/51999Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4a55fbb06f3e919cc81e3462b23f8d94f6292a9b
Reviewed-on: https://gerrit.libreoffice.org/51494Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

...otherwise testCopyPastePageStyle would have caused the call to
xFilter->filter in paste() to fail, throwing an "End of content node doesn't
have the proper start node" RuntimeException in
SwXBodyText::createTextCursorByRange (sw/source/core/unocore/unotext.cxx) called
from the writerfilter::dmapper::DomainMapper_Impl ctor
(writerfilter/source/dmapper/DomainMapper_Impl.cxx) (and which would be caught
and swallowed in RtfFilter::filter (writerfilter/source/filter/RtfFilter.cxx),
causing it to return false).

Change-Id: I83b720a365e06edc41c3d9c82614df488ee33d35
Reviewed-on: https://gerrit.libreoffice.org/52013Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I0f606816871d90173dedaa9fc4eb7e6ccebe0b1a
Reviewed-on: https://gerrit.libreoffice.org/51919Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ibceac7c35fabc548a82ed9c086ca778608429572
Reviewed-on: https://gerrit.libreoffice.org/52041Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2615edfeb9c7bc879bef0db74a3cc82567ac1c88
Reviewed-on: https://gerrit.libreoffice.org/52040Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Id9089986012588690b6d5e33cd71d094ef2357dd
Reviewed-on: https://gerrit.libreoffice.org/51982Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I40bc25fa6c230d5ee5b9e3af68e01d0d8ad56e72
Reviewed-on: https://gerrit.libreoffice.org/52038Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I658c1e29a468900297ccbfcfc4b1b7a2c073caee
Reviewed-on: https://gerrit.libreoffice.org/52035Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I4533c4d8cc2742592a0f34b3cdeebee556fd1f67
Reviewed-on: https://gerrit.libreoffice.org/51785Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

regression from
    commit 5b75a169
    move cairo extract bitmap code from canvas to vcl

Change-Id: Ic8d7cd9d54010ae272073877da18a985e931e22a
Reviewed-on: https://gerrit.libreoffice.org/52005Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

it used to live at icon-themes/galaxy/res/helpimg/starmath/ar_right.png

but got moved by...

commit 2f6f851a
Date:   Wed Sep 28 07:30:35 2016 +0200

    tdf#100015 (related) Move Math help icons to correct location

    So that they are actually packaged into the theme zip

and then removed by...

commit 38ded033
Date:   Mon Dec 12 15:11:13 2016 +0100

    Move help-specific images (the actual files) away from core

leaving this dialog missing its arrow image

Change-Id: I08127a823868d0b32b5f74bd5a7fb3fbfae95b28
Reviewed-on: https://gerrit.libreoffice.org/52023Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...fail when SRCDIR is a read-only tree

Change-Id: I80a372b3eb71faed1215305a55df93390c846eed
Reviewed-on: https://gerrit.libreoffice.org/52020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...otherwise fails if SRCDIR is a read-only tree

Change-Id: I0b81be5ba055dac133e5ee638f21c3c5f4d5736b
Reviewed-on: https://gerrit.libreoffice.org/52015Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Function removed

Change-Id: I2346a0ba91afb72c7c68a6d50fc103d0409ae374
Reviewed-on: https://gerrit.libreoffice.org/51896Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Fallback icon theme changed from Tango to Colibre

Change-Id: I525f6d85468e5c300e1fb11ce72ba7d551d5aa4c
Reviewed-on: https://gerrit.libreoffice.org/51959Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>