This might actually matter in practice given

https://stackoverflow.com/questions/27422871/does-deletedc-automatically-unselect-objects

"DCs get a default 1x1x1 bitmap when they're created. This will leak if you don't put it back."

Change-Id: Ib2d361995621ad429277ff52cb8c9fdfc0009953
Reviewed-on: https://gerrit.libreoffice.org/38875Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5622786c5192ea7a5225f3b9cd81a4b6a0dae594
Reviewed-on: https://gerrit.libreoffice.org/38877Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6d77039f0cafe0f436cc687bb424588a59c3d464

Change-Id: I221c81ff2f0bee7a8643304201722dbbbc114bec

Change-Id: I672bbb2ac30c5e27b729fe34e206642e436c076b

Change-Id: Ic0cfa565048793181ece17b33337e011028a2aad

Change-Id: I5261d8d96f83b8b81b0dc2576cbd9241705ae9b7

Change-Id: I563aa8ee285d4c2ecdb45835b5cee38074295106

Change-Id: I8c605e2c64fee4d369732f783cc9dd76f7dc858c

This is a follow-up to 45a7f5b6 "Keep WID ranges
sorted, and join adjacent ones".  While SfxItemSet::MergeRange relies on the
m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the
various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT)
that each individual range has an upper bound not smaller than its lower bound.
Arguably, all SfxItemSet instances should fulfill the stronger guarantees
required and checked by MergeRange.

And in many cases the ranges are statically known, so that the checking can
happen at compile time.  Therefore, replace the two SfxItemSet ctors taking
explicit ranges with two other ctors that actually do proper checking.  The
(templated) overload taking an svl::Items struct should be used in all cases
where the range values are statically known at compile time, while the overload
taking a std::initializer_list<Pair> is for the remaining cases (that can only
do runtime checking via assert).  Most of those latter cases are simple cases
with a single range covering a single item, but a few are more complex.

(At least some of the uses of the existing SfxItemSet overload taking a

  const sal_uInt16* pWhichPairTable

can probably also be strengthened, but that is left for another day.)

This commit is the first in a series of two.  Apart from the manual changes to
compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and
svl/source/items/itemset.cxx, it only consists of automatic rewriting of the
relevant SfxItemSet ctor calls (plus a few required manual fixes, see next).
But it does not yet check that the individual ranges are properly sorted (see
the TODO in svl::detail::validGap).  That check will be enabled, and the ensuing
manual fixes will be made in a follow-up commit, to reduce the likelyhood of
accidents.

There were three cases of necessary manual intervention:

* sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in
braced-init-list syntax now, so needs explicit narrowing conversion to
sal_uInt16.

* In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the
definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually.

* In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx,
sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx,
sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx,
some comments had to be put back (see "TODO: the replaced range can contain
relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx).

A few uses of the variadic form erroneously used nullptr instead of 0 for
termination.  But this should have been harmless even if promoted std::nullptr_t
is larger than promoted sal_uInt16, assuming that the part of the nullptr value
that was interpreted as sal_uInt16/promoted int was all-zero bits.  Similarly,
some uses made the harmless error of using 0L instead of 0.

Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35
Reviewed-on: https://gerrit.libreoffice.org/38861Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib543b4a84305467e8a9ce34bdc2c6a211f399cad

This used to require extra SDKs in days of yore but now just always build
those libraries on WNT.

Change-Id: I92c0a35917df42e136c022c762f0333f657a9ec6

Change-Id: I789051e4721cf9f0af13e1fdb128953c8ba2521e
Reviewed-on: https://gerrit.libreoffice.org/38696Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

The following changes made:
- Unnecessary line breaks makes reading the file difficult
- Convert to doxygen comments
- Move comment at end of file to more appropriate position,
  convert to doxygen style commenting, and remove sig
- Remove unnecessary comments

Change-Id: I0c2c40de953cd9ad90133ca2d96ae742594f4ec6
Reviewed-on: https://gerrit.libreoffice.org/38505Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I06d0cd4c7986a59f54102f945a560f710887ad8b
Reviewed-on: https://gerrit.libreoffice.org/38514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I5a339a4211ec8eb547459996be69610b9f2b3766
Reviewed-on: https://gerrit.libreoffice.org/38147Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I1131f246c43806adb8a83f6eeafca2b734851a0e
Reviewed-on: https://gerrit.libreoffice.org/38888Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This was even more confusing than previously..

Change-Id: I9cbdd05e9b59662dfde4a08422d0d2846849719f

Only font name switch (f) is implemented.

Change-Id: I09df8230dff3cf0619065da69bfaf3caad0a39ae
Reviewed-on: https://gerrit.libreoffice.org/38654Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Field commands were closed when a seperator appeared. Those
fields that only had begin and end fldChar just disapeared.

Change-Id: I77928393826a3ffd4a35fb8fe9adeb1892f99683
Reviewed-on: https://gerrit.libreoffice.org/38653Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

...that were missing from 3de594d3 "More tests
to suppress (all .PHONY test targets should be covered now)" (and one wasn't
even properly marked as .PHONY).  Thanks to Rene for spotting.

Change-Id: Ieed81a3999921bdfe9bca96c6002d8906b2ddfad

...after 57949716 "Bump GCC baseline to 4.8.1"

Make this a fatal configuration error for now.  The check should be removed
completely after LO 6.0 branch-off.

Change-Id: I70cf65d6b0eb7158008f28449794c66c1b775916
Reviewed-on: https://gerrit.libreoffice.org/38869Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Keep the exclusion for determining the direction, but include them in the final
formula result and selection.

Change-Id: Ic752229bad17ac25de9ef598f3da32e0fd257fd1

Change-Id: Ie5669bd75d9b4be047d98402cb69ac313ab618df
Reviewed-on: https://gerrit.libreoffice.org/38787Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

The intention here is to deny the move of a frame that's inside a table
inside a section.  But the code also checked if there a column frame
in-between, so it allowed the move for a frame in a section with 2 cols,
but not without columns (which does not sound intentional, since that's
a simpler case). So drop the requirement to have a column frame between
the argument and the section frame, just check that there is no table
frame in between.

This is needed, but not enough to split the section in the bugdoc (but
at least now the content of the section is marked as movable).

Change-Id: I9155b291a19c692efc30f01f8e206fac5f1ccf81
Reviewed-on: https://gerrit.libreoffice.org/38858Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  e24e053c82ad4ee86dd7eb4e9490c9c62af2b291

tdf#107573 help page for change of UI term outline

Change Tools -> Outline numbering to Tools -> Chapter numbering

Change-Id: Id820b226f08d3c224512e34fd96d37ed4c2c300d
Reviewed-on: https://gerrit.libreoffice.org/38853Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Instead, use FormulaTokenArrrayPlainIterator everywhere, especially in
the FormulaCompiler.

This is the final step of a long chain of commits. (Split up into many
"uncontroversial" bits, and then this, to make potential bisecting
easier.)

Also added a logging operator<< for FormulaTokenArray, for SAL_DEBUG,
SAL_INFO etc goodness.

Change-Id: I02fe29f3f1e0dc33e5cba69e594223b4178a12bc
Reviewed-on: https://gerrit.libreoffice.org/38851Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

...as happens e.g. with /usr/bin/gcc "gcc (SUSE Linux) 4.8.5" on
gandalf.documentfoundation.org, reporting "4.8" instead of "4.8.5" (and thus
failing since 57949716 "Bump GCC baseline to
4.8.1", e.g., <https://ci.libreoffice.org/job/lo_tb_master_linux/18923/>).

Keep it simple and assume that the micro would be at least 1 when missing...

Change-Id: I096dd6671ad012e5bf890d3bf510780661f62d24

Change-Id: I9dbbf403624a49513e4c596aef80754cd4e0a88d
Reviewed-on: https://gerrit.libreoffice.org/38867Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7b5c8aeb087efe007c687dc1f206bcb0e8b0173e
Reviewed-on: https://gerrit.libreoffice.org/38864Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

see <https://lists.freedesktop.org/archives/libreoffice/2017-June/077909.html>
"Re: Some baseline thoughts" and
<https://lists.freedesktop.org/archives/libreoffice/2017-June/077910.html>
"minutes of ESC call ..."

Change-Id: I09fb8dc228c23a39e7e332742095b0e2dfce711d
Reviewed-on: https://gerrit.libreoffice.org/38860Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idc601e9ca4ac3ea429d3b514ad6af4198954ca33
Reviewed-on: https://gerrit.libreoffice.org/38859Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I3da1559bd3434d574db65a3b492e1060c46143ee
Reviewed-on: https://gerrit.libreoffice.org/38849Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Icd115383970d351ed8b224bbbd18e98ae0cc8f0d

Change-Id: Ief7d4c8e1866604eda6308ea2a5c1ce4b1c093bc
Reviewed-on: https://gerrit.libreoffice.org/38836Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7e680e1913c787ce0adad5be1f84668d57ad00b3
Reviewed-on: https://gerrit.libreoffice.org/38821Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Use documentPicker instead of own programming

Change-Id: Ibd4e0f987254830aeaba1140ec1f84b649ca1387

Testing will be done differently

Change-Id: I94b121bb89e553fdc96427f8c19c7d2b11821554

Change-Id: Ia2596e11f303edf5e1b81ab90062fd93df42159b
Reviewed-on: https://gerrit.libreoffice.org/38847Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Project: help  c5180610e70541db0c684fa29100c66355b8bfc2

tdf#84675 Add VBA functions to tree file

Add current VBA functions to the tree (Contents tab)

Change-Id: I433cd9a77fd1fe6a15ea6778a475a96840299a3c
Reviewed-on: https://gerrit.libreoffice.org/38856Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>