Change-Id: I6d582032d419b832aa2610cad61d9c5596fcc9a4
Reviewed-on: https://gerrit.libreoffice.org/70299
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

In a previous commit only x/y coordinate were considered.

For better overview make use of the OOXML converter for orients and relations.

Change-Id: I9792ccfbc2ebb58fd768c14278cdfd9b54efe62f
Reviewed-on: https://gerrit.libreoffice.org/69523
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I7224eaf1b569d018a85fee6a65afe43d0d37bfbc
Reviewed-on: https://gerrit.libreoffice.org/70298
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I1db6c5e4841530be7d46e8829899bf3f8cef8a3b
Reviewed-on: https://gerrit.libreoffice.org/70293
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

This opacity influences the whole shape (stroke and fill).

Change-Id: I82e10e07dbf2f321805b55a5f4831a513e52dab8
Reviewed-on: https://gerrit.libreoffice.org/70292
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ie6a9ef6441b2b0053ea539bc0f1846fba8422313
Reviewed-on: https://gerrit.libreoffice.org/70297
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

I'm not exactly sure how, but in case
sw/qa/uitest/findReplace/findSimilarity.py and
sw/qa/uitest/findReplace/findReplace.py are in the same suite, then 3
tests from the later fail for me.

I don't see anything obviously problematic in either of these tests, so
just split them to separate suites, these are slow tests after all, so
more parallelism is good anyway.

(What may happen is that one of the dialogs remember its state in the
user profile, but then why this doesn't happen for everyone is unclear.)

Change-Id: If11f5b171972422fab5f79a047b1aabb1adee04d
Reviewed-on: https://gerrit.libreoffice.org/70296Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins

With this commit we are making numbers of columns
dynamic, but the number of maximum supported
columns will be the same (1024).
Such approach will allow us to check issues
(eg. performance, LO format etc.), and improve it.

Increasing number of maximum columns, will be done
in separate commit.

Change-Id: Ibac4101e9ffc05e3548eca1c198f6319ac7ff9aa
Reviewed-on: https://gerrit.libreoffice.org/44802
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Sometimes, developers mention other bugs in the body as
related issues.
This might create mislead information in the release notes
E.g: https://wiki.documentfoundation.org/Releases/6.1.1/RC1
* Caolán is mentioned as fixer of i#66963 because the id is in
the body of 9c3d8b1c
which fixes tdf#98558
* M. Stahl is mentioned as fixer of tdf#112447 because the id is
in the body of 31e66bd0
This bug was fixed by Bjoern Michaelsen in
ce2fce9a

Change-Id: I8d0ee038741dbb27364a56a7fa9285f32839c37b
Reviewed-on: https://gerrit.libreoffice.org/69750
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I775e9d6d6bedbfe00a4e5349cf0a664ccbd0ecc4
Reviewed-on: https://gerrit.libreoffice.org/70288
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

So that Insert - Comment command would not insert an & on Windows
with Hungarian keyboard layout

Change-Id: I83f43cdc0b3f32e284cd747648de5bcb07505314
Reviewed-on: https://gerrit.libreoffice.org/70279
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Corresponding command was removed in
b94abbc8 (2004!)
This and 15bdac20
is why this accelerator showed up as uno:AnimationMode in the list
instead of a human readable name

Change-Id: I7b2f2cf76c75d815b85b1ceb6e8468588e3d15f1
Reviewed-on: https://gerrit.libreoffice.org/70268
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

The uno:StyleCatalog command was removed in
b4c18dc0

Change-Id: I31118e97c5445b1021ea60b2629f12d2f60595cd
Reviewed-on: https://gerrit.libreoffice.org/70267
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ie46fcc58039ce9686b779d27699e4988e93e8bd7
Reviewed-on: https://gerrit.libreoffice.org/70195
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Commit 881043d1 (#i98792# Allow frequent
calls to slide show update()., 2009-04-27) added a comment in
sd::SlideshowImpl::updateSlideShow() talking about an "above" case, when
the slideshow update suggests to not wait till the next update,
but later commit 12dcf5e6 (slideshow:
cleanup main-loop usage, post-yield listeners, etc., 2015-11-13) removed
that handling.

That was fine till opengl rendering was introduced, which swaps its
backbuffer in an idle handler. Given that OpenGLFlushIdle's priority is
TaskPriority::POST_PAINT and SlideshowImpl::maUpdateTimer's priority is
TaskPriority::REPAINT, the GL backbuffer is not always painted while an
animation is ongoing.

This is more visible when tweaking the bugdoc to have an e.g. 5 sec
animation, then starting the slideshow results in waiting for 5 seconds
and only then the slide shows up, without an animation.

Fix the problem by re-introducing the handling of the fUpdate == 0, and
processing idle events there, which means the GL backbuffer will be
always painted, regardless if fUpdate is a small number or 0.

Change-Id: I25b2dc0aa41af62d9bd89617178eb2e9997f5b17
Reviewed-on: https://gerrit.libreoffice.org/70287Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ic2bd25bcbcc7f5fb6e29ced70fddb74385b5fb2f
Reviewed-on: https://gerrit.libreoffice.org/70077
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I49ffb2fff63a8818c4e84a26923fca1484bf1e36
Reviewed-on: https://gerrit.libreoffice.org/70284Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

These were originally added in commit
4105862b

Avoid the reported problem for the other two instances
(Calc and Master document) too

Change-Id: Ief3adafec1f05f9fb881da76c844fe8525143029
Reviewed-on: https://gerrit.libreoffice.org/70272
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found by:
run-clang-tidy-7 -checks=-*,misc-unused-using-decls

Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27
Reviewed-on: https://gerrit.libreoffice.org/70027
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Note that we can't work with the table box (and frame format) of
pTableTextNodeInfoInner in RtfAttributeOutput::TableVerticalCell(). This
is because cell definitions are written in
RtfAttributeOutput::TableDefinition(), and the loop only calls
setCell(), i.e. the cell index is updated in the node info, but the
table box is not.

Import was already working as-is.

Change-Id: Ia089c42b3a49f1a8f012a8cadaa8bcad16128c3e
Reviewed-on: https://gerrit.libreoffice.org/70269
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

... to take into account possible differences of results of dynamic_cast
vs static_cast; the change casts dynamically, as before the commit, and
only adds asserts on the result of the cast.

Thanks to sberg for pointing my mistake out!

Change-Id: Ib77d443e5a858e744f369f58542de603f948fd1c
Reviewed-on: https://gerrit.libreoffice.org/70274
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib808e35d3cc3c2895993193ac6ed05d556c1857d
Reviewed-on: https://gerrit.libreoffice.org/70275
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I6b264a2f2e2995e880169f6224c60f023584469d
Reviewed-on: https://gerrit.libreoffice.org/70270
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I7b329b4da49464e2bb34c29b8db0aa8e21c94c0e
Reviewed-on: https://gerrit.libreoffice.org/70283
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia6e48da3abe6d142135f0e916f02e27b63bbcb57
Reviewed-on: https://gerrit.libreoffice.org/70280
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie5b9e2a603146dd6bd0e22c80f7cee23ccfd39b2
Reviewed-on: https://gerrit.libreoffice.org/70282
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I15ab841fb9398a52d4df48b4bc4022b0f469f771
Reviewed-on: https://gerrit.libreoffice.org/70281
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

These helpers are used in code generator code; so any invalid UTF-8
or UTF-16 in the conversion is programmer's error which needs fixing.
Thus, the behavior of toUtf8/fromUtf8 which asserts the validity is
fine here.

Change-Id: I3004e233c9de59f8e348455f1f04d23e8c51ed3d
Reviewed-on: https://gerrit.libreoffice.org/70249
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This reverts commit 50580f45.

Revert "raise cairo baseline to 1.10.0"

This reverts commit 58a0e60d.

32bit baseline is currently at cairo 1.8.8

Change-Id: I5156df6aee03dbbb2e209dbd5717a98580256170
Reviewed-on: https://gerrit.libreoffice.org/70260
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

there may have been changes not caught by undo to the object's
ordinal, so on use of RemoveObject (or ReplaceObject) call GetOrdNum
on the object to get its current position within its parent.

We can keep nOrdNum for the desired dest position within the parent
for InsertObject

Change-Id: I3bdabf387dd630fc1fadaaa1f3d8c05e93865e4f
Reviewed-on: https://gerrit.libreoffice.org/70251
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In addition remove spinbox pressed state (it wasn't useful) and
draw white filled empty rect for spinbox as we don't draw the
background automatically.

Change-Id: I892108c5839dc463cdb9e4f4f09276fc184f4944
Reviewed-on: https://gerrit.libreoffice.org/70258
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I053b30b00dbda67819af68020e2f6fa4a5b5134e
Reviewed-on: https://gerrit.libreoffice.org/70255
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The helper marco is used in export code to convert UTF-16 internal
string representation to UTF-8 used in XML encoding. I suppose that all
strings here should be already valid UTF-16 (an invalid input should
have been validated at import/input stage). An invalid string at this
stage means a programming error in another part of code that breaks this
precondition, and should not be handled at export stage.
(See also commit 0267a232.)

This effectively changes flags used in conversion from UTF-16 to UTF-8,
so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of
RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be
truncated on invalid bytes instead of inserting U+FFFD, and would fail
assertion in debug builds.
Other changed flags don't affect UTF-16-to-UTF-8 conversion.

Change-Id: I12b2cc5378208904c3266924187d6402700ed6f3
Reviewed-on: https://gerrit.libreoffice.org/69801Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I5676281be56ff454962900fe7500d078b1f9e7e9
Reviewed-on: https://gerrit.libreoffice.org/70252
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Hopefully fixes problems on 32-bit linux.

Change-Id: I1fc22f1bb37c8297bd3bd6828206d1ffa9ae722d
Reviewed-on: https://gerrit.libreoffice.org/70241
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Move most common code into Qt5Instance (static) functions.
Not much saved with regard to LOC, but since the code was
95% C'n'P, I hope it'll be less error prone this way.

Also handle all QApplication argument pointers via
std::unique_ptr from the beginning.

Change-Id: I87b2f571d398db7ccce3e740f16205b251be4ced
Reviewed-on: https://gerrit.libreoffice.org/69578
Tested-by: Jenkins
Reviewed-by: Aleksei Nikiforov <darktemplar@basealt.ru>

Currently there is no point for a seperate KDE5 SalData class.
The additional NWF settings fix the wrong popup menu for qt5, so
this just moves all the NWF data and gets rid of KDE5SalData.

Change-Id: I1c02d1f660df288a0d2e1c6607b34fc1ce593727
Reviewed-on: https://gerrit.libreoffice.org/70005
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

The code is using expicit (mostly W) Windows API, and is independent
from the macro. Removing it here allows to catch places where some
UNICODE-dependent macro is used unintentionally.

Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45
Reviewed-on: https://gerrit.libreoffice.org/70237Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I1816f23fea88e6b840539a88504956b00a546522
Reviewed-on: https://gerrit.libreoffice.org/70243
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I721b80d7ce28d36babbd2bd1957fcbd6a2d27a27
Reviewed-on: https://gerrit.libreoffice.org/70242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>