Change-Id: Ia095a3adee271cf7235fb7c13824d7f265658897

Change-Id: If88abe20eeec478d340f913973d4f4815dc0e510

Change-Id: If488129c8b563b82932b58e16328922cc2653da8

Change-Id: I53e2c5789c9d96187b13bb0d52da9d70f24b39b6

Also used the new OUString::number(...) methods.

Change-Id: I3174c43d56d1ae359901bb8a13fe0096f2c74808
Reviewed-on: https://gerrit.libreoffice.org/1766Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>

Change-Id: Ib14021a2253fffd4badbf13db1f49a2309e4bb14

Change-Id: Ifcc3594273de3507ec9b208e9e762bed0f969d72

Change-Id: I76b23bcdca2e7394fd5ab67e8341f4cdb46f8a64

Change-Id: Icaacf3bc1a02a017692432aec36aba06d3f5dde5

Change-Id: Ibadc8327cef327625d6b4663c1487b126e2e6920

Change-Id: I5345a062206a065f01bb19ca808c467d94da5259

Change-Id: I4d2f85106045a22be61c6b42fad941e4d4cf88d5

also fixes a bug where the font format of the first portion of a rich text string
gets to be set as the default cell style for that cell

Change-Id: Ib2e85e6f2a971940b94100c2bf45d85d8afa2869

...as -Wsign-promo caused other problems and has been removed again with
488823a1 "Remove -Wsign-promo."  It had
originally been introduced with e8bbb768 "ensure
correct export size type in stream operation," apparently to detect an
SvStream::operator<< call with a bool argument that would pick the "int"
overload instead of the "unsigned char" (aka sal_Bool) one (which would have
happened to trigger the -Wsign-promo warning "by luck," given that sal_Bool is
unsigned char and not signed char, say).

Change-Id: I0bf4389753e53a535bd90ca2a98b6a5be63d179a
Reviewed-on: https://gerrit.libreoffice.org/1798Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>

Change-Id: If9eecbf69a4486dcd84d475719aa66f480faea0b

Follow-up to https://gerrit.libreoffice.org/#/c/1803/ .

Change-Id: I9131854a579ef57e38dfef7faa539bec98fc305b

This has the disadvantage that it makes comparisons involving fast
OUString concatenation via operator+ ambiguous, as can be seen in
scriptdlg.cxx, but it allows comparing String and OUString wihout
explicit conversion, which is nice for incrementally converting code.

Change-Id: Ibfc728bdb161a01e0f8311915c97bcbba8b58c0b
Reviewed-on: https://gerrit.libreoffice.org/1803Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>

Project: dictionaries  7d469f332804f6ed3efcdfd5f7217703aded1e35

...a regression introduced with 2fe85238
"fdo#46808, Adapt SystemClipboard UNO service to new style."

Change-Id: Ia98eadc0fc80762455c1e8cc33797b322b83e458

Change-Id: Ieb8e782eab9c9bde1d2099d8cc32eceef9f00002

...00134920 "New option for INDIRECT reference
syntax" and e6ef9f12 "Rename this option to make
it sound more generic" had marked
/org.openoffice.Office.Calc/Formula/Syntax/StringRefAddressSyntax (formerly
IndirectFuncGrammar) as oor:nillable="false", even though it is given no value
in officecfg, and the sole code reading it (SCFORMULAOPT_STRING_REF_SYNTAX case
in ScFormulaCfg ctor, sc/source/core/tool/formulaopt.cxx) is prepared to read a
nil value.

Change-Id: Icab871c821f437cd095280e9af8b0c0c11bbef8f

Change-Id: I5706fc9201359c05c00d0a97009994d7d188d5bf

Change-Id: Ie46a2627d247fb293606c6deab3254113b741336

Change-Id: Ie830fe9f7276fbc8f20e7d37424116d6653a6931

Change-Id: I0b204e9a81aad3e4f5fafc17bbd0c3935eb5cdb5

Change-Id: Ib4ca01df58da4129d5262c344c7c092925e19caa

Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
Reviewed-on: https://gerrit.libreoffice.org/1773Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Also, remove some chained appends, and sanitize some functions call.

Change-Id: I5bfed073bd84e4dee4bc7e7b4715e413859beb50
Reviewed-on: https://gerrit.libreoffice.org/1772Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8
Reviewed-on: https://gerrit.libreoffice.org/1771Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

... remove some RTL* macros.

Change-Id: I919d17e14334c9220b47775355512df8dfa00bca
Reviewed-on: https://gerrit.libreoffice.org/1768Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Change-Id: I554bb631a9b8d7b334483eeaed9b096451660a75

- unconverted assertion in dinfdlg.cxx
- wrong replaceAt in SidebarWin.cxx
- obsolete cast in SpellDialog.cxx

Change-Id: I18450c0c6fdd275b7f81a7fce58cdf98bb806e27

replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

See http://nabble.documentfoundation.org/Cppcheck-Variable-nMode-is-reassigned-in-fstat-cxx-td4030405.html
Thank you Stephan!

Change-Id: I780d422fe03c4c125cc89fee778d820a20553c1c

See http://nabble.documentfoundation.org/About-parenthesis-problem-in-testintrosp-cxx-td4030420.html
Thank you Lubos!

Change-Id: If46b3d3aa304f2c16d66813ff337a70b3a520e76

Number of repeated column styles were limited to MAXCOL effectively
being MAXCOLCOUNT-1 and in an --enable-dbgutil build yielded lots of
warnings when importing a document that has a style applied to all
including the last column.

For example see attachment of fdo#59583
https://bugs.freedesktop.org/attachment.cgi?id=73282
or fdo#59325 https://bugs.freedesktop.org/attachment.cgi?id=73014

Change-Id: I74dbbe3065a46015b0b7c8f61d58690a1c08c855

Change-Id: Ieb8e782eab9c9bde1d2099d8cc32eceef9f00002

If followed by '(' (with or without space inbetween) an identifier can
not be a column/row label. Prevent arbitrary content detection in case a
macro function of the same name is meant (fdo#59583) or if it wouldn't
resolve to a known function name at all, that earlier resulted in #REF!
instead of #NAME? in the case of unknown function but label found.

Change-Id: Id36a0c9ebad2d62867b4f9fe00ae78d464e77109

Change-Id: Ifbd7dcc3fa8d18192d2ac2fc5faca1b0637c93c2

(...whatever it is that causes them to be raised at least in my build).

Change-Id: I52889de876e448ae8e90ec328e65cda2025968e2