This reverts commit d9ae7573.

This reverts commit 03c766e6.

Change-Id: I05621cc1bf6d4201120c8757d5c2886723d7d18c

Change-Id: I6e3bdf0cfcdfa46cf47e4db1e0703c948b4a35b2

Change-Id: I84e8a3833ae16cc9197b8b772404587a3dea1158

Change-Id: I115cc8e17ae6cb89d215528acb0d0fe25eb71d85

Change-Id: I5bb93f9228e69dfd46b450089f34cac7204f10b8

so that focus ends up on the visually first enabled control

Change-Id: Ia279c4531536305ce43eb8372abde2445769487d

Change-Id: Ib2e9c5a72239fc0fa3a54ac3717d90fe1b779d63

because the dialogs are modal ones so no different
than most commands. (Probably cut and paste and few
notice using themes where empty toggles have no
frame and are indistinguisable from non-toggle)

Change-Id: If82b59e7cebb71bc834a48970283b2cf68e5fdf9

Change-Id: I0025ce0107deaaf6b4698745691c9f0bfddc7c34

Change-Id: Icba94fdd75d5e09fd81744d2f5ce55886b8777b4

Change-Id: I945a46a8ca3df8c6cf7982a531025d8d8b6c31a4

This appears to be messy:  The /org.openoffice.Office.Views/WindowType
configuration group template has both a nilable bool "Visible" property and a
UserData/Data string property that encodes various things like geometry---but
also visibility---in a string.

Now, likely due to the problem that has meanwhile been fixed through
f3f79cc9 "Resolves fdo#46074: Fix
Partial::contains for paths that go past a leaf node," some
registrymodification.xcu files in the wild contain such WindowType entries in
"default" state, without a UserData/Data string and with a nil "Visible"
property.

The way SfxChildWindow::InitializeChildWinFactory_Impl and
SvtViewOptions::IsVisible are implemented, they will always lead to an invisible
window for such broken registrymodification.xcu data (as IsVisible unhelpfully
returns false for a nil value, and InitializeChildWinFactory_Impl uses that
value when there is no UserData/Data string).

For the Math formula editor window (ID 30378) this means that it can disappear
from the UI completely, as there appears to be no UI trigger for the user to
show it in case it is hidden.

The fix is to introdue SvtViewOptions::HasVisible (which only returns true if
the property is not nil) and change InitializeChidlWinFactory_Impl to only use
the value of IsVisible() if HasVisible() returns true.  This makes the code even
more baroque, but this is a rather central, generic piece of code for all sorts
of windows, so I do not want to break any other uses by e.g. changing IsVisible
to return true for a nil property.

Change-Id: Iae40075a7116a8aabd2d25aa9334709522e23d8f

Change-Id: I0fada447af361c319851360d04a94948148e5a26

Change-Id: I1bec67344ddd5d1caf417355fafd344f48517f77

... because it is added automatically by the external expat_utf16.

Change-Id: Ifdad11b275f7074be6f2e92df2e3c30c7097a5b7

Change-Id: Ie1dfa8bac9d894d86d15fed98341d4700d656fb9

Change-Id: I0143516455f5abad2da6b13a985d08b37e5c3cae

Change-Id: Ie59b0bab6bec6957f13a3931b6be46985e3db2c4

Change-Id: I02ca44cc33d1d8e1ebc9f158f859c9218d2ed832

Change-Id: I44c3b830a61ef1f65833732b5bc66c061ed27c21

Change-Id: I69d883e623f7fffd37c05b85a6655009da9c23a8

Change-Id: If7cefe8d2e188e65a465a25a5d5f77e6daebcd17
Reviewed-on: https://gerrit.libreoffice.org/760Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

Change-Id: I34228049e15ee8a899a4c5e1484d7ed3bc541dd4
Reviewed-on: https://gerrit.libreoffice.org/748Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>

...in old LO 3.5 registrymodifications.xcu, which causes trouble when migrating
to >= LO 3.6, see <https://bugs.freedesktop.org/show_bug.cgi?id=52022#c23> for
all the details.

Change-Id: I8fa1e67998c9588b9d8bf3a3b52e4b0684d3d705

Change-Id: I97dd4411b5293b8f61527505e54608442eb18cca

Change-Id: Id506fa56d07be56d63715703e354625715275933

Change-Id: I60230e57993ee24fc80eb26d16588f131ec1f8dc

Change-Id: Ib9a0aa8e22cb84b07b7346e5647b2a2667f05c6a

Change-Id: I80b20f5df179f994e5004c1ef390457c252478ef

Change-Id: I509cf60e4bbbe7dfb25a3943d97c9d35a22e0bb6

Change-Id: Icea58e7c1dea14f524d6a8d479b7d85e79d6266b

Change-Id: I6afabf33e1d1ab890c979193c25381e0d38c1f50

Change-Id: I454e5f4522cd5c5c1f04fde7cb79feab5ae63528

Change-Id: I716c0a08565e874bcb0667e72ed5261231a4743d

Change-Id: Ibb61dc696c4341a0b58d8fd7c2fdfb4c5b991596

Change-Id: I45301c519037ac6c027bfb5a44e8a2a2d53b3ad2

Change-Id: Ief6d6678a04084a90d07d87780689b92af2e3ba4

Change-Id: Ica624c28b4e423531be3ef6a601f266d1cad1d07