Change-Id: I70698e02cc6c6555b8dc4b362a7dfa0cfafa2327
Reviewed-on: https://gerrit.libreoffice.org/58776
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

* Update helpcontent2 from branch 'master'
  - New Help housekeeping
    
    remove deprecated files (gbuild has replaced them)
    
    Change-Id: I00a0a1558dfa80486dd64df37273c90bc6262fb0
    Reviewed-on: https://gerrit.libreoffice.org/58784
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Use PRODUCTNAME from the configure.
    
    Change-Id: Ibc742e653f44093372bed4e103fedb3a597dfdac
    Reviewed-on: https://gerrit.libreoffice.org/58793Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
    

The problem is that the pMaster->GetFormatted() screws up the offset of
the follow frame; there isn't any hope of fixing this up when it happens
so deep inside Format_()... so instead try a conservative check on the
outside (can't check the position there as Format_ moves around quite a
bit) and format the master there already, and then SetOfst() to fix
things.

Change-Id: I0a119ccf1561ece031cec03db3c36155f271a6a8
Reviewed-on: https://gerrit.libreoffice.org/58726
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - Update the README.txt.
    
    Change-Id: Id493d2d1fa21a160b4fc7d2bb160e6cb6a38c93b
    

Change-Id: I59c5499586c16768afde822cd6d580540d1bcd73
Reviewed-on: https://gerrit.libreoffice.org/58764
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The test used to fail when umask originally was e.g. 077.

Change-Id: I21d346532698feebccc8bb3f6cb9a9dd3002a20e
Reviewed-on: https://gerrit.libreoffice.org/58757
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

... to be handled by the same code.

Change-Id: I96fae066ccf2bef474fe4faf8068b7290eea8d8b
Reviewed-on: https://gerrit.libreoffice.org/58766
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: If255723834d049865fcf6fd0eac7768dfcbad2a1
Reviewed-on: https://gerrit.libreoffice.org/58760
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I931ed8945b4af713ead42e0eca0bb5fb6cb07d9c
Reviewed-on: https://gerrit.libreoffice.org/58759Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5b27c4803a9927ff9e2be084e7abbae7fdf94f55
Reviewed-on: https://gerrit.libreoffice.org/58696
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Since the __CxxDetectRethrow may increment __ProcessingThrow, which then
must be decremented in __CxxUnregisterExceptionObject, and the latter does
many other funny things with exception handling CRT machinery, we cannot
use those internal functions (neither alone, nor together), or we end up
breaking runtime's expectations: the runtime code checks __ProcessingThrow
left and right, expecting its non-0 value to indicate "we are unwinding...
possibly called from a dtor()". In this case, e.g., std::current_exception
returns nullptr inside catch block.

This creates our own copy of __CxxDetectRethrow, which does not mangle the
global state, and just performs the same checks. This is a dirty hack, and
it relies on current layout of the exception description layout - so must
be synchronized in the event of changes!

Change-Id: I2c475fbc2468073b796c7e9d0f4dfcd315896489
Reviewed-on: https://gerrit.libreoffice.org/58730
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as discussed on #libreoffice-dev

Change-Id: I5314bdcaf0e023db615c68785b76f4ee6144b079
Reviewed-on: https://gerrit.libreoffice.org/58758
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I0308ddd467ab6e283c0503f98885a248eb28290c
Reviewed-on: https://gerrit.libreoffice.org/58738
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

At least cl version 19.14.26433 generates such warning C4996 now.  While the one
about the using declaration in boost/iterator.hpp looks somewhat bogus, the one
in boost/circular_buffer/details.hpp is about an actual use of std::iterator as
a base class in Boost-internal code.  If further such places in external/boost
crop up that need fixing, an alternative approach could be to extend the
external/boost/include/ wrappers to be also used with MSVC.  (Globally setting
_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING has avoided, as it also
finds uses in our own code that should be fixed, like
58222feb "warning STL4015: std::iterator is
deprecated (clang-cl)".)

Change-Id: I6a41421a590fcee57b4ac8bcb7c3631fdfdecb81
Reviewed-on: https://gerrit.libreoffice.org/58755
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It's enabled in Line and Filling toolbar so do the same
in the sidebar

Change-Id: Icc64705268a9efb46ab463131ddf486dad12f085
Reviewed-on: https://gerrit.libreoffice.org/58747Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

- it's in practice never used nowadays, group threading has higher
priority in the code and since SwInterpreter's allowed opcodes are
a subset of group threading's, there should be no formula where
control flow gets as far as using SwInterpreter
- the only opcodes SwInterpreter allows are ocAdd, ocSub, ocMul,
ocDiv, ocSum and ocProduct, which is a rather limited set and group
threading should handle all that as well
- if SwInterpreter performs anything better than group threading,
there shouldn't be a problem doing the same for group threading
- it's yet another code path that should be handled, tested, etc.
and the added complexity is not worth it
- it shares some code with OpenCL handling, which is both added
hassle in case OpenCL code needs changes, and it also causes confusion
such as people thinking SwInterpreter has something to do with OpenCL

Change-Id: I99052862b60b6266c70dd436d1d7938177dc6bd9
Reviewed-on: https://gerrit.libreoffice.org/58643
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Mostly only the certificate selector was left + the global runtime switch.

Change-Id: I11e8e0920806eb61848512df6dea48c594febfe4
Reviewed-on: https://gerrit.libreoffice.org/58751
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I1baee1ec55e310aec2ec1010234d739eec5020c8
Reviewed-on: https://gerrit.libreoffice.org/58749
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2fff7354556769104e9ffaafc504d3159f63e4e8
Reviewed-on: https://gerrit.libreoffice.org/58748
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Icf3a07c6b79296feb233bbe08a6d69ab21a41414
Reviewed-on: https://gerrit.libreoffice.org/58746
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I75554209ad247173381ea96a14c8bf532bed13a8
Reviewed-on: https://gerrit.libreoffice.org/58724
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9ce151dfdb58fd4bb539aaa461a6c873c9ad18a5
Reviewed-on: https://gerrit.libreoffice.org/58716
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

This restores compatibility for API users who called getByName() on the
bitmap table and expected that the result can be set as a value for the
GraphicURL property.

Changing the property type to cppu::UnoType<css::uno::Any>::get() is
necessary, otherwise scripting languages figure out (via reflection)
that the type doesn't match, and SwXFrame::setPropertyValue() is not
called.

Change-Id: Idd62f109e91dbaebf1138b9038f66c6c648d780e
Reviewed-on: https://gerrit.libreoffice.org/58745Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Try harder to use fw declarations, and a few newly analyzed files

Change-Id: I50299e9115ced60468c7bc5e63013addbaec48c0
Reviewed-on: https://gerrit.libreoffice.org/58618
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I0b6c2d116496da64f91cb5cafb81b69e02366d96
Reviewed-on: https://gerrit.libreoffice.org/58743
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ice8c141db20d43ccc8d6e2b56004a4a28d2b257a
Reviewed-on: https://gerrit.libreoffice.org/58729
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

The reqif xhtml subset doesn't allow formatting of cells, which means
that the tables created with the UI and imported tables look different,
e.g. the later ones have no borders.

Fix this inconsistency by applying the default table autoformat during
import (in reqif mode). The import result looks better this way, and the
export will ignore it anyway.

Change-Id: I310770594e7a00e62f23d9df8cb16c2b95e1e44a
Reviewed-on: https://gerrit.libreoffice.org/58741Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I7803f673e835bd4575616d4e4b465ca144e282c8
Reviewed-on: https://gerrit.libreoffice.org/58720
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...to hopefully find out why <https://ci.libreoffice.org//job/lo_ubsan/996/
consoleFull#-14523843999567f988-cbcf-4519-af05-6000b834f13f> still fails in
UITest_writer_tests after c57191e0 "Try to make
test_tdf81457_table_merge_undo deterministic".

Change-Id: I142f89c508eb66a82e656b0ef32f595796b547fc
Reviewed-on: https://gerrit.libreoffice.org/58728
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib29c429a34a3895fa0747a54194dcd60ad41e45d
Reviewed-on: https://gerrit.libreoffice.org/58704
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

forgot to remove this in the 3.38 upgrade

Change-Id: Idaa9fd8e8036f305ec64c4a474d904d72daef0e8
Reviewed-on: https://gerrit.libreoffice.org/58721
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Add check for GLib support for modules which depends on
dbus and glib separately.
Also fix copy-paste typo.

Change-Id: Ibd33573b2f8dff9e0a7f2e0fc983d93878bb5357
Reviewed-on: https://gerrit.libreoffice.org/57157
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Until now, during docx import the pPrDefault properties have been
directly added to the parentless styles. However, things like
table styles are supposed to over-ride these document defaults, but
not style defaults. Since the docDefaults are merged into the style,
table-styles were unable detect if they could override them.

Exporting doesn't export pPrDefaults well, so the
properties still need to be merged into the style when
round-tripping.

Almost every existing unit test document is a proof test.
It effectively ought to act as a non-functional change.
Plus, this basically reverts 7f697ec2
so that unit test still covers bug 103961.

Change-Id: I4948299ddd610c07d828f2bd57c58734f1b94c49
Reviewed-on: https://gerrit.libreoffice.org/58203Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

for their preview widgets. since...

commit 4be44a7a
Date:   Thu May 24 19:09:44 2018 +0200

    SOSAW080: Cleanup of SdrModel

Change-Id: I102b64bdacc56a41091bbe60e932c2915f20323f
Reviewed-on: https://gerrit.libreoffice.org/58693
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Fixes CVE-2018-0495 and "the ASN.1 code".

Remove one hunk of nss-android.patch.1 that should be obsolete with the
current Android toolchain baseline.

Change-Id: I5516edec17b72f53acd2749e8840805eead077bc
Reviewed-on: https://gerrit.libreoffice.org/58697
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Iae997959a0ec2c9edb1c795533692ec4e579449f
Reviewed-on: https://gerrit.libreoffice.org/57313
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

pass SfxItemSet around by std::unique_ptr

Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7
Reviewed-on: https://gerrit.libreoffice.org/58649
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1
Reviewed-on: https://gerrit.libreoffice.org/58708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ever since
    commit c760d61b
    Date:   Fri Jul 27 15:28:44 2018 +0200
    remove SdrGrafObj::IsSwappedOut

Change-Id: I68c98449b98a3ac5da3bf26917ad2a76226f470c
Reviewed-on: https://gerrit.libreoffice.org/58707
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>