Change-Id: If49c33e271426ff5c2d0c6cc4010670f797bdd38
Reviewed-on: https://gerrit.libreoffice.org/65001
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

side-step the entire misery of proper positioning of non-native
tooltips just like in gtk3

Change-Id: I09a75fae672d3d999c946c50c547d5f2cfa3ec14
Reviewed-on: https://gerrit.libreoffice.org/64956
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

* Update helpcontent2 from branch 'master'
  - StarDesktop object and reorder indexes
    
    Add StarDesktop object description
    Reorder "Other commands" to add UNO objects
    
    Change-Id: Ia6547ea059276f8946b03392d29d968187bcd26c
Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/64981
    Tested-by: Jenkins
    

Change-Id: I5ad26f30704708aac42f2c48fa38382c38f98b2a
Reviewed-on: https://gerrit.libreoffice.org/64998
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I155036f6a47c765595938ff325ede6bbe6dd5c48
Reviewed-on: https://gerrit.libreoffice.org/65000
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

seems CaptionComboBox has devolved to a ComboBox that doesn't allow typing
space

Change-Id: I6beffaa8157eb91f0fd9fbe7f0de92a54e97470c
Reviewed-on: https://gerrit.libreoffice.org/64979
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I01ae503df29dbce12b10d661072a7a45e2336d2e
Reviewed-on: https://gerrit.libreoffice.org/64978
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

since...

commit 08da15ca
Author: Jakub Trzebiatowski <ubap.dev@gmail.com>
Date:   Fri Mar 11 20:58:34 2016 +0100

    tdf#90855 Improve the 'Insert Bookmark' dialog

Change-Id: Iabe462ddcfc2ea1a0eaeafe0d126f87158db97fd
Reviewed-on: https://gerrit.libreoffice.org/64977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If01e88d80922ca140e7e5d388cb5760f0bb20d79
Reviewed-on: https://gerrit.libreoffice.org/64913
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I7b163a344f36a1ae1170228e65dfe8828b2c7ee1
Reviewed-on: https://gerrit.libreoffice.org/64989
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I2914579b935a7e7556264222293d043618555b91
Reviewed-on: https://gerrit.libreoffice.org/64997
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4305310ea296a5326838759742b14e687158d426
Reviewed-on: https://gerrit.libreoffice.org/64954
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1172359ed57e5f19e7d3d7af30e6fbf8e54d9e75
Reviewed-on: https://gerrit.libreoffice.org/64950
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I409c9c572eb8f3d68c8a387844b43988b4ab5c32
Reviewed-on: https://gerrit.libreoffice.org/64949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

... and don't modify standard frame styles to have no borders and padding.
This makes "Frame", "OLE", and "Graphics" frame styles of imported DOC
files to have usual settings (for "Frame", it's 1.5 mm padding and all
borders set to 0.05 pt black line).

All objects that need invisible frame will have them with all necessary
settings set explicitly, which allows to copy and paste such frames to
other documents without problems.

This makes DOC import aligned with DOCX import in this regard.

Change-Id: I6f05cf71e63ceccb8e0ddebe23ec41bf69af9b52
Reviewed-on: https://gerrit.libreoffice.org/64992
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

... instead of the naïve algorithm. Short test case with 4 values:

10000000007
10000000011
10000000013
10000000017

     Naïve Var: -21845.3333333333
   Welford Var: 17.3333314259847
VAR() two-pass: 17.3333333333333

Change-Id: I2f27ab91166551e96c0e467f41bd6e6d49b50295
Reviewed-on: https://gerrit.libreoffice.org/64993Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Correct some Format - Row/Column/Cell paths
    
    Some Format - Row/Column/Cell paths are corrected
    as Format - Rows/Columns/Cells
    
    Change-Id: If9795322ca50f3f5646b9195de69eb1e348662cf
    Reviewed-on: https://gerrit.libreoffice.org/64985
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I21790869be9c87e923cb4d87b58b2dc4b143fb25
Reviewed-on: https://gerrit.libreoffice.org/64971
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

This was wrong since

    commit 298ee506
    CommitDate: Sun Nov 20 00:14:28 2016 +0100

        PivotMedian: Implement median as a new pivot table function

and in fact in a debug build failed an assertion

soffice.bin: include/o3tl/typed_flags_set.hxx:85:
  constexpr o3tl::is_typed_flags<E, M>::Wrap::Wrap(type name std::underlying_type<_Tp>::type)
  [with E = PivotFunc; typename std::underlying_type<_Tp>::type M = 4607; typename std::underlying_type<_Tp>::type = int]:
  Assertion `static_cast<typename std::underlying_type<E>::type>(~0) == M || (value & ~M) == 0' failed.

when one of the functions (e.g. StdVar) not included in the mask
was chosen as pivot table data function.

Change-Id: I5b9efc7d2cbcf6fece3ef228db8f6e0ffa17b510
Reviewed-on: https://gerrit.libreoffice.org/64974Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Writer has the internal invariant that if a text (non-table) selection
starts outside a table, it should end outside a table as well.  This
means if you start your selection before a table and you try to select
till the end of the table, your selection will end at the start of the
next non-table node in fact.

This is especially confusing if you turn the selection into a paragraph
enumeration, where the last paragraph's 0 -> 0 character range is
"selected" (i.e. none of the paragraph content is selected) and still
the paragraph is included in the paragraph enumeration.

Special-case the "selection ending at para start after a table"
situation when it comes to turning this selection into a paragraph
enumeration to avoid the unexpected empty paragraph at the end.

Change-Id: I51432dee9e5d76971533c8059edab1cd9683434b
Reviewed-on: https://gerrit.libreoffice.org/64972Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces in sentences
    
    Change-Id: Id9e9094b932af787ceccbe5ea867459afe6677c0
    Reviewed-on: https://gerrit.libreoffice.org/64897
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: Ic6c51cdc219e663c59dee32f61e337709c90fbd2

The graphicsPort property of NSGraphicsContext is deprecated in 10.14.
CGContext is there since 10.10 so we can use it unconditionally.

But sadly this did not enable me to un-comment the assert() a few
lines below.

Wonder if this deprecation is just a cleanup of the API, and
functionality-wise the CGContext property is exactly the same as
graphicsPort?

Change-Id: I2d5d0c766c343faa2d8cabea3a0729ce5b3a34e3

* Update helpcontent2 from branch 'master'
  - Related: tdf#121173 double spaces
    
    Change-Id: Iecc58ab0812c3a1bd279e28b8d0bf2de99a24792
    Reviewed-on: https://gerrit.libreoffice.org/64887
    Tested-by: Jenkins
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I004b2738929e9755dba03c8cab5cb2e2ccae707d
Reviewed-on: https://gerrit.libreoffice.org/64129
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Change-Id: I458f44d16b242700b228db647582c4b40b14661a

These were never implemented. Likely because they aren't used
internally by Calc, which for formula expressions in the
interpreter and for DataPilot / pivot table uses a different
approach, but they are needed for
css::sheet::XSheetOperation::computeFunction()

Change-Id: I1af038bf9db8d0c04d69598b992b827b083e2248
Reviewed-on: https://gerrit.libreoffice.org/64957Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: Ia6b57f0cf508686c437027e5753258169c18b0f7

(See 1d028d47 "Fix Linux RPATH of various
external modules" for the original external/coinmp/rpath.patch missing a patch
for CoinUtils/configure.)  This is a blind fix attempt for
<https://ci.libreoffice.org/job/lo_daily_update_gandalf/559/console>

> /lo/home/tdf/lode/jenkins/workspace/lo_daily_update_gandalf/instdir/program/libCoinUtils.so.3 has unexpected RPATH  0x000000000000001d (RUNPATH)            Library runpath: [/opt/rh/devtoolset-7/root/usr/lib/../lib64:$ORIGIN]
> /lo/home/tdf/lode/jenkins/workspace/lo_daily_update_gandalf/postprocess/CustomTarget_check_dynamic_objects.mk:20: recipe for target '/lo/home/tdf/lode/jenkins/workspace/lo_daily_update_gandalf/workdir/CustomTarget/postprocess/check_dynamic_objects/check.done' failed

after ed81fe44 "Enabling Developer Toolset 7 for
Jenkins' remaining GCC master jobs" enabled GCC 8 at gandalf's
/opt/rh/devtoolset-7/root/ (which is at the same location as a CentOS Developer
Toolset 7 special GCC 7, but is actually a plain GCC 8, cf.
<https://lists.freedesktop.org/archives/libreoffice/2018-December/081544.html>
"Re: Compiler baselines") for the lo_daily_update_gandalf job.  Presumably
libtool added to RPATH a path to find that GCC 8 installation's
/opt/rh/devtoolset-7/root/usr/lib64/libstdc++.so.6.

Change-Id: I37c98faffe3e6c014e321b756a18a8468c32877c
Reviewed-on: https://gerrit.libreoffice.org/64942
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Eventually OSX should also depend on SVP and SVP should just
export the platform agnostic code, so we can get rid of all
the IOS and ANDROID ifdefs.

Since the SVP mode now also uses a default DPI value of 96,
we can get rid of those "broken" adjustments to the tests in
commit a4ab0c08 ("Row height tolerance level increase for
unittest") and commit 1e55a47e ("tdf#62268: allow row
height recalculation on document load").

The DPI handling on OSX seems really broken. Additionally DPI
should probably a float value, as rounding results in various
of-by-one errors in tests.

Change-Id: I47881683a9c3d3e1b4f8e7aba1d03842da4d6652
Reviewed-on: https://gerrit.libreoffice.org/64736
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Somehow there is a difference how the formula looks when converting via command line
vs exporting from UI.
In UI the sum formula looks like: 'sum( (0) ) (0|0|0|0)'
while in cmd line it looks like:  'sum( (0) ) () '

Both look sane, so just don't treat the second one as error.

Change-Id: I345c062a9e7c8b9c849885bc6cb88167a3491dd8
Reviewed-on: https://gerrit.libreoffice.org/64941
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Adds a configure test to check for the enabled ClassPathURLCheck.
Should be reverted, if our jars pass it.

Change-Id: I040b41f329ccae21b92118fd58270682e50e95c1
Reviewed-on: https://gerrit.libreoffice.org/64709
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

I'm not sure this is the best idea, but without a context many
things will definitly break. In theory this is just needed for
bitmap-only rendering mode.

This is a more general solution of commit e659c6a1 ("Work
around odd macOS 10.14 graphicsContextWithWindow failure").

Change-Id: I3708c25b302a38e1b0c0cccbcacd6cb9b5ff33dc
Reviewed-on: https://gerrit.libreoffice.org/64952
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

* Update helpcontent2 from branch 'master'
  - correct command names for opening/saving remote files
    
    Change-Id: I2fc0b696a60dbdb3e18dc483b67c5ad57836f211
    Reviewed-on: https://gerrit.libreoffice.org/64675
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Don't send a SalEvent from AquaSalFrame::SetWindowState, if we
don't have a NSWindow and therefore can't actually move. Just
like most other function, we can return early in this case.

Also clean up duplicate code in AquaSalFrame::ShowFullScreen and
remove some duplicate mpNSWindow checks.

Change-Id: I90365ea64191682a7e867b80467c0a1bafdbc868
Reviewed-on: https://gerrit.libreoffice.org/64951
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I4cadbb928ab0fbb407e9d569e77e6c20229e1810
Reviewed-on: https://gerrit.libreoffice.org/64940
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ib97d0da4c52215009dd2142908168c68ea0aebcb
Reviewed-on: https://gerrit.libreoffice.org/64939
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Problem was: during mailmerge, all paragraphs became list nodes
when the last node in original document (template) was list node.

Change-Id: I8b457c5ef04ab6569e7860deb1f5b3d73dadacd0
Reviewed-on: https://gerrit.libreoffice.org/64955Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I09e98f04b8ca2f2a3908f27276055fe9a308f5a8

Change-Id: I5d77a3dddeb5524bfef13a4871ffc5bb6be6cae0
Reviewed-on: https://gerrit.libreoffice.org/64900
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>