new statusbar element property mandatory=true/false to determine
if this element can be hidden if total statusbar width is not
enough to fit all elements.

marked some calc and draw statusbar elements as not mandatory.

Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f
Reviewed-on: https://gerrit.libreoffice.org/56443
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

The case when the thread is re-scheduled exactly after checking for
m_bExecute but before taking the solar mutex.

Change-Id: I494c123a6225da60407391771622208c055ae49b
Reviewed-on: https://gerrit.libreoffice.org/56585Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Ia70144d6c86b1b08e14425bf537e9c39d585a614
Reviewed-on: https://gerrit.libreoffice.org/55820
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

when creating signature line.
OOXML Export expects this.

Change-Id: Ib6ab1f879c5ef27e8347002576ba95104117cadd
Reviewed-on: https://gerrit.libreoffice.org/56576
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

GCC trunk towards GCC 9 emits -Wdeprecated-copy because SalVisual has implicit
copy functions but a user-declared dtor.  The implicitly-defined copy functions
are actually used (so cannot be deleted), but in fragile interaction with the
semantics of the user-provided dtor in the SalColormap(sal_uInt16) ctor.

Changing SalVisual into a move-only class (moving the "this instance must delete
its visual member" information) doesn't work well, as SalDisplay::ScreenData is
used as a supply of SalVisual instances (but which will never be of the "this
instance must delete its visual member" variety) that are then copied into
SalColormap::m_aVisual.

As only SalColormap creates SalVisual instances of the "this instance must
delete its visual member" variety, what actually works is to track that
information in SalColormap instead of directly in SalVisual, and make
SalColormap a move-only class.

Change-Id: Ib968a38c40b660ce91981b3c7b281f4add6ece6b
Reviewed-on: https://gerrit.libreoffice.org/56579
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

When subsets are non-contiguous, we need to include the parts between
subsets.

Change-Id: I28214dccc75e6a6af5c65397b2126049a65bf79f
Reviewed-on: https://gerrit.libreoffice.org/56571
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I75b37dab51f3510f6e7155c191a85af99b0d350f
Reviewed-on: https://gerrit.libreoffice.org/56547
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7
Reviewed-on: https://gerrit.libreoffice.org/56491
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I86c7c0f73a21f670676716d7c22f519ed82da145
Reviewed-on: https://gerrit.libreoffice.org/56544
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I80cd0b051a137f51aa03ebc573369c945ca502da
Reviewed-on: https://gerrit.libreoffice.org/56553
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6107079f8474a2ddc76a9cb6e93552d95861dc6c
Reviewed-on: https://gerrit.libreoffice.org/56563
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I748382e73a2e2b80292e8c396cb61ca805c03549
Reviewed-on: https://gerrit.libreoffice.org/56562
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I224c5d7b2562cc0ad5d03dc7dffc5476c83a5f54
Reviewed-on: https://gerrit.libreoffice.org/56561
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I199b5f3bd0d8555dc01d6f51208ebe4526a32f9a
Reviewed-on: https://gerrit.libreoffice.org/56559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8d7561df19d433db5454bcf4d60e1cb81c44f031
Reviewed-on: https://gerrit.libreoffice.org/56558
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I27ef6e27c8eef01a5de0f117ee03364ca545b27a
Reviewed-on: https://gerrit.libreoffice.org/56560
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6433050af217668800c7257433c11bfec37d9634
Reviewed-on: https://gerrit.libreoffice.org/56557
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0b90d59e627691c6c187f34591992301102afcfe
Reviewed-on: https://gerrit.libreoffice.org/56556
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I99b9809b3924285b4f0d58905352777b948ee592
Reviewed-on: https://gerrit.libreoffice.org/56546
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6d4d4899670d8c3254f8c4337a14ba2bb937a2bf
Reviewed-on: https://gerrit.libreoffice.org/56555
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I864e09c6c86a852bc79d9e2ea6b50c568fd0155f
Reviewed-on: https://gerrit.libreoffice.org/56554
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If6cc62d08fbd589f332514e01a42aae8f919e68f
Reviewed-on: https://gerrit.libreoffice.org/56552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I38101b3046c4354f48b6c9d34a016351659e9795
Reviewed-on: https://gerrit.libreoffice.org/56551
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie934c2d0ad0c71b22d84976661b19d07e2eb64d4
Reviewed-on: https://gerrit.libreoffice.org/56550
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic3059e266a9276786e33ba5adf846e51551bdd6f
Reviewed-on: https://gerrit.libreoffice.org/56549
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id1ccd3657ffb0a5ae4762ea6ce25f8ce2c77db92
Reviewed-on: https://gerrit.libreoffice.org/56548
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic32996b3aaf415109c1fdc336db138ec12159ce2
Reviewed-on: https://gerrit.libreoffice.org/56545
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I18f5563be60fa7826d8f720288abcfaf9d93313e
Reviewed-on: https://gerrit.libreoffice.org/56564
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I64b5d78e9a63c3b78b6ac87123bf09903556f8d9
Reviewed-on: https://gerrit.libreoffice.org/56543
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

There appears to be a lot of caching involved in the code invoked
by ScGetPivotData(). Testcase is e.g. tdf#89186-1 (with minimal
formula size disabled again).

Change-Id: If7e2a972898c358dc8f80cf238f8d5ccf541f16d
Reviewed-on: https://gerrit.libreoffice.org/56525
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Lets assume that that was an oversight, and change all those user-provided
copy assignment ops into implicitly-defined ones (that will now also copy
Bundle::mnColor).  Avoids -Wdeprecated-copy with GCC trunk towards GCC 9, as the
copy ctors were already left implicitly-defined (and so already copied
Bundle::mnColor).

Change-Id: I43e323b55d059c7afecaddab0d777b6df47182c8
Reviewed-on: https://gerrit.libreoffice.org/56539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

See https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c44

Change-Id: Ib2d828a66bc14faa4f341eec9210e1effdebd7c1
Reviewed-on: https://gerrit.libreoffice.org/56541
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The assertion fails when one reproduces tdf#69460 but removing the
assert() does not cause any problems.

Change-Id: Idaa5d41a0cf76073e406d7152fc3b4e9ebd3e876
Reviewed-on: https://gerrit.libreoffice.org/56538Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I50b842afc505ce603225fb2d25281cc8e9240200
Reviewed-on: https://gerrit.libreoffice.org/56537Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

...as that member is only used in m_aIdToStyle, and it was confusing how the
user-provided HashedStyle copy ctor initializes it to zero while the implicitly
defined copy assignment op copies it.  (And existence of only one of those
copy functions also triggered -Wdeprecated-copy with GCC trunk towards GCC 9.)

Change-Id: I176ef95af8780fefe21e53f61fd66f5e2d9156ab
Reviewed-on: https://gerrit.libreoffice.org/56528
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Which is used in e.g. the Calc cell border dialog. The approach is
similar to commit 60790935 (tdf#96657 -
vcl opengl: implement invert: Track Frame., 2016-01-09) but that one was
for rectangles, this one is for polygons.

Change-Id: Ib1feebab2d14f4450fee0afe96afcea906965fdb
Reviewed-on: https://gerrit.libreoffice.org/56534Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I017c100f83faac64ad3a8430010c226b438e6a07
Reviewed-on: https://gerrit.libreoffice.org/56529
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

add to NB grouped (full and compact) in Edit group
cause Format is only Format selected text but not Format page.
Edit group is most generic group that fit's for page selection

Change-Id: I49af8ff5b560655d43c55818da391a768d26ef04
Reviewed-on: https://gerrit.libreoffice.org/56430
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

If the fon supports Graphite features we can get the feature
descriptions from the font, but this descriptions are mostly
limited (available in a limited number of languages), so it is
better to only use this descriptions only if the feature does not
have an OpenType description available.

Change-Id: Ic0b81cb8cc22e1e73f30e6a960167cfa982fbfc7
Reviewed-on: https://gerrit.libreoffice.org/56318
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I85243dff96b9090de0fd55564b44abb6142d9ac2
Reviewed-on: https://gerrit.libreoffice.org/56524
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>