- 21 Nis, 2019 1 kayıt (commit)
-
-
Mike Kaganski yazdı
On Windows, gpgme expects gpgme-w32spawn.exe to be in the same directory as the current process executable. This assumption might be wrong, e.g., for bundled python, which is in instdir/program/python-core-x.y.z/bin, while gpgme-w32spawn.exe is in instdir/program. In this case, if an operation in a python script requires initializing gpgme, it will be interrupted by a modal warning box telling that gpgme-w32spawn.exe was not found. If we can't find gpgme-w32spawn.exe in the current executable location, then try to find the spawn executable, and inform gpgme about actual location using gpgme_set_global_flag. Change-Id: Ie30a0d4a6666767e8c54f1bdc67b67570d6ea47a Reviewed-on: https://gerrit.libreoffice.org/71014 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit cca68302) Reviewed-on: https://gerrit.libreoffice.org/71036Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
- 20 Nis, 2019 3 kayıt (commit)
-
-
Mike Kaganski yazdı
Also provide a default pivot table style for those tables that don't have a style info. Let's use the style settings that Excel uses. Change-Id: I8006a33a0aa0e92629f7db0a9c24a6ff52d17945 Reviewed-on: https://gerrit.libreoffice.org/70933 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/71006Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Tamás Zolnai yazdı
Handle %7c with small letters. Make sure that the output parameter's content is not affected by decoding. Change-Id: Ie3faad2461815497c0edfb04a589fc57aeb7d66b Reviewed-on: https://gerrit.libreoffice.org/70873 Tested-by: Jenkins Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit f6dc5636) Reviewed-on: https://gerrit.libreoffice.org/70984Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Tamás Zolnai yazdı
Change-Id: I3352bf9ade88bd86f7ca3d53238364216547d52b Reviewed-on: https://gerrit.libreoffice.org/70830 Tested-by: Jenkins Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 2317ad57) Reviewed-on: https://gerrit.libreoffice.org/70983Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
- 19 Nis, 2019 3 kayıt (commit)
-
-
Tor Lillqvist yazdı
Change-Id: Ic33646ec1af38d36c344fd7ec1ccfdcb838bc716
-
Tor Lillqvist yazdı
Change-Id: I04a3a22918ead008b560c2e1159747e8d28da404
-
Tor Lillqvist yazdı
Factor out the setFilterPropsFromFormat() also used by SwVbaDocument::SaveAs2000() to a header file of its own. Change-Id: I4bc9e1e420719a115036beb7e82a4ac3feac05f0
-
- 18 Nis, 2019 10 kayıt (commit)
-
-
Muhammet Kara yazdı
Bring White option to the first place, to save toner on print as users tend to click on the first option. Change-Id: Id63c4402f8dc07a83eef69c3dfde3dd086c899b8 Reviewed-on: https://gerrit.libreoffice.org/70831 Tested-by: Jenkins Reviewed-by:
Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit d5b59b8d) Reviewed-on: https://gerrit.libreoffice.org/70868Tested-by:
Muhammet Kara <muhammet.kara@collabora.com>
-
Michael Stahl yazdı
Change-Id: I3fe30de8140dce3d81cdfae7d41e0bd465b1d5f4 Reviewed-on: https://gerrit.libreoffice.org/70879 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 2d85b75b)
-
Stephan Bergmann yazdı
After recent additions of 61c4f96d "Support AdoptOpenJDK" and 41507db5 "Support Amazon Corretto" to our hard-coded list, there is now reports that at least Debian and Ubuntu tried to distribute versions of OpenJDK with the java.vendor propety set to string like "Debian" or "Ubuntu". Instead of trying to catch up with an ever-growing hard-coded list, it is probably better to stop relying exclusively on such a hard-coded list, and for unknown vendor values, try out whether the SunInfo backend (which supports the "generic" OpenJDK) would be able to handle the given JRE. (For simplicity, assume that any versions of such JREs are supported. Our baseline is Java 6, and there are unlikely any older versions of JREs from unknown vendors out there. If this turns out to be problematic, we could include information about problematic vendors after all, or add a general check that JREs from unknown vendors are at least Java 6.) Many functions in jvmfwk/inc/vendorplugin.hxx that used to take a set of sVendor/sMinVersion/sMaxVerison/arExcludeList paramters had to be revised to take a vendorSettings parameter instead, and VendorSettings::getVersionInformation has been changed to return a boost::optional, so that unknown vendors can be handled gracefully. Reviewed-on: https://gerrit.libreoffice.org/70460 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3d27b2fa) Conflicts: jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx jvmfwk/source/framework.cxx Change-Id: Ibf915f2ddd59e09b77e2c03be688cac0547b9ac9 Reviewed-on: https://gerrit.libreoffice.org/70587 Tested-by: Jenkins Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Caolán McNamara yazdı
there may have been changes not caught by undo to the object's ordinal, so on use of RemoveObject (or ReplaceObject) call GetOrdNum on the object to get its current position within its parent. We can keep nOrdNum for the desired dest position within the parent for InsertObject Change-Id: I3bdabf387dd630fc1fadaaa1f3d8c05e93865e4f Reviewed-on: https://gerrit.libreoffice.org/70409Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
Jan Holesovsky yazdı
The problem is that with LOK, the creation of Idle here causes a deadlock when the dialog is being opened and its first paint is requested. No real idea what change now causes the problem (this used to work), but given that the use of the Idle is a hack in the first place, let's use the GetFocus/LoseFocus handlers instead, and act accordingly only when the focus of the interesting controls changes. Change-Id: Ib6c0267a064cb31438544e47fe3e0869b575ef7c Reviewed-on: https://gerrit.libreoffice.org/70917Reviewed-by:
Aron Budea <aron.budea@collabora.com> Tested-by:
Aron Budea <aron.budea@collabora.com>
-
Andras Timar yazdı
Change-Id: I2c054ba672c7ab52a6e3f3f085823fd5015f0d62
-
Mike Kaganski yazdı
... otherwise Excel would reset data formatting e.g. from currency to plain numbers upon refresh. Excel relies on per-field format setting in pivot tables, while Calc takes fields formatting from source. Change-Id: Ia8cdf3f8fcd23720e3daaf989152c170057b339c Reviewed-on: https://gerrit.libreoffice.org/70860Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70919
-
Mike Kaganski yazdı
Change-Id: Ia5ca829877712b9814ce6eee392d8f1f23a7e97b Reviewed-on: https://gerrit.libreoffice.org/70915Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com>
-
Tomaž Vajngerl yazdı
IsPaintTransparent() is preventing to paint the background but not sure why this is needed. removing this condition doesn't seem to have any ill effects. Reviewed-on: https://gerrit.libreoffice.org/70855 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 1e917af2) Change-Id: I5ac54e208e4f1c9941beb4012aa44182d21dbed9 (cherry picked from commit 23d475949580d1b104f9bd34abe0441cfc0461ae)
-
Tomaž Vajngerl yazdı
This should prevent the crash - at least it did for me AFAICS. Change-Id: I489264d8054e6577b948b0ab307c863d3140788a Reviewed-on: https://gerrit.libreoffice.org/70755 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9f392d0c)
-
- 17 Nis, 2019 4 kayıt (commit)
-
-
Henry Castro yazdı
Change-Id: I41a9ff0d281d9032ddaafbbcb55352254a809efe Reviewed-on: https://gerrit.libreoffice.org/70824 Tested-by: Jenkins Reviewed-by:
Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70880Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
Jan Holesovsky <kendy@collabora.com>
-
Henry Castro yazdı
document" Change-Id: I976318fe299306b65190b4f5ae0ed2565830c6f7 Reviewed-on: https://gerrit.libreoffice.org/70475 Tested-by: Jenkins Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Reviewed-by:
Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70794Tested-by:
Jan Holesovsky <kendy@collabora.com>
-
Muhammet Kara yazdı
Users need an in-process copy of pdf to share with peers and discuss the redacted areas Change-Id: I68c16c6f09690a9d5cd2df191963107029e5ed88 Reviewed-on: https://gerrit.libreoffice.org/70863Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com> (cherry picked from commit 06eb265d) Reviewed-on: https://gerrit.libreoffice.org/70864
-
Noel Grandin yazdı
The message from clang-tidy is: warning: object destroyed immediately after creation; did you mean to name the object? The guard in RequestHandler::ExecuteCmdLineRequests comes from commit cf333a87 Date: Sun Jan 21 22:10:09 2018 +0300 tdf#38915: set cProcessed condition on any process outcome and I'm sure it's intention was to set the flag on exit from the function, not immediately. Reviewed-on: https://gerrit.libreoffice.org/60183Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit 867ee21f) Change-Id: Ibf874a5774770df00b9db7f673554e7ffda55072 Reviewed-on: https://gerrit.libreoffice.org/66168 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 16 Nis, 2019 2 kayıt (commit)
-
-
Muhammet Kara yazdı
Users might accidentally move the main shape of the page being redacted. Let's prevent that. Change-Id: Ic0f3c2c819d1f974d203fa5fd70d57e5545ba8ef Reviewed-on: https://gerrit.libreoffice.org/70843Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Mike Kaganski yazdı
Excel expects the group field items to be in ascending order starting from "<01/02/2010", then "Jan", "Feb", ..., then end with ">01/02/2020". Change-Id: I29e9b55f43091ed007f59e10dec64f46a37c7d5f Reviewed-on: https://gerrit.libreoffice.org/70800 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70815Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
- 15 Nis, 2019 8 kayıt (commit)
-
-
Tor Lillqvist yazdı
Might help in some cases in the customer application. Change-Id: Icdc13780d4623e9df8bc057760c1295d7d6ffd61
-
Ashod Nakashian yazdı
Change-Id: Ica7448458ecc5e9adc802a288f72b1fceb709f79 Reviewed-on: https://gerrit.libreoffice.org/70724Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
The slide-sorter is actually still necessary to apply/change the master slide of a given slide, so we must enable it. Change-Id: I3f59f58be76ab1c63453b4f6288044572800a556 Change-Id: I7554ba4afd28d7ea4f3ed6ba375d9765a89ef21c Reviewed-on: https://gerrit.libreoffice.org/69618Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Change-Id: Ife85b3c728c59f7fb4e0184211efc9b652c5f4e7 Reviewed-on: https://gerrit.libreoffice.org/69615Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Change-Id: I4cb6ce6d961b4ba4d542c14cb37370788cf75e45 Reviewed-on: https://gerrit.libreoffice.org/69613Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
- 13 Nis, 2019 3 kayıt (commit)
-
-
Ashod Nakashian yazdı
Change-Id: I1e09d458d1c6c4842750368fbd45ef326fa1bedb Reviewed-on: https://gerrit.libreoffice.org/70160Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Change-Id: Iebd85e5e60c76e6d0756d15e1fa6107a3fcc837d Reviewed-on: https://gerrit.libreoffice.org/70162Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Mike Kaganski yazdı
Two tests in sc/qa/unit/pivottable_filters_test.cxx were extended to also test round-trip of group fields in XLSX. Change-Id: I70b7c15b09040c64fa1da2f88001af7ba16f2c6f Reviewed-on: https://gerrit.libreoffice.org/69653 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70687Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
- 12 Nis, 2019 6 kayıt (commit)
-
-
Mike Kaganski yazdı
Despite being optional as per ECMA-376-1:2016, Excel 2016 seems to require the presence of "name" attribute in dataField element of pivot table definition, so make sure to write at least empty string there. Change-Id: Iaab5674f86b7dd0b267776678e11af47086635d7 Reviewed-on: https://gerrit.libreoffice.org/70522Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70684
-
Mike Kaganski yazdı
The test should guarantee presense of w:val attribute of w:rStyle element. Turns out we must not use w: namespace before attribute name; likely it is true when attribute namespace is the same as of its element. Change-Id: I28e2936b51f039473326c6debf4b5559e2baf24c Reviewed-on: https://gerrit.libreoffice.org/70612 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70681Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Mike Kaganski yazdı
It turns out that this change revealed unit tests written incorrectly (and untested), or maybe which became broken (not testing) because of some previous assertXPath change? They incorrectly used 3-arg form of it to check node content equality to passed string, while in fact, an attribute was looked for with that name, and its empty return tested to match default empty 4th argument. Change-Id: If24e18518543102d115a22a6282e4cca9cf694e2 Reviewed-on: https://gerrit.libreoffice.org/70581Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/70680
-
Dennis Francis yazdı
field labels, else on export to xlsx, Excel will fail to load the pivot table due to case-insensitive duplicate field labels in the pivotCacheDefinition1.xml. This could be done just for xlsx export filter, but we do normalization in dpcache.cxx anyway and it would not hurt if we do a case-insensitive normalization here. The private member ScDPCache::AddLabel had code duplication and more importantly it is called in loop for every label in the database so results in O(n^2) time complexity where n is the number of labels, so removed it to reuse normalizeLabels() at the only call-site. Also added a unit test that checks case-insensitive normalization. Change-Id: Id563dee232a98a2aea9f4fc29254f6942e1c5ba7 Reviewed-on: https://gerrit.libreoffice.org/70498Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by:
Dennis Francis <dennis.francis@collabora.com>
-
Tor Lillqvist yazdı
I wonder wheter we should just include all of instdir/share. Seems that I have to add more and more of it all the time anyway. I don't remember why I thought (many years ago) that an app would need just a subset. (Maybe I thought that an app would not, at least not initially, have functionality that would use most of the stuff in shre. But that has changed now.) Change-Id: I62f935e3ab9c4709373fad11ed120ecca033b4aa
-
Tor Lillqvist yazdı
Change-Id: I71a822495c8a41cf01efe611911afcafea81118d
-