Kayıtlar (commit) · dc05737d46cd6f4a7f430c7ac8b4e512de12b159 · LibreOffice / core

03 Agu, 2018 1 kayıt (commit)

uitest Impress Document properties · dc05737d

Zdeněk Crhonek Agu 01, 2018 yazdı

Change-Id: Ida877ab6e65d4bcbd42d37fd2567db63f84ed8ad
Reviewed-on: https://gerrit.libreoffice.org/58456
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

dc05737d

02 Agu, 2018 35 kayıt (commit)

[pt_PT] Added 20 autocorrect words · 6ec8c8ed

Marco A.G.Pinto Tem 16, 2018 yazdı

Change-Id: If2cd89b76433ce32e072805969e2381a30f62125
Reviewed-on: https://gerrit.libreoffice.org/57482
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>

6ec8c8ed

turn SfxPickList singleton a member of SfxApplication · 653394fb

Caolán McNamara Agu 02, 2018 yazdı

SfxPickList listens to the SfxApplication so it can
be made a member of that, and drop the singleton, which
is causing trouble like...

 #0  0x00007ffff613ad7d in ImplDbgTestSolarMutex() () at /libreoffice/symbols/vcl/source/app/dbggui.cxx:47
 #1  0x00007ffff6ee86e1 in SfxBroadcaster::RemoveListener(SfxListener&) (this=0x5555565d0380, rListener=...) at /libreoffice/symbols/svl/source/notify/SfxBroadcaster.cxx:126
 #2  0x00007ffff6eea993 in SfxListener::~SfxListener() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/svl/source/notify/lstner.cxx:66
 #3  0x00007ffff7207b45 in SfxPickListImpl::~SfxPickListImpl() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:84
 #4  0x00007ffff7207b45 in SfxPickListImpl::~SfxPickListImpl() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:84
 #5  0x00007ffff7206aa5 in std::default_delete<SfxPickListImpl>::operator()(SfxPickListImpl*) const (this=<optimized out>, __ptr=<optimized out>) at /usr/include/c++/7/bits/unique_ptr.h:78
 #6  0x00007ffff7206aa5 in std::unique_ptr<SfxPickListImpl, std::default_delete<SfxPickListImpl> >::reset(SfxPickListImpl*) (__p=<optimized out>, this=0x7ffff76775a8 <SfxPickList::ensure()::aUniqueInstance>) at /usr/include/c++/7/bits/unique_ptr.h:376
 #7  0x00007ffff7206aa5 in SfxPickList::~SfxPickList() (this=0x7ffff76775a8 <SfxPickList::ensure()::aUniqueInstance>, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:188
 #8  0x00007ffff44dc041 in __run_exit_handlers (status=0, listp=0x7ffff4884718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
 #9  0x00007ffff44dc13a in __GI_exit (status=<optimized out>) at exit.c:139
 #10 0x00007ffff44bab9e in __libc_start_main (main=0x555555557880 <main(int, char**)>, argc=10, argv=0x7fffffffdde8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffddd8) at ../csu/libc-start.c:344
 #11 0x00005555555578da in _start ()

Change-Id: Ic781f3eb065fef14da1f10a56246b9b7068e1529
c781f3eb065fef14da1f10a56246b9b7068e1529
Reviewed-on: https://gerrit.libreoffice.org/58494
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

653394fb

coverity#1438198 silence using invalid iterator · 1cb3195f

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: Ibccf6d3838335ae2d8a3a7f8187df8f2e173f043
Reviewed-on: https://gerrit.libreoffice.org/58482
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1cb3195f

coverity#1438194 silence Resource leak · 668e68d3

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: I54cf8e4fc430feb2e34d3f6f0f2abce81973b09a
Reviewed-on: https://gerrit.libreoffice.org/58481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

668e68d3

m_xStringLength is unused · 46d5bde3

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: I244ca2c34363d0776a3cc18953a1c9b28467da44
Reviewed-on: https://gerrit.libreoffice.org/58493
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

46d5bde3

KF5_HAVE_GLIB etc. are apparently unused · 8fee33ba

Stephan Bergmann Agu 02, 2018 yazdı

...ever since their introduction with 4d78cf97
"Extend build system to support linking against KDE Frameworks 5"

Change-Id: I47f0b6c440aa345d564abac5a12a4af35b8fcf4e
Reviewed-on: https://gerrit.libreoffice.org/58476
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

8fee33ba

Remove no-longer functional --with-alloc · 0e2a8bbf

Stephan Bergmann Agu 02, 2018 yazdı

...after db354dfa "the custom SAL allocator is
no longer used"

Change-Id: Ia897e2d3cf20bb240dcc3eed801b81f86267dc6a
Reviewed-on: https://gerrit.libreoffice.org/58475
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

0e2a8bbf

update credits · cbd383aa
Christian Lohmaier Agu 02, 2018 yazdı
```
Change-Id: Idfce6ffe88615f64319d7e1112ac6c4bde2a88d9
```
cbd383aa

Reportdesign: try to fix EndListening · c8d8fdea

Julien Nabet Tem 03, 2018 yazdı

Looking at history:
2014-05-02:
    reportdesign: sal_Bool->bool
e23c98d7

2008-06-16:
    INTEGRATION: CWS rptchart02 (1.7.4); FILE MERGED
    2008/05/16 12:53:21 oj 1.7.4.6: #i89365# copy props before set args at chart
    2008/05/07 06:56:32 oj 1.7.4.5: #i88842# set databaseprovider at chart
    2008/04/30 13:03:34 oj 1.7.4.4: #i88843# impl clone method
    2008/04/16 06:28:15 oj 1.7.4.3: RESYNC: (1.7-1.8); FILE MERGED
    2008/04/03 06:35:18 oj 1.7.4.2: #i86343# remove unused code
    2008/03/12 09:45:16 oj 1.7.4.1: impl chart handling
b8fe847a
@@ -299,10 +297,9 @@ void OObjectBase::EndListening(sal_Bool /*bRemoveListener*/)
     DBG_CHKTHIS( rpt_OObjectBase,NULL);
     OSL_ENSURE(!m_xReportComponent.is() || isListening(), "OUnoObject::EndListening: not listening currently!");

+    m_bIsListening = sal_False;
     if ( isListening() && m_xReportComponent.is() )
     {
-        m_bIsListening = sal_False;
-
         // XPropertyChangeListener
         if ( m_xPropertyChangeListener.is() )
         {
Since isListening() returns the value of m_bIsListening
(see https://opengrok.libreoffice.org/xref/core/reportdesign/inc/RptObject.hxx#79)
quite suspicious.

We may think that "m_bIsListening = false;" should be put if we succeed in removing the listener
382      if ( isListening() && m_xReportComponent.is() )
383      {
384          // XPropertyChangeListener
385          if ( m_xPropertyChangeListener.is() )
386          {
387              // remove listener
388              try
389              {
390                  m_xReportComponent->removePropertyChangeListener( OUString() , m_xPropertyChangeListener );
391              }
392              catch(const uno::Exception &)
393              {
394                  OSL_FAIL("OObjectBase::EndListening: Exception caught!");
395              }
396          }
397          m_xPropertyChangeListener.clear();
398      }
Either in the try after the remove or in a finally if we don't want to care about catch part.
(see https://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#377)
But considering the 2008 commit and the former state before it, it seems it was on purpose to put m_bIsListening in all cases so...

Change-Id: I7db8ba45d915e28e707cea61d16ef94fc13b969a
Reviewed-on: https://gerrit.libreoffice.org/56898
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

c8d8fdea

sw user field type: fix locale of string -> float conversion · 6ca5d288

Miklos Vajna Agu 02, 2018 yazdı

The key part is the SwUserFieldType::GetValue() hunk, the field type has
to always use the same locale, which means if we get an SwCalc reference
that works with the document or field locale that has to be switched
temporarily.

Change-Id: I26ff18e74f477729a66b066c4baf6d215a7685bc
Reviewed-on: https://gerrit.libreoffice.org/58492Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

6ca5d288

Add missing sal/log.hxx headers · 82828c6c

Gabor Kelemen Tem 28, 2018 yazdı

rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.

Change-Id: Ia7f773511624099505d6a36a8d6e23c0cde4a737
Reviewed-on: https://gerrit.libreoffice.org/58225
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

82828c6c

tdf#116350 Import preset text geometry (text effects) · bf342011

Szymon Kłos Tem 20, 2018 yazdı

"Font effect" implementation, instead of normal
text, content is converted to "fontwork".

Change-Id: I5d02c7faedb66a4b919e64ae1b830bffb69984c1
Reviewed-on: https://gerrit.libreoffice.org/58358
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

bf342011

WITH_HELPPACK_INTEGRATION is no longer substituted · 587d2c03

Stephan Bergmann Agu 02, 2018 yazdı

...since 255bfc28 "WITH_HELPPACK_INTEGRATION
isn't substituted anywhere"

Change-Id: I59d8befc55b36cc32096f75217d91bccc8b72160
Reviewed-on: https://gerrit.libreoffice.org/58474
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

587d2c03

Notebookbar: Added shortcuts toolbox in draw · 7489dd5a

Kshitij Pathania Agu 02, 2018 yazdı

Change-Id: Icb1dbc5539c1fe64c2ee4906602578460860e9c8
Reviewed-on: https://gerrit.libreoffice.org/58464
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

7489dd5a

add invalid argument check to HandleIIOpCode() · 983b234b

Luboš Luňák Agu 02, 2018 yazdı

This should have been part of 6b8be4b2aaca5.

Change-Id: I6f0263b014d0d7aa4622884922bca218c85ce29d
Reviewed-on: https://gerrit.libreoffice.org/58473
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

983b234b

loplugin:expressionalwayszero · 89f2d244

Stephan Bergmann Agu 02, 2018 yazdı

...after d3e7bbec "coverity#1438196 deliberate
'Constant' variable guards dead code", so finally just remove the code guarded
by always-false bSupportSvtGraphicFill, which has been dead ever since
70e3eb2c "Resolves: #i121267# added support for
taking clipping into account..." introduced bSupportSvtGraphicFill

Change-Id: I0d95e7346c2bfd29de51ae2e4253e8298e143333
Reviewed-on: https://gerrit.libreoffice.org/58469
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

89f2d244

loplugin:returnconstant in filter · 6008cfd6

Noel Grandin Agu 01, 2018 yazdı

Change-Id: I0ebbd835ddc50e984920950e1559faf163c2c30f
Reviewed-on: https://gerrit.libreoffice.org/58429
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6008cfd6

ALLOC is no longer substituted · f53470d1

Stephan Bergmann Agu 02, 2018 yazdı

...since db354dfa "the custom SAL allocator is
no longer used"

Change-Id: Ie4cca54568091f20448997bb4eae7e01230572bf
Reviewed-on: https://gerrit.libreoffice.org/58471
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

f53470d1

Fix dependency · 66467726

Mike Kaganski Agu 02, 2018 yazdı

Change-Id: Iff0fa9e4bdc8e7498805fbe2553f67df5c6db744
Reviewed-on: https://gerrit.libreoffice.org/58465
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

66467726

Access2Base - Fix undeclared variable · 8c65831e

Jean-Pierre Ledure Agu 02, 2018 yazdı

CloseConnection: error handling is switched off
Error was not user visible but left connection(s) unclosed.

8c65831e

[API CHANGE] add some more asserts to the string functions · 2f3684b2

Noel Grandin Tem 31, 2018 yazdı

rtl_[u]String_alloc now requires that the length be >= 0.
Since this function is only @since Libreoffice 4.1, it is unlikely
to be widely used externally.

Removed some unit tests that were testing invalid or out of
range paramers, which are already not allowed according to the
documented contract of those functions.

The change in writerfilter is because the new asserts triggered
when running testFdo74745

The change in SwTextNode::EraseText is because testFdo60842
triggered the assert in replaceAt.

The change in SwFieldSlot::SwFieldSlot is because
testMoveRange::Import_Export_Import triggered the assert in
replaceAt.

The changes in SwFieldSlot::SwFieldSlot and TabControl::ImplGetItemSize
are due to failures in the uitests.

Change-Id: Ib317261067649b0de96df12873ce31360cd24681
Reviewed-on: https://gerrit.libreoffice.org/58390Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2f3684b2

Directly prevent multiple change broadcasts · 4804a147

Armin Le Grand Agu 01, 2018 yazdı

Instead of using members in SdrObject and a class
(SdrDelayBroadcastObjectChange) to prevent special,
selected SdrObnjects from executing BroadcastObjectChange,
use existing possibilities.

Change-Id: Iccab28249cfdc73219143b681495c84d7f520b62
Reviewed-on: https://gerrit.libreoffice.org/58451
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

4804a147

Add missing sal/log.hxx headers · bd832095

Gabor Kelemen Tem 28, 2018 yazdı

Change-Id: If562b1aa1d676d2c1cf513e953238abbb846c65c
Reviewed-on: https://gerrit.libreoffice.org/58224
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

bd832095

Update git submodules · 1e9f594f

Olivier Hallot Agu 01, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - New 6.1 video for module's help entry pages
    
    Must be cherry-picked to 6.1 branch
    
    Added localize=false to prevent translation. Translation
    will be displayed in captions.
    
    Note: videos and collateral files are available in help online
    ONLY
    
    Change-Id: If57a384783a2e31c90b069c1f0b33746d569f800
    Reviewed-on: https://gerrit.libreoffice.org/58433
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

1e9f594f

Use memcpy for string ImplNewCopy functions · 12af39cf

Noel Grandin Tem 29, 2018 yazdı

Change-Id: If0072a2fd7d3111b48413143610025124f365207
Reviewed-on: https://gerrit.libreoffice.org/58275
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

12af39cf

forcepoint#67 null deref · 0327615c

Caolán McNamara Agu 01, 2018 yazdı

Change-Id: I666c6b1795e037d3bb74d4ccc33be0e161bfb157
Reviewed-on: https://gerrit.libreoffice.org/58444
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

0327615c

forcepoint#66 make sure we don't get stuck endlessly reparsing · e7a44268

Caolán McNamara Agu 01, 2018 yazdı

Change-Id: Ie2733e8d7f73e5f6a072604c477e949cd944189a
Reviewed-on: https://gerrit.libreoffice.org/58441
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

e7a44268

loplugin:stringloop in various · d5415561

Noel Grandin Agu 02, 2018 yazdı

Change-Id: Ia400e67108e622ae63a8d59667eae96c858f22dc
Reviewed-on: https://gerrit.libreoffice.org/58463
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

d5415561

coverity#1438196 deliberate 'Constant' variable guards dead code · d3e7bbec
Caolán McNamara Agu 02, 2018 yazdı
```
Change-Id: I8b4cec8c82a5d1eb57d96908b784bbc2704ac8fa
```
d3e7bbec
coverity#1438197 deliberate 'Constant' variable guards dead code · 6c3067a5
Caolán McNamara Agu 02, 2018 yazdı
```
Change-Id: I4fb8a0bcfb3785fbd144ab25adbe6505684dc8c4
```
6c3067a5

forcepoint#67 detect cairo surface creation failure · 3a00d7bb

Caolán McNamara Agu 01, 2018 yazdı

if e.g. too large

Change-Id: I7de8748a5ed695c1b3ddc8c1358414f3acd68c94
Reviewed-on: https://gerrit.libreoffice.org/58453
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

3a00d7bb

libxmlsec windows: no longer build the mscrypto backend · 22f60a3e

Miklos Vajna Agu 01, 2018 yazdı

Only the mscng one is used.

Change-Id: Ic8716cd465b2631da56f47d36811731be205fc3e
Reviewed-on: https://gerrit.libreoffice.org/58446
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

22f60a3e

Revert rtl_alloc_preInit back to boolean argument · e3c0b6e6

Stephan Bergmann Agu 01, 2018 yazdı

This effectively reverts 271a663d "rtl: support
start/stop threads around pre-init" again, now that
df6ba650 "Remove 'officially dead now' rtl_cache
slab allocator mechanism" removed the wsupdate thread.

(rtl_alloc_preInit is an internal-use-only C function, so changing its arguments
doesn't affect URE compatibility.)

Change-Id: Ie9bce86377f9520e2600e4111ac525dddace10f8
Reviewed-on: https://gerrit.libreoffice.org/58443
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

e3c0b6e6

loplugin:returnconstant in cui,desktop · df6270e9

Noel Grandin Agu 01, 2018 yazdı

Change-Id: Ieec9e3d9e2e18add9a1bc7e0e15bb8435ea51954
Reviewed-on: https://gerrit.libreoffice.org/58428
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

df6270e9

tdf#119029: also export rotation for data series · 8f904928

Mike Kaganski Agu 01, 2018 yazdı

Change-Id: I6a9895145e0c54d35bf404f209721a0c718e4446
Reviewed-on: https://gerrit.libreoffice.org/58401
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

8f904928

01 Agu, 2018 4 kayıt (commit)

tdf#119042: Also check if SfxViewFrame::Current() is nullptr · d0a481d0

Mike Kaganski Agu 01, 2018 yazdı

Change-Id: I5ac43ff626bfb4e2e754cacead5bf87115f3ce4b
Reviewed-on: https://gerrit.libreoffice.org/58447Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Jenkins

d0a481d0

NB calc: add tabbed compact layout to calc · 89fd0dff

andreas kainz Tem 29, 2018 yazdı

similar to writer

Change-Id: Id8e6e2f658228a86a8460e879f1e2942a8209664
Reviewed-on: https://gerrit.libreoffice.org/58284
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

89fd0dff

forcepoint#66 protect against infinite parse recurse · 84aa79f5

Caolán McNamara Agu 01, 2018 yazdı

Change-Id: I0313cc141469a00b7d6a5bd15400e9d5a8f686cf
Reviewed-on: https://gerrit.libreoffice.org/58440
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

84aa79f5

loplugin:returnconstant in chart2 · d1ea4db0

Noel Grandin Agu 01, 2018 yazdı

Change-Id: If44096ccf8d176023a1b7b8ae722e04417e4c131
Reviewed-on: https://gerrit.libreoffice.org/58425
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

d1ea4db0