- 15 Ock, 2019 40 kayıt (commit)
-
-
Bjoern Michaelsen yazdı
Change-Id: I173f8e2e74d4892f259fb62b623cad87523bc990 Reviewed-on: https://gerrit.libreoffice.org/66334 Tested-by: Jenkins Reviewed-by:
Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
-
Justin Luth yazdı
LIKELY TO EXPOSE SECTION EXPORT/IMPORT PROBLEMS. That is already happening somewhat because support for forms/protected sections was added in LO6.2. By making this change, it will help to expose problems faster, with the hope that they can still be fixed for 6.2. Columns in page styles are very problematic, because it doesn't let you override the number of columns (except to put sub-columns inside one of the existing columns). So, always attempt to insert a column into it's own section, and never into the page style itself. I'm rather excited that this didn't cause any unit test failures. I've made a lot of section fixes over the years (and some this week which are required for the unit test to work). This change seems very natural, and gets rid of a regression-prone hack. I found all of the existing unit tests with columns and tested them. About 10 files - all look fine including complex files tdf81345.docx and tdf104061_tableSectionColumns.docx Change-Id: If02f1bfd91b1cf8210665244d0782ff926cc2869 Reviewed-on: https://gerrit.libreoffice.org/65557 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org>
-
Justin Luth yazdı
The new XATTR_FILL* was introduced a few years ago and the UI changed to that, but .doc import was still importing into RES_BACKGROUND and although the property showed up OK, it couldn't be changed or seen by the UI and somehow hidden/unavailable as UNO properties. Change-Id: Iea1805a321a306994ab23bb66a354dca8e3a3d40 Reviewed-on: https://gerrit.libreoffice.org/64186Reviewed-by:
Justin Luth <justin_luth@sil.org> Tested-by:
Justin Luth <justin_luth@sil.org>
-
Jens Carl yazdı
Move XIndexAccess Java tests to C++ for ScStyleFamiliesObj. Change-Id: I19f783597656a1e429ea592115497e11e8a0a6a2 Reviewed-on: https://gerrit.libreoffice.org/66346 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
Jens Carl yazdı
Move XNameAccess Java tests to C++ for ScStyleFamiliesObj. Change-Id: Ief102954b4393ab54747bbe1ea4f7f5b0346393e Reviewed-on: https://gerrit.libreoffice.org/66345 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
Stephan Bergmann yazdı
...while being careful to keep initializing *ustrName to an empty string when returning false (whether or not client code relies on that detail) Change-Id: Idd079a0b5a31b844287048dce57bf0fafcc32d1d Reviewed-on: https://gerrit.libreoffice.org/66388 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Michael Stahl yazdı
A frame that is fully hidden does not have a SwParaPortion, see SwTextFrame::Format() early return. (regression from 9bda4a67) Change-Id: I6b06824e53cef7218b60f60fced8f863adad8b62 Reviewed-on: https://gerrit.libreoffice.org/66385 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Mike Kaganski yazdı
... using svt::AcceleratorExecute to detect user-configurable key combinations. Change-Id: Iad4f6d3e0becfb896d4b4342c819c98e04789a1c Reviewed-on: https://gerrit.libreoffice.org/66377 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Caolán McNamara yazdı
Change-Id: Iee42beb96ff4d059c685173fdde453981b300b3c Reviewed-on: https://gerrit.libreoffice.org/66360 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
heiko tietze yazdı
Fix values for toolbar expander triangles with 7px resp. 4px depend now on the actual toolbar height. Change-Id: I0241e3cfa9472bfbd2533afa84bcbfd9ef92c920 Reviewed-on: https://gerrit.libreoffice.org/66166 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com>
-
heiko tietze yazdı
By default on now Change-Id: I7619d290e3dd9032b765057b8878d5dad035eafc Reviewed-on: https://gerrit.libreoffice.org/66351 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com>
-
andreas kainz yazdı
textobjectbar are now the same in all sw modules orientation was removed cause it's page orientation instead of text orientation Change-Id: I3d1f32d426d6266f7482b93f55fa847d639d91aa Reviewed-on: https://gerrit.libreoffice.org/66174 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Noel Grandin yazdı
Change-Id: I76ca0cd28b4c6a95d9021c760f61db982283377b Reviewed-on: https://gerrit.libreoffice.org/66313 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: I04c078257fd9290ca17410b4833828f7f6bfd266 Reviewed-on: https://gerrit.libreoffice.org/66352 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
#0 std::__uniq_ptr_impl<sw::MergedPara, std::default_delete<sw::MergedPara> >::_M_ptr (this=0x108) at include/c++/8.2.0/bits/unique_ptr.h:150 #1 0x00007f759b5ef71e in std::unique_ptr<sw::MergedPara, std::default_delete<sw::MergedPara> >::get (this=0x108) at include/c++/8.2.0/bits/unique_ptr.h:343 #2 0x00007f759b870d00 in SwTextFrame::GetMergedPara (this=0x0) at sw/source/core/inc/txtfrm.hxx:437 #3 0x00007f759be822f9 in sw::GetAttrMerged (rFormatSet=SfxItemSet of pool 0x4aae540 with parent 0x0 and Which ranges: [(68, 68), (90, 91)] = {...}, rNode=..., pLayout=0x4b6f490) at sw/source/core/text/txtfrm.cxx:378 #4 0x00007f759bf47a53 in SwTextNode::GetParaAttr (this=0x51bf980, rSet=SfxItemSet of pool 0x4aae540 with parent 0x0 and Which ranges: [(68, 68), (90, 91)] = {...}, nStt=0, nEnd=0, bOnlyTextAttr=false, bGetFromChrFormat=true, bMergeIndentValuesOfNumRule=true, pLayout=0x4b6f490) at sw/source/core/txtnode/thints.cxx:2072 #5 0x00007f759baea5cc in SwEditShell::GetPaMAttr (this=0x50e7050, pPaM=0x4b42e38, rSet=SfxItemSet of pool 0x4aae540 with parent 0x0 and Which ranges: [(68, 68), (90, 91)] = {...}, bMergeIndentValuesOfNumRule=true) at sw/source/core/edit/edattr.cxx:144 #6 0x00007f759baea772 in SwEditShell::GetCurAttr (this=0x50e7050, rSet=SfxItemSet of pool 0x4aae540 with parent 0x0 and Which ranges: [(68, 68), (90, 91)] = {...}, bMergeIndentValuesOfNumRule=true) at sw/source/core/edit/edattr.cxx:184 #7 0x00007f759c733449 in SwView::StateTabWin (this=0x4e28f10, rSet=SfxItemSet of pool 0x4aae540 with parent 0x0 and Which ranges: [(10082, 10082), (10084, 10084), (10415, 10415)] = {...}) at sw/source/uibase/uiview/viewtab.cxx:1234 #8 0x00007f759c6f8c83 in SfxStubSwViewStateTabWin (pShell=0x4e28f10, rSet=SfxItemSet of pool 0x4aae540 with parent 0x0 and Which ranges: [(10082, 10082), (10084, 10084), (10415, 10415)] = {...}) at workdir/SdiTarget/sw/sdi/swslots.hxx:13525 Change-Id: I126a043ad3dc274da629a9a4efe349eafd85b485 Reviewed-on: https://gerrit.libreoffice.org/66326 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icebcf1a6ab073dce935a74ce79ee0f302b62e8a8 Reviewed-on: https://gerrit.libreoffice.org/65947 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Stephan Bergmann yazdı
...after 23a8d5ff "Upgrade external/boost to Boost 1.69.0", where at least some GCC versions apparently choke on -Wundef there even though going through external/boost/include/boost/optional.hpp with #pragma GCC diagnostic ignored "-Wundef" (<https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/23929/>): > In file included from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/core/explicit_operator_bool.hpp:22:0, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/optional/optional.hpp:30, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/external/boost/include/boost/optional/optional.hpp:27, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/optional.hpp:15, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/external/boost/include/boost/optional.hpp:27, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/vcl/outdevstate.hxx:31, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/vcl/outdev.hxx:39, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/vcl/window.hxx:25, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/vcl/ctrl.hxx:25, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/vcl/fixed.hxx:25, > from /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/comphelper/source/misc/xmlsechelper.cxx:25: > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/type_traits/detail/config.hpp:85:69: error: "__clang_major___WORKAROUND_GUARD" is not defined, evaluates to 0 [-Werror=undef] > && !BOOST_WORKAROUND(BOOST_MSVC, < 1900) && !BOOST_WORKAROUND(__clang_major__, <= 4) > ^ > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/config/workaround.hpp:253:10: note: in definition of macro ‘BOOST_WORKAROUND’ > ((symbol ## _WORKAROUND_GUARD + 0 == 0) && \ > ^~~~~~ > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/type_traits/detail/config.hpp:85:69: error: "__clang_major__" is not defined, evaluates to 0 [-Werror=undef] > && !BOOST_WORKAROUND(BOOST_MSVC, < 1900) && !BOOST_WORKAROUND(__clang_major__, <= 4) > ^ > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UnpackedTarball/boost/boost/config/workaround.hpp:254:9: note: in definition of macro ‘BOOST_WORKAROUND’ > (symbol != 0) && (1 % (( (symbol test) ) + 1))) > ^~~~~~ Change-Id: I9fe6bf0019fcddad7e1b5606a162474130a9250e Reviewed-on: https://gerrit.libreoffice.org/66349 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Michael Stahl yazdı
Change-Id: I44e969d8d3a8fe6b6426d61a1cbe83154c8518dd Reviewed-on: https://gerrit.libreoffice.org/66329 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
fixes CVE-2018-16840 Change-Id: Ica995a28a71eb5d5277d045d57fee9ba0f88883f Reviewed-on: https://gerrit.libreoffice.org/66328 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
Change-Id: Ifc64dae74df341e107857e43223ead04b9c1061e Reviewed-on: https://gerrit.libreoffice.org/66309 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
* fixes CVE-2018-14404 * drop one hunk from libxml2-android.patch that was added in commit 6a17d2f2; presumably nan() exists now given that other code is calling it. Change-Id: I696cc4e1da55536ea1c89a6e0446ce5bc8398ba4 Reviewed-on: https://gerrit.libreoffice.org/66308 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
Change-Id: If20998f8565b5534a96b3f29ccec572273edca1d Reviewed-on: https://gerrit.libreoffice.org/66306 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
... which has removed Guchar, Gushort, Guint, Gulong... Change-Id: Ia54ad378031f167f6779f6ffe574b85c1e72f26d Reviewed-on: https://gerrit.libreoffice.org/66305 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Caolán McNamara yazdı
Change-Id: I8a9ec82d46a3df04554c139264755c8f28f5e897 Reviewed-on: https://gerrit.libreoffice.org/66335 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I29ab070f9664939d1e10d1cccb2a62cfdc0570e7 Reviewed-on: https://gerrit.libreoffice.org/66337 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Miklos Vajna yazdı
This was a problem since RtfAttributeOutput::NumberingLevel() started to use OutputItemSet() or when m_aStyles and m_aStylesEnd was separated, but both were already like this in commit 5bbc027d (cws-vmiklos01.diff: Better RTF export filter, 2010-09-17). If m_aStylesEnd is not consumed by NumberingLevel(), then the first run will include its contents, which is incorrect. Change-Id: Ifc93ae5f0057102fab636febae5ee2462361878e Reviewed-on: https://gerrit.libreoffice.org/66332 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Noel Grandin yazdı
Change-Id: Icc946b986f62d986e979e6a3f3ba0d2c28cb9adf Reviewed-on: https://gerrit.libreoffice.org/66312 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Mike Kaganski yazdı
... to not leak temporary cat files Change-Id: I99e230054f1a3ed6aabce63d427483808e969716 Reviewed-on: https://gerrit.libreoffice.org/66343 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Stephan Bergmann yazdı
<https://dev-www.libreoffice.org/src/boost_1_69_0.tar.bz2> is a copy of <https://dl.bintray.com/boostorg/release/1.69.0/source/boost_1_69_0.tar.bz2>, SHA256 hash as given at <https://www.boost.org/users/download/>. * removed from external/boost/include/boost/ those files that are no longer present in workdir/UnpackedTarball/boost/boost/ * the shrunk external/boost/rtti.patch.0 can probably be removed completely in a follow-up commit * the patch to libs/filesystem/src/operations.cpp in external/boost/boost-android-unified.patch.1 no longer applied, and appears to be no longer necessary anyway (seeing a working build without it of --with-distro=LibreOfficeAndroid and NDK r16b); but with the non-standard Clang 5.0.300080 from NDK r16b, the build now caused failures like > workdir/UnpackedTarball/boost/boost/type_traits/detail/is_function_cxx_11.hpp:36:11: error: class template partial specialization contains a template parameter that cannot be deduced; this partial specialization will never be used [-Wunusable-partial-specialization] > struct is_function<Ret BOOST_TT_DEF_CALL(Args...)BOOST_TT_NOEXCEPT_DECL> : public true_type {}; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > workdir/UnpackedTarball/boost/boost/type_traits/detail/is_function_cxx_11.hpp:35:38: note: non-deducible template parameter 'NE' > template <class Ret, class...Args BOOST_TT_NOEXCEPT_PARAM> > ^ > workdir/UnpackedTarball/boost/boost/type_traits/detail/is_function_cxx_11.hpp:22:40: note: expanded from macro 'BOOST_TT_NOEXCEPT_PARAM' > #define BOOST_TT_NOEXCEPT_PARAM , bool NE > ^ showing that that version of Clang has the same problem handling noexcept(b) as a deduced template parameter as MSVC has, as already supported by the code * new external/boost/sse.patch.0 needed on Windows x86 to silence errors like > C:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/type_traits/detail/is_function_cxx_11.hpp(111): error C2215: '__vectorcall' cannot be used with '/arch:SSE' (<https://ci.libreoffice.org/job/gerrit_windows/26117/>); according to <https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros ?view=vs-2017>: "_M_IX86_FP Defined as an integer literal value that indicates the /arch compiler option that was set, or the default. This macro is always defined when the compilation target is an x86 processor. Otherwise, undefined. When defined, the value is: [...] 1 if the /arch:SSE compiler option was set." and we specify /arch:SSE explicitly for Windows x86 since 8bd6bf93 "fdo#82430: configure: MSVC build: avoid using SSE2 instructions" * boost::logic::tribool conversion operator to bool is explicit now Change-Id: Iea49560d734f545539f062dce46740fbf812dd84 Reviewed-on: https://gerrit.libreoffice.org/66189Reviewed-by:
Stephan Bergmann <sbergman@redhat.com> Tested-by:
Stephan Bergmann <sbergman@redhat.com>
-
Arkadiy Illarionov yazdı
Loop iterates over children to set their state 7967e5e5 follow-up Change-Id: I425b3204fb3581a22e9ed2b00c7b8c24ed2060a8 Reviewed-on: https://gerrit.libreoffice.org/66333 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Andrea Gelmini yazdı
Change-Id: I8a91600a6559decf5b9a8a576d91a6401c6b92d9 Reviewed-on: https://gerrit.libreoffice.org/66342 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Arkadiy Illarionov yazdı
Use range-based loop or replace with STL functions Change-Id: I7ab254241ff5b9637ac28282ad0868b3c55a1fb3 Reviewed-on: https://gerrit.libreoffice.org/66135 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I01b7b42d626a29b0702cc2aa51d0fdeb75282740 Reviewed-on: https://gerrit.libreoffice.org/66320 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I02026ffd808fa4939666c791c476cd0c0632cde3 Reviewed-on: https://gerrit.libreoffice.org/66319 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I104168fbbd04f81d500bc9d63d4328aee0a11f24 Reviewed-on: https://gerrit.libreoffice.org/66318 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I8c472a7d363eb308e9ec78aadd7f1f20c824447b Reviewed-on: https://gerrit.libreoffice.org/66317 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
the erase on the preceding line will delete it, ever since commit a846c710 Date: Wed Jul 25 12:26:15 2018 +0200 loplugin:useuniqueptr in SwGlossaryList Change-Id: I8f71bca8eebf762aeea3225d3a3b52ec2ac60e19 Reviewed-on: https://gerrit.libreoffice.org/66316 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
no need to use heap objects here Change-Id: Iadc35b019da7b9446ede79c96a9d8ce8c6db81ef Reviewed-on: https://gerrit.libreoffice.org/66315 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ib83be524b5c15e4639a834494726501ac7aa6755 Reviewed-on: https://gerrit.libreoffice.org/66314 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I369ef79e88a40c01f5384e2427c3dec429ea0457 Reviewed-on: https://gerrit.libreoffice.org/66311 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-