Change-Id: I1a52e05994d6a31aa5e65bc3357f48258fb6f049

Removed in commit f4826959
"new loplugin:unusedenumconstants".
And add a comment.

Change-Id: I63d6f46aa92e31db08e51e47a62104dc7d3d3359
Reviewed-on: https://gerrit.libreoffice.org/34057Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and drop read-only enumerators

Change-Id: Ibc4c2a99448a83fc179e2779f8f3e5c8f034ae7b
Reviewed-on: https://gerrit.libreoffice.org/34059Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7ba75517dc68f5fd977f140b6a7e37fbfe1fcf7f
Reviewed-on: https://gerrit.libreoffice.org/33914Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

since we only use the AsciiCString enumerator.
Consequently simplify the GetConnectionIdentifier method

Change-Id: I9e1a1318d2f12bfd18edeb8479e0e7171b22d0f1
Reviewed-on: https://gerrit.libreoffice.org/34026Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

and drop some read-only enumerators

Change-Id: I96380efec90abe02fa02c3f766f2b6180723da0d
Reviewed-on: https://gerrit.libreoffice.org/34058Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...by using glibc's backtrace_symbols(3).  If this is ever implemented for other
platforms, backtrace_symbols' interface may turn out to be awkward; but just use
it directly for now.  Also, the output from backtrace_symbols isn't too useful
in itself, as for non-exported symbols it only prints soname+offset, but some
addr2line postprocessing can turn that into something half-way decent.

Change-Id: I58cc7912aa7d8031729fc116a82a409c1c16977a

...after 56d071c1 "rename SAL_DEBUG_TRACE to
SAL_DEBUG_BACKTRACE" (looks like this doesn't get used much...)

Change-Id: I1d653775e88e9fa2ba7b62fce39d52fc21ffe363

Change-Id: If26e39fedc1687ceb08d3e8663f95f4d84b5c488

Change-Id: I8e35594104ba85470eda387bc227e88bf77ccffd

Change-Id: Ic7fe2dec012efb8ba180feb4d3df6f4bfbf6c38a

Change-Id: Id5577ae0b3bdf31b6d5e409cd2c0033d9f2591a2
Reviewed-on: https://gerrit.libreoffice.org/34046Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

and drop unused INVERT enumerator

Change-Id: I6db12ff76a5515bcb4691403b8fb380f9d74c1c9
Reviewed-on: https://gerrit.libreoffice.org/34055Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators

Also fix a bug in x11::convertBitmapDepth where we were incorrectly
passing BmpConversion enumeratirs to ReduceColors

Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242
Reviewed-on: https://gerrit.libreoffice.org/34062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Explorer file view option in Settings is working now.
To listen to the preference updates in the app
a custom class SettingsListernerModel has been added.
SettingsListenerModel.java file contains the methods
to instantiate and set OnSettingPreferenceChangedListener
in the implementing class.
LibreOfficeUIActivity implements this listener
and it is triggered by onSharedPreferenceChanged() method
in SettingsActivity.
This class can also be used to listen to other preference changes
in Settings.

Change-Id: I063024df01cf183d2a6211648e32805795af20a9
Reviewed-on: https://gerrit.libreoffice.org/34012Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>

Change-Id: Ieb8f90be8effde5f25bc872784c3ea2177b14bf9
Reviewed-on: https://gerrit.libreoffice.org/34056Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie5642709b0befe49f8d31fe73867b541a0ea11a9
Reviewed-on: https://gerrit.libreoffice.org/34032Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

ScRTFColTwips is a vector with some extra logic

Change-Id: I1ef08152d57f73404d08a566e311fdbe8934f68c
Reviewed-on: https://gerrit.libreoffice.org/34047Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

use unique_ptr for ScEEParser.

mpParser needs mpEngine to initialise.
declare, construct and destruct in right order.
make use of virtual dtor of mpParser.

let dtor default for ScRTFImport and ScHTMLImport (they have
no own members).

Change-Id: Ic6f830df121d687084ea394e68a37797e53f7108
Reviewed-on: https://gerrit.libreoffice.org/34044Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iaad3a9784d2ad30f2c04f18e9987446238425c6b
Reviewed-on: https://gerrit.libreoffice.org/34043Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iac60817702f7691adbabdea8a59efc4f56f249da
Reviewed-on: https://gerrit.libreoffice.org/34042Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This effectively reverts commit 32cae6a2.

Change-Id: I15bb0a5c4acaeee6d47dd93a71601d9687d701bc
Reviewed-on: https://gerrit.libreoffice.org/34028Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia3da23e0ef2fa710403745bd11255ed001516da4
Reviewed-on: https://gerrit.libreoffice.org/34020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Just do like other platforms, so that the fonts are avialble to unit tests
since cppunittester is not run from instdir.

Change-Id: Ib209473f5b6b07a154fecb430dca45b32e8fa556
Reviewed-on: https://gerrit.libreoffice.org/34048Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: Ib318c3ff14970483fdcda1fdd6de9969f47ccbe8
Reviewed-on: https://gerrit.libreoffice.org/33647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: Ib8f7b3793732a113e764c4345c07803eb8bcbc3f
Reviewed-on: https://gerrit.libreoffice.org/33196Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

I assume this is a compiler bug, the patch can be dropped when we don't
build on this baseline anymore.

Change-Id: Ic65f830b888864db075efefd5b2e5d2520d9213e
Reviewed-on: https://gerrit.libreoffice.org/34033Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I4061f9f421666064f918d8a46375f7f770626ab6

Change-Id: I64d7e39506495e9fcc78bb670b897338a01a9ae1

Change-Id: I275e96ce3761b61b62748a1e75f1a7a88640e7cf

For SVG there are 2 draw:image children in the draw:frame, and the
SdXMLEventContext::EndElement() applies the content of
office:event-listeners to the shape created from the last draw:image
and then MultiImageImportHelper::solveMultipleImages() throws
it away because it's the bitmap fallback of the SVG.

Avoid that problem by calling solveMultipleImages earlier:
The ODF schema ensures that all the draw:image elements occur before
the optional property-bearing child elements of draw:frame,
so we just call solveMultipleImages on the first such optional
element, so that all subsequent properties get applied to the one
surviving shape.

(likely regression from 44cfc7cb)

Change-Id: I2be5f6f424dbfd90ca2179ce6f9057929540e762

Change-Id: Ieaee60607200973f8d725d19a9c63bdc2f230850

Change-Id: I7cd699632b05ac8de6c5e3a6dbc66b8de7d88054

Change-Id: I4abce924a89f611c28d0441ae097b310193b5dae

no logic changed intended, SetPixelIndex expands
to this, just want to clarify that this is an alpha
value, not an index into a palette

Change-Id: Ie9bb188b116adf3eab4e2bb1d6da8badbaead88b

Change-Id: I402f5485af0c1e60677b8291c879bc7ca14633d3

Change-Id: I957a8f1396425eda8530417aecfde6a70570d058
Reviewed-on: https://gerrit.libreoffice.org/33922Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ic313ce3807c9b16563cc3421a84d1d28dab54670
Reviewed-on: https://gerrit.libreoffice.org/33928Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ieb3065d899099804a598e0750799810195c36343
Reviewed-on: https://gerrit.libreoffice.org/33921Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>