Change-Id: Iad71c4f79dbe03e2e325453eb0506a2d92d67c2d
Reviewed-on: https://gerrit.libreoffice.org/36891Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia2f54b536a4262e19abe260e8e19c9b15cc2d0ec
Reviewed-on: https://gerrit.libreoffice.org/36779Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... because that calls CompressRedlines, which may combine the new
redline with a previous one.

In that case, the part of the new redline that follows the currently
handled overlap cannot be checked for overlaps with subsequent existing
redlines.

So prevent this with a new flag m_isForbidCompressRedlines and instead
call CompressRedlines() at the end of AppendRedline().

Change-Id: I7567962c31366ded9a433a13232d3db985745e43
Reviewed-on: https://gerrit.libreoffice.org/36901Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic8bd538e80469b672ddd9c5fcceb2f5aac81d2a1
Reviewed-on: https://gerrit.libreoffice.org/37051Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4c348ee56ae3e90513c8ebd19e0f506bbf0d70f0

Change-Id: I2b4f0680f4adedc5661c6a9d2556ac3ecf2c4659
Reviewed-on: https://gerrit.libreoffice.org/38311Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Leave the macros in place for now, because there is still more of this
stuff in sc/../xestream.hxx

Change-Id: I633e12ee572010823e0a223b529a07b00e707b78
Reviewed-on: https://gerrit.libreoffice.org/38295Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I61079e041a79195f9e9cb77ce80368ef7e909cef
Reviewed-on: https://gerrit.libreoffice.org/38288Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: I3f22301e4301ab90e4a1090f2c47cf2403422282
Reviewed-on: https://gerrit.libreoffice.org/38309Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fixes regression from 73661c6f

Not sure why these need their own scp2 Module

Change-Id: I26386a5105b8244eacfcb1760091e8806c55abd8

Change-Id: I65f95e7245f08592ea11cc75e1cf34dcbdf16b40

Change-Id: Ie0c0e68512e92879774c754c89354e2c83cd149b
Reviewed-on: https://gerrit.libreoffice.org/38300Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This way at export time we can preserve the correct content-type, which
isn't the same for DOCX and DOCM.

Change-Id: I08fa734c72fab7400bd327a07a760839556dbf6f
Reviewed-on: https://gerrit.libreoffice.org/38298Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Iba155637cbbdfc5d6b3a427372695d4d03319621
Reviewed-on: https://gerrit.libreoffice.org/38297Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I39a7ccedc94a0427b20d03f513255aa00f02baab

Project: help  465e8ac1bbd9d6605b73f906acfee980f352947b

helpcontent2: rename postprocess_helpimages to helpcontent2_helpimages

Change-Id: Ie8cc9e4cca21201b16bf0b1aae185d692cf0c214

Project: help  b726222b3b24c87972e772bb5f20e620784cfae5

helpcontent2: fix incremental rebuild of *.ilst files

They only depend on the perl script so won't get rebuild if images are
added or removed in source/media/

Use the same hack as in postprocess, make the targets PHONY so they
always get rebuilt.

Also fix a stray \ that caused the wrong output "[PRL] " to be printed
too early.

Change-Id: I03c8696591cf47395211feaed360fbd5642733a0

(regression from 99b7c4f5)

Change-Id: I2c3c0478a12e86d78074a8e1b25818de32d4b091

Change-Id: Iabc62f8166cb4f2013fc6c2908c8172f9acb0336
Reviewed-on: https://gerrit.libreoffice.org/38294Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

should not have been committed in the first place, was an accident

Change-Id: Ie38cc77624bae5b3f9cc110085d0fe19b26c75c6

Otherwise it was disposed in the middle of its own mouse event handler
FuSelection::MouseButtonUp().

Change-Id: I0d96048526dece7232e5a777364ad4da1d64c904
Reviewed-on: https://gerrit.libreoffice.org/37976Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56
Reviewed-on: https://gerrit.libreoffice.org/38208Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic7fbd750321e4cfde1cfb0e04ffb545bb1f66d9c
Reviewed-on: https://gerrit.libreoffice.org/37921Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic336b33bd747cd55955231cbe0b5a9d474adf3ab

Change-Id: If48795746adecf6762a5f1173171c62faf1ac345
Reviewed-on: https://gerrit.libreoffice.org/38290Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic5250563b7dc9c19771d3f728d2087ef335ceb46
Reviewed-on: https://gerrit.libreoffice.org/38279Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

If clipping is requested, but no clipping region is defined,
clipping is ignored.

Change-Id: I793c1de1f4f6b0203727c0ff6aa8adecc43ad413
Reviewed-on: https://gerrit.libreoffice.org/38021Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18

Change-Id: I5c39a745b70655f92953ec785d01a3a52d9ec42b

Change-Id: I8c1a01fa54addfdf78eaff45952e306de812e954
Reviewed-on: https://gerrit.libreoffice.org/38128Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

the change-tracking side bar in experimental mode as well as the usual
dialog

Change-Id: Ic4d652d0d125b883bef0d91e4ab3cee4a9f84284

ASAN reports this about JunitTest_chart2_unoapi

==27381==ERROR: AddressSanitizer: heap-use-after-free on address 0x6060005bd218 at pc 0x7ff229755271 bp 0x7fffb52c6c30 sp 0x7fffb52c6c28
READ of size 8 at 0x6060005bd218 thread T0
    #0 0x7ff229755270 in o3tl::UnsafeRefCountingPolicy::decrementCount(unsigned long&) include/o3tl/cow_wrapper.hxx:41:68
    #1 0x7ff2297551bf in o3tl::cow_wrapper<basegfx::Impl2DHomMatrix, o3tl::UnsafeRefCountingPolicy>::release() include/o3tl/cow_wrapper.hxx:203:29
    #2 0x7ff2297515f0 in o3tl::cow_wrapper<basegfx::Impl2DHomMatrix, o3tl::UnsafeRefCountingPolicy>::~cow_wrapper() include/o3tl/cow_wrapper.hxx:248:13
    #3 0x7ff242ef440f in __run_exit_handlers (/lib64/libc.so.6+0x3a40f)
    #4 0x7ff242ef4469 in __GI_exit (/lib64/libc.so.6+0x3a469)

The reason appears to be the UnsafeRefCountingPolicy on the global
IdentityMatrix, so every B2DHomMatrix that is created on any thread
will manipulate the refcount of that global without synchronisation.

Let's just remove the global and hope the extra allocations don't matter.

Change-Id: I4962ab2e622286f29b912a57448f3f1a53eeb592

since...

commit bcad173f
Date:   Wed Feb 8 11:12:00 2017 +0200

    Reapply "create ErrorHandlerFlags scoped enum for error handling flags""

    This effectively reverts commit 32cae6a2.

Change-Id: Ice41023bc741af46db3018bbb0eb08b4a339987e

* support poorly documented 'fd' suffix in rotation attribute
* allow non-integer rotation

Change-Id: I3d72f2a708e6585597db09366c00c50038abc9c1
Reviewed-on: https://gerrit.libreoffice.org/38207Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

for toolbar title string resource and identifier (for config)

Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28
Reviewed-on: https://gerrit.libreoffice.org/38274Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The behavior was adjusted with
72ef0d88 , but the ids
for sprmTFCantSplit90 and sprmTFCantSplit remained mixed up.

Change-Id: Ic97224a3af39e5df707a6dba59b785580c17b739
Reviewed-on: https://gerrit.libreoffice.org/38117Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

When you create an autofilter on a column which contains many different
values, you will have problems.

First of all, if you exceed 65535 values, you will enter in an infinite
loop because a uint16 is incremented for each value, and after 65535,
you restart to 0.

Secondly, the algorithm executes a double loop in O(n2) to determine
checked values, it's too long. Instead of that, all checked values can be
determined before.

This patch is graciously offered by Linagora.

Change-Id: Idc4500f6a496ae789aae11eb0e183aee157daa20
Reviewed-on: https://gerrit.libreoffice.org/38269Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  ca78b4f149dd82723a3b53a93063c881096fa71f

Fix bookmarks and ahelps on Chinese Conversion dialog page

Add missing bookmarks
Remove unnecessary ahelps
Sync label spelling with UI

Change-Id: I5240d1386ef3abd716c6e6647b50c96a21555a65
Reviewed-on: https://gerrit.libreoffice.org/38244Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  78472fa975bce0b4bb26bce0cad6c15c910e8361

tdf#107299 Fix reference to File - Templates menu item

Change-Id: Iae0120954fc7ac7a1748ece724eb4c6ddd3321b7
Reviewed-on: https://gerrit.libreoffice.org/38243Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  5cb25526e443e7492414ec27254843826de194cd

Fix bookmarks and ahelps on 3D-Settings toolbar page

Remove duplicate bookmarks
Remove unnecessary ahelps

Change-Id: I986b3e8dfc5aa9c00c5414ab41845060ff43d709
Reviewed-on: https://gerrit.libreoffice.org/38242Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>