Change-Id: I0a0e07a6a71ed95d783d35b7d94b857074ec3450
Reviewed-on: https://gerrit.libreoffice.org/47523Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

remove now unused class member

Change-Id: I30ffcf60833580a5f0029fa4efef80507d7918df
Reviewed-on: https://gerrit.libreoffice.org/47524Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I898e9d0e3e2cf1ed41489231d1cd761171bfcea4
Reviewed-on: https://gerrit.libreoffice.org/47514Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

when opening the navigator with a blank filter

Change-Id: Ib019714c3c778506633f4d4fa23e8faa0ac1851d
Reviewed-on: https://gerrit.libreoffice.org/47518Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

Change-Id: I8e756b43606a32b95f6192f40a5f32d13a65eec1
Reviewed-on: https://gerrit.libreoffice.org/47522Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Write a warn if a URL is created from a internal GraphicObject
URL as this is now deprecated.

Extract the way to determine if a URL is internal to its own
function, so it can be used to check and rewrite places that use
it.

Change-Id: Iedf13a596eab839094ea98e41787865bf6783adf
Reviewed-on: https://gerrit.libreoffice.org/47495Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I937320d1f9da51f7d0dbeb589855f6479c712288
Reviewed-on: https://gerrit.libreoffice.org/47494Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

In some cases we assume wrong size in svgio filter which we tried
to "fix" outside when we render svg to bitmap. This reverts the
"fix" and is now practically the same when rendering a svg
graphic (might be good to combine in the future). The fix for
svgio is fixed in a different commit.

Change-Id: I43ee35d3220b3a750b8f72f22085f6a34b9d26b8
Reviewed-on: https://gerrit.libreoffice.org/47497Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Previously we cached an icon only if we changed the scaling factor
or re-colored the icon, however if we have svg icons we want to
cache all of the variants, including the unscaled/un-colored one
as svg rendering is slower than loading cached png icons.

Change-Id: Ie2c14687892bbd12b8e04c690a66c5a1a92ac8b0
Reviewed-on: https://gerrit.libreoffice.org/47498Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: If477373f6e5a39ccd61332356a821f7c7d38d28d
Reviewed-on: https://gerrit.libreoffice.org/47488Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Without this, the modified status resulting from applying
the cell-formula immediately before saving is lost, since
it is clobbered after the save.

Change-Id: Ie402812d0fc0528020161fffe57e8220c5abfeb5
Reviewed-on: https://gerrit.libreoffice.org/47366Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

even if start is 1 of 0

Change-Id: I7e6ad8bcd20f160e08d8795aa38e52fe3aa3cbee
Reviewed-on: https://gerrit.libreoffice.org/47515Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iefba0ea6122bd9b1dde59f33c0c67077fecb7eca

Change-Id: I2ece697efccd316900761ef327bfc060b6493b97
Reviewed-on: https://gerrit.libreoffice.org/47501Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I80b4d8a4d2abdfb54fe60a880555ea1ff62af987
Reviewed-on: https://gerrit.libreoffice.org/47503Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I697edeacd286f1786d55ec53a781e53122acbdbe
Reviewed-on: https://gerrit.libreoffice.org/47502Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I429d07962acb372be460bee4e1c2b1e05dcce19b
Reviewed-on: https://gerrit.libreoffice.org/47500Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This reverts commit 89e354ef.

Change-Id: I73435ba76d7d7ca7ebf91eeced470fb792786c92
Reviewed-on: https://gerrit.libreoffice.org/47513Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie00a963c5eb575ae1e96f6e1aa10da1a2ce421e4
Reviewed-on: https://gerrit.libreoffice.org/47485Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

See bt https://bugs.documentfoundation.org/attachment.cgi?id=138913

Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=12d5e57dcac22c288ef23075b82e3e3e87929912

Change-Id: Ic079b87370207a1e51d747e250caea2bfcbc8c17
Reviewed-on: https://gerrit.libreoffice.org/47496Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I15400165c5233277a171b19e69db7497ce525e7f
Reviewed-on: https://gerrit.libreoffice.org/47482Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The problem here is presumably that the parser thread reports a
low-level SAX exception and the main thread reports a high-level filter
exception at the same time, so both threads modify maSavedException
concurrently.

Change-Id: Ic8ce9a4992208a24a111c990a67be163858ddaf8
Reviewed-on: https://gerrit.libreoffice.org/47478Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I090347046725a1ebb7a36f465654c29f7443d20d
Reviewed-on: https://gerrit.libreoffice.org/47467Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Project: help  03d3affe49661345c23168f1f7b59e781753b08c

Add l10n to the 'Module' string in Help UI

Change-Id: I3b1b202ea4544f1458086abf3b149dcd0be2d115
Reviewed-on: https://gerrit.libreoffice.org/47489Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Also add an assert to ErrorBox to ensure the mutex is acquired

Change-Id: I3e426024dad6ddfc5cffc7861b0cba9e8989c018
Reviewed-on: https://gerrit.libreoffice.org/47388Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

on any of our platforms

Change-Id: Id453ada9c79c76f2736f568436e386b05bcd08c5
Reviewed-on: https://gerrit.libreoffice.org/47468Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

first attempt was in commit e75abe6e,
reverted in 7accac09

Change-Id: I460e9ab5fcca3a99656e5d8434fa04c2387d7183
Reviewed-on: https://gerrit.libreoffice.org/47463Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  abf8c3ef55e98aeb9011020e8a217a0bd8de17ff

Various fixes on Impress General options page

- ahelp and bookmark fixes
- Templates window on startup instead of wizard
- Preseter Console option
- tdf#114310 Add spacing... option renamed

Change-Id: I930402fc1a8efa74ec747b06b2c720a963d6cc38
Reviewed-on: https://gerrit.libreoffice.org/47425Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Patch is thanks to Jon N.

Change-Id: Idba9ec9b32b144523f0e7da5f7273f6af9fdfd31

Extended the bridge to include original LibreOfficeKit.h
as well as Kit pointer (set in init call)

Change-Id: I5e96f2706ac4d1ee897b977d3322bdc1b91f1a0b

Change-Id: I972ff9e0dbb73f6a38c886e1acd03cc4d62da2ec
Reviewed-on: https://gerrit.libreoffice.org/47251Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I7136f5c0bc884a2f9ea945b4e0bc093a5ef2d8df
Reviewed-on: https://gerrit.libreoffice.org/47481Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I5376616ed1b1a1087dd8bac6830d31212252e4bd
Reviewed-on: https://gerrit.libreoffice.org/47459Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

In particular, the STR_SVT_MIMETYPE defines are dead
since
    commit 1b694dad
    Date:   Thu Aug 24 22:14:27 2017 +0200
    loplugin:unusedmethods

Change-Id: I641ec0a14efedc55c9d6a4de4a28784c273602e9
Reviewed-on: https://gerrit.libreoffice.org/47464Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id3f223d8d2220fb7d7bb2aaa50bb1a8e29bc0f70
Reviewed-on: https://gerrit.libreoffice.org/47462Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

it is always nullptr

Change-Id: I0eae17a58423cceda08867f4dc5945a3e5553d5e
Reviewed-on: https://gerrit.libreoffice.org/47461Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  189c97fd18cdcb99ad4b4d77a8ae97f8ce41f3b9

Fix typo

Change-Id: I7a9fab7c50139bcd5f5b5999b4e61e89f2e8e646
Reviewed-on: https://gerrit.libreoffice.org/47298Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  9e6681b78b9578eb739c3577218d6ce9141e7091

Fix typos

Change-Id: I2a98c7a079c69ac32b382d6c320dde456be98cf1
Reviewed-on: https://gerrit.libreoffice.org/47282Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  e3dc182b9dda0ba1a0e42dcea00e4d3b01e4b34f

Fix typos

Change-Id: I4ab0df8ed7f3d8ac95f28220c9b4f59e2a6a1eb2
Reviewed-on: https://gerrit.libreoffice.org/47281Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  f1126fd812d5f812803f666f7fb4bcd5024c9772

Fix typos

Change-Id: Ie3e0490e8ca41f9d4f20b834a3d5865c0fb18ad7
Reviewed-on: https://gerrit.libreoffice.org/47480Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>