- 21 May, 2019 18 kayıt (commit)
-
-
Michael Weghorn yazdı
Base class's 'Qt5FilePicker::setDescription' does the same, namely nothing. Change-Id: Ie89a1e1edaf20c49a1b16f43000a4a054b21f3b2 Reviewed-on: https://gerrit.libreoffice.org/68051 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 3035db41) Reviewed-on: https://gerrit.libreoffice.org/72648
-
Michael Weghorn yazdı
Use base class's 'Qt5FilePicker::getDirectory' instead to reduce duplication. Strictly speaking, the 'KDE5FilePicker::implGetDirectory' implementation used by 'KDE5FilePicker::getDirectory' suggests that the display directory is returned rather than the selected directory, and the same method 'implGetDirectory()' was actually previously used by the 'KDE5FilePicker::getDisplayDirectory()' method as well (removed in a previous commit). The code worked fine inside KDE5FilePicker (where the native Plasma/kde5 file dialog is used) but would lead to incorrect results when used inside Qt5FilePicker, e.g. for the following scenario * open folder picker displaying $HOME that contains a directory "bar" * do a single mouse click on the "bar" directory * click "OK" The call to 'toOUString(m_pFileDialog->directoryUrl().url())' inside 'getDirectory()' would return '$HOME/bar' for the native QFileDialog on KDE Plasma 5, but '$HOME' when used with the non-native QFileDialog Anyway, the implementation inside 'Qt5FilePicker::getDirectory' works fine for both cases, so just drop the KDE5FilePicker one. Reviewed-on: https://gerrit.libreoffice.org/68050 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit fa738707) Change-Id: I86dcf98ed310636b899ad289d8a8a8fa263dd2e9 Reviewed-on: https://gerrit.libreoffice.org/72647 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Michael Weghorn yazdı
Base class's 'Qt5FilePicker::getDisplayDirectory' does the same. Change-Id: I835603848736a328d0cf63b0bdc87895761e229c Reviewed-on: https://gerrit.libreoffice.org/68049 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit d5ac5eb5) Reviewed-on: https://gerrit.libreoffice.org/72646
-
Michael Weghorn yazdı
Base class's 'Qt5FilePicker::disposing' is the same. Change-Id: I91069385541a519f006d10b0580104f14beb551e Reviewed-on: https://gerrit.libreoffice.org/68048 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 1542aad2) Reviewed-on: https://gerrit.libreoffice.org/72645
-
Michael Weghorn yazdı
Change-Id: I4680cc4a8507d0d2409301b62ab81165fcfcdba1 Reviewed-on: https://gerrit.libreoffice.org/68047 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 6d00c53f) Reviewed-on: https://gerrit.libreoffice.org/72644
-
Michael Weghorn yazdı
... and related signals/slots. Those from the Qt5FilePicker base class do the same thing, except for one 'SolarMutexReleaser' that was commented out in 'KDE5FilePicker::getFiles' for no apparent reason since that line was added in commit 8fb0881a. Take over the slightly nicer syntax for the range-based for loop from 'KDE5FilePicker::getSelectedFiles' to 'Qt5FilePicker::getSelectedFiles'. Change-Id: I419f933d256f3b85eccaea85803b4890770efa24 Reviewed-on: https://gerrit.libreoffice.org/68046 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit e180574f) Reviewed-on: https://gerrit.libreoffice.org/72643Tested-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Michael Weghorn yazdı
... and related signals/slots. They are the same as in the Qt5FilePicker base class. Change-Id: I115d0daa6beace44b9c791fc892d7cf553c562bb Reviewed-on: https://gerrit.libreoffice.org/68045 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 9c960a6b) Reviewed-on: https://gerrit.libreoffice.org/72642
-
Michael Weghorn yazdı
Base class's 'Qt5FilePicker::setTitle' is the same. Change-Id: I071bf5f962c2d8b0821d78e97793c8637f5c0a1b Reviewed-on: https://gerrit.libreoffice.org/68044 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4a5761b6) Reviewed-on: https://gerrit.libreoffice.org/72641
-
Michael Weghorn yazdı
Drop the 'm_xListener' member and methods using it. The inherited Qt5FilePicker methods do the same thing. This also avoids that two methods are called when a file or filter is selected, since the 'QFileDialog::filterSelected' and 'QFileDialog::fileSelected' signals had been connected to slots in both, the qt5 and kde5 fpicker constructors. Change-Id: I60e3eda29e6497f51165e87d0c4ab2e17f209a1c Reviewed-on: https://gerrit.libreoffice.org/68043 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 1e9148f9) Reviewed-on: https://gerrit.libreoffice.org/72640
-
Michael Weghorn yazdı
Drop the '_dialog' member from KDE5FileDialog and use the one from Qt5FileDialog instead. Move up 'm_bIsFolderPicker' to Qt5FilePicker. Also, move some of the related functionality from the kde5 file picker to the qt5 one, in particular take over missing parts from 'KDE5FilePicker::setMultiSelectionMode' to 'Qt5FilePicker::setMultiSelectionMode' and drop the former (now inherited from the base class). This e.g. also makes sure that only folders are available for selection when using a FolderPicker in qt5 (e.g. in the dialog to add a JRE in "Tools" -> "Options" -> "Advanced"). The functionality had only been implemented for kde5 beforehand. Since the QFileDialog is set to non-native mode in Qt5FilePicker constructor, native mode needs to be excplicitly enabled again for kde5. Since Qt's signal/slot mechanism is used to connect signals on the object in both constructors (Qt5FilePicker/KDE5FilePicker), some events will trigger multiple actions. This will be taken care of in subsequent commits, along with further refactoring. Change-Id: I245d46c12945acb91c9b52dcff5c83248ac087dd Reviewed-on: https://gerrit.libreoffice.org/68042 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 0e496318) Reviewed-on: https://gerrit.libreoffice.org/72639
-
Michael Weghorn yazdı
While this does not make much sense by itself as of now, it will allow to reduce code duplication in follow-up commits. Change-Id: Ie1a9bf3e516044ad5e56c526d1cf49cf1cb76f8a Reviewed-on: https://gerrit.libreoffice.org/68041 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 77c0c38e) Reviewed-on: https://gerrit.libreoffice.org/72638
-
Caolán McNamara yazdı
Change-Id: Ie956560885fd9bb9e7367018a2f6e37a26c3c6af Reviewed-on: https://gerrit.libreoffice.org/72495Tested-by:
Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ibc12e52d075c7bc7c33b7c25841cfd122d6c014e Reviewed-on: https://gerrit.libreoffice.org/72452 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Caolán McNamara yazdı
Change-Id: I8fd0ebc336c222184485f72eb7c9d97922ab1386 Reviewed-on: https://gerrit.libreoffice.org/72497 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Grzegorz Araminowicz yazdı
Change-Id: Ieaf341dd13e06046044f3523c3aad74476160402 Reviewed-on: https://gerrit.libreoffice.org/69328 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/72473
-
Grzegorz Araminowicz yazdı
before that there were imported two GroupShapes: - empty one with properties like id, name, InteropGrapBag - second one with actual shapes also fixed tests that relyed on that behaviour Change-Id: I2b94a53e21666b16725c4353448d75e916e4f9df Reviewed-on: https://gerrit.libreoffice.org/69252 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/72472
-
Grzegorz Araminowicz yazdı
it will allow to preserve SmartArt when saving PPTX files Change-Id: I9bb66c59d202b4ce426864599014d042d4aa04b0 Reviewed-on: https://gerrit.libreoffice.org/68916 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/72471
-
Tamás Zolnai yazdı
.. if the original shape fill is defined with a theme Override the alpha value with the current value get from FillTransparence API attirbute even if the color is defined with a style or a color scheme. Reviewed-on: https://gerrit.libreoffice.org/72596 Tested-by: Jenkins Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 259d01a3) Change-Id: I09d26238a9c2b501279e6749687dc535e614bbd6 Reviewed-on: https://gerrit.libreoffice.org/72618 Tested-by: Jenkins Reviewed-by:
Andras Timar <andras.timar@collabora.com>
-
- 20 May, 2019 1 kayıt (commit)
-
-
Mark Hung yazdı
SwLinePortion::Truncate() called in SwTextFormatter::FormatReset() delete the portion referred by m_pFirstOfBorderMerge. Change-Id: I68e134c86db617d37ea2efa09dad4409772146b5 Reviewed-on: https://gerrit.libreoffice.org/72300 Tested-by: Jenkins Reviewed-by:
Mark Hung <marklh9@gmail.com> (cherry picked from commit 96acebb7) Reviewed-on: https://gerrit.libreoffice.org/72512Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
- 19 May, 2019 1 kayıt (commit)
-
-
Tamás Zolnai yazdı
Write the correct theme path to the InteropGrabBag, the same path what is generated and checked in the export code. Reviewed-on: https://gerrit.libreoffice.org/72500 Tested-by: Jenkins Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit a8bba60e) Change-Id: I32617c1a11cf3bafb142f7c8839b498aaac49aa0 Reviewed-on: https://gerrit.libreoffice.org/72521 Tested-by: Jenkins Reviewed-by:
Andras Timar <andras.timar@collabora.com>
-
- 18 May, 2019 1 kayıt (commit)
-
-
Caolán McNamara yazdı
this seems to have been wrong for a very long time, but we used to get away with it back in the .src era with presumably amusingly random strings from other parts of the ui shown in the summary of changes are of the organizer page of the dialog Change-Id: If223182170ba8519d7899f8044f01c2a12f4e391 Reviewed-on: https://gerrit.libreoffice.org/72491Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
- 17 May, 2019 5 kayıt (commit)
-
-
Katarina Behrens yazdı
In a filepicker, user can select any file filter ('All files' for example) and still choose to open .odb file. Specific UIName of the current filter ('ODF Database' in this case) shouldn't therefore be a hard requirement, the correct file extension is enough. Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24 Reviewed-on: https://gerrit.libreoffice.org/72377 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit dc17f247) Reviewed-on: https://gerrit.libreoffice.org/72453Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Christian Lohmaier yazdı
Change-Id: I7d712426ff82242fd1a53779ad1e7df6d6fa86d9 (cherry picked from commit b5bc0d40)
-
Caolán McNamara yazdı
so just Window:SetUpdateMode was called, not also SvTreeListBox::SetUpdateMode Change-Id: I37a91f8aff6e8a2399cb7cacfcdc6b3f8b1f44ab Reviewed-on: https://gerrit.libreoffice.org/72451Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
Christian Lohmaier yazdı
* Update translations from branch 'libreoffice-6-2' - update translations for 6.2.4 rc2 and force-fix errors using pocheck Change-Id: Ic143bd8070d7f8ef2c46265a88cfc215717c807c
-
Miklos Vajna yazdı
Regression from commit 8c73b16f (DOCX import: declare wpg as a supported feature, 2013-12-05), the problem was that <wpg:graphicFrame> did not forward to to the relevant oox context, and also Writer had no idea how to create a com.sun.star.drawing.OLE2Shape. Fix the later by using the same service name that's in use for the non-groupshape case. (cherry picked from commit fdf4aaa3) Change-Id: Id3536854da7c1f01525bb38d801496ecebd4c161 Reviewed-on: https://gerrit.libreoffice.org/71524Tested-by:
Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
- 16 May, 2019 4 kayıt (commit)
-
-
andreas kainz yazdı
Change-Id: I58a7391aec0c5cb3b5b5feb6be1ab3ecac2f0d5e Reviewed-on: https://gerrit.libreoffice.org/72356 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 3490c872) Reviewed-on: https://gerrit.libreoffice.org/72363Reviewed-by:
Xisco Faulí <xiscofauli@libreoffice.org>
-
Henry Castro yazdı
Rejecting paragraph formatting is not implemented yet. "Reject All" command is affected because the changes were not removed Change-Id: Ic4af1def97025643ecbc5cf0752cd06d9b94c74a Reviewed-on: https://gerrit.libreoffice.org/69865 Tested-by: Jenkins Reviewed-by:
Henry Castro <hcastro@collabora.com> (cherry picked from commit c033d8e5) Reviewed-on: https://gerrit.libreoffice.org/72404Reviewed-by:
Xisco Faulí <xiscofauli@libreoffice.org>
-
Tamás Zolnai yazdı
Change-Id: I326b2803bf2d98d440e14d7f3f75ca61c2c9e49a Reviewed-on: https://gerrit.libreoffice.org/72303Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by:
Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit aa446591) Reviewed-on: https://gerrit.libreoffice.org/72360Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Caolán McNamara yazdı
Change-Id: I46d14df66c529495a7e9f1596fcdbb0b093810c5 Reviewed-on: https://gerrit.libreoffice.org/72298 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/72400Tested-by:
Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
- 15 May, 2019 6 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I5ea2e5d7b79efbd2b14d0b528e5a5c3e44e643bc Reviewed-on: https://gerrit.libreoffice.org/72292Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
Tamas Bunth yazdı
Change-Id: I2a987278320a5685780962de2d3dfc165f3ef3aa Reviewed-on: https://gerrit.libreoffice.org/72311 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Tamas Bunth yazdı
Change-Id: I7bdc959921ecb0cbf19037a78b63eaeb8fc52814 Reviewed-on: https://gerrit.libreoffice.org/72206 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/72310Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Michael Stahl yazdı
The problem is that somehow a subraction of 1 from nPos made its way into commit 938f8a6b, which is likely some copypasta blunder. Change-Id: I46362fb416b9078ffe441396bcf927bfa5a23fd7 Reviewed-on: https://gerrit.libreoffice.org/72282 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit afb566b6) Reviewed-on: https://gerrit.libreoffice.org/72288Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Miklos Vajna yazdı
Regression from commit 49b67cdc (tdf#96961 sw Hide Whitespace: still show whitespace on the last page, 2016-01-08), the problem was that in case a page used to be the last one but no longer is, then its height was kept unchanged. Fix this by invalidating the size of the old last page after the insertion of the new last page, this way SwPageFrame::MakeAll() will be called later to resize the page. (cherry picked from commit c4589dd7) Conflicts: sw/qa/extras/layout/layout.cxx Change-Id: I672a70a77af5d306b1f8bd0b5ad6c2e375497124 Reviewed-on: https://gerrit.libreoffice.org/72301Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
andreas kainz yazdı
Change-Id: I91186550387e682e23b9cf3feb7a61d1a6973ece Reviewed-on: https://gerrit.libreoffice.org/72296 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com> (cherry picked from commit ac9a59cb) Reviewed-on: https://gerrit.libreoffice.org/72329Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
- 14 May, 2019 3 kayıt (commit)
-
-
Serge Krot yazdı
Change-Id: Id821b0d8bef69a7124ee41558e822cf8b025df9d Reviewed-on: https://gerrit.libreoffice.org/72232 Tested-by: Jenkins Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/72293Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Caolán McNamara yazdı
Change-Id: Iab34aa645252aea9c306f06814d75e405a2160e8 Reviewed-on: https://gerrit.libreoffice.org/72279Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
Szymon Kłos yazdı
Change-Id: Ib652174148e6997c1aabe0251a62612f28243d6e Reviewed-on: https://gerrit.libreoffice.org/67200Reviewed-by:
Szymon Kłos <szymon.klos@collabora.com> Tested-by:
Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit a4ac1a93) Reviewed-on: https://gerrit.libreoffice.org/72277Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
- 11 May, 2019 1 kayıt (commit)
-
-
Tamás Zolnai yazdı
Reviewed-on: https://gerrit.libreoffice.org/71916Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ae3aabdb) Change-Id: Ib07c606083b833389fcb82aac57ca8535d6e861f Reviewed-on: https://gerrit.libreoffice.org/72051 Tested-by: Jenkins Reviewed-by:
Andras Timar <andras.timar@collabora.com>
-