Change-Id: I1e5777e5dcc04d0aa53d1ac4b9091f310ae59035

Change-Id: I6069102f6b9df72a63a840758158f672fdd6c621

Change-Id: Iee1e943db369532e88e1d5badcfb5106e9d6ef26

Change-Id: Ibffbb6cba4fc3905a5d87be8305c9809bf67229b

... that's still allowed by the configure check

Change-Id: I1abfdfc09522dcfbd487d87a6ff49a0b4803daad

I've addressed the root cause the right way.

Change-Id: I1b3b13d28e4acc9f9ec814c0ad242166aa34a65e

Change-Id: If4ae85bec451897f5c22397f4301200d1d3c77ac

Painting only the necessary regions works fine normal background color,
but not for gradients, as the result is obviously different in case of
gradients.

Change-Id: I624410ed08604c13a810f784d6226d592295c5d3

Change-Id: I695cf16bc3b06823ae9e0546cb751e41eb201706

Change-Id: Id0adf3733ac4c2c08ded659c2d621ddbbbb434c5

They are not exported automatically, as SvxUnoNameItemTable needs a
Which ID, and it's different for drawinglayer and Writer gradients.

Change-Id: I5dd7d828b1f0e577e26510e3c5ca74386d000f16

so that if a new ones appears in icu we should compile time warn
about it

Change-Id: Ic116dce40a2aedee417320bc5291bb5b7d0ac391

Change-Id: Ic541e2510567ca0f264730568c482fef521e6318

Change-Id: I7cde7c609ee4e5e2cd9ab0be8f973b2626670f13
Reviewed-on: https://gerrit.libreoffice.org/1875Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

This is needed in tubes.

Change-Id: Ia77968a68da4e781c6e5d4c202b3e5f751f1c952
Signed-off-by: Tomas Chvatal <tchvatal@suse.cz>
Reviewed-on: https://gerrit.libreoffice.org/1904Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

These bad calls to putenv suddenly caused the buildIdFile string (macro-expanded
from bootstraprc's UserInstallation) in cleanExtensionCache
(desktop/source/app/app.cxx) to contain nonsense at least in a local
libreoffice-4-0-0 of mine, as getenv("UserInstallation") started to return some
non-null pointer pointing to garbage.

Change-Id: Ib93fd4e1caef016bd0e00bf09800b9532824ac4b

Use diskette icon for saving-related actions again.
http://user-prompt.com/about-antiquated-metaphors-in-icons/
This partially reverts commit f76c017c.

Change-Id: Iec9f0f5d6b62556e922f42247d058df817147da6
Reviewed-on: https://gerrit.libreoffice.org/1889Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>

ICU_CFLAGS=" " && ./configure  does not actually set anything

Change-Id: I7e88ca553fcb8449a337af36554dd1996bc6dd7d

Change-Id: Ie2d2a6b28be8167749822e22a85db057dfdd25a2

Change-Id: I04b4d378c016b5c31c66e0fccfb9b8afe2a08d76

Change-Id: Ie169ac426d6de107025023dae987cbce6179007f

Change-Id: I49ffee7c1e65d8e79865e5b596d18111e0c64279

Change-Id: Ic2d8b1e6f9dbaeee3e3ad9280236abd503de3ffd

Change-Id: Id0af5555685c67c02fecd8b10a40d4fb8135a2df

Change-Id: I6fbd5cef4f5935f7932bd9b64774315baee0e50d
Reviewed-on: https://gerrit.libreoffice.org/1838Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>

Change-Id: I60f588efb35d5968c21b7b0e0fc29bcbbd2dd50d

Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6
Reviewed-on: https://gerrit.libreoffice.org/1909Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

* Code cleanup + replacing drawText() with drawTextLayout().
This solves mirrored LTR text in an RTL ui

Change-Id: Ib89aee7c817811c7b3751dc6f941a34ed763d993
Reviewed-on: https://gerrit.libreoffice.org/1521Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>

  When writingmode is set to RTL, the table is start drawn from Last column
to first column.  There is no problem with left&right lines, Because these
are not depends on the LTR or RTL writingmode.  But the bottom & top line
depends on writing mode.  As these two lines are drawn from previous cell to
next cell(left to right) the nX value should be nX-1 in RTL writingmode.

Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e
Reviewed-on: https://gerrit.libreoffice.org/1834Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>

Change-Id: Iae6343a71137c5ffbc9d38f56c01d5b182975912

Change-Id: Id455dd87f01bbea0c5a4ae26734c0aba5699ac71

Change-Id: Ic41f95431203409b8412733870a4d8ec0fc93192

Change-Id: Ic0f8101c2619bf83feddbe0bd74d0b88941bbbe7

Change-Id: I5013e8b2ce99478f2445756e181f009b93d4e746
Reviewed-on: https://gerrit.libreoffice.org/1905Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

- the mysqlc library did link against the mysqlcppconn only when a
  SYSTEM_MYSQL_CPPCONN is used
- mysqlc is an EXTENSIONLIB, mysqlcppconn is PLAINLIBS_NONE
- one N was missing in Extension makefile, and use
  gb_Extension_add_library to put in mysqlcppconn
- manifest.xml, description.xml: update PLACEHOLDERS

Change-Id: If45714f81056a6c1a4cb3380b50cc3dcc0443bb8

Change-Id: Ia64bc884ed04a5d5652fb743f543a39e6b6bbcf2
Reviewed-on: https://gerrit.libreoffice.org/1901Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I33a9ff3393b90c5b9f7d7fa85e8761c02160664f
Reviewed-on: https://gerrit.libreoffice.org/1900Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

It no longer gets stuck in a loop so easily.

The key thing I realized was that there is a fundamental difference to
how the ATSUI and CoreText APIs handle text buffers and the start
offsets into them:

ATSUCreateTextLayoutWithTextPtr() takes a pointer to the whole buffer,
plus start offset and length. These are stored as part of the layout
object. Other ATSUI calls that use the layout object interpret index
parameters as relative to the buffer start, not relative to the start
offset of the layout object.

CTTypesetterCreateWithAttributedString() on the other hand takes an
attributed string that has been created from a CFString that already
is based on a potential substring of a buffer. I.e. the CTTypesetter
has no knowledge of the original buffer. All index parameters are
relative to that substring of the buffer, as are return values.

Change-Id: I7026f323d90a72e1ae1784a69f521e347baffaea

The CoreTextLayout class is clearly based on the ATSLayout class, so
in order to make it easier to compare code of the two, rename fields
back as they are in the latter. Also add the corresponding comments
where applicable.

Once the CoreText code fully works and has superseded the ATSUI code,
sure, we can change field naming convention if we want.

Change-Id: I0d47ad0206fa895339506471bb638bd04f426490