- 26 Nis, 2012 40 kayıt (commit)
-
-
Markus Mohrhard yazdı
-
Markus Mohrhard yazdı
# Changes to be committed:
-
Takeshi Abe yazdı
-
Takeshi Abe yazdı
-
Takeshi Abe yazdı
-
Markus Mohrhard yazdı
-
Stephan Bergmann yazdı
-
Stephan Bergmann yazdı
-
Stephan Bergmann yazdı
...that are no longer bundled extensions. Otherwise, old user data where these were still recorded as bundled extensions could cause execeptions at start up about duplicate implementations.
-
Stephan Bergmann yazdı
...detected now that the default service manager XContentEnumerationAccess no creates its own XServiceInfo instances.
-
Stephan Bergmann yazdı
...otherwise, if they are bundled, their per-user data is not regenerated, leading to inconsitencies.
-
Kohei Yoshida yazdı
The tests themselves do pass, however. The crash is caused by some sort of cleanup, due to someone calling a pure virtual function or some such. I'll work on converting these tests into C++.
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
Thereby laying down the foundation for arbitrary field support in cells.
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
This cleans up the code quite a bit.
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
Luckily this works just fine for the very simple field items. More work ahead to fully support all types we currently allow in headers and footers.
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
The idea is to keep a reference to the ScHeaderFooterTextData instance in ScHeaderFooterTextObj which is the authoritative copy, instead of making copies of it everywhere. This way when the text is updated in ScHeaderFooterTextObj all the other places will see it too without needing to propagate the change.
-
Kohei Yoshida yazdı
This removes lots of needless broadcasting, and makes the code a lot simpler. But it introduced a bug I need to look into...
-
Kohei Yoshida yazdı
Again, this inheritance makes no sense.
-
Kohei Yoshida yazdı
-
Kohei Yoshida yazdı
This shared base class makes no sense. Let's keep it simple.
-
Kohei Yoshida yazdı
This is to reduce dependency on ScHeaderFooterContentObj from ScHeaderFieldObj. Eventually that member should be removed and ScHeaderFieldObj be replaced with ScEditFieldObj.
-