Kayıtlar (commit) · e9073eadef4e7635ab86316d1a68be5023632c78 · LibreOffice / core

01 Şub, 2018 40 kayıt (commit)

idlc: MSVC: pragma warning: make more specific, remove obsolete · e9073ead

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I0fbba0c1b12f9ade703ceee477dae4056fe9d31e
Reviewed-on: https://gerrit.libreoffice.org/48994Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

e9073ead

include: MSVC: pragma warning: make more specific, remove obsolete · 8e07fb35

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Iba5ffe646e5a6cf8ecfb635c21546025fc5606db
Reviewed-on: https://gerrit.libreoffice.org/48995Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

8e07fb35

jvmfwk: MSVC: pragma warning: make more specific, remove obsolete · 94a5665e

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ibb69ba9c994e44c162318e40c4469c311309f326
Reviewed-on: https://gerrit.libreoffice.org/48996Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

94a5665e

o3tl: MSVC: pragma warning: make more specific, remove obsolete · 1e96364c

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Id9d038d50d5b6335a2f354c759b2c1e5dd413cec
Reviewed-on: https://gerrit.libreoffice.org/49037Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1e96364c

odk: MSVC: pragma warning: make more specific, remove obsolete · 682cef7d

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ie5957edb3954507505a7df9fad9f8da6b87b09d0
Reviewed-on: https://gerrit.libreoffice.org/49038Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

682cef7d

oox: MSVC: pragma warning: make more specific, remove obsolete · a584c0a2

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I3b3f46be30fce0f9193ee8d52159b16d022d903f
Reviewed-on: https://gerrit.libreoffice.org/49039Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

a584c0a2

LibreOfficeKit: MSVC: pragma warning: make more specific, remove obsolete · f365bca5

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Id8dd284a9db04eae458593d8e411b44223d16a8e
Reviewed-on: https://gerrit.libreoffice.org/49040Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

f365bca5

Use more specific tag in SAL_INFO and SAL_WARN here · 8bc49ff1

Tor Lillqvist Şub 01, 2018 yazdı

Surely we shouldn't be using the very generic "sw" for such a
feature-specific part of the Writer code.

Change-Id: Id8913b9121a419f5da1f46a552fab95c903a3b13

8bc49ff1

Fix typo · d24e83aa

Andrea Gelmini Şub 01, 2018 yazdı

Change-Id: Ib02367b1d93d15d32850a36375bfa5b83ef4f33d
Reviewed-on: https://gerrit.libreoffice.org/49098Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

d24e83aa

Fix typos · 0a01eacb

Andrea Gelmini Şub 01, 2018 yazdı

Change-Id: Id9d4f277ec684f4baaa9f16000da1b208d745e03
Reviewed-on: https://gerrit.libreoffice.org/49099Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

0a01eacb

ofz#3032 slk fuzzing timeouts on filling all rows · 2525d7cd

Caolán McNamara Şub 01, 2018 yazdı

which tells us that we're way too slow, which isn't really interesting news,
set an arbitrary limit for number of rows to import

Change-Id: Ie835088eab4e363a7deb19e9e5dbe43c1838520b

2525d7cd

tdf#85940 Add basic list styles to context menu · 7f4b7db2

Yousuf Philips Ock 20, 2018 yazdı

Change-Id: I9bdc3f1ba64ed47a6569b93e6685adad47c41718
Reviewed-on: https://gerrit.libreoffice.org/48238Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

7f4b7db2

Avoid empty avoid name for SfxPrintingHint · 4b2476b5

Julien Nabet Ock 30, 2018 yazdı

Create a brand new doc on Writer, click Print then Cancel button
=>
warn:legacy.tools:2382:2382:sfx2/source/doc/sfxbasemodel.cxx:3071: Empty event name!

Here's the bt
0 0x00007ffff1da379c in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&) (this=0x5555578f0630, aName="", xController=empty uno::Reference) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3073
1 0x00007ffff1da134b in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) (this=0x5555578f0630, rBC=..., rHint=...)
at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2731
2 0x00007ffff12768d1 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x5555578e9420, rHint=...) at /home/julien/lo/libreoffice/svl/source/notify/SfxBroadcaster.cxx:49
3 0x00007ffff1eec7b6 in SfxPrinterController::jobFinished(com::sun::star::view::PrintableState) (this=0x55555c092d20, nState=com::sun::star::view::PrintableState::PrintableState_JOB_ABORTED) at /home/julien/lo/libreoffice/sfx2/source/view/viewprn.cxx:329
4 0x00007fffec314318 in Printer::FinishPrintJob(std::shared_ptr<vcl::PrinterController> const&) (xController=std::shared_ptr (count 2, weak 0) 0x55555c092d20)
at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:519
5 0x00007fffec3143b1 in Printer::ImplPrintJob(std::shared_ptr<vcl::PrinterController> const&, JobSetup const&) (xController=std::shared_ptr (count 2, weak 0) 0x55555c092d20, i_rInitSetup=...) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:529
6 0x00007fffec3128ef in PrintJobAsync::ExecJob(void*) (this=0x55555c09b940) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:275
7 0x00007fffec3128c5 in PrintJobAsync::LinkStubExecJob(void*, void*) (instance=0x55555c09b940, data=0x0) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:273

This behavior has been like this since:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=87dfa6dd336d596112c0beb6b42f082178461678

This patch will allow SfxBaseModel::postEvent_Impl to not return early
See https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/sfxbasemodel.cxx#3059

Change-Id: I77ff916c15944693f9f0848bf8f18659f9b519df
Reviewed-on: https://gerrit.libreoffice.org/48936Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4b2476b5

Fix typos · ae8b65ee

Andrea Gelmini Şub 01, 2018 yazdı

Change-Id: I5cfa53bbe82fc3611770fdbe3b58d593f7a7c89f
Reviewed-on: https://gerrit.libreoffice.org/49100Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

ae8b65ee

osl: change osl_psz_removeFile() -> osl_unlinkFile() · 2de83d5a

Chris Sherlock Ock 28, 2018 yazdı

Also a few cleanups.

Change-Id: I3269d623917efda3a873f745dbce8bb25dce79be
Reviewed-on: https://gerrit.libreoffice.org/48792Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2de83d5a

connectivity: remove dead code · 192b2f75

Chris Sherlock Ock 06, 2018 yazdı

Change-Id: Ia968179d90978dc6c737effce5447efda60c1f66
Reviewed-on: https://gerrit.libreoffice.org/47490Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

192b2f75

Updated core · 8a29d632

Mike Kaganski Ock 15, 2018 yazdı

Project: help  0f7a354db93f0affe218cae7e0ea294a4efe5891

Correct parameter syntax

Change-Id: Ib9f805c33b1a2243197e5addfe9bf777b4e88ed5
Reviewed-on: https://gerrit.libreoffice.org/47889Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

8a29d632

ofz#5872 Direct-leak · 0e5d5389
Caolán McNamara Şub 01, 2018 yazdı
```
Change-Id: Id792ecc80dd3367f070c9a613f3999a8c3e386a1
```
0e5d5389

tdf#42949 Remove unneeded helpids.h headers (3/3) · f38c49cd

Gabor Kelemen Ara 20, 2017 yazdı

A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directory sw.

Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I100fd818b0e68eaaecbfaf7c7b58e95dea489aeb
Reviewed-on: https://gerrit.libreoffice.org/46870Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

f38c49cd

tdf#42949 Remove unneeded helpids.h headers (2/3) · 73bfe83a

Gabor Kelemen Ara 15, 2017 yazdı

A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directories r* - svx*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I81bdb80161b0207f5df651eb17c58caef44250d3
Reviewed-on: https://gerrit.libreoffice.org/46869Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

73bfe83a

tdf#42949 Remove unneeded helpids.h headers (1/3) · 4fae455f

Gabor Kelemen Ara 14, 2017 yazdı

A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directories b* - e*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I221d22f68584115d71660a97c4f108595625d12c
Reviewed-on: https://gerrit.libreoffice.org/46868Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

4fae455f

Use std::max · c35d44ff

Stephan Bergmann Şub 01, 2018 yazdı

(with the nice side-effect of removing one more false -Wsign-compare from
Android builds where USHRT_MAX is erroneously of type unsigned int)

(the original cast of rMax (of some unsigned type) to (signed) long had
probably originally been added to silence some signed-vs.-unsigned comparison
warning, so would no longer be necessary when using std::max)

Change-Id: I26212e731e26d885b848c7351a9ca5f9735e1f78
Reviewed-on: https://gerrit.libreoffice.org/49081Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

c35d44ff

sw: convert DELETEZ to std::unique_ptr in SwXFrame · 2a94fddc
Michael Stahl Şub 01, 2018 yazdı
```
Change-Id: I1aa9d0fc8712773ea87ea8419c384f6f23258387
```
2a94fddc

deps w/ hardlinks: don't create it as foo_ only to move it to foo · 23961ff6

Christian Lohmaier Eyl 21, 2017 yazdı

this breaks with CCACHE_HARDLINK=1 on close-enough rebuilds, as there
will be "foo" from previous run (hardlinked to ccache-dir), and foo_
will be hardlink to the same file, resulting in mv to barf out since
foo_ and foo are the same file (and -f/force doesn't help in this case)

Change-Id: Iaefcec05b34dad88f49477693e2157c1ca0623ac
Reviewed-on: https://gerrit.libreoffice.org/42586Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

23961ff6

sd: Remove unused keywords · b52275dd

Takeshi Abe Ock 11, 2018 yazdı

Change-Id: I1a180aaca32cabc56a6d5a6a3f0b23680d60aaf3
Reviewed-on: https://gerrit.libreoffice.org/47760Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

b52275dd

sw: convert DELETEZ to std::unique_ptr in SwUndoTableNumFormat · 69656809

Michael Stahl Şub 01, 2018 yazdı

Change-Id: Ia1123e2b5f4b3bb2d827d2cdbeff485c3c2a56da
Reviewed-on: https://gerrit.libreoffice.org/49080Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

69656809

sw: convert DELETEZ to std::unique_ptr in unodraw.cxx · e2d0e559

Michael Stahl Şub 01, 2018 yazdı

Change-Id: I89aaf157ded42ea3e968c706e4431f03d8f19ed7
Reviewed-on: https://gerrit.libreoffice.org/49078Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

e2d0e559

apparmor: fix @{HOME}/.mozilla/firefox access for XML signing · b6176bde

Rene Engelhard Ock 21, 2018 yazdı

the #include <abstractions/private-files-strict> bringing
"audit deny @{HOME}/.mozilla/** mrwkl," in actually denies everything here.
Use just <abstractions/private-files> and allow profiles.ini, secmod.db
and cert8.db.

At least opening the Digital Signatures dialog doesn't log apparmor DENIED
now...

Change-Id: Id557626fc26745841f0cca005d483fd1e6ac922d
Reviewed-on: https://gerrit.libreoffice.org/48264Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

b6176bde

Pass also webdavs:// URLs directly to soffice binary · 25214012

Katarina Behrens Ock 30, 2018 yazdı

instead of going via kioexec & temp file

Change-Id: I48ed5de97a2914025f01884f5ed0d0edce452112
Reviewed-on: https://gerrit.libreoffice.org/48900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

25214012

Support for webdav:// and webdavs:// schemes from command line · 65abd11d

Vasily Melenchuk Ock 25, 2018 yazdı

We have currently support for WebDAV schemes as vnd.sun.star.webdav://
but it is not user and tools friendly.

Some related refactoring in ucb to reuse existing code instead of
manual parsing of URLs.

Change-Id: Ib14411796d6cf11afd80d5132abe67d4e46a42e1
Reviewed-on: https://gerrit.libreoffice.org/48585Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

65abd11d

split out SFX_METRIC_ITEM into separate field · ae5f89fd

Noel Grandin Ock 31, 2018 yazdı

instead of overloading the nMemberId field
and thus fix various places that were effectively setting the METRIC
flag and causing a warning in SvxUnoConvertToMM

And fix bug in
    sw/source/core/unocore/unomap.cxx
where the PropertyAttribute::READONLY was in the wrong place,
ever since
    commit 84a3db80
    Date:   Mon Sep 18 23:08:29 2000 +0000
    initial import

Change-Id: Ifc2bf56709f19aea75300b2fda62ce551efc26af
Reviewed-on: https://gerrit.libreoffice.org/48950Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

ae5f89fd

Change bitmap table to store XBitmap instead of GraphicObject URL · e02efb62

Tomaž Vajngerl Şub 01, 2018 yazdı

As we want to get rid of GraphicObject URLs for the more robust
image life-cycle handling, it was necessary to change the way
bitmap table stores and handles images, so that they always
store a Graphic object (wrapped in UNO object that provides the
XGraphic and XBitmap interface).

In addition this changes loading and saving from ODF (xmloff) and
OOXML (oox) filters so they don't depend on GraphicObject URL
anymore, but load or save directly to / from  XGraphic or XBitmap.

Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21
Reviewed-on: https://gerrit.libreoffice.org/49074Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

e02efb62

add XGraphicStorageHandler interface · a61747c2

Tomaž Vajngerl Şub 01, 2018 yazdı

This is a XGraphicObjectResolver (future) replacement as it will
not be needed anymore. All resolving from URL to URL will be
replaced by loading, saving and serialization of XGraphic objects
(when appropriate), which is covered by this interface and
implementation by XmlGraphicHelper - the same that implements the
XGraphicObjectResolver.

Change-Id: I227634e443ce336218c2a2effaf34f9ef3576382
Reviewed-on: https://gerrit.libreoffice.org/49073Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

a61747c2

hash implementation for Graphic objects, for set/map use · 3195fce9

Tomaž Vajngerl Şub 01, 2018 yazdı

Change-Id: I58547ad90d1aba6b1734a547c8138d1476c4b813
Reviewed-on: https://gerrit.libreoffice.org/49072Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

3195fce9

these TODOs have been done · 62222b40

Noel Grandin Ock 31, 2018 yazdı

Change-Id: I5457f38f4668175a8f3e1b0f24a90963ee9d585f
Reviewed-on: https://gerrit.libreoffice.org/49076Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

62222b40

Fix typos · 5acfb93c

Andrea Gelmini Ock 31, 2018 yazdı

Change-Id: Icb4f4d9039278318d5f7f6302d57957b2c02bdb8
Reviewed-on: https://gerrit.libreoffice.org/49069Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

5acfb93c

Fix typos · 01c43770

Andrea Gelmini Ock 31, 2018 yazdı

Change-Id: I455efa82de60b764a500e1cc092ae08e800ec824
Reviewed-on: https://gerrit.libreoffice.org/49068Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

01c43770

embedserv: MSVC: pragma warning: make more specific, remove obsolete · 2c9904f3

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I0abd5662648b09f31164d919688e17a651bf78c8
Reviewed-on: https://gerrit.libreoffice.org/48976Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2c9904f3

extensions: MSVC: pragma warning: make more specific, remove obsolete · dc4dae12

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I7bbb280810af51adc25595667f1c40aca0a8ae26
Reviewed-on: https://gerrit.libreoffice.org/48977Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

dc4dae12

external: MSVC: pragma warning: make more specific, remove obsolete · 98e9e033

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ic17ffd6fc34504cf848d963e787e685ed2142080
Reviewed-on: https://gerrit.libreoffice.org/48978Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

98e9e033