Change-Id: Iadeb311c364324d26acab8a856358e0a5c5673dc

Change-Id: I33faa4b960ae78d31c026bcbd114cb7c5d5b5aea

Avoid the horrible convention of hard-coding in a C++ unit test code
addresses of data in the spreadsheet document being tested. Instead,
mark the expected (= as calculated by Excel) and calculated (by
LibreOffice) formula results, rectangular blocks of data, so that the
C++ code can easily find it, and then compare. This is much more
flexible. No need to edit hardoded row and column numbers in the C++
code when adding more test data.

The systematic.xls file has documentation on how to maintain it.

Change-Id: I4fb088fe21831dd3b3213d21916460a708aa0842

Used the same style as existing code, added a new virtual isMinOrMax()
and add some special casing in Reduction::GenSlidingWindowFunction(),
and fsim_count() and fmax_count() functions that count how many
non-NaN numbers we actually see. As such, I am not sure at all that
this is an ideal way to do this, but will have to do for now.

Change-Id: I846a8d24f4563f8fae1a45971a4ce202ed918487

Change-Id: If7326fd1242d90ff92e62d141714960476198605

Not sure why the code from f5e72070
did not produce correct results any longer. Anyway, now OpenCL
division works right in case of empty or zero cells.

Clearly I need to add unit tests to make sure this stuff keeps
working. In later commits.

Change-Id: I93b787ad5da453af1601768308fb614a332ed142

We get correct result by simplifying the code;)

No need to have the outer "if (gid0 < X)" test around the calculation
code generated by Reduction::GenSlidingWindowFunction(). The lhs and
rhs check the gid0 range themselves and that leads to the desired
result for subtraction.

While fixing this I noticed that the handling of empty cells in
division is also wrong. Will fix in another commit.

Change-Id: Ia45bd81e692a17b0453cc79cd4673a00e119562a

Change-Id: Ic3d26f45251ff27bacd572f0cb7a7aadf091e808

Change-Id: I264d7d89f0f8a420d04081541bf0a8a4708c9b58

Change-Id: Idda78e546db90e939a87ac5ef27363809ce41697

Change-Id: Idc10cfed44636213693fb0e7c859c5b1ffccd4e1

Change-Id: Ib634ce5ef43748f039e2bd9610398267b19c919a

Change-Id: Id4426ece2407f298dea157ff1034c6d15dcd9139

Change-Id: I6b2f8beb25cb5743db9d5f0b92dfce723c6d89e5

Change-Id: I20c0cf4ad14252fdbf9a73c7675a0704e8a03823

Change-Id: I1845d3e5c898e2e4bb929d723171e1cc79d57c4e

Change-Id: Iafb8c9fc0238d99c446aa2d0d0e03bda133b3554

Change-Id: I6acf72b623eb2211edc6e5a5c1f84acb6964620b

Change-Id: Idc7f4d852a10e4943beca1f1986dc8e7cf2354d5

Change-Id: I93ee4300bb642ca2fe032a1763c0cb36ae51bd3e

Change-Id: I928883cae95fbeba54913dfa2acc429ad15f336d

Change-Id: Iad3c349b3f66a5bba281b33de9ca689dd5015a83

Change-Id: I278c7c2516fde01355abe3030733a5798e1c96c2

Change-Id: I49d864b0449a78bb0ba187015debb8cc584407e0

Change-Id: I960c4ad4ffe4f0e86f3d1f0fb364296f31bf9d92

the Call() already does a check

Found with:
git grep -A 1 -w 'IsSet()'
    | grep -B 1 '.Call('
    | grep ':'
    | cut -d ':' -f 1

Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847

Change-Id: I2298b113f3ed1b2a715808dc8f9f906702e16485

Change-Id: I0245bfc1a4a1516fe45fdc69d2df98e09218a9cf

Change-Id: I443e37567e9907b06cd75af7ba84f00a40584b08

Change-Id: I3dfa6d8c780db88e1b195415ae2035a6e6b0cf4c

Change-Id: I085fc6e31a387e81f9afb80b9054a47f5ffbbee3

Change-Id: I37fc97591a653ec298e66edd676b8556c78d99a1

Change-Id: I4d2a1feabe553003ef992422b4d50def992b08f2

Change-Id: I90cc21cc089725507e7bbdf373466f7fc51993b1

Change-Id: Id6b91dcbfafb798b62feeb65e7d1b6a5d608d1c8

Change-Id: I0e984135a5abf918ba556c700ffa111097fd48c1

Change-Id: I377671a552764e39f0f651c03949c99005084dcb

Change-Id: I7a945e0d299eaf20f8245c6697959885f4ef4ade

(cid#1326323 Unguarded read)
Just switch this to an AtomicInteger, it's cheaper, and doesn't require synchronization,
so less chance of a deadlock.

This is an API change since this is a protected field in a public class, but anyone
messing with the internals of this class should have known better.

Change-Id: Idafc760c2e9d83442b8209ad23d180acb8dccb20

Change-Id: I2e73a85a3d8cab0a73c8c776d7406d99411d95d0