and

coverity#1397055 Inferred misuse of enum

copy and paste error from the other converted call site I bet

Change-Id: I63701db153c5fd424374a95dd757d9fd7a8bc216

regression from...

commit b894104a
Date:   Thu Dec 8 00:43:09 2016 +0200

    Pass GlyphItem around

    We have this nice structure that contains (almost) all the information
    we need, so pass it around instead of passing separate fragments of said
    information.

presumably this is the correct fix given the context of the other changes

Change-Id: I8518e739b1caa00ea5ae1569282e98810462d4c3

...containing replacements for global operator new/delete (that can be linked
into executables), but which is no longer used.  The mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2012-March/028690.html>
"operator new no longer routes through rtl_AllocMemory in libsalcpprt under
gbuild link rules" has the details of how this was used on some platforms (but
not on others) before the switch to gbuild, and has been "lost" ever since---but
apparently a loss not mourned much over the years.

For the SDK, c5f97428 "INTEGRATION: CWS jsc3:
#i62434# copy libsalcpprt.a" added the library (under Linux) and
6db9c5af "INTEGRATION: CWS jsc3: #i62434# extend
link options for executbales to link libsalcpprt.a, LINUX only" added its use to
odk/settings/settings.mk, but fc0ca57f
"INTEGRATION: CWS jsc21" removed that use again (for no documented reason).  So
this is an incompatible change, but unlikely to actually affect any users of the
SDK.

Change-Id: Ia38b4c439f21fca3f5d9af7d1a34054e992054e9
Reviewed-on: https://gerrit.libreoffice.org/31810Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ieda3afdbdbcc8aa21f6584edc21738c4edb84000

and

coverity#1397040 Unchecked return value
coverity#1397047 Unchecked return value
coverity#1397049 Unchecked return value
coverity#1397050 Unchecked return value
coverity#1397051 Unchecked return value

Change-Id: Idf7dd7818b74c661a1f7a757f0bdc16e2d1d5c72

Looks like it was introduced by

    commit 19b34c00
    loplugin:passstuffbyref in svtools

and since it's windows only, probably some subtle mis-compilation.

Aron Budea tracked this one down.

Change-Id: I77e65ea8a1fb0003d6ff0f3b0f8019f275ff3462
Reviewed-on: https://gerrit.libreoffice.org/31893Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5bd58f94fbea3d59849f60f2096e5191dbb0d810

Move one header file to inc/

Change-Id: If8f4bfcf29464011fe68573e7d4e67900aacc2cd
Reviewed-on: https://gerrit.libreoffice.org/31891Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

This solves the problem of rows with too big minimal height causing
layout failure (the table just goes out of page, does not flow to
next page).

It does so with three steps:
1. Currently, a row with a minimum height that flows to next page
repeats whole min height on that (and possibly following) pages.
If this behaviour continued, then that would cause layout loop:
the row min height would be too high for the page, so it would
keep flowing to next pages (actually just go beyond the botom
because of layout failure). To mitigate this, the patch changes
the behaviour to measure total height of all frames of the row:
the function lcl_calcHeightOfRowBeforeThisFrame calculates the
total height of previous row frames for the same row, then in
places where we need to get min height, this value is subtracted
from row min total height. On following pages the min height of
frames will get less each time.

2. When the row is split, the possibility to split depends on if
the minimum height of the row fits into the vertical space left.
The minimum height is found as maxinum of two values: minimal
contents of the row (e.g., height of first line of text, or an
object, or lower table cell), and the minimum height setting.
As the minimum height setting should not prevent the cell to
flow, (it only should ensure that total height is no less), we
should not consider the setting when the split is performed
(we should be able to keep on first page as little as required).
To allow this, a new bool member introduced in SwRowFrame:
m_bIsInSplit, with its setter and getter. When it is true,
the routines that calculate min height ignore the min height
setting. It is set in lcl_RecalcSplitLine around lcl_RecalcRow
and SwRowFrame::Calc that decide if it's possible to keep part of
row's content on first page, and update table's height to fit
the rest of space.

3. It turns out, that if contents of the splitted cell has less
height than the min height setting, then following happens.
In SwTabFrame::Split, all rows below splitted one are moved to
follow flow table; then table frame's Shrink method used to shrink
the freed height. At this moment, still, the height of splitted
row is too high, and total height of table is too high. Then,
lcl_RecalcSplitLine is called, where row is first shrunk, and then
lcl_RecalcRow and SwRowFrame::Calc try to move contents and resize
the splitted row. They get the minimum height of content (we already
don't consider the min height setting), but then "last row will fill
the space in its upper" (see SwRowFrame::Format). Row returns its
previous size, table does not resize, it doesn't fit to page, and
split fails.
To try to fix that, I call SwTabFrame::Shrink in lcl_RecalcSplitLine
after lcl_ShrinkCellsAndAllContent before lcl_RecalcRow.

Unit test included.

Change-Id: I8422e43cff7d6b5955541ed3fe930779429ed55b
Reviewed-on: https://gerrit.libreoffice.org/31774Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

..in eaa7f301

Change-Id: I149ee4087dffe54fd63bacd3bb5aba67159fac72

Change-Id: Ib85895c21cef9baeccc468b476cbd8170ee4c9ce

Change-Id: I7c905255627fb5286378e077d52932e9b184f054
Reviewed-on: https://gerrit.libreoffice.org/31853Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Ic8ed367a5774eb3a939163fb1c1fe9518c3d7d2d
Reviewed-on: https://gerrit.libreoffice.org/31855Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Ic4463db8aeca6ae9a86f7b890f95eb73724c6a1b

Change-Id: Ie4b7d45d26fbd839f9afcd11a7ba4bff80ed54e8
Reviewed-on: https://gerrit.libreoffice.org/31854Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

This patch caused a regression that on creation of a new sheet
while there's an unfinished edit of a cell, by using "+" in bottom
left corner, that edit is committed to newly created sheet instead
of that in which it was performed.

Also, fixing original problem (tdf#42432), it forced the pending
edit on deleted page to go to an existing page, which could
overwrite existing data without being noticed (dataloss).

Reverting the patch does not reintroduce the original problem that
it intended to fix (a crash) in master.

Change-Id: I696a85ec9d08ebb3621ebdbce4d9f71eadcdb2c2
Reviewed-on: https://gerrit.libreoffice.org/31843Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Project: help  89416253fdd67a9334660238f2c23f0fdfb3a10e

fix emph tag

Change-Id: I5335a8dfce80fef6a59b102bac11a0017b4fff54

Change-Id: I3861a04a02a17113d25c0fd065f8870b0ef020ca

nItemStartPos was never defined
initial commit ee62af2e
Date:   Wed Apr 13 10:18:14 2005 +0000
    INTEGRATION: CWS visibility03 (1.1.2); FILE ADDED

Change-Id: If63d5594d32bae9e5b3b89e7d2bc6106e7663071
Reviewed-on: https://gerrit.libreoffice.org/31857Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e
Reviewed-on: https://gerrit.libreoffice.org/31799Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7a6f55ad7f3a26a88263660b97dd8650858890f8
Reviewed-on: https://gerrit.libreoffice.org/31859Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  957f72b1e3aeeb596eb9c82b4b623d09d1122e71

tdf#103527 (related) Drop redundant Color settings page

It has no substantial content so it could create only confusion

Change-Id: I393c7f5b3094977ceb2a84876b0cd2d434d9f9af
Reviewed-on: https://gerrit.libreoffice.org/31849Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  4d650fceb5cf89f9ef2ce4ccfb602043c99fce59

Drop help page for .uno:PreviewPrintOptions

I can't find any trace of this command in core or
in the git log so probably no one will miss this page.

Change-Id: I3a4e8de28ef717fb2db6df38f63468604730c3fd
Reviewed-on: https://gerrit.libreoffice.org/31848Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  eb6324c80763f482d2adefe4d91c2f31904f2fa0

tdf#93299 Reconnect 'Outline and Numbering' page and UI

Update bookmark and ahelp HIDs.
Add a description to the 'Edit Style' button.

Change-Id: I9866c00e62d5ea54881e3c8156ef57db4d998fbc
Reviewed-on: https://gerrit.libreoffice.org/31842Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  992226ad77e2790074d1f718523dc55d4201c045

tdf#76488 (partial) Reconnect Printer Setup window and help

Update bookmark and ahelp ids.
Removed sys=WIN marks because these informations are visible
on Linux too (no idea about Mac though).
Add documentation about the Options button.

Change-Id: Ia59119b266b4794655f7236622fc1c5c40b4095c
Reviewed-on: https://gerrit.libreoffice.org/31858Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  0b50898fdae10df8a54b60bbb77e68031e63cfb3

tdf#76488 Fix HIDs for Properties - Font tab

test-hid-vs-ui says:
From source/text/shared/01/prop_font_embed.xhp,
referenced items ['DocumentInfoPage'] were not
found inside sfx2/uiconfig/ui/documentfontspage.ui.

Change-Id: I18a64e22b44bc53de96e8db4cb49b7848c743037
Reviewed-on: https://gerrit.libreoffice.org/31845Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Change-Id: Ic409bd4977fdf610294bd13b7ea83ef9a4c48667
Reviewed-on: https://gerrit.libreoffice.org/31750Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>

since commit 96ec36cf
Date:   Thu Dec 8 21:49:47 2016 +0100
    ucb: replace "SimpleList" trash

found by cppcheck

Change-Id: I13d62bdb6cb1a714182f90078d4a2990c790301a
Reviewed-on: https://gerrit.libreoffice.org/31856Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Above field of struct SwRectFnCollection were removed because of
loplugin:unusedfields. I can't find them refered in the source
code but they do affect alignments.

Also append correspoinding member functions for SwRectFnSet.

Partially recover d2df0357
and e18b0836.

Change-Id: I38f2b7a31565773b749cfeb1f47574c390d38527
Reviewed-on: https://gerrit.libreoffice.org/31795Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibed5435e23730dc901155e79152e9becd3e70566
Reviewed-on: https://gerrit.libreoffice.org/31262Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

Change-Id: Ic862bb1ce3efa61d6a01fc56fb9e84cf98bb7cd0
Reviewed-on: https://gerrit.libreoffice.org/31355Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

See https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c876d497dd3320cbc06cf21b7b14ab859755bac
This one fixes tdf#104551

Change-Id: Idd173bcb85655ec1b210fa00510fbabba0f5d867
Reviewed-on: https://gerrit.libreoffice.org/31844Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

There was a race condition that the OpenGL code was initialized before
the old report has been uploaded. Therefore the OpenGL setting was
overwritten by the new start and we were not getting the old value.

Now we store any value that wants to be added before the dump.ini is
ready in a temporary map and will write them as soon as we write all the
common information.

This problem was introduced by the dialog requesting permission to
upload the crash report.

Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024
Reviewed-on: https://gerrit.libreoffice.org/31846Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I3951a237789ee4b7697f70bc527ffbb6a626206a
Reviewed-on: https://gerrit.libreoffice.org/31776Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Ie5be0307fa8ac0292f7692f9674e07776cb1948d
Reviewed-on: https://gerrit.libreoffice.org/31777Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

There is no such thing as simple text layout in this brave new world.

Change-Id: I641b7efa5ec8fdd9839c291e7f2fdb736361ef1e
Reviewed-on: https://gerrit.libreoffice.org/31824Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

The original issue for reference:
https://bz.apache.org/ooo/show_bug.cgi?id=36691

Change-Id: I3b68c2c9f7cb94445875ef5a005e73dcfe65fa3a
Reviewed-on: https://gerrit.libreoffice.org/31823Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Replace it with a check from ICU that actually makes sense.

Change-Id: Ie8789444a967420d58f5575f42bc45677bfa96a1
Reviewed-on: https://gerrit.libreoffice.org/31822Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: I15289eecfbfb29ee549470a7f752e0c7fd9f811e
Reviewed-on: https://gerrit.libreoffice.org/31820Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>