Change-Id: I78d207a4be9eeb9ddf1782ed2488c928d9d1744a
Reviewed-on: https://gerrit.libreoffice.org/29222Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Iad1091f3c4363940e956219e1723e159c35ea280
Reviewed-on: https://gerrit.libreoffice.org/29220Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I4c87e3fb418211a5f3750746e1b6928fbe8f1741

Change-Id: Iaa7fd4112084d673cf768ebb732e1ea8a3383bdc

Change-Id: Icccd2db45616de708d83058d76ace312db8af94e

Change-Id: I7d0351931b0baa434bd24db05358e096cfa1b6e2

Change-Id: I9cfe2f3ec96ee72ff2e7657661a003086d301db6

Change-Id: I829e2d45ac9fabc8fe1a26bebd9e6ce8c2af29c7

Change-Id: I032b872f75b59904c1c81e8932ad8058ece301b0

(__declspec attribute 'allocator' in MSVC 2015 atlalloc.h; clang-cl)

Change-Id: I88d2bc4667ded75a545c95f428e654be787b03f8

Change-Id: I4cae18e1359f2e30ef4d4d7d550306489fcedd74

At least make-4.1-5.fc24.x86_64's /usr/bin/make (indirectly) links against
libfreebl3.so, so it could erroneously pick up our instdir/program/libfreebl3.so
delivered there from external/nss.  But that's a problem for ASan/UBSan builds,
where that libfreebl3.so is instrumented and expects to find certain symbols
exported from the executable (and which /usr/bin/make of course doesn't have),
so running make from within external/liblangtag/ExternalProject_langtag.mk
fails.

Turns out that the only place where LD_LIBRARY_PATH is needed during the build
of external/liblangtag is when running
workdir/UnpackedTarget/langtag/data/reg2xml.

(This is unrelated to the recent changes to external/liblangtag by the way; just
happend to show up now by accident, when doing an incremental build where
external/nss had already been built when external/liblangtag got rebuilt.
external/firebird has a similar problem, but everybody seems to run ASan/UBSan
builds with --disable-firebird-sdbc anyway for now.)

Change-Id: I6e045b6d33a154e350f4640265e6568f96634187
Reviewed-on: https://gerrit.libreoffice.org/29211Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4e9ef9e607a15ab49ea16a2c3920e36a3a1aded2
Reviewed-on: https://gerrit.libreoffice.org/29179Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: Ib400c5930be84d26665b0e12a61508c8fbfd7f08
Reviewed-on: https://gerrit.libreoffice.org/29105Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This reverts commit b0eecd2d.

Now that the necessary parent commits are in, we can re-apply this.

sample pptx crashes down in the depths of (apparently pre-installed on
32bit Windows 10) Flash.ocx

Change-Id: I4e083d492e56e72df47b2c172d7f07f0e39b82ea
Reviewed-on: https://gerrit.libreoffice.org/29199Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I88ae046866c616cc7de226e85eaab1a0e76eb59e

concat string in module i18npool to improve readability

Change-Id: I7f447d64703cf5eb07742329ff2656f67214898b
Reviewed-on: https://gerrit.libreoffice.org/29206Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

... it's declared in poolio.hxx

Change-Id: I8cc4a7152f66cf89fb01cd7a718974d76825ec04
Reviewed-on: https://gerrit.libreoffice.org/29181Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I935de8e287f94f3219542dfe67f7bb4a05be14da
Reviewed-on: https://gerrit.libreoffice.org/29200Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

SetRefCount writes only SfxPoolItem members m_nRefCount and m_nKind

Change-Id: Ibd06d4edc619b9a840a8a232d9395dd85c452149
Reviewed-on: https://gerrit.libreoffice.org/29195Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

... is not unused but only in ifdef _WIN32

commit c4cd079b
Date:   Thu Sep 22 15:08:42 2016 +0200

    loplugin:unusedmethods in sc..vcl

Change-Id: I36c8d57fddfffe8c99cf40ae514270f445388d08

Change-Id: I87c0fb287aa0b3fc5ad0216d8007772de3d03b2f

commit 7419057e
Date:   Thu Sep 22 16:34:14 2016 +0200

    loplugin:unusedmethods in chart2..svx

removed that but vcl/unx/kde/salnativewidgets-kde.cxx needs it.

Change-Id: I1ddc98ffafb1f6a1a22642a9a83cc58085cb4271

commit 7419057e
Date:   Thu Sep 22 16:34:14 2016 +0200

    loplugin:unusedmethods in chart2..svx

removed that from
include/vcl/printerinfomanager.hxx
vcl/unx/generic/printer/printerinfomanager.cxx
but not the empty base class implementation from
vcl/null/printerinfomanager.cxx

Change-Id: I9bfd1c77490c70b9bf7a69c93d34bd0249cce64f

Change-Id: I88df0a06482a04609eb0c394dc7d9a023fc7e921

by reverting part of commit
    commit 7419057e
    Author: Noel Grandin <noel@peralex.com>
    Date:   Thu Sep 22 16:34:14 2016 +0200
    loplugin:unusedmethods in chart2..svx

Change-Id: I72515c9b5f3739f57d4b63a724a9fa32075b2612
Reviewed-on: https://gerrit.libreoffice.org/29197Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

by reverting part of commit
    c4cd079b
    Author: Noel Grandin <noel@peralex.com>
    Date:   Thu Sep 22 15:08:42 2016 +0200
    loplugin:unusedmethods in sc..vcl

Change-Id: I4d925532369b37e13d97edd907c12f59a350e6ea
Reviewed-on: https://gerrit.libreoffice.org/29196Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ief06d3ea0288e8ebf34f2f67f3d1dfc9405b6d49
Reviewed-on: https://gerrit.libreoffice.org/29180Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

This reverts commit d141d5b3.

seems like I pushed it too soon, it depends on other commits not in yet.

Change-Id: Id4d3f80b3906395838afaffb2b0d00437d17f6dd
Reviewed-on: https://gerrit.libreoffice.org/29182Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

reduced size because it is stored in widely used SfxPoolItem.
converted 'if' chains to 'switch case'

Change-Id: Id9b5e375b681c88e8c91c561abd1a50610aa4815
Reviewed-on: https://gerrit.libreoffice.org/29186Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

In zforlist.cxx the function SvNumberFormatter::GetPreviewStringGuess
switches between the system locale and en_US in order to guess the
formatting of a number.  This results in poor performance, because in
the created SvNumberFormat only the last used locale is cached.

Caching more than 1 entries improves the load time for the document
attached to tdf#53698 from 90s to 60s in case of non en_US locales.

Change-Id: Id0eb4447dea6213015e2d958d8303a1e7892487a
Reviewed-on: https://gerrit.libreoffice.org/29136Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifb6045885049733415895f58cdd911256f48323c
Reviewed-on: https://gerrit.libreoffice.org/29187Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8
Reviewed-on: https://gerrit.libreoffice.org/29183Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

The problem, as seen by the user is that during shape text edit,
sometimes just traveling with the cursor causes invalidations, which is
unexpected.

What happens is sd::Window::KeyInput() invokes
sd::DrawViewShell::MakeVisible(), which does a pixel-to-logic
conversion, but because the map mode is in general disabled in the LOK
case, nothing happens. Then a bit later aVisArea.IsInside(rRect) fails,
as it compares pixel and logic units, which results in
sd::ViewOverlayManager::UpdateTags() scheduling an async call to
sd::ViewOverlayManager::UpdateTagsHdl(), which at the end causes a full
invalidation in sd::SmartTagSet::remove().

Fix the situation by temporarily enabling map mode, so we don't detect
a visible cursor area as a non-visible one.

Change-Id: I6d16f24d13143dc263a89317fbc38111e652c0ac

Change-Id: Ice2657c8e8ecccb67d1b14292514a42ff37caa39

KDE theme engines can explicitly support rollover menubars via
styleHint( QStyle::SH_MenuBar_MouseTracking ).

So this adds support for this feature to the vcl::Menu.

Change-Id: Ica923ff2d06cfd54e548ba858b3d90f70d9c255a

Selecting radio and check boxes is handled via
QStyleOptionMenuItem::checked. Actually forwarding the
QStyle::State_Sunken creates strange artifacts in all
menus.

Change-Id: Ia0b0864b9bec5961023b4f25315a8acf1fae4683

This will always redraw the progress bar over the last one.
It stops the flickering at least in KDE4 from re-painting the
background, but obvously will break any transparent or alaiasing
effect, if it was used.

There is actually a mbProgressNeedsErase in the global settings,
so actually use it when setting a new progress value.

Change-Id: Ic62784da4f6d08bf0e03a9e04848a5cc687ee236