This reverts commit 29e1b2f1
in preparation for reverting 2d4b87f0

Change-Id: Id319c001b399a3105d6c9f87a58168f956ad46c3

Change-Id: Ifc7577f46625562183ed3ee2273f28b9dcfc13df

so move potentially throwing call to a manually called finish()
additionally don't make it leak something that is not a RuntimeException,
the caller does not expect it.

Change-Id: I8b19585ae197f5ac8625dc85d4c4860a1c11b262

regression from .ui conversion:

commit 5c72a213
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Jan 21 14:41:16 2014 +0000

    convert table filter page to .ui

    Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52

Change-Id: Ic7d41d64d4c15eabf7b7f83a17482c473154434a

Change-Id: I74955a05bf13f7b33650d11c5cf4b1388382da2a

Change-Id: Id22ba872865bd8136c65c73152097805e696a695

Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994

Change-Id: Ic6b813b3f826300d3b59b7105690ab611bb4bd44

Change-Id: I910c37a19c1f627ec0c92dcb044db92e9e24c25e

Change-Id: I99281928665f6738a7f8d5fd04104445c06b17e8

Change-Id: I8ceaa2544cef8119cb394a2f4aebea066d04609e

Change-Id: If5f3eb41b74b02ee44902216eada64d49bc5e9e8

Change-Id: Ica81e236e205cbb994220015a51ffb1f98785bd6

Change-Id: I2540e78f13d856a9ada59b6ed416974b361b6a14

The BASIC dialog format is not specified by ODF anyway, so the change
was particularly stupid.

(regression from 2d4b87f0)

Change-Id: I5b20d690093b0d2b898f3e45cc0292fb72fbb353

Change-Id: I6506190c09405d4d82ae4fc4356e4ec936f2431d

to avoid the dread 64bit

vcl/source/outdev/map.cxx:391: long int ImplLogicToPixel(long int, long int, long int, long int, long int): Assertion `std::abs(n) < std::numeric_limits<long>::max() / nMapNum / nDPI'

assert on executing...

soffice.bin abi10619-1.doc --convert-to pdf

Change-Id: Id81d8e7eb9a962a5bc7f50d9c02da052cee24da1

Change-Id: Ibf4a2ed99024568b2d370b22919e3a25c43c6fbf

Change-Id: I9aec5b5e982b5b29b5937fba1cebf6b429d82adf

...even if it is known to be dangerous

Change-Id: Ied96284e33b966bf072d0961054479ec7f891dea

Change-Id: I0721c0b620a7de994d71752034daeeb4d00659f7

'Locale' : ambiguous symbol, could be 'com::sun::star::lang::Locale' or 'icu_54::Locale'

Change-Id: Id5688195907624467d3956aff4b27f6839e03015

Change-Id: Ia8097b6d92c9bc4e3841d96bcb8cd553969f54a0

EscherPropertyContainer may allocate a 1-byte buffer if there are no
vertices / segments. (happens in sw_filters_test)

 in EscherPropertyContainer::CreateCustomShapeProperties(MSO_SPT, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) filter/source/msfilter/escherex.cxx:3853:25

Change-Id: I56dedbd57d38cd017183060e924cb1340ea58ebf

Change-Id: I5e92ca9dbb0c9f33c9511cc4b12db1433e40fa68

Change-Id: I62ff8a172a9c4f361ef5fcb6d60bd9fd2e959c2d

hopefully..

C:/cygwin/home/tinderbox/master/svl/source/items/srchitem.cxx(111) : error C2872: 'Locale' : ambiguous symbol
could be 'C:\cygwin\home\tinderbox\master\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/lang/Locale.hdl(17) :  com::sun::star::lang::Locale'
or       'C:\cygwin\home\tinderbox\master\workdir\UnpackedTarball\icu\source\common\unicode/unistr.h(79) : icu_54::Locale'

Change-Id: I9d9650cd058fb4328fcaa2ae8f5adbb903001817

Those attributes contain a lot of interesting properties, among them
the heading level which fixes this bug.

Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b

So move it there. While at it, make it use SAL_WARN() instead of
printf.

Also, add a few more SAL_WARN() and SAL_INFO().

Change-Id: Ib058fb20d07757331ca364a8d7649abc59e9494b

Change-Id: I9c31d91dab2bc47148c0439947c331e411159891

(and no need to hold css::uno::Sequence objects by pointer either).  Regression
from e537d227 "hard to find accidental leaks
with all the deliberate ones" caused JunitTest_svx_unoapi to sometimes crash.

Change-Id: I3579c4bbac58d7e341c8acb52dd3f0f06f7b2245

Change-Id: I58fd91354fe41673216674f5ae9c11c17cb3f29d

Limit duplication for SfxRequest FN_NUMBERING_OUTLINE_DLG in sw shells

Change-Id: Ibbf58480232f3b393d13548508b7cdbc98690847
Reviewed-on: https://gerrit.libreoffice.org/14313Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Limit duplication for SfxRequest FN_FORMAT_FOOTNOTE_DLG in sw shells

Change-Id: I6f1ce98acf44a3811e4666a6bd9952232429f55a
Reviewed-on: https://gerrit.libreoffice.org/14312Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I704e7d0ca6422f1388cd111c6998ba6ceb48d2bf
Reviewed-on: https://gerrit.libreoffice.org/14311Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5a594b3d6ef84b022ce4a92a865beba735d47113
Reviewed-on: https://gerrit.libreoffice.org/14322Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... as the mdds storage segment may change when a formula cell is
inserted at a position such that two segments are merged into a new one.

Change-Id: I449a89005418aff7ea12099ea931b786959dbc3b

Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

::dbtools::ensureRowSetConnection throws on failure, and it can fail
of course if the database doesn't exist

its not generally useful to throw through a vcl event handler as that just
leads back to the dispatch loop.

Change-Id: I8e8f4cff06de5684f163ed1b658a8794f54a7df2