Kayıtlar (commit) · ebfc6b6863fa54abd33ba95130a8434c70e42f58 · LibreOffice / core

01 Eki, 2015 4 kayıt (commit)

vcl: Fix possible memory leak in OpenGLSalBitmap · ebfc6b68

Daniel Robertson Eki 01, 2015 yazdı

Fix possible memory leak in OpenGLSalBitmap::CreateTexture

Change-Id: Ic2d259569a5e89f60af7065b9d66ef03f82f90e7
Reviewed-on: https://gerrit.libreoffice.org/19049Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

ebfc6b68

remove old standalone Sun bug numbers · e209d115

Noel Grandin Eyl 30, 2015 yazdı

Sun bug numbers without any accompanying text are completely useless.

Fixed with
   git grep -lP '//\s*#\d+#\s*$'
       | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.

Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

e209d115

basebmp: these headers are not used from other modules · 8e27c688
Miklos Vajna Eki 01, 2015 yazdı
```
Change-Id: I88c5c341b88a6ea62730e5d3dd1962365c531f70
```
8e27c688

Revert "by default use the system memory allocator" · 6e8e898a

Markus Mohrhard Eki 01, 2015 yazdı

It seems that even on Linux the system allocator is worse than our
internal allocator. e.g:
http://perf.libreoffice.org/perf_html/chitest_of_cppu_sc_on_vm139.details.html

This reverts commit 006d30b1.

6e8e898a

30 Eyl, 2015 36 kayıt (commit)

tdf#92702 Unable to select menu items that were initially off-screen · 4f1dca50
László Németh Eyl 30, 2015 yazdı
```
Revert "Last item of menu with title cannot be hilighted"

This reverts commit 8ced97ca.
```
4f1dca50
bridges: fix build with --enable-assert-always-abort · 592b43ac
Michael Stahl Eyl 30, 2015 yazdı
```
Change-Id: I6079481046ca3f7d66975d41fccc15b862a3223b
```
592b43ac
don't believe xls wrt size to reserve · 358ca9ea
Caolán McNamara Eyl 30, 2015 yazdı
```
Change-Id: Id9864f199e270d13d801348b12f1e94dd80558c7
```
358ca9ea
add xls support to fftester · ac9e7af6
Caolán McNamara Eyl 30, 2015 yazdı
```
Change-Id: I23e219cec1a8d98e02c3584041f67ff42dd29bd8
```
ac9e7af6
cppcheck: uninitMemberVar · 9e481f60
Caolán McNamara Eyl 30, 2015 yazdı
```
Change-Id: I8409a6f00803e357a20b53fd59d77f155e057753
```
9e481f60
titchy typo ScImportExcel->ScExportExcel · 80c41303
Caolán McNamara Eyl 30, 2015 yazdı
```
Change-Id: I05624acbdf4695ef652e619662996ac41afed410
```
80c41303

vcl: clean up before error returns in OpenGLContext::ImplInit() · 5efad739

Michael Stahl Eyl 30, 2015 yazdı

JunitTest_chart_unoapi fails here with "assert(!hasCurrent())" because
the initialization apparently fails due to lack of a
wglCreateContextAttribsARB in the VM, so ensure that the hTempRC is not
active and also deleted in all cases.

Change-Id: I7e03b95d1146af48a24e34692c3c2827298fccee

5efad739

Blind fix for cross compilation · 08ba2b28
Stephan Bergmann Eyl 30, 2015 yazdı
```
Change-Id: I3b44f153f66dfc8cbd95c23e5456ffad8df46949
```
08ba2b28
Mention the relevant GCC bug ID · 8217c99f
Stephan Bergmann Eyl 30, 2015 yazdı
```
Change-Id: I3edd39ce3180383c5274380896a0b3884bd08998
```
8217c99f
vcl: even in the newfangled OpenGL world, initializing members is ... · 37d24365
Michael Stahl Eyl 30, 2015 yazdı
```
... still a good idea.

Change-Id: Iecbc9dc8481b0ccc85f1fb82d9e9884bdba61b28
```
37d24365

Work around GCC 5.1 ICE · 6cc54913

Stephan Bergmann Eyl 30, 2015 yazdı

  in constexpr expansion of ‘operator|<ImplFontAttrs>((ImplFontAttrs)33554432u,
   (ImplFontAttrs)16777216u ...

in unotools/source/config/fontcfg.cxx, at least with "g++ (GCC) 5.1.1 20150618
(Red Hat 5.1.1-4)"

Change-Id: I715e92d524ceaffdd2f0e73a39d1c816ee8f1644

6cc54913

Fix typos · a18fc918

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

a18fc918

Fix typos · 1f03430e

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: I8450ed77094094b19d77a0ffa37fe9fbaa889fa3
Reviewed-on: https://gerrit.libreoffice.org/18969Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

1f03430e

Fix typos · 3f6da86e

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: I13c3dc33722f139582f27412d5d336264d3d15a3
Reviewed-on: https://gerrit.libreoffice.org/18942Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

3f6da86e

Fix typos · a50539e2

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8
Reviewed-on: https://gerrit.libreoffice.org/18953Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

a50539e2

Fix typos · eab0904f

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: I81f6f356c1a6873fcc9a3bde487127b673fa9a61
Reviewed-on: https://gerrit.libreoffice.org/18952Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

eab0904f

Fix typos · f891d8cf

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: I9dbe1e05cf73af20c25392e639a807854e87fc6e
Reviewed-on: https://gerrit.libreoffice.org/18946Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

f891d8cf

Fix typos · ae13a681

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: Id66432ef80fc2963fd2cbc6fad5d8e135e8975b0
Reviewed-on: https://gerrit.libreoffice.org/18956Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

ae13a681

Fix typos · d344d2b1

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: I6dfb5fb468c1305a8f248bf5788c5760135fd835
Reviewed-on: https://gerrit.libreoffice.org/18955Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

d344d2b1

Fix typos · b3ebda45

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: Ia8b2176a439742769e61fb6a981000f316033071
Reviewed-on: https://gerrit.libreoffice.org/18954Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>

b3ebda45

implement save slide background for impress · ed25a000

Caolán McNamara Eyl 30, 2015 yazdı

to go along with the existing "set background",
same sort of thing as the competitor's effort

Change-Id: I2a1106771ead2cd926f3d631850447499340697c

ed25a000

drop unused headers · 73909474
Caolán McNamara Eyl 30, 2015 yazdı
```
Change-Id: If28362f97b36e378c426c3747beaddce6933b771
```
73909474

shared_array->unique_ptr<[]> · 66343a8a

Caolán McNamara Eyl 30, 2015 yazdı

where we don't need to share the data

Change-Id: I0edc9d62186d96095ee67e3c93f5cf186dffcb71

66343a8a

maSvgDataArray only populates a uno::Sequence, so use that instead · 78c83032
Caolán McNamara Eyl 30, 2015 yazdı
```
Change-Id: I335d5ee70e95e1a3b204d34f6df4cb62f3fb3cad
```
78c83032

Fix typos · 00d2eeeb

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: Iaa9dd3f02f21947742643349d3b878126017477d
Reviewed-on: https://gerrit.libreoffice.org/18947Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

00d2eeeb

Prefer getSelectedFiles to getFiles · 5e264440

Julien Nabet Eyl 18, 2015 yazdı

Anyway, add extension dialog allows to select only 1 file.
So getFiles and getSelectedFiles both return a 1 cell array which contain the full path of the file.

See http://nabble.documentfoundation.org/Multiselection-needs-work-tt4153207.html

Change-Id: I475ea519648d075b482a07d23b15af2ddb8f4637
Reviewed-on: https://gerrit.libreoffice.org/18711Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

5e264440

tdf#94173: Calc doesn't save your own created autoformat presets · 652158c3

Julien Nabet Eyl 15, 2015 yazdı

Auformat list (maData) is defined as "MapType" which itself is defined like this:
boost::ptr_map<OUString, ScAutoFormatData>
so default sorting is ascii

2 consequences:
1) Default didn't appear first
2) When adding a new autoformat entry when it was new first one of the list
wasn't saved because of iterator was incremented first before looping
See https://bugs.documentfoundation.org/show_bug.cgi?id=94173#c5
There were some other weird behaviors too according to comments of the bugtracker

Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=72c1b6141d590fb4479925ed8bc88b79357c2bfc

Solution:
Add a Compare so Default entry is always first one so the first time incremented iterator is ok and
new entry (even if new first one in list) is saved

Thank you Markus for the idea! (I was lost in Compare syntax)

Change-Id: I9ba0cdc63c66b747db102bb661cd09fbfe5996ae
Reviewed-on: https://gerrit.libreoffice.org/18598Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

652158c3

Probably good to move the more complicates test after the light-weight ones · 8727afe7

Tor Lillqvist Eyl 30, 2015 yazdı

We will return false if any of the tests here match, so good to test
the trivial things first before ones involving a potentially complex
function call.

Change-Id: I531282041c888799d37d95ae773daa349e60a37d

8727afe7

Fix typos · cf2921cc

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: Iad3a3d77c5d4412a5c0e0b6adcb9bff3389f863c
Reviewed-on: https://gerrit.libreoffice.org/18983Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cf2921cc

Avoid unhelpful -Wunused-variable · e2618814

Stephan Bergmann Eyl 29, 2015 yazdı

...at least from "g++ (GCC) 5.1.1 20150618 (Red Hat 5.1.1-4)" with
--disable-debug, when a namespace-scope const variable with a "complex"
initializer declared in an include file remains unused.

Avoid that warning via SAL_CONSTEXPR, which in turn requires large parts of
o3tl::is_typed_flags to be SAL_CONSTEXPR, which in turn requires a new
HAVE_CXX14_CONSTEXPR to allow assert in constexpr functions, which in turn
requires using -std=c++14 instead of -std=c++11 where available, which in turn
(a) requires to /not/ use -std=c++14 if it would run into a bug between Clang
and libstdc++ discussed at <https://llvm.org/bugs/show_bug.cgi?id=24115>
"llvm-nm fails to build with gcc 5.1's libstdc++" (and which hits us in
sfx2/source/control/thumbnailview.cxx), and (b) requires a new
HAVE_CXX14_SIZED_DEALLOCATION to work around GCC 5.1 -Werror=sized-deallocation
(where Clang >= 3.7 only supports C++14 sized deallocation when explictly
enabled via -fsized-deallocation, btw).

This effectively reverts ff6462e6 "avoid unused
variable warning:" again.

Change-Id: I424e3561452a3e6d8c8a9604d6c737cab49840c4
Reviewed-on: https://gerrit.libreoffice.org/18918Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

e2618814

Fix typos · 638b6d7e

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: I8e9c6c72c89411d8de04e5edd9317cd54f7c472a
Reviewed-on: https://gerrit.libreoffice.org/18958Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

638b6d7e

Fix typos · 9956b99e

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7
Reviewed-on: https://gerrit.libreoffice.org/18959Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

9956b99e

Fix typos · 3764f743

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: Id27f5a357c1333dec5c24c4f5e0fdaed7a775774
Reviewed-on: https://gerrit.libreoffice.org/18963Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

3764f743

Fix typos · 6d623c9e

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: Ibe0a436f38da760267d9b33893e3c2e8fef2f1d5
Reviewed-on: https://gerrit.libreoffice.org/18964Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

6d623c9e

Fix typos · 8e4388f6

Andrea Gelmini Eyl 30, 2015 yazdı

Change-Id: I42c0ab2012553e11f8c1372103488ba1d291d5a9
Reviewed-on: https://gerrit.libreoffice.org/18965Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

8e4388f6

Fix typos · 7319f5fa

Andrea Gelmini Eyl 29, 2015 yazdı

Change-Id: Ic3d2171521e308261c354d8f699b44b26c95f1ea
Reviewed-on: https://gerrit.libreoffice.org/18978Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

7319f5fa