The ordering between clearing mnThreadId and OpenGLContext shouldn't
matter since it was already inconsistent.

Change-Id: I0b7b6457547e9e38527de58ba062fd7092178056

... so the next time something overflows the main thread's message queue
it's easier to debug.

Change-Id: I90a35e46f3b2cab190c7da5e53024ec549159ac6

Change-Id: I3ca3f7732583111c8f49cc6fc71ba9fcada08f96
Reviewed-on: https://gerrit.libreoffice.org/23990Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ib941321d43a9a04d57f3c7c4a55528927fed5036
Reviewed-on: https://gerrit.libreoffice.org/24009Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <anistenis@gmail.com>

I removed all the OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFOs
or OSL_DEBUG_LEVEL > 0

Change-Id: I261644a179e763612204bbb0e54a869fa1a62298
Reviewed-on: https://gerrit.libreoffice.org/23035Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

I removed OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFO(..)s
or OSL_DEBUG_LEVEL > 0 and made sure that it doesn't break the
build

Change-Id: I3eccdd769ff32e57e12209706e5fbbdd9638de54
Reviewed-on: https://gerrit.libreoffice.org/23068Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

I replaced OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0 conditionals
as suggested in easyhack. I didn't convert those fprintf statements
because they were required for debug output formatting according to me

Change-Id: I54d5b0873f527fd04d736eeb01d18f73eb9be74f
Reviewed-on: https://gerrit.libreoffice.org/23069Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

I disentangled my previous patch to make one patch per module. I also
modified the patch according to new directions given by Sweet5hark

Change-Id: Id690f7c1e87230e4d10e1c9fe472f35d1d1caa8b
Reviewed-on: https://gerrit.libreoffice.org/22924Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

regression, likely from 2660d24a:

1/ Since that change mxAccessible in ScCsvGrid holds a rtl::Reference on
a ScAccessibleCsvGrid
2/ Which in turn holds a VclPtr<> (aka a rtl::Reference with lipstick)
on the ScCsvControl

These are a circular references, making both of them live forever and
leak past the point where on LibreOffice close all of Vcl is long gone,
when these are dtored. Clearing mxAccessible on disposing should help.

Change-Id: Iebb2635ec4ea143e7f0dbfebad2e6141a68e72e8
Reviewed-on: https://gerrit.libreoffice.org/24020Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ie48eb08edd1335661d1ef57ae652713143951317

Change-Id: I80987ea1bfac7478574de46ee30fc58fcc17eb68

Change-Id: Ic8d319dac1d18f548d47ac84e489c04412a38d1a

Change-Id: Id55410931305a9695a001977a5227b430a984e99

Change-Id: I6818f6c9593bfe7105cc194fcf6f69131046e4f3

Change-Id: I9cec61867b4e6e8abde7749047974c6de87b9669

Change-Id: I93a09bf8e475ec1aa2ebf7754c7048c81696922b

Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b

Change-Id: I1f61be80ac1ebe42668580b09a261e7e3af1a403

Change-Id: I387417bf8fdfa85379b6d8eaa32738d0ed7ab519
Reviewed-on: https://gerrit.libreoffice.org/23900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Currently the Windows-specific method ImplSalYieldMutexAcquireWithWait()
uses a messaging mechanism to learn about the SolarMutex being free again.
This is not reliable when the MessageQueue overflows (MS allows 10000
messages per queue). It is more safe to use MsgWaitForMultipleObjects.
This also allows to not only wait for the SolarMutex to be freed, but
also to detect when SendMessage() is used which needs to lead to a
reschedule to not block current Window handling.

Change-Id: Id317dda62aaa1fe7677d8d28929e6936e5a22705
Reviewed-on: https://gerrit.libreoffice.org/23921Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

In case an image had text, then ShapeExport::WriteGraphicObjectShapePart()
wanted to write "only the text", but PowerPointShapeExport::WriteTextShape()
had no idea how to write an image, so at the end nothing was exported.

Change-Id: I6c1ad0b41d4c5dc260b952322fb8a59e7f175603

Change-Id: Ia2255e1e3f7a8834a4b5d2a6bbab2c6dd498d356

This reverts commit cf1ecad2. Library_mysqlc is
external_code, so cannot use these LIBO_INTERNAL_ONLY features.

The spec says in theory a % suffix could be also supported, but let's
wait till that is seen in a real-world document.

Change-Id: Ie026915e38dcb03c99085a1740075364b00e1c8d

m_nRT2 and m_nWinBits fields are not in use anymore, at least as far
back as 2013, when the heading files were moved around

Change-Id: Ie3299a5999976450803332aeab72d5c0e68227e2
Reviewed-on: https://gerrit.libreoffice.org/23960Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Add tests for GridColor and FootnoteLineColor

Change-Id: Ia1112cbff5fd77ae1fa83fac362e917eb35f530d
Reviewed-on: https://gerrit.libreoffice.org/24001Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Change-Id: I3e030743b640d5a5f6b3bf4a4e9ba50ccd001287

Change-Id: I8e6d8e66cdab2e50ee10882e139be29c14ce50f6

Change-Id: I403f148060891feec56d7d2ef173a9c4934baf9e
Reviewed-on: https://gerrit.libreoffice.org/23995Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I4ba49ba94a3270a5d53754320e5fbd49e3f5c848

Change-Id: Ifad573ac687548a889165012e7b7bb2f4b82750c

The sfx2 impl. of XStorable::isReadonly isn't really helpful
for files w/o write permissions that were switched to edit
mode, as it returns the state of the UI. So instead let's just
rely on the state of the .uno:Save slot.

Change-Id: I3b033be3c9424a4479e9224f02d186960b540d21

Change-Id: I21a53381ad4018034de3833e8e244d0d7a7d28b8

Save as/to remote don't work there. Still would be
nice to have the modified state icon change there too,
but that's for a future investigation.

Change-Id: Id119a40c39f9c69738b1e61e23ffe3424276229e

Change-Id: I8aa14bb76a26aa12771000b393bee37d26ba85e7

Change-Id: I58a00f721cbb37f97fdbc599d57c26b1e89f4c73
Reviewed-on: https://gerrit.libreoffice.org/23998Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

What a mess.  Ideally, Frame would use its own rBHelper.rMutex, not SolarMutex.
But much of the framework code it calls into uses SolarMutex, too, making it
difficult to change that without running into the risk of deadlock.  And then,
some member variables are cleared early in Frame::disposing, while others are
only cleared en bloc at the end.  Be conservative and keep it that way (as other
Frame functions recursively called from within Frame::disposing could observe
the difference and rely on the current behavior), even if that means creating
lots of small, independent locked regions within Frame::disposing (which can be
detrimental to both performance and correctness).

Change-Id: I28f9a379ce03ed661e96c7deb8eb73cb58fb2cf7

Change-Id: I489859a53f98a1e70f8a79c3a974dd0d8954ccd1

Change-Id: Iabecc0d240c499ef81d8b85c8d0b37383813b06a