Change-Id: I34cb3f1739c6c3ee983be6ca0c70051a5fcfcb5d
Reviewed-on: https://gerrit.libreoffice.org/69115
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib4591197b17811a37b3a33f943fff03f1efd9550
Reviewed-on: https://gerrit.libreoffice.org/69114
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I672ea969efccf660d9a23847b26535031144e3da
Reviewed-on: https://gerrit.libreoffice.org/68473
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ic37967dedb2378106db2f3f437781c8ad20cad56

To me it looks like pArr is leaked in the bAgain = true case, or the code
is rather misleading.

Change-Id: I41ea26052671f127141d5421d0c446da4606da28
Reviewed-on: https://gerrit.libreoffice.org/69091
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The max-opencl-group-length ugly hack splits too long cell groups
into smaller ones, but 60a66bd5 accidentally made the temporary
group delete the array if the HW triggered this hack.
Testcase: 'SC_MAX_GROUP_LENGTH=1000 make CppunitTest_sc_copypaste'

Change-Id: I47ab08cd8511ad66e887c3c2d5eef25b08858c60
Reviewed-on: https://gerrit.libreoffice.org/69090Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I813b166a8c4658e08b185a43a464b6b370b62c66
Reviewed-on: https://gerrit.libreoffice.org/69099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

as opposed to the SfxTabDialogController case which already works

Change-Id: If72ca14803e3ff4d716ecab56454a8e2324f460c
Reviewed-on: https://gerrit.libreoffice.org/69098
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4bee58ab65a45d140fcb44a1def71ff505b78539
Reviewed-on: https://gerrit.libreoffice.org/69097
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6a363142945fc0b77e6c84649d32ffc27a5e2f04
Reviewed-on: https://gerrit.libreoffice.org/69082
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Use range-based loop or replace with STL functions

Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76
Reviewed-on: https://gerrit.libreoffice.org/69010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Fixes CVE-2019-7310.

Add patch to fix CVE-2019-9200 too.

CVE-2018-20662 looks irrelevant because we don't build pdfunite tool.

Change-Id: I5e7ddabbb341f6bfefb376d552b50c4006f41906
Reviewed-on: https://gerrit.libreoffice.org/69094
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

==26032==ERROR: AddressSanitizer: odr-violation (0x7f3b41f544a0):
  [1] size=96 'vtable for svgio::svgreader::SvgCharacterNode' master/svgio/source/svgreader/svgcharacternode.cxx
  [2] size=96 'vtable for svgio::svgreader::SvgCharacterNode' master/svgio/source/svgreader/svgcharacternode.cxx
These globals were registered at these points:
  [1]:
    #0 0x43a090 in __asan_register_globals.part.13 (workdir/LinkTarget/Executable/cppunittester+0x43a090)
    #1 0x7f3b31e6e86d in asan.module_ctor (instdir/program/libsvgiolo.so+0x6186d)

  [2]:
    #0 0x43a090 in __asan_register_globals.part.13 (workdir/LinkTarget/Executable/cppunittester+0x43a090)
    #1 0x7f3b41da5bad in asan.module_ctor (workdir/LinkTarget/CppunitTest/libtest_svgio_read.so+0x82bad)

Change-Id: Id2b32936d603ac2ed7df12d7e6f3ade094621578
Reviewed-on: https://gerrit.libreoffice.org/69092Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins

DispBlanksAs=gap mode of OOXML is different from
treat-empty-cells=leave-gap mode of OpenDocument,
because formulas with no numerical values and
strings are no gaps in OOXML line charts, but zeroes.

When the data source of the line charts contains
formulas with no numerical values or strings,
but it doesn't contain empty cells, as a workaround,
the charts will be imported with the
treat-empty-cells=use-zero setting to get the same
line chart as in MSO.

Note: now result of ScChart2DataSequence::getData(),
a sequence of Any values contains UNO void values for
empty cells instead empty strings, allowing the
distinction of the empty cells and cells with empty
string values.

Change-Id: If9a101d66b5b750051928fa7b10b05cea6040071
Reviewed-on: https://gerrit.libreoffice.org/69054
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Each plugin currently uses its own recursive AST run, which adds up.
This patch adds another shared plugin which internally contains all
(suitable) plugins and dispatches to them from the same one recursive
run. This patch converts ~25 plugins and for starmath's accessibility.cxx
reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any
plugins). As there are almost 50 more plugins to go, this can theoretically
result in 4.56s final time, although probably not all plugins can be
that easily converted, if at all.

This mostly requires very little change in many plugins (see e.g.
BadStatics), some even work without any functionality change (e.g.
CharRightShift). Traverse* calls require some changes but are often
not that difficult. WalkUp* probably can't be supported, although some
plugins can(?) possibly be adjusted to not rely on them. And of course
some plugins can be left as they are, using their own recursive run.
See description at the top of generator.cxx for description of how to
convert a plugin.

The sharedvisitor.cxx source is generated based on scanning relevant
plugin sources using a clang-based scanner/generator. The generated
source is intentionally included instead of getting always generated,
as the generating currently takes some time, so it should get updated
in git whenever a change in a plugin triggers a source change in it.

Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01
Reviewed-on: https://gerrit.libreoffice.org/68026
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I3b32a8f657078ba76d92bee7bff6bab1b226e31e
Reviewed-on: https://gerrit.libreoffice.org/69083
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Separator added before the popup menu
Extends patch 9ccdb944

Change-Id: Ie7d0beb45004985b25ae41458399ec979ca474ce
Reviewed-on: https://gerrit.libreoffice.org/69078Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

Regardless of the value of the View -> Field Shadings option, shadings
were always lost when saving to HTML.

Implement handling of this in the HTML conditionally, so in case that
UI option is on, then shadings are preserved in the HTML result;
disabling that option results in the old behavior, though.

Change-Id: I1bd19f4c6e22aff2f84fac25f0a506ad0127cc3c
Reviewed-on: https://gerrit.libreoffice.org/69081Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

This code was automatically converted from Java to Python.
It might be used at some point if the remaining java wizards
are converted to python, however that's not the case as
per today, thus this code is unused.

Let's get rid of it as it might create confusion

Change-Id: Ic58ade24b10f7a0654b3e8ae39f6afa712589c3d
Reviewed-on: https://gerrit.libreoffice.org/67868
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

This table has style:row-height="2.014cm" on its 2nd row (1142 twips).

In the 1st call of FormatLayoutTab(), the 1st row of the table is split
and the 2nd row moves to the next page.

In the 2nd call of FormatLayoutTab(), the 1st row grows from 400 to 454
twips, presumably due to the style:min-row-height="0.801cm" on it.

In the 3rd call of FormatLayoutTab(), the GetFollow()->ShouldBwdMoved()
returns true and the 2nd row moves back again, because
SwTabFrame::CalcHeightOfFirstContentLine() determines the height of the
2nd row as the maximum height of cells with rowspan=1 (400 twips), which
fits on the 1st page, ignoring the style:row-height="2.014cm" on the row
(1142 twips), which does not fit on the 1st page.

This loops until "LoopControl_1 in SwLayAction::InternalAction" is
triggered, and then eventually stops in 5.4 but loops even more since
commit 18765b9f, for unknown reasons.

Change-Id: I1a5c50d21c241e593419e63644ee758cdd9ed319
Reviewed-on: https://gerrit.libreoffice.org/69061
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Hopefully makes it easier to find locations in the code related to
HiDPI issues.

Change-Id: I2b4e5ff6d66c0ca5792250c3fd0d42eeb59eb3ef

The setting is only available from ODatabaseSource itself, not from
its Settings property. So treat it separately on export (it is also
treated separately at import: see OXMLDataSource::OXMLDataSource).

Change-Id: I2ecdea8748e95380c123afdb9507dfa5a4abd838
Reviewed-on: https://gerrit.libreoffice.org/69031
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221
Reviewed-on: https://gerrit.libreoffice.org/68893
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Frame was correctly formatted until spellchecker comes and
calls GetCharRect which somehow reformats the frame causes the misalignment.

So instead of calling GetCharRect, just call GetPaintArea as the frame is already
formatted at this point.

Change-Id: I31df9140174c40cf4cf39891490301cbe4c5806a
Reviewed-on: https://gerrit.libreoffice.org/68927
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Regression from commit 1c4025ba

Change-Id: I59ce8b6ada368c5c3f444a6e35a1dcb487d3539e
Reviewed-on: https://gerrit.libreoffice.org/69075Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I2227f09ac03f79e424704e00bd072741b3b0eb0d
Reviewed-on: https://gerrit.libreoffice.org/69077
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Regression from commit 29cbbad6 (DOCX
import: fix rounding error in table cell widths, 2014-11-07), which
changed truncation to rounding for the twips -> 1/10000th of relative
width conversion during import, but left export unchanged.

But adapting the export is not that easy: one part would be the
std::unique() call in
WW8TableNodeInfoInner::getColumnWidthsBasedOnAllRows() to not require
exact comparison, but doing so has it own side effects (multiple failing
tests).

So just revert the mentioned commit, as a minor rounding error is much
better than a broken vertical merge. And once it's clear how to adapt
export at the same time, this rounding on the import side can be
re-introduced.

Change-Id: I9e01ea5cc2c2f8aabe1e21cb8118c9c0e2c45494
Reviewed-on: https://gerrit.libreoffice.org/69065
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I08c974135f1936e6fc4f992091e5038d66d524c3
Reviewed-on: https://gerrit.libreoffice.org/69073Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic511f618e9dde2288491c01cfcd889970fd6e4e5
Reviewed-on: https://gerrit.libreoffice.org/69066Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Fix regression from:

commit dc9ee533
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date:   Fri Jun 15 19:32:15 2018 +0200

    vcl: parser of font features included in the font name

Where hb_feature_from_string() was replaced by a simple parser that supports
avery limited subset of the syntax it supports (as documented in
https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string)

Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f
Reviewed-on: https://gerrit.libreoffice.org/69062Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: I1919300071a06242fe832880b46c944989daa4b6
Reviewed-on: https://gerrit.libreoffice.org/69057
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

A algorithm that gives better results for dynamically sized
widgets is to increase proportionally only the points in shapes
that are over the half of the widget width (or height, when
adjusting the other dimension). This preserves the margins and
doesn't distort the shape of the paths, which is especially
visible when the source needs to be largely resized in one
dimension only.

Change-Id: I2cceb249063387c0f7400ef8d75adb5899aa8c23
Reviewed-on: https://gerrit.libreoffice.org/69056
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I460a71f363eb3b7f89786b8bd02f4b8f9521f4c7

Change-Id: I9dd3a25e68da00acff24f5ccfafbfc97d9efcf54
Reviewed-on: https://gerrit.libreoffice.org/69058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

It is wasteful to parse svg icons all the time so lets cache the
result when this make sense in a LRU map.

Change-Id: I95cc317c9301138a9e384d270223ba147a123e59
Reviewed-on: https://gerrit.libreoffice.org/69055
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

i.e. https://help.libreoffice.org/Common/Special_Settings#Supports_primary_keys

"This tri-state check box by default is set to the undetermined state"

otherwise the fix for tdf#123975 has no effect

this change initially in...

commit 3208fcb3
Date:   Thu Sep 13 22:57:58 2018 +0200

    tdf#119743: add Features entries in Properties block Drivers.xcu

Change-Id: Ic08fb1330985b90eec10662d50462f4ec127b9f9
Reviewed-on: https://gerrit.libreoffice.org/69042Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

typically indeterminate is an initial state which is not returnable
to, this is not the case for PrimaryKey

Change-Id: I82f318e18ad9beabd9ca6e3003a736fee9a5e931
Reviewed-on: https://gerrit.libreoffice.org/69043Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - Compiler error due to incorrect indentation 
    
    Change-Id: I041f9ac5d160ef2ebb23e77ce3d35f02e3b703e4
    Reviewed-on: https://gerrit.libreoffice.org/69053
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

As far as I can tell these do not need to scan everything, so the filtering
(and faster) base plugin is sufficient.

Change-Id: I0912a730bb5ec9670d1faa5c83f573902118cc95
Reviewed-on: https://gerrit.libreoffice.org/68872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I17927231da389ce54d2fb8ade0091c7e7033a808
Reviewed-on: https://gerrit.libreoffice.org/69049Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins