Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716

SvxBackgroundColorItem inherits from SvxColorItem and for backwards
compatibility with the StarOffice 5 binary file format (yes, really)
writes/reads only rgb and not the transparency value, so copying and pasting
text from a sidebar comment in writer to itself or another one results in a
black character background as the default COL_AUTO turns into black

Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5

Change-Id: I0fc1967d3863723b0c8e3e082fac19cc49aba345

...was like this ever since it got introduced in
b7595847 "implemented date acceptance patterns
API."  Found with clang-tidy's clang-analyzer-deadcode.DeadStores.

Change-Id: Ib1572ca9f254e3e835dbbe088f6a48c24dbd8235

Change-Id: I7e61051ca8d7ae2314514e60097ff86481d4ceae

Change-Id: Idcbd9a20ab13d0717f8728673e2c55e87aa92be4

Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6

Change-Id: I2c2f36a9c1b7348ba9f399b05a9f0319e1c40a0e

...as the underlying problem, according to
<https://bz.apache.org/ooo/show_bug.cgi?id=84676> "mixing neon and the hidden
embedded contents old [sic] another neon inside libhttp.so of gnome-vfs2 is
unreliable," presumably does not affect --with-webdav=serf

Change-Id: I2abfeaeac5174a735f46b2838bd84dda0af9a487

...according to <https://www.opengl.org/sdk/docs/man/html/glGetError.xhtml>:
"To allow for distributed implementations, there may be several error flags. If
any single error flag has recorded an error, the value of that flag is returned
and that flag is reset to GL_NO_ERROR when glGetError is called. If more than
one flag has recorded an error, glGetError returns and clears an arbitrary error
flag value. Thus, glGetError should always be called in a loop, until it returns
GL_NO_ERROR, if all error flags are to be reset."

(The original code was flagged by clang-tidy's
clang-analyzer-deadcode.DeadStores.)

Change-Id: Ia64e2133b6a4581230b999d4b8b63aa59199ee32

the paste special listener listens to owner changed, but expects
the owner changed event to contain the new contents, while the
original code expected getContents to be explicitly called to get
the new contents. So on owner changed always return the up to
date contents

Change-Id: Iaa7df2c01d360c3c5831b2258b4c2d41740fdffc

...at least while MenuWindow is mostly a TODO still;
and ImplHanldeHelpEvent can be protected

Change-Id: Ice0bb37e7e774e51445a9d78b2cf5eaba12f6341

...as https-equivalent to complement vnd.sun.star.webdav scheme.  See the mail
thread starting at
<http://lists.freedesktop.org/archives/libreoffice/2015-August/069929.html>
"What autogen.sh for an alternative ContentProvider for dav:// scheme?" for why
it is considered beneficial to have the WebDAV UCP support---in addition to the
standard pair of http[s] schemes---a non-standard pair of
vnd.sun.star.webdav[s] schemes different from the "accidentally supported"
non-standard pair of dav[s].

Change-Id: I7032aa1ed599f735969cf0163cd9dc121a1fdcb3

cf. 9228f412 "Missing davs URL scheme handling"

Change-Id: Ia161691cc213b5b2c1a3a589ce05b6ad8558013c

...looks like it was just forgotten in e557f06c
"INTEGRATION: CWS tkr10: i84676 neon and gnome-vfs2"?

Change-Id: I1bae95273f43e58425181bbc4667f87a6389e3a9

Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f

Change-Id: Id2ee43ff95b6d28252f58e4930b81faf8b3b4b7f

Change-Id: I262a9e75ec20fad15b550b84989fd7acc118c53a

Change-Id: I8ccaf0e8eea9c47257561e66114972bebf16e3af

Change-Id: I0d67b6c155d44e9c9072ef7c3519850c45a51313

Change-Id: I000a8fbfec9c81a61773b5db24b5a7b6c708dc06

with the variadic variants.

Change-Id: Id8d0c61b0454652abbbd09be0c72696a057dc2d2
Reviewed-on: https://gerrit.libreoffice.org/18008Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ie36f46e2eae72e8838aa5e45f96bd02fef45f7d5

Change-Id: I9abe56c88171629b68d72119f1359d750675d08a

Change-Id: I83634fa276048607cc0572178964417ce7373e0c

Change-Id: I50e07779a541bbea6b285a855fb54d419d4aed13

(which is a single-instance service, so there is likely no benefit in
initializing it lazily anyway)

Change-Id: Ie7e8272f11372149391a1190d5e71137dddaa03b
Reviewed-on: https://gerrit.libreoffice.org/18016Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I5ab147c8b737396db6371b9d92e7f19955ed7f28

Change-Id: I16d5772b0f8455518866cb03729e9bab95be8087

Change-Id: I983a24964f71967f1c0fdbde6dde0524d8c3456c

Change-Id: Ib3dacf63db01649992c7fe7571b54f964202fc3b

Change-Id: I5be4cfb951100d36054e409043cb9becbe52338d

Change-Id: Ibeace7ce7621033cf04e3186c212bbb4a27492a1

Change-Id: Iaab5763d4fbde431bac6f7ecbf4527ad889b6891

Change-Id: I0244f12f1ee2e61ac577222a14b011aee5ddbd54

Change-Id: I2801f54cecf9c8b7d43f8e1c1699cfd7fdd918e3

Change-Id: I5fca36f79aa98606770c77dad5b757288bd47842

Change-Id: I63e2f5055a87593708f672341b5849554b4db6fb

Change-Id: I5350322e5c957127fe125e633b31b2492410995e

Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93