Reverts partly https://cgit.freedesktop.org/libreoffice/core/commit/?id=43109b751bf5fd36318de56b2fb686acc724673f

Change-Id: Ief7fd752d260031e243ea4304f6c55fa4dc42bfd
Reviewed-on: https://gerrit.libreoffice.org/23984Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I9f90c55f74216c2f3452e5b30d85b304668330b3

Change-Id: Idfebcc36c756023e491baf2c4259bd580785dd44

Change-Id: I59d65ba81afab41e781f9dea5339a01d7918c51c

Change-Id: Ie84eeac24f22c5e3d3a4f63728a73023d626ccc0

Change-Id: I997213ca28efc2df04d454ffaf3c81c9cbad09ac

Change-Id: I8abc272d12e62e25be358dc4c73008971f1cd609

Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e

...which simplifies access to m_xContext member.

Change-Id: Ia028b5ae26d94527b6668365ab1197103afb8c22

ThumbnailDefaultView is now able to dynamically update the size of the thumbnail in its item.
Removed padding for thumbnails.

Change-Id: Ibc267c848a844098a59525c76e234f4f9c4d0ed1
Reviewed-on: https://gerrit.libreoffice.org/23816Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091

Change-Id: Ia043e0a5b7ec9623f6575a83374720be1f3b6b83

And gives the error:

include/c++/4.8/cstdio:120:11: error: no member named 'gets' in the global namespace

when it's build against libstdc++.

Commit 9e6221f1 (clang does not like gnu++11
that much, use c++11 instead, 2014-09-06) added support for invoking clang for
IDE purposes even in a tree configured for gcc. Extend this in case configure
sets -std=gnu++1y for gcc as well.

Change-Id: Ib767ef8f30bd6eb9ac825a1521184041f1269d93
Reviewed-on: https://gerrit.libreoffice.org/23983Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Mark some class methods as pure.
warnings look like this:
> dbaccess/source/core/api/RowSetBase.cxx
> 593    assertWithSideEffect	398	warning	Assert statement calls
> a function which may have desired side effects: 'isAfterLast'.

Change-Id: I1b69340c3714be4678b599fa9a8ca933122aa857
Reviewed-on: https://gerrit.libreoffice.org/23981Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I80349233e4fe3969da98814edaa1df52bb9adb35
Reviewed-on: https://gerrit.libreoffice.org/23959Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Iec3e2218c356c5a3d01edc0aa55ad9fd18e957f2

Change-Id: I426026938c4cf0e6af22be11dca8e68f991004c0

Change-Id: I629ff54ea721f4d9626258690767088b1abfb0c6

Change-Id: Ibb62a7fd5975ca891333f78a6f3c7c50329aa073

... in modules editeng to oox.
Replace with C++11 delete copy-constructur and
copy-assignment.
Remove boost/noncopyable.hpp includes and
one unused boost/checked_delete.hpp include in linguistic.

Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80
Reviewed-on: https://gerrit.libreoffice.org/23928Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

replace if constructs with switch
remove temp variables

tried to squeeze the enum in one of the 3 classes
but it doesn't feel right anywhere.
ScHeaderFooterContentObj doesn't use it, except for initialzing
ScHeaderFooterTextObj.
ScHeaderFooterTextData holds it but nothing more.
ScHeaderFooterTextObj uses it but always has to get it via
ScHeaderFooterTextData.GetPart()

Change-Id: I838ebff2e116e24a1c9359d6652bf5b1d30da48a
Reviewed-on: https://gerrit.libreoffice.org/23352Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

... in modules reportdesign to sdext
Replace with C++11 delete copy-constructur and
copy-assignment.
Remove boost/noncopyable.hpp includes.
Make some overloaded ctors explicit
(most in sd slidesorter).
Add deleted copy-assignment in sc/inc/chart2uno.hxx.

Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a
Reviewed-on: https://gerrit.libreoffice.org/23970Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

When you change the UI language and click OK,
Restart Now window opens instead of warning window.

Change-Id: Ic503bf4536a855891456f48745b748786857200f
Reviewed-on: https://gerrit.libreoffice.org/23421Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

get value by reference

introduced in
commit 8c2f2e1d and
commit f9b200ce

Change-Id: Iba84dd752f4cbdde9f3676c434d107efabe63a38
Reviewed-on: https://gerrit.libreoffice.org/23974Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1

Change-Id: I035eec1f3701c48b9a85c60400c68f9365299b48

Change-Id: Iff26c89ea6079e0f12691dbc04bb36f02b85c305
Reviewed-on: https://gerrit.libreoffice.org/23920Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

and eliminate converting backwards and forwards between
sal_Char*/OString/OUString

Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f
Reviewed-on: https://gerrit.libreoffice.org/23919Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

+ use SAL_INFO instead of OSL_TRACE for the impacted lines and surroundings

Change-Id: Icf12f51d68af15527ec7baf79a2d60608d849c97
Reviewed-on: https://gerrit.libreoffice.org/23975Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie5ce24292d3346aaf28315ef20a626190a3ec664

Change-Id: I00cfe81921f0c9c7a3a0c7834491ca0c25e21fca

+ remove useless call to OUString constructor

Change-Id: I6544e74dad2b24c694967aae9766af8870c8c06e
Reviewed-on: https://gerrit.libreoffice.org/23973Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I1c61841be58d49132ac3c69a6b227d75e829f769
Reviewed-on: https://gerrit.libreoffice.org/23972Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Icc6bef40a66d5616667d55bf02f10e19153457a7
Reviewed-on: https://gerrit.libreoffice.org/23971Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

+ use const iterator when possible

Change-Id: I6aa0c312394309455df804947565a3b876aa4d19
Reviewed-on: https://gerrit.libreoffice.org/23968Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Found with coccinelle:	http://coccinelle.lip6.fr/

Currently only applied to C code.

(cherry picked from commit aaf15142)

Change-Id: I7d43b024752ebd47e84e2e51028f8fd132410800

This is only a quick ugly hack and not a real fix. Basically we need to
prevent either using STYLE with more than one parameter in conditional
formatting functions or forbid the usage of STYLE completely.

In some way the usage of STYLE in conditional formatting means that our
current conditional formatting is not yet perfect. STYLE inside of a
conditional format is just insane from an evaluation perspective.

Change-Id: Ia1cc8c8cc8f00c8d4a055b1c2d128de3e1f8e4fa

Change-Id: Iadbd57ccdf4ae0fb37e8ba632ab9747d549bbab3
Reviewed-on: https://gerrit.libreoffice.org/23840Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>

First stacktrace:

soffice.bin: /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577:
sal_Unicode rtl::OUString::operator[](sal_Int32) const:
Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed.
...
3  0x00002aaaab327452 in __GI___assert_fail (assertion=0x2aaaaeea62a8 "index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())", file=0x2aaaaeea6260 "/home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx", line=577, function=0x2aaaaeea6860 <rtl::OUString::operator[](int) const::__PRETTY_FUNCTION__> "sal_Unicode rtl::OUString::operator[](sal_Int32) const") at assert.c:101
4  0x00002aaaaed91e89 in rtl::OUString::operator[](int) const (this=0x7fffffff2770, index=0) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577
5  0x00002aaaaee1c66f in SbRtl_Val(StarBASIC*, SbxArray&, bool) (pBasic=0xa2a7ec0, rPar=..., bWrite=false)
    at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:1792

Second stacktrace:

0x00002aaaaee6054d in printfmtstr (rStr="", rRes="", rFmt="\£0.##") at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534
534             while( *pFmt != '\' );
(gdb) bt
0  0x00002aaaaee6054d in printfmtstr(rtl::OUString const&, rtl::OUString&, rtl::OUString const&) (rStr="", rRes="", rFmt="\£0.##")
    at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534
1  0x00002aaaaee617ce in SbxValue::Format(rtl::OUString&, rtl::OUString const*) const (this=0xb12dd60, rRes="", pFmt=0x7fffffff20e0)
    at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:883
2  0x00002aaaaee217af in SbRtl_Format(StarBASIC*, SbxArray&, bool) (pBasic=0xa2cffa0, rPar=..., bWrite=false)
    at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:3519

Change-Id: I1798a1545ce08efa9d6fc39f4696195f9dc96c67
Reviewed-on: https://gerrit.libreoffice.org/23956Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I87b8664366c44d80a3ad1b4062ccb99bb1cdb8b9
Reviewed-on: https://gerrit.libreoffice.org/23955Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>