after
    commit dbb1dbe7
	Date:   Mon Apr 23 15:23:08 2018 +0200
    loplugin:useuniqueptr in X11SalData

Change-Id: I6398fd79b9190654258d60628952aa89dcd5898c

Change-Id: I408f9193680ea73c61fcfb2bd1e860152219702c

passing count as first element in array, dodgy.

Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463

Change-Id: Ic6f1a018b4d0016af5a19052ef46ea87c7923acb
Reviewed-on: https://gerrit.libreoffice.org/53416Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I827e997391834d10a617b7c5be8ceafc19e97219
Reviewed-on: https://gerrit.libreoffice.org/53343Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idad3c18c57e4ae4121505a0bd9761f8569685e33
Reviewed-on: https://gerrit.libreoffice.org/53358Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idb210207112994e1247c35e0dce1c6cd2f80f371
Reviewed-on: https://gerrit.libreoffice.org/53365Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

regression from
	commit 5d0e485e
	use actual UNO enums in reportdesign..svtools

Also make some of the "template<> set" property helpers only fire on
actual property change

Change-Id: I930fd255d287c3c7e5b064823fd1e8d4b665eae0
Reviewed-on: https://gerrit.libreoffice.org/53412Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic9853c967cdc36b1bf919a4914b04bf6752f0834
Reviewed-on: https://gerrit.libreoffice.org/53374Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I61a6d5cc5690a2899986ec831655e480a1f414d1
Reviewed-on: https://gerrit.libreoffice.org/53360Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7c70f9c590dd63cca1dce16ce184fc7e14922de2
Reviewed-on: https://gerrit.libreoffice.org/53353Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Using nested install is bad because (1) MS advises against it (though it
most possibly doesn't relate to our specific case, when we install the
vc redist exe package in UI part, so actually only a single MSI session
is active at any time); (2) because it adds some extra interactions
(user sees something "unrelated" being installed, which raises concerns;
additional admin authentication required); and (3) because it runs in
InstallUISequence, thus only installing the UCRT when doing interactive
installation (unattended installs, including GPO, need to install UCRT
separately).

This patch aims to incorporate the original UCRT MSU (Windows Update)
packages (https://support.microsoft.com/en-us/help/2999226) available as
a zip archive from
https://www.microsoft.com/en-us/download/details.aspx?id=48234
- the same as used in VC redists for VS 2015 and 2017. This obsoletes
the separate installation of the redist; since we also have the redist
as merge module in our MSI, that is enough (and removes redundancy).
The MSUs are installed using wusa.exe in a custom action (deferred,
non-impersonating).

As a small bonus, embedding MSUs instead of redist EXE allows us to
shrink the size of installer a little (~10 MB).

As deferred custom actions cannot access current installer database,
we workaround this by using initial immediate impersonating action to
extract the binaries into a temporary location. To ensure that the file
gets removed upon completion (both successful and failed), we use an
additional cleanup action.

Commit 61b1d631 is effectively reverted.

Change-Id: I1529356fdcc67ff24b232c01ddf8bb3a31bb00bd
Reviewed-on: https://gerrit.libreoffice.org/52923Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

they are then aggregated to the other and passed to the function

Change-Id: I158a747de9c22d50716fc066074a593b4928d6bf
Reviewed-on: https://gerrit.libreoffice.org/53424Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I6e7af6e6178f3820a73bae6008d8046161a0d8a5
Reviewed-on: https://gerrit.libreoffice.org/53425Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

... since otherwise gbuild doesn't understand it and (e.g.) make odk.clean fails

Change-Id: Ie6098bcf1ff99ee1a5df5fd5219d3b3c82075f71

Change-Id: Ib84ee30c21a0b9ac09d80cf4aa8898ad5d1d12e5
Reviewed-on: https://gerrit.libreoffice.org/53367Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ia8a541b3d1e1f27c493ba371d970bfff3a893ae2

GooString became const...

Change-Id: Icc95be2e8603a4e22c6a9ac2008986bacd0bfba5

... since archs with the "Zero VM" take loooong otherwise and eventually
gets killed after 150 minutes of "inactivity" (no output)

Change-Id: If421378920c791fdc5d165cc452bdd40e136c8d1

We assume the SolarMutex is always taken when doing GL calls, but
putting DBG_TESTSOLARMUTEX() into WinOpenGLContext::makeCurrent()
pointed out two places in the persona code where this invariant wasn't
hold, fix those.

Opening the dialog and downloading previews of one category, then
clicking on an other button to download previews of an other category no
longer results in a crash while calling glBindFramebuffer() with this.

Change-Id: Ib8148a709f89c2dc44da102e2023cc61ba890744
Reviewed-on: https://gerrit.libreoffice.org/53414Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

and text is nullptr, seeing as an end G_MAXINT translates to str len,
assume the same for start

Change-Id: I76b8bb0e66694129d36bbe08a6d55fc434f3434f
Reviewed-on: https://gerrit.libreoffice.org/53376Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

All labels located in the L10N module receive their german counterpart.
Thanks to Gisbert Friege.

Change-Id: I472b0b86f1e7745c09f6ec4960c9846cacbdfd09

Change-Id: I33cab261f107ed29e36d0093a87ffc3a2de21a54
Reviewed-on: https://gerrit.libreoffice.org/53361Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  395b1815dc3f2f21302e3858357c6cf16a449ab2

Formatting in help text, further corrections.

Change-Id: I7950ef7267129d111bb5c63fc9b962fd80e13131
Reviewed-on: https://gerrit.libreoffice.org/53385Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Project: help  8763bde02f185447ab6133d8107be090bb4fc012

Review some outdated text in the Access2Base help page

Change-Id: I61c4b9f4b66750eab2e5724add50865719b13576
Reviewed-on: https://gerrit.libreoffice.org/53382Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I15a0626bcbeaea8e74455526bf485c8eb617e74e
Reviewed-on: https://gerrit.libreoffice.org/53359Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6f933b54c11a4939870c3a788a4928f2d6f12850
Reviewed-on: https://gerrit.libreoffice.org/53349Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: translations  e3802bb90081c3cc63ca8ec9726772d8e42299b0

Updated Slovenian translation

Change-Id: I999a9807259234ebfd080b070035ea5bcbc4b170

    <cols>
      ...
      <col min="5" max="16384" width="31.75" style="3"/>
    </cols>

may be present even if there isn't any content. Apparently used
with pageBreakPreview to grey out the area.

Change-Id: I6a79f9ec692ec07b02f4b4205ccd0cf3cf9f363f

Change-Id: I9a8bddebf06688ed7e65eacb680aa2d28ad94c54
Reviewed-on: https://gerrit.libreoffice.org/53220Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: Icdb865e511047b166767ca9e87e808c308ad7643
Reviewed-on: https://gerrit.libreoffice.org/53324Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Project: help  063187cceb37702ed5cfff401318d3b751387083

paragraph IDs need to be unique...

Change-Id: Id44418c90ee071cd98f20ecfa0296b06292d3343

Change-Id: I4d76d49742056d278e73a995dcbb8c4a64b374bd
Reviewed-on: https://gerrit.libreoffice.org/53323Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Project: help  7b2fa0a342d200612718eede865b3d649eb72d7e

Add sample files for complex trigon functions

Same sample file for all trignometric & hiperbolic
complex functions.

Minimal impact in translation

Change-Id: I15e3a5388cfdef919e269274c255ccca6b07f987
Reviewed-on: https://gerrit.libreoffice.org/53340Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  db93e0bc4548b5e2b5b26bc79d845a97aab8f409

Add sample file for trigonometric functions

Change-Id: I2645a468dfffdd53a1eaf1b96e18cee097f34c2a
Reviewed-on: https://gerrit.libreoffice.org/53368Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

The left mragin value is usually spelled out in RTF and DOCX, but this
bugdoc used the WW6 RTF markup to declare the numbering rules and there
the margin value was missing.

This also allows me to partially revert the changes to testTdf106953
from commit 56a695fd (tdf#112211 RTF
import: fix unwanted direct formatting for left indents, 2017-09-26).

Change-Id: I9902f2f9ada4080cb4d873624ae9824342c6ee77
Reviewed-on: https://gerrit.libreoffice.org/53364Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ib19f98e398216e8e240918fd82ac19c24b551709
Reviewed-on: https://gerrit.libreoffice.org/53362Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Export has changed, so that it only exports a tab when the
footnote paragraph has a hanging indent. Adjusting the import
code to match that change.

Please test with MSO before flagging this patch as a regression.
Certainly there will be some documents previously saved by LO
which will now, in LO, show an extra tab character after the footnote.
Any previously saved document without a hanging indent will display
this extra tab. However, MSO has always seen that extra tab, so
these patches are enhancing compatibility.

This patch corrects several incorrect assumptions:
-The paragraph style is not necessarily "Footnote".
-The paragraph may have directly defined a hanging margin.
-An aesthetic tab is needed on a hanging indent, not a defined margin.

Change-Id: Ieaa76448ce202d92efdb8d1fc04ba2674ed120ba
Reviewed-on: https://gerrit.libreoffice.org/52172Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Icdc99c51fe3548f96f5da5ccd3ac88bfccffc63c
Reviewed-on: https://gerrit.libreoffice.org/53354Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>