Kayıtlar (commit) · f71c1124d0e963872db39c1724d61e9b9f02820b · LibreOffice / core

13 May, 2019 6 kayıt (commit)

Tor Lillqvist May 13, 2019 yazdı

lo_runLoop() *is* used in the "Unipoll" case (i.e. current Online and
mobile apps).

Change-Id: I01ef3d8bc8140531f697952ef142150fc905a8d4

f71c1124

Using the m_FeedbackFDs is now necessary also on iOS · dfce9071

Tor Lillqvist May 13, 2019 yazdı

Until recently we had managed without them on iOS, but that changed
with the recent "Unipoll" work, I think. (Without this change, the iOS
app now runs into assertion failures early on. But note that this
change is not enough to make it work fully again.)

Change-Id: I09d25326ba73ce897da5c91f30530f5b3d5fd272

dfce9071

tdf#124923: Need to call InitVCL() on iOS before using SolarMutexGuard · 74264014
Tor Lillqvist Nis 24, 2019 yazdı
```
Change-Id: If5781ae101e58c26368e57787cb301f84ffa82a5
```
74264014
Fix warning: unannotated fall-through between switch labels · 06c86a16
Tor Lillqvist May 06, 2019 yazdı
```
Change-Id: Ieda620525bca6562327e304a91e4793bd9e90d7d
```
06c86a16

CppunitTest_sw_tiledrendering: close the document while LOK is still active · c3fcb4a1

Miklos Vajna May 10, 2019 yazdı

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccae (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

(cherry picked from commit c1486533)

Conflicts:
	sw/qa/extras/tiledrendering/tiledrendering.cxx

Change-Id: I2fe050bf40d68dafa0334f4149e54958c492122d
Reviewed-on: https://gerrit.libreoffice.org/72216Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

c3fcb4a1

unipoll: add a --unipoll parameter to gtktiledviewer. · d06197f6

Michael Meeks May 09, 2019 yazdı

Arguably should be the default. Implementation is a bit cute -
re-starting the main-loop as a child of a callback from its
idle handler.

Change-Id: I95e87c8a4ae3de745d7ca1f636859dd1d8deca17
Reviewed-on: https://gerrit.libreoffice.org/72070Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>

d06197f6

10 May, 2019 17 kayıt (commit)

CppunitTest_sc_tiledrendering: close the document while LOK is still active · 42977af4

Miklos Vajna May 10, 2019 yazdı

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccae (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

(cherry picked from commit 6eac1c9e)

On cp-6.0, this is a regression from the cp-6.0-only commit
49fe72fe (sfx2: LOK: route the parent sidebar
window instead of the deck, 2018-10-10).

Conflicts:
	sc/qa/unit/tiledrendering/tiledrendering.cxx

Change-Id: I2515e18713c9f20a4f70de478ab062bab5650608
Reviewed-on: https://gerrit.libreoffice.org/72127Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

42977af4

CppunitTest_desktop_lib: close the document while LOK is still active · d1bc69ad

Miklos Vajna May 09, 2019 yazdı

Otherwise the LOK notifiers won't be released (since LOK is not active),
and we leak vcl::Windows in GetLOKWindowsMap()::s_pLOKWindowsMap.

In dbgutil builds, this leads to an assertion failure if the sidebar is
active.

(cherry picked from commit da17ccae)

On cp-6.0, this is a regression from the cp-6.0-only commit
49fe72fe (sfx2: LOK: route the parent
sidebar window instead of the deck, 2018-10-10).

Conflicts:
	desktop/qa/desktop_lib/test_desktop_lib.cxx

Change-Id: Idedb9578478ff4a9f2e17c0cfd203da6f007bdbd
Reviewed-on: https://gerrit.libreoffice.org/72098Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

d1bc69ad

svx lok: fix crash on select all when there is no mpMarkedObj yet · a81b7eba

Miklos Vajna May 09, 2019 yazdı

Fixes the online.git HTTPWSTest::testRenderShapeSelectionImpress()
testcase by reverting one hunk of commit
3fb298f6 (lok: writer: svg export
transformed images, 2019-03-26).

This was probably meant to be a cleanup, but getting the sdr mark,
followed by getting the sdr object of the mark always gives us a shape,
while directly accessing mpMarkedObj does not.

Change-Id: Id733ba5c6fdf6fc86a3e9f7de62b4bdcbf9b06db
Reviewed-on: https://gerrit.libreoffice.org/72039Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

a81b7eba

unipoll: let InitVCL tolerate double init. · d48b5414

Michael Meeks May 09, 2019 yazdı

We need to get VCL initialized early in UniPoll mode, since the main
setup doesn't occur until runPoll is invoked, and we want to call lots
of virtual methods that take the SolarMutex before then - which requires
VCL to be initialized.

Change-Id: Id9c1b74c126cf7bb71d6560b7585d37327a9f5ef
Reviewed-on: https://gerrit.libreoffice.org/72069Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

d48b5414

crashtesting: crash on importing tdf#123420-2.xlsx · e40b4457

Dennis Francis May 09, 2019 yazdı

since

commit c2f1c68f
Date:   Fri Apr 19 23:15:53 2019 +0530

    tdf#122590: follow-up : import x14:cfRule priorities

Fix is to import the priorities for iconSet x14:cfRule too.

Thanks to Caolán McNamara for notifying me about the regression.

Change-Id: Ib5b703a6911ab6480d42ac1e004a144043d3ad24
Reviewed-on: https://gerrit.libreoffice.org/72035
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit ea5f1ec4)
Reviewed-on: https://gerrit.libreoffice.org/72120Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

e40b4457

fix copying of maVectorGraphicData in ImpGraphic · 1f514f0e

Tomaž Vajngerl May 10, 2019 yazdı

a8c9f2f6 removed copying of
maVectorGraphicData by mistake in operator= which means that the
source of SVG files won't be copied and will disappear.

Change-Id: I339b65e6b54215d6a108a00d630916e94da24e21
Reviewed-on: https://gerrit.libreoffice.org/72097Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

1f514f0e

lok: avoid locking table when ScSpecialFilterDlg is destroyed · c5457de0

Henry Castro May 10, 2019 yazdı

ScSpecialFilterDlg by default does not lock the table, but in tiled
rendering case, switching sheets are locked when the dialog is closed

Thanks Michael Meeks for debugging

Change-Id: Ifa32fd63085f3e082b97ad0313dff7b826b95d2e
Reviewed-on: https://gerrit.libreoffice.org/72074Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

c5457de0

drawinglayer: avoid AA for hairline polygons built from hori/vert lines only · c42b28be

Miklos Vajna May 09, 2019 yazdı

For one, it seems this was the intention already since commit
85c70f37 (CWS-TOOLING: integrate CWS
aw063, 2009-03-04): "suppress AntiAliasing for pure horizontal or
vertical lines".

For another, this fixes the TileCacheTests::testTileWireIDHandling()
testcase in online.git, which assumes that the indicators at the corners
of the Writer body frame (paragraph marks hidden / default case) can be
painted multiple times, producing pixel-by-pixel matching results. But
in reality AA breaks that assumption, and we know these indicators are
never diagonal lines.

(cherry picked from commit f8b4d371)

Conflicts:
	basegfx/test/B2DPolygonTest.cxx

Change-Id: Ib74f823165799991296b64cee58ec106dbdcedcf
Reviewed-on: https://gerrit.libreoffice.org/72032Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>

c42b28be

tdf#124953: Use rangelist's combined range top-left address... · 8a27eeb1

Dennis Francis Nis 25, 2019 yazdı

as origin address in the conditional format formula on xlsx export.
Excel seems to get confused if anything else is supplied as the
origin in the formula.

For example, before this patch, for a condfmt range over the
range-list [A3:C5 E1:F2], the origin address used in the formula
(for text search type entries) is A3.

<conditionalFormatting sqref="A3:C5 E1:F2">
   <cfRule type="containsText" dxfId="0" priority="1" operator="containsText" text="ABC">
       <formula>NOT(ISERROR(SEARCH("ABC",A3)))</formula>
   </cfRule>
</conditionalFormatting>

In this patch we use the top-left cell address(A1) of the combined range "A1:F5" as
the origin address.

       <formula>NOT(ISERROR(SEARCH("ABC",A1)))</formula>

Reviewed-on: https://gerrit.libreoffice.org/71312
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit ca40d4ce)

Change-Id: If08a859bc361f925148ff463758d03ebbc41c0ac
Reviewed-on: https://gerrit.libreoffice.org/72009Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

8a27eeb1

Markus Mohrhard Tem 14, 2018 yazdı

Change-Id: I4c5ca66ce550de74d8b9396aa0213c558b7f884f
Reviewed-on: https://gerrit.libreoffice.org/57445
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 0f0466c6)
Reviewed-on: https://gerrit.libreoffice.org/72008Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

baf7d49f

Markus Mohrhard Tem 14, 2018 yazdı

Change-Id: I7523d17e9945dfbdf0c346fff8eddd40593f946a
Reviewed-on: https://gerrit.libreoffice.org/57444
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 16048ebc)
Reviewed-on: https://gerrit.libreoffice.org/72007Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

569c2229

Markus Mohrhard Tem 14, 2018 yazdı

Another set of cases where MS Excel needs the formula.

Change-Id: I58344a540ad69ff9b8c56aa817730079bd011acd
Reviewed-on: https://gerrit.libreoffice.org/57443
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 6df45ae3)
Reviewed-on: https://gerrit.libreoffice.org/72006Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

0420bf0d

add test for tdf#117816 · 02a57aa5

Markus Mohrhard Tem 14, 2018 yazdı

Reviewed-on: https://gerrit.libreoffice.org/57433
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 7e8dbbb0)

Change-Id: I470b4137a3b4e23acf0f4e949a7a834fed8069db
Reviewed-on: https://gerrit.libreoffice.org/72005Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

02a57aa5

tdf#117816, work around MS Excel bug with containsText cond format · 5328e047

Markus Mohrhard Tem 14, 2018 yazdı

Excel seems to require the formula that is equal to the containsText
condition.

According to cfRule (18.3.1.10) "Only rules with a type attribute
 value of expression support formula syntax." which contradicts the
MS EXCEL behavior.

Change-Id: Ifa3f9fee58194f70a64b37c62922513435d43bb8
Reviewed-on: https://gerrit.libreoffice.org/57432
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit e77596be)
Reviewed-on: https://gerrit.libreoffice.org/72004Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

5328e047

tdf#122590: follow-up : import x14:cfRule priorities · 333d4dd7

Dennis Francis Nis 19, 2019 yazdı

If there are x:cfRule's and x14:cfRule's with matching
range-list, then insert the conditional-fmt entries into
the document in the order of the priorities. That is
don't just append the x14:cfRule entries to the document
after the x:cfRule entries are inserted.

There was also a off-by-one bug in the priority export
of x14:cfRule entries. This caused the priority numbers
to be duplicated. This is also fixed.

Reviewed-on: https://gerrit.libreoffice.org/71311
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit c2f1c68f)

Change-Id: I5b0d11c4456b2966b808f6ee589075a870f43768
Reviewed-on: https://gerrit.libreoffice.org/72003Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

333d4dd7

tdf#122590 Import and export xlsx x14:cfRule element for type = cellis. · d034fdbb

Gülşah Köse Mar 25, 2019 yazdı

Reviewed-on: https://gerrit.libreoffice.org/69713
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 8c637b47)

Change-Id: I3d940269ec25657b64c714400a2828781dd9dd3e
Reviewed-on: https://gerrit.libreoffice.org/72002Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

d034fdbb

PPTX: Fix import / export of image transparency · c85ad473

Tamás Zolnai May 07, 2019 yazdı

Reviewed-on: https://gerrit.libreoffice.org/71916Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit ae3aabdb)

Change-Id: Ib07c606083b833389fcb82aac57ca8535d6e861f
Reviewed-on: https://gerrit.libreoffice.org/71933Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

c85ad473

08 May, 2019 3 kayıt (commit)

Respect page margins of the source doc during redaction · 83e6a2cf

Muhammet Kara May 07, 2019 yazdı

Change-Id: Ieaa50a2eba17145180ddd5d2bfc77add4801c43a
Reviewed-on: https://gerrit.libreoffice.org/71929
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit 141e33bc)
Reviewed-on: https://gerrit.libreoffice.org/71960Tested-by: Muhammet Kara <muhammet.kara@collabora.com>

83e6a2cf

tdf#125135: Standardize content placement for redaction · dd3f2fee

Muhammet Kara May 03, 2019 yazdı

Correct the position & size by roundtrip conversion
from/to wmf as a temporary solution.

Simplify a bit.

Change-Id: I6515571bb85134a4c48f00397c7554d190633575
Reviewed-on: https://gerrit.libreoffice.org/71860
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/71932Tested-by: Muhammet Kara <muhammet.kara@collabora.com>

dd3f2fee

tdf#120515 ODT filter: relax layout requirement before export · bed1a383

Miklos Vajna Kas 05, 2018 yazdı

This reverts commit 343af46f (ODT
filter: make sure we have a layout before export, 2017-11-29) as it
causes a performance problem with large documents (see bugreport).

I added it initially for the EPUB export, but there this is no longer
needed as commit 3ed8466b (EPUB export,
fixed layout: switch to a metafile-based approach, 2017-12-01) switched
to the better metafile-based approach.

(cherry picked from commit e83c1f0e)

Change-Id: Ie404e23db77b8ded1d29f42b6279a3cd06a574b5
Reviewed-on: https://gerrit.libreoffice.org/71943Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

bed1a383

06 May, 2019 9 kayıt (commit)

libreofficekit: send show/hide messages for dialogs · 3ef1164b

Szymon Kłos Nis 29, 2019 yazdı

Change-Id: I2b3ff5e5122b2be099be500ac544bf81f8d1b2ae
Reviewed-on: https://gerrit.libreoffice.org/71544
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/71545Tested-by: Jan Holesovsky <kendy@collabora.com>

3ef1164b

lok sc: Fix the formula input bar and address bar notifications. · 4a226f94

Jan Holesovsky Kas 15, 2018 yazdı

Apparently we did not have the pInputWin living in the background; but
now we have. There is no reason to treat it in an 'else' branch, these
checks should be separate either way.

Change-Id: Ibb8d92fb1e2803942460d2063847917d082fcb2e
Reviewed-on: https://gerrit.libreoffice.org/71863Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>

4a226f94

LOK: remove duplicate cursor invalidations for same view only · 8e9c36df

Ashod Nakashian May 05, 2019 yazdı

This limits duplicate cursor invalidation removal to same
view only, which seems to have been left in error.

We should now remove any old cursor invalidations (for
the same view) and only keep the latest (current) one.

Change-Id: Ie2323d0c5fcf3977576a1bdc098c95351a5753e0
Reviewed-on: https://gerrit.libreoffice.org/71846Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

8e9c36df

WidgetDefinition: add "action" state for the PushButton · c76f89ed

Tomaž Vajngerl May 06, 2019 yazdı

Change-Id: I0db9ec275cc95184ceb2cdbce8ae5343a10582c1
Reviewed-on: https://gerrit.libreoffice.org/71862Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

c76f89ed

LOK: trace queue only when it is changed · 79dbfbec

Ashod Nakashian May 05, 2019 yazdı

Change-Id: I9b8e060c2c7655565b95004d82bf50ada2ed0d08
Reviewed-on: https://gerrit.libreoffice.org/71845Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

79dbfbec

Notify the client when we close the sidebar · 60c048e6

Ashod Nakashian May 05, 2019 yazdı

Change-Id: I4879d65285e01cf2fd99233d226f4201997b4dd7
Reviewed-on: https://gerrit.libreoffice.org/71844Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

60c048e6

LOK: support sidebars in writer and calc · 5ddf6302

Ashod Nakashian May 06, 2019 yazdı

Change-Id: I3a3bd1fb6922e435599f604328f558be60594729
Reviewed-on: https://gerrit.libreoffice.org/71843Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

5ddf6302

[cp] Updated Fix Table Properties macro · 5d307ea4

Aron Budea May 06, 2019 yazdı

Change-Id: I7f8695789e1223df7bbb235fa6081ed91502ab99
Reviewed-on: https://gerrit.libreoffice.org/71838Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

5d307ea4

unipoll: emit user input-events & uno commands directly when in unipoll mode. · 33bfff35

Michael Meeks Nis 27, 2019 yazdı

Rather than emitting asynchronously at idle.

Change-Id: I6c72e9fad0b5587941e3a4a4d17d331a0d889942
Reviewed-on: https://gerrit.libreoffice.org/71770Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

33bfff35

03 May, 2019 5 kayıt (commit)

unipoll: cleanup runPoll. · 4eef543e

Michael Meeks May 03, 2019 yazdı

Setting a custom thread name is a terrible idea for online unit tests.

Change-Id: I1f5843255ab59072f806587ffcf655958380fe8e
Reviewed-on: https://gerrit.libreoffice.org/71761Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

4eef543e

unipoll: get SolarMutex lock counting right. · 283d7235

Michael Meeks May 03, 2019 yazdı

lo_startmain drops the SolarMutex without taking it, interestingly.

Change-Id: I2280e2fa6acb8739f970983032db72a8241d1c4f
Reviewed-on: https://gerrit.libreoffice.org/71742Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

283d7235

Bump version to 6.0-30 · 404c1203
Andras Timar May 03, 2019 yazdı
```
Change-Id: I5d8e95e2d4cfc8d94552d31ff36f2a10271e0b46
```
404c1203

libpng: upgrade to release 1.6.37 · c62c9feb

Michael Stahl May 02, 2019 yazdı

Fixes CVE-2019-7317.

Change-Id: I3374f5cbd6552e2c1569d63ee680d0c1d9389621
Reviewed-on: https://gerrit.libreoffice.org/71663
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit e2abbc00)

c62c9feb

sfx2: Enable sidebar on calc and writer, but not in impress · fba6d426

Ashod Nakashian May 03, 2019 yazdı

Change-Id: I8d846bc1f794cf16fd45486fd83ef87f43fd52c7
Reviewed-on: https://gerrit.libreoffice.org/71715Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

fba6d426