Change-Id: I45e26c9cdc00ae6d3bc56534d612b83b5ac26074
Reviewed-on: https://gerrit.libreoffice.org/72125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I44c4b5a6d4f0aada0ed95d8cd4d05366958c6207
Reviewed-on: https://gerrit.libreoffice.org/72124
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I315dcba7501b0f71a83d3bfec05f80f66ed51224
Reviewed-on: https://gerrit.libreoffice.org/72132
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

* Update helpcontent2 from branch 'master'
  - Typos
    
    Change-Id: Id5040a184e0dbc5456ceb8010a35dc0380b7e01f
    

Change-Id: Ib1d5adedff17f6e250029fe8b20ad491aa2718b3
Reviewed-on: https://gerrit.libreoffice.org/72136
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2729cb85f156ddafec69cc3280e9d8544f7c6182
Reviewed-on: https://gerrit.libreoffice.org/72117
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I78578cd1578317a16d2eb62e23ddcc01bc39347a
Reviewed-on: https://gerrit.libreoffice.org/72130
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Make "Content" a label for the drawing area

Change-Id: I2238ea42d33564d848376e3c33b9d9a46af094ae
Reviewed-on: https://gerrit.libreoffice.org/72045
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Arguably should be the default. Implementation is a bit cute -
re-starting the main-loop as a child of a callback from its
idle handler.

Change-Id: I95e87c8a4ae3de745d7ca1f636859dd1d8deca17
Reviewed-on: https://gerrit.libreoffice.org/72072
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

... and the cell didn't have a number format applied already,
[HH]:MM:SS instead of wall clock time format HH:MM:SS which comes
to a surprise anyway if the result is >=24h.

Related to tdf#125099

Change-Id: I6c19a86177f8714ac588d6798acf86e247a79b26
Reviewed-on: https://gerrit.libreoffice.org/72131Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: Ic943faba4b042299dbe2fd8a38d5d27832e39aad
Reviewed-on: https://gerrit.libreoffice.org/72116
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

This reverts commit f43b5d1e, now that the
experiment is done.

Change-Id: I0f483023c7f9f4f5ae1edaa7abb7056e1c4e30a1
Reviewed-on: https://gerrit.libreoffice.org/72129
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This takes the saving from (very long time, I lost patience), to around
2s on my machine.

Change-Id: Ife28a1616c0da65070f7e604b256134156af0e9a
Reviewed-on: https://gerrit.libreoffice.org/72123
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

SwUndoTOXChange was effectively dead code since commit
60732d71 "#i42807# clear undo stack
before changing of TOX properties, update TOX after changing properties"
and was resurrected by commit 4f0b568e.

* Calling Update() from Undo is wrong, as there is no guarantee that
  the index was up-to-date before the change
* Calling Update() from Redo is pointless, as there will be a Redo
  of SwUndoUpdateIndex anyway, given that the only caller of
  ChangeTOX, namely, SwTOXMgr::UpdateOrInsertTOX(), does that
* SwUndoTOXChange cannot retain a pointer to SwTOXBase as its life-time
  is tied to the SwSectionNode
* Repeat applying the same attributes to the same ToX is utterly
  pointless

Change-Id: I84a9de3176d1062d1a43acbc9270c547fde7936a
Reviewed-on: https://gerrit.libreoffice.org/72118
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccae (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

Change-Id: I2fe050bf40d68dafa0334f4149e54958c492122d
Reviewed-on: https://gerrit.libreoffice.org/72126Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

This just stops the bleeding (crash) in a special case when screen
number argument of SalFrame::ShowFullScreen is -1 (meaning
'fullscreen spanning all available displays')

It doesn't yet extend the fullscreen window over all screens, this
will be done in a follow-up fix

Change-Id: I2cf48096a1fe1ec33c943f10acb41c59585b325f
Reviewed-on: https://gerrit.libreoffice.org/71965
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

...to check whether it has any effect on the strange Jenkins UBSan bot failures
that started with <https://ci.libreoffice.org/job/lo_ubsan/1253/>

Change-Id: I9e7c8c89d3347feb0d5d56f67ac3495553acfc3e

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccae (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

Change-Id: I2515e18713c9f20a4f70de478ab062bab5650608
Reviewed-on: https://gerrit.libreoffice.org/72101Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Should save a lot of debugging of out-of-sync part state between
the calc core and lok clients.

at   ScTabControl::Select ()
from ScTabControl::SwitchToPageId (... nId=2)
from doc_setPart (... nPart=1)

we really don't want to hit this:

   if ( pScMod->IsTableLocked() )      // may not be switched now ?
   {                                                                                                                                │
       // restore the old state of TabControls

Change-Id: I02b29e9e0e29ce37b64e3f082811bc080c0dc254
Reviewed-on: https://gerrit.libreoffice.org/72114
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

We need to get VCL initialized early in UniPoll mode, since the main
setup doesn't occur until runPoll is invoked, and we want to call lots
of virtual methods that take the SolarMutex before then - which requires
VCL to be initialized.

Change-Id: Id9c1b74c126cf7bb71d6560b7585d37327a9f5ef
Reviewed-on: https://gerrit.libreoffice.org/72071
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I01916000ba2300a3905fe606301abd8ddadd3770
Reviewed-on: https://gerrit.libreoffice.org/72113
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I397cb6a0d033a78e854c10d9f33e24e94a9d733e
Reviewed-on: https://gerrit.libreoffice.org/72112
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia4424b2be84ece65305bb4e5bed505bed49ebda8
Reviewed-on: https://gerrit.libreoffice.org/72106
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I053dc3e8c5a5acc40e90db50c8b7d3c04feaa032
Reviewed-on: https://gerrit.libreoffice.org/72108
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In testUserFieldTypeLanguage the locale was set to de-DE
first then revert by calling SetLocaleConfigString with an
empty string when the test finished. Calling
SetLocaleConfigString with an empty string set the system
locale to the system default, which is not necessarily en-US
which is the default for unit tests.

Unfortunately it makes testTdf108021 fail because the
layouts in the testTdf108021 are different in en-US and
zh-TW locale in my environment. This locale-dependent layout
issue is tracked as tdf#125025 now.

Change-Id: I50ae2df5fb4624f94d070742c6189bf333370137
Reviewed-on: https://gerrit.libreoffice.org/71480
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I7f11f6b466cce85718ecf3d158f78962e756479f
Reviewed-on: https://gerrit.libreoffice.org/72111
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Hyperlink inserted to text box lost after export.

Change-Id: I796e54339292cb4a5e98de1ead6558d66587d353
Reviewed-on: https://gerrit.libreoffice.org/72033
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

...that has been dead ever since d49bc78f
"tdf#46723 - enable configmgr unit tests"

Change-Id: Ie7f8e6dc669f66798364f907dab65afdfe4f63c0
Reviewed-on: https://gerrit.libreoffice.org/72104
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie59a7ee3b95eafe2a2f743a76f8feb993c0c3daa
Reviewed-on: https://gerrit.libreoffice.org/72110
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

It's converted to QString anyway.

Change-Id: I5d9ccf05416dae603c195edc335d7b522dcf8c5d
Reviewed-on: https://gerrit.libreoffice.org/72102
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Solved by adding additional shape filling whole diagram.
MS PowerPoint does the same when converting SmartArt to shapes.

Background shape is also copied when loading from drawingML fallback,
appearently there is no background information.

Corrected SmartArt import tests, so that they are aware of extra shape.

Change-Id: I6154f8e1b34e5867ab582d6fc54459c7c93edbac
Reviewed-on: https://gerrit.libreoffice.org/72012
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

To test the patch , cherry pick this icon-patch first
https://gerrit.libreoffice.org/#/c/72082/

Change-Id: I706aee5695a2e275095832070382a9def4d89611
Reviewed-on: https://gerrit.libreoffice.org/72107Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I468108c74480e61215a85232421e8ce1a00e846d
Reviewed-on: https://gerrit.libreoffice.org/72058
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7bc0c6554b4d5e870a49740b2b7243d9a9246ca8
Signed-off-by: Aurimas Fišeras <aurimas@members.fsf.org>
Reviewed-on: https://gerrit.libreoffice.org/72063
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Icc3b4daa50305da0d74f63647c98b887df210a10
Reviewed-on: https://gerrit.libreoffice.org/72078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

not before vowels with a consonant sound so its a url not an url

Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2
Reviewed-on: https://gerrit.libreoffice.org/72062Reviewed-by: Jens Carl <j.carl43@gmx.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iccea3b686b02e03552fa5c836ee5a29103930d04
Reviewed-on: https://gerrit.libreoffice.org/72056
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Regression from
    commit 7282014e
    Date:   Fri Feb 1 15:15:16 2019 +0100
    tdf#50916 Makes numbers of columns dynamic.

Change-Id: Ibc96c36675d8b530b84f9680654f7d8a3b612d9c
Reviewed-on: https://gerrit.libreoffice.org/72053
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I04289589196ac69b31f75989d9252c79d03c890f
Reviewed-on: https://gerrit.libreoffice.org/71633
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>