for gtk3. Probably also a fairly dumb idea for gtk2, but with the
extra unblocking opportunities it probably just "works out ok" in
that model.

Change-Id: I3d4716c691fc84a5e68c210fee51f9e31cfacc02

Change-Id: Ic12b2914b4f39a96d1455dc280c97d64639b9849

Change-Id: I334c0a5004fa417f1cb3b1e768988644c712be7f

Change-Id: If126707fe637917a5f73950c751a97c30ad2e692

Change-Id: I1c85127f02697d39f17d4d5f52cb997352886701

Change-Id: I7fd09e4595be82ebd292042b09cc4c3e96b59d66

> sal/systools/win32/uwinapi/legacy.c(21,14) :  error: 'GetShortPathNameW' redeclared without 'dllimport' attribute: previous 'dllimport' ignored [-Werror,-Winconsistent-dllimport]
> DWORD WINAPI GetShortPathNameW(LPCWSTR lpszLongPath,LPWSTR lpszShortPath,DWORD cchBuffer)
>              ^
> C:/PROGRA~2/WI3CF2~1/8.1/include/um\fileapi.h(780,1) :  note: previous declaration is here
> GetShortPathNameW(
> ^
> C:/PROGRA~2/WI3CF2~1/8.1/include/um\fileapi.h(776,1) :  note: previous attribute is here
> WINBASEAPI
> ^
> C:/PROGRA~2/WI3CF2~1/8.1/include/shared\apisetcconv.h(22,20) :  note: expanded from macro 'WINBASEAPI'
> #define WINBASEAPI DECLSPEC_IMPORT
>                    ^
> C:/PROGRA~2/WI3CF2~1/8.1/include/um\winnt.h(175,36) :  note: expanded from macro 'DECLSPEC_IMPORT'
> #define DECLSPEC_IMPORT __declspec(dllimport)
>                                    ^

Change-Id: Ifb0d3179bca9da192afc0af4e731a799f6d392b2

And reduce copypasta

Change-Id: I140bb8ad68bc35ba41c272cc4eb89b4a2d209a45

Change-Id: I8df633d53d3669b073dd20b631adc50570a066dd

Project: help  c0662674bcd161f5fc386ac9055fd1ac5f01891b

typo "Extended Tipsoption" → "Extended Tips option"

reported via pootle

Change-Id: Ide68ca859b48503ce9bdaba8d240c41a39eacfa4

LOK sends all mouse events to SwEditWin, so add initial hit testing in
its mouse handler to forward the mouse events to the right VCL widget.

Change-Id: I67e8e19f47156261fd7c7eafd4e63f743e0c4ce9

Project: help  8c0daf0bded9159bf8b8601cce0a43263de166d3

typo "a surface textures" → "a surface texture"

via pootle-feedback

Change-Id: I2acbf164e446ab0e9903e93ae6e850bf10dec6bc

...escaping from main or being unexpected, in various places, which started when
62dbe2e6 "Clean up osl_getSystemPathFromFileURL
implementation" made osl_getSystemPathFromFileURL (indirectly) call
rtl_uString_newConcatAsciiL, which can throw std::length_error.

There is no ideal fix for this.  "The distinguishing characteristic of logic
errors [i.e., incl. std::length_error] is that they are due to errors in the
internal logic of the program.  In theory, they are preventable."
([std.exceptions])  That means that throwing a logic error is more akin to
raising an assert than to throwing some other kind or exception that is intended
to be handled by the program.  Which in turn means that it would generally be
more useful to cause such errors to cause calls to std::abort (and produce a
core/backtrace), than to catch and try to somehow handle them.  But there
appears to be no way to tell Coverity not to emit warnings about uncaught logic
errors, and it tends to emit quite a number of them for each signle "root
cause," so be pragmatic for now and catch it close to the root.

Change-Id: Iee71f50e3304954e9e88f326e0fa2167b6051ca2

VclPtr related, dialog dtor is never called, so timer
is never stopped and timer refers to deleted parent
data

Change-Id: I804ba082817802c0017e61c6b86c5d3694995ea8

depending on constness is a little worrying, lets just use different
names

Change-Id: I3e7ca96c8c7dc8d58a7415d39b937984961aa619

Browser and Hide Whitespace page height now use
SwPageFrm::GetContentHeight, which is const.

A few improvements are done for both paths as well.

Change-Id: I73a8e920ccfa96d76cbbb002bed6a85f2e636ede
Reviewed-on: https://gerrit.libreoffice.org/19730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

"OutputDevice subclass dispose() function MUST call dispose() of its superclass
as the last thing it does"

Change-Id: I3f0977cc031edef61b24eb316790de32a24ccbcf

... so just ignore all clipPath until its support is implemented in filter/source/svg/

Regression introduced by 3056a6b6.
Verified that tdf#95332 and tdf#65864 are still rendered correctly

Change-Id: Ie3bdee545a81554ef2a95d373e2559e2540ddaa5
Reviewed-on: https://gerrit.libreoffice.org/19889Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

when merging in pages from another model the already cloned page references
a masterpage from the old model. To not create an undo action that falsely
reflects that, remove the masterpage from the page first. This reflects
better what happens in this state, setting the masterpage for this page
the first time.

Change-Id: I0288268cb0963ddc2e8446661ffd30a94a0744d2

Isolation of windows headers using prewin.h
and postwin.h headers and making headers
dependent on them more self contained.

Conversion of TCHAR to WCHAR and
LPCTSTR to LPCWSTR etc. and cleanup
of unnecessary casts.

Change-Id: I7eff5c477d9223a064bfb4d962ff6d61960ee69c
Reviewed-on: https://gerrit.libreoffice.org/19901Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib6d2f8b4e71436c3a7c26bdfc9847152ebaf0739
Reviewed-on: https://gerrit.libreoffice.org/19900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I89708d13da2b3882aa0b7578b5acf48b6408010b

The goal of this is to have buttons in the Sidebar and NotebookBar automatically disabled
without an additional wrapper.

Change-Id: I8d25cdc6b87323e02daf6969c68582354f301375

so LibreOffice thinks its window is smaller than what gtk3 has allocated
for it.

For gtk3 (like firefox does) split size and position handling, leave
position/move handling to the configureEvent, but listen to sizeAllocate
and use that for the size handling.

Leave gtk2 as it always was

Change-Id: Ic52d6971595741ed658247b651e9e16c2ef9ed0b

caused by my commit e85b2333
"convert Link<> to typed"

Change-Id: Ieeb9e6fa5d5be3789ea70549e85d4bd3ffd51e59

Change-Id: Ifd88084d18df73ee18c497d0e4fd05acc3402ddf

Change-Id: I32ae2419ce6f7cce6e3da182c582b49be8dd362f

Change-Id: Ia0f22c5bb3594331626d931a8a271b0183962d55

Change-Id: I4ab69d0d8cbbadf0e09854bcf5efefa931566a8d

Change-Id: I348fd0d3eb288fe640fbb52704e91cda6a03b986

Change-Id: I4fa56a36b68db8c771a5d634be3655d1f9fdda70

Change-Id: I95c7c37ca743aede1dcb57b5633f478310fbbd01

Change-Id: I2c43a1dd3bee277dfd79f1806233b4d27d6b5cac

Change-Id: I8746ca87ed89bddafb839863829307f5fc51def0
Reviewed-on: https://gerrit.libreoffice.org/19914Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I83688a70b864bddb2af0a0a5b34968099c49d112
Reviewed-on: https://gerrit.libreoffice.org/19913Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I11d282c3be86feb57f5279220d84d8a121df0dbd

Change-Id: I61a7f92843ef888f64eb5b97267ba30227d64d73

E.g. when AC_PACKAGE_NAME contains spaces, PRODUCTNAME was set to empty.

Change-Id: Ie53ad1b770e54eeb03513fa2a7cfc2f4ebe65a2b

Change-Id: I046ca3c7b16906695c8b15beb33d3ccf735315a5

Change-Id: I4629d67b8cc69a2ace5a20f3d22505d7fc1ad10b